From: Andi Kleen <andi@firstfloor.org>
To: Ondrej Zary <linux@rainbow-software.org>
Cc: linux-fbdev@vger.kernel.org,
Kernel development list <linux-kernel@vger.kernel.org>,
Paul Mundt <lethal@linux-sh.org>,
Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
Subject: Re: [RFC PATCH v2] Resurrect Intel740 driver: i740fb
Date: Sun, 21 Aug 2011 22:13:27 +0000 [thread overview]
Message-ID: <m24o1ae7lk.fsf@firstfloor.org> (raw)
In-Reply-To: <201108212242.12717.linux@rainbow-software.org> (Ondrej Zary's message of "Sun, 21 Aug 2011 22:42:06 +0200")
Ondrej Zary <linux@rainbow-software.org> writes:
>
> The i740_calc_fifo() function formatting is nice but does not pass
> checkpatch. Making it checkpatch-compliant makes the code look ugly. How to
> make it both nice and compatible with Linux coding style?
When checkpatch.pl and sanity conflict, sanity should generally win.
-Andi
--
ak@linux.intel.com -- Speaking for myself only
next prev parent reply other threads:[~2011-08-21 22:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-21 20:42 [RFC PATCH v2] Resurrect Intel740 driver: i740fb Ondrej Zary
2011-08-21 22:13 ` Andi Kleen [this message]
2011-08-21 22:36 ` Alan Cox
2011-08-23 9:03 ` Ondrej Zary
2011-08-23 9:25 ` Michel Dänzer
2011-08-23 9:58 ` Ondrej Zary
2011-08-23 9:10 ` Dave Airlie
2011-08-26 6:24 ` Ondrej Zary
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m24o1ae7lk.fsf@firstfloor.org \
--to=andi@firstfloor.org \
--cc=FlorianSchandinat@gmx.de \
--cc=lethal@linux-sh.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rainbow-software.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).