From: Krzysztof Halasa <khc@pm.waw.pl>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Jeff Garzik <jeff@garzik.org>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
ak@suse.de, adaplas@gmail.com,
linux-fbdev-devel@lists.sourceforge.net,
benh@kernel.crashing.org
Subject: Re: [git patches] two warning fixes
Date: Fri, 20 Jul 2007 20:34:46 +0200 [thread overview]
Message-ID: <m3644e2abd.fsf@maximus.localdomain> (raw)
In-Reply-To: <alpine.LFD.0.999.0707191100480.27353@woody.linux-foundation.org> (Linus Torvalds's message of "Thu, 19 Jul 2007 11:04:29 -0700 (PDT)")
Linus Torvalds <torvalds@linux-foundation.org> writes:
> More people *should* generally ask themselves: "was the warning worth it?"
> and then, if the answer is "no", they shouldn't add code, they should
> remove the thing that causes the warning in the first place.
Sure. If a routine uses must_check yet its return value may be
safely ignored then that must_check is simply misplaced and should
be removed. It does not mean all must_checks are bad - each of them
isn't bad unless one can demonstrate it is.
Back to sysfs_create_bin_file() - if one can demonstrate a caller
can safely ignore the return value (which, it seems, is the
case), then exactly this very must_check should be removed.
--
Krzysztof Halasa
next prev parent reply other threads:[~2007-07-20 18:34 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-18 23:55 [git patches] two warning fixes Jeff Garzik
2007-07-18 23:59 ` Andi Kleen
2007-07-19 0:05 ` Jeff Garzik
2007-07-19 1:19 ` Benjamin Herrenschmidt
2007-07-19 1:41 ` Andrew Morton
2007-07-19 1:50 ` Linus Torvalds
2007-07-19 2:05 ` Benjamin Herrenschmidt
2007-07-19 2:36 ` Andrew Morton
2007-07-19 1:37 ` Linus Torvalds
2007-07-19 2:32 ` Jeff Garzik
2007-07-19 13:40 ` Krzysztof Halasa
2007-07-19 18:04 ` Linus Torvalds
2007-07-19 18:20 ` Stephen Hemminger
2007-07-20 18:34 ` Krzysztof Halasa [this message]
2007-07-21 0:32 ` Benjamin Herrenschmidt
2007-07-22 4:03 ` Jeff Garzik
2007-07-22 21:29 ` Benjamin Herrenschmidt
2007-07-23 3:26 ` Kyle Moffett
2007-07-19 13:38 ` Krzysztof Halasa
2007-07-19 18:00 ` Linus Torvalds
2007-07-20 12:54 ` Tim Tassonis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3644e2abd.fsf@maximus.localdomain \
--to=khc@pm.waw.pl \
--cc=adaplas@gmail.com \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=jeff@garzik.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).