linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* drivers/video/aty/radeon_backlight.c
@ 2006-12-13 13:46 James Cloos
  2006-12-13 14:29 ` drivers/video/aty/radeon_backlight.c Michael Hanselmann
  0 siblings, 1 reply; 3+ messages in thread
From: James Cloos @ 2006-12-13 13:46 UTC (permalink / raw)
  To: linux-fbdev-devel; +Cc: linux-kernel

Are there any dependencies in $subject which would preclude changing
drivers/video/Kconfig with:

 config FB_RADEON_BACKLIGHT
         bool "Support for backlight control"
-        depends on FB_RADEON && PMAC_BACKLIGHT
+        depends on FB_RADEON
         select FB_BACKLIGHT
         default y
         help
           Say Y here if you want to control the backlight of your display.

or is radeon_backlight.c only functional when -DCONFIG_PMAC_BACKLIGHT,
even though the pmac routines are all ifdef'ed?

-JimC
-- 
James Cloos <cloos@jhcloos.com>         OpenPGP: 1024D/ED7DAEA6

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: drivers/video/aty/radeon_backlight.c
  2006-12-13 13:46 drivers/video/aty/radeon_backlight.c James Cloos
@ 2006-12-13 14:29 ` Michael Hanselmann
  2006-12-13 15:32   ` drivers/video/aty/radeon_backlight.c James Cloos
  0 siblings, 1 reply; 3+ messages in thread
From: Michael Hanselmann @ 2006-12-13 14:29 UTC (permalink / raw)
  To: James Cloos; +Cc: linux-fbdev-devel, linux-kernel

On Wed, Dec 13, 2006 at 08:46:24AM -0500, James Cloos wrote:
> Are there any dependencies in $subject which would preclude changing
> drivers/video/Kconfig with:

Yes.

> or is radeon_backlight.c only functional when -DCONFIG_PMAC_BACKLIGHT,
> even though the pmac routines are all ifdef'ed?

Did you actually test wether it works? As far as I know, only Apple
(PowerPC) hardware uses these registers yet and have no use anywhere
else.

Greets,
Michael

-- 
Gentoo Linux developer, http://hansmi.ch/, http://forkbomb.ch/

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: drivers/video/aty/radeon_backlight.c
  2006-12-13 14:29 ` drivers/video/aty/radeon_backlight.c Michael Hanselmann
@ 2006-12-13 15:32   ` James Cloos
  0 siblings, 0 replies; 3+ messages in thread
From: James Cloos @ 2006-12-13 15:32 UTC (permalink / raw)
  To: Michael Hanselmann; +Cc: linux-fbdev-devel, linux-kernel

>>>>> "Michael" == Michael Hanselmann <linux-kernel@hansmi.ch> writes:

JimC> Are there any dependencies in $subject which would preclude
JimC> changing drivers/video/Kconfig ....

Michael> Yes.

Ok. Thanks.

JimC> is radeon_backlight.c only functional when -DCONFIG_PMAC_BACKLIGHT,
JimC> even though the pmac routines are all ifdef'ed?

Michael> Did you actually test wether it works? As far as I know,
Michael> only Apple (PowerPC) hardware uses these registers yet
Michael> and have no use anywhere else.

No, I only noticed the file by coincidence and wanted to find out
about it before testing.

Thanks for the quick reply!

-JimC
-- 
James Cloos <cloos@jhcloos.com>         OpenPGP: 1024D/ED7DAEA6

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2006-12-13 15:33 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-12-13 13:46 drivers/video/aty/radeon_backlight.c James Cloos
2006-12-13 14:29 ` drivers/video/aty/radeon_backlight.c Michael Hanselmann
2006-12-13 15:32   ` drivers/video/aty/radeon_backlight.c James Cloos

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).