From mboxrd@z Thu Jan 1 00:00:00 1970 From: Timur Tabi Date: Fri, 30 Apr 2010 01:44:12 +0000 Subject: Re: [PATCH 5/5] fsl-diu-fb: Support setting display mode using EDID Message-Id: List-Id: References: <1272584978-19063-1-git-send-email-agust@denx.de> <1272584978-19063-6-git-send-email-agust@denx.de> In-Reply-To: <1272584978-19063-6-git-send-email-agust@denx.de> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: Anatolij Gustschin Cc: linux-fbdev@vger.kernel.org, wd@denx.de, dzu@denx.de, devicetree-discuss@lists.ozlabs.org, linuxppc-dev@ozlabs.org, yorksun@freescale.com On Thu, Apr 29, 2010 at 6:49 PM, Anatolij Gustschin wrote: > +Optional properties: > +- EDID : verbatim EDID data block describing attached display. > + =A0Data from the detailed timing descriptor will be used to > + =A0program the display controller. The property name should be lower-case. > =A0/* > =A0* These parameters give default parameters > @@ -217,6 +218,7 @@ struct mfb_info { > =A0 =A0 =A0 =A0int x_aoi_d; =A0 =A0 =A0 =A0 =A0 =A0/* aoi display x offse= t to physical screen */ > =A0 =A0 =A0 =A0int y_aoi_d; =A0 =A0 =A0 =A0 =A0 =A0/* aoi display y offse= t to physical screen */ > =A0 =A0 =A0 =A0struct fsl_diu_data *parent; > + =A0 =A0 =A0 char *edid_data; edid_data should be "u8 *". "char *" is should be used only for strings or arrays of characters. > + =A0 =A0 =A0 /* Still not found, use preferred mode from database if any= */ > + =A0 =A0 =A0 if (!has_default_mode && info->monspecs.modedb !=3D NULL) { No need for the "!=3D NULL" --=20 Timur Tabi Linux kernel developer at Freescale