* RE: [PATCH 1/2] ARM: SAMSUNG: Add Window Positioning Support for
From: Jingoo Han @ 2011-08-26 5:56 UTC (permalink / raw)
To: AJAY KUMAR RAMAKRISHNA SHYMALAMMA
Cc: linux-samsung-soc@vger.kernel.org, linux-fbdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, FlorianSchandinat@gmx.de,
lethal@linux-sh.org, Jingoo Han, Marek Szyprowski,
ben-linux@fluff.org, BANAJIT GOSWAMI
In-Reply-To: <1314301917-9938-2-git-send-email-ajaykumar.rs@samsung.com>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="windows-1254", Size: 2118 bytes --]
Hi, Ajay.
> -----Original Message-----
> From: Ajay Kumar [mailto:ajaykumar.rs@samsung.com]
> Sent: Friday, August 26, 2011 4:52 AM
> To: linux-samsung-soc@vger.kernel.org; linux-fbdev@vger.kernel.org; linux-
> arm-kernel@lists.infradead.org
> Cc: FlorianSchandinat@gmx.de; lethal@linux-sh.org; jg1.han@samsung.com;
> m.szyprowski@samsung.com; ben-linux@fluff.org; banajit.g@samsung.com
> Subject: [PATCH 1/2] ARM: SAMSUNG: Add Window Positioning Support for s3c-
> fb driver
>
> This patch:
> --adds a data-structure to hold the current position of windows.
> --adds an ioctl number to support dynamic positioning the windows.
>
> Signed-off-by: Ajay Kumar <ajaykumar.rs@samsung.com>
> Signed-off-by: Banajit Goswami <banajit.g@samsung.com>
> ---
> arch/arm/plat-samsung/include/plat/fb.h | 14 ++++++++++++++
> 1 files changed, 14 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/plat-samsung/include/plat/fb.h b/arch/arm/plat-
> samsung/include/plat/fb.h
> index bd79c0a..77ed75c 100644
> --- a/arch/arm/plat-samsung/include/plat/fb.h
> +++ b/arch/arm/plat-samsung/include/plat/fb.h
> @@ -22,6 +22,18 @@
> */
> #define S3C_FB_MAX_WIN (5)
>
> +/* struct s3cfb_window_pos
> + * @win_pos_x: X-coordinate of window from the left.
> + * @win_pos_y: Y-coordinate of window from the top.
> + */
> +struct s3cfb_window_pos {
> + int win_pos_x;
> + int win_pos_y;
> +};
> +
> +/* Custom ioctl */
> +#define S3CFB_WIN_POSITION _IOW('F', 1, struct s3cfb_window_pos)
Can you change the number from 1 to 203 as follows?
+#define S3CFB_WIN_POSITION _IOW('F', 203, struct s3cfb_window_pos)
We already use this number as S3CFB_WIN_POSITION.
> +
> /**
> * struct s3c_fb_pd_win - per window setup data
> * @win_mode: The display parameters to initialise (not for window 0)
> @@ -35,6 +47,8 @@ struct s3c_fb_pd_win {
> unsigned short max_bpp;
> unsigned short virtual_x;
> unsigned short virtual_y;
> +
> + struct s3cfb_window_pos winpos;
> };
>
> /**
> --
> 1.7.0.4
ÿôèº{.nÇ+‰·Ÿ®‰†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±ýöÝzÿâžØ^n‡r¡ö¦zË\x1aëh™¨èÚ&£ûàz¿äz¹Þ—ú+€Ê+zf£¢·hšˆ§~††Ûiÿÿïêÿ‘êçz_è®\x0fæj:+v‰¨þ)ߣøm
^ permalink raw reply
* Re: [RFC PATCH v2] Resurrect Intel740 driver: i740fb
From: Ondrej Zary @ 2011-08-26 6:24 UTC (permalink / raw)
To: Dave Airlie
Cc: linux-fbdev, Kernel development list, Paul Mundt,
Florian Tobias Schandinat
In-Reply-To: <CAPM=9tzF7C_gW44csqYwK+wdT9mwWBrA3O_9JQNfg=6aip4kag@mail.gmail.com>
On Tuesday 23 August 2011, Dave Airlie wrote:
> On Sun, Aug 21, 2011 at 9:42 PM, Ondrej Zary <linux@rainbow-software.org>
wrote:
> > Hello,
> > this is an v2 attempt to resurrect an old (like 2.4.19) out-of-tree
> > driver for Intel740 graphics cards and modify it for recent kernels. The
> > old driver is located at:
> > http://sourceforge.net/projects/i740fbdev/files/
> >
> > It was easier to create a new driver based on skeletonfb, using most of
> > the low level HW code from the old driver. The DDC code is completely
> > new.
> >
> > The driver was tested on two 8MB cards: ManLi and Diamond Stealth II G460
> >
> > The i740_calc_fifo() function formatting is nice but does not pass
> > checkpatch. Making it checkpatch-compliant makes the code look ugly. How
> > to make it both nice and compatible with Linux coding style?
> > (the remaining // comments mark things that need attention - missing xpan
> > and suspend/resume)
> >
> > Changes in v2:
> > - fixed 15bpp (16bpp 555) mode
> > - not working 1280x1024-32 is not a bug but card's feature, it's now
> > handled correctly by the driver
> > - 24bpp modes still don't work in fbtest but it looks like fbtest bug!
> >
> > Is there any better way to test fb drivers than fbtest?
> >
> > no signed-off-by yet
> >
> > --- linux-2.6.39-rc2-orig/drivers/video/Kconfig 2011-04-06
> > 03:30:43.000000000 +0200 +++ linux-2.6.39-rc2/drivers/video/Kconfig
> > 2011-07-30 11:34:10.000000000 +0200 @@ -1117,6 +1117,17 @@ config
> > FB_RIVA_BACKLIGHT
> > help
> > Say Y here if you want to control the backlight of your display.
> >
> > +config FB_I740
> > + tristate "Intel740 support (EXPERIMENTAL)"
> > + depends on EXPERIMENTAL && FB && PCI && X86_32 && AGP_INTEL
> > + select FB_MODE_HELPERS
> > + select FB_CFB_FILLRECT
> > + select FB_CFB_COPYAREA
> > + select FB_CFB_IMAGEBLIT
> > + select VGASTATE
> > + help
> > + This driver supports graphics cards based on Intel740 chip.
> > +
>
> It shouldn't need AGP_INTEL, as its an AGP card not an integrated
> chipset, it might need just AGP.
Oops, I copied that from I810 and then forgot about it...will fix that to
really match the driver requirements.
BTW. i740 cards are really picky, they don't even POST with most boards that
don't have i440LX/EX or i440BX/ZX chipsets.
--
Ondrej Zary
^ permalink raw reply
* [PATCH] fbdev: fix parsing of standard timings
From: Tomi Valkeinen @ 2011-08-26 12:38 UTC (permalink / raw)
To: linux-fbdev
The standard timings parses uses 1:1 dimensions when the ratio in the
EDID data is 0. However, for EDID 1.3 and later the dimensions are 16:10
when the ratio is 0.
Pass the version and revision numbers to get_std_timing() which can then
make the right decision about dimensions.
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
---
drivers/video/fbmon.c | 20 ++++++++++++++------
1 files changed, 14 insertions(+), 6 deletions(-)
diff --git a/drivers/video/fbmon.c b/drivers/video/fbmon.c
index 4f57485..6a6f92e 100644
--- a/drivers/video/fbmon.c
+++ b/drivers/video/fbmon.c
@@ -493,7 +493,8 @@ static int get_est_timing(unsigned char *block, struct fb_videomode *mode)
return num;
}
-static int get_std_timing(unsigned char *block, struct fb_videomode *mode)
+static int get_std_timing(unsigned char *block, struct fb_videomode *mode,
+ int ver, int rev)
{
int xres, yres = 0, refresh, ratio, i;
@@ -504,7 +505,10 @@ static int get_std_timing(unsigned char *block, struct fb_videomode *mode)
ratio = (block[1] & 0xc0) >> 6;
switch (ratio) {
case 0:
- yres = xres;
+ if (ver < 1 || (ver = 1 && rev < 3))
+ yres = xres;
+ else
+ yres = (xres * 10)/16;
break;
case 1:
yres = (xres * 3)/4;
@@ -533,12 +537,12 @@ static int get_std_timing(unsigned char *block, struct fb_videomode *mode)
}
static int get_dst_timing(unsigned char *block,
- struct fb_videomode *mode)
+ struct fb_videomode *mode, int ver, int rev)
{
int j, num = 0;
for (j = 0; j < 6; j++, block += STD_TIMING_DESCRIPTION_SIZE)
- num += get_std_timing(block, &mode[num]);
+ num += get_std_timing(block, &mode[num], ver, rev);
return num;
}
@@ -599,6 +603,10 @@ static struct fb_videomode *fb_create_modedb(unsigned char *edid, int *dbsize)
struct fb_videomode *mode, *m;
unsigned char *block;
int num = 0, i, first = 1;
+ int ver, rev;
+
+ ver = edid[EDID_STRUCT_VERSION];
+ rev = edid[EDID_STRUCT_REVISION];
mode = kzalloc(50 * sizeof(struct fb_videomode), GFP_KERNEL);
if (mode = NULL)
@@ -632,12 +640,12 @@ static struct fb_videomode *fb_create_modedb(unsigned char *edid, int *dbsize)
DPRINTK(" Standard Timings\n");
block = edid + STD_TIMING_DESCRIPTIONS_START;
for (i = 0; i < STD_TIMING; i++, block += STD_TIMING_DESCRIPTION_SIZE)
- num += get_std_timing(block, &mode[num]);
+ num += get_std_timing(block, &mode[num], ver, rev);
block = edid + DETAILED_TIMING_DESCRIPTIONS_START;
for (i = 0; i < 4; i++, block+= DETAILED_TIMING_DESCRIPTION_SIZE) {
if (block[0] = 0x00 && block[1] = 0x00 && block[3] = 0xfa)
- num += get_dst_timing(block + 5, &mode[num]);
+ num += get_dst_timing(block + 5, &mode[num], ver, rev);
}
/* Yikes, EDID data is totally useless */
--
1.7.4.1
^ permalink raw reply related
* Re: [PATCH/RFC v2 1/3] fbdev: Add FOURCC-based format configuration
From: Florian Tobias Schandinat @ 2011-08-26 17:07 UTC (permalink / raw)
To: Laurent Pinchart; +Cc: linux-fbdev, linux-media, magnus.damm
In-Reply-To: <1313746626-23845-2-git-send-email-laurent.pinchart@ideasonboard.com>
Hi Laurent,
hope we're close to the final thing now. Just a few minor issues.
On 08/19/2011 09:37 AM, Laurent Pinchart wrote:
> This API will be used to support YUV frame buffer formats in a standard
> way.
>
> Last but not least, create a much needed fbdev API documentation and
> document the format setting APIs.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> Documentation/fb/api.txt | 299 ++++++++++++++++++++++++++++++++++++++++++++++
> include/linux/fb.h | 27 ++++-
> 2 files changed, 320 insertions(+), 6 deletions(-)
> create mode 100644 Documentation/fb/api.txt
>
> diff --git a/include/linux/fb.h b/include/linux/fb.h
> index 1d6836c..c6baf28 100644
> --- a/include/linux/fb.h
> +++ b/include/linux/fb.h
> @@ -69,6 +69,7 @@
> #define FB_VISUAL_PSEUDOCOLOR 3 /* Pseudo color (like atari) */
> #define FB_VISUAL_DIRECTCOLOR 4 /* Direct color */
> #define FB_VISUAL_STATIC_PSEUDOCOLOR 5 /* Pseudo color readonly */
> +#define FB_VISUAL_FOURCC 6 /* Visual identified by a V4L2 FOURCC */
>
> #define FB_ACCEL_NONE 0 /* no hardware accelerator */
> #define FB_ACCEL_ATARIBLITT 1 /* Atari Blitter */
> @@ -154,6 +155,8 @@
>
> #define FB_ACCEL_PUV3_UNIGFX 0xa0 /* PKUnity-v3 Unigfx */
>
> +#define FB_CAP_FOURCC 1 /* Device supports FOURCC-based formats */
> +
> struct fb_fix_screeninfo {
> char id[16]; /* identification string eg "TT Builtin" */
> unsigned long smem_start; /* Start of frame buffer mem */
> @@ -171,7 +174,8 @@ struct fb_fix_screeninfo {
> __u32 mmio_len; /* Length of Memory Mapped I/O */
> __u32 accel; /* Indicate to driver which */
> /* specific chip/card we have */
> - __u16 reserved[3]; /* Reserved for future compatibility */
> + __u16 capabilities; /* see FB_CAP_* */
> + __u16 reserved[2]; /* Reserved for future compatibility */
> };
>
> /* Interpretation of offset for color fields: All offsets are from the right,
> @@ -246,12 +250,23 @@ struct fb_var_screeninfo {
> __u32 yoffset; /* resolution */
>
> __u32 bits_per_pixel; /* guess what */
> - __u32 grayscale; /* != 0 Graylevels instead of colors */
>
> - struct fb_bitfield red; /* bitfield in fb mem if true color, */
> - struct fb_bitfield green; /* else only length is significant */
> - struct fb_bitfield blue;
> - struct fb_bitfield transp; /* transparency */
> + union {
> + struct { /* Legacy format API */
> + __u32 grayscale; /* != 0 Graylevels instead of colors */
You should adjust the comment as well, to avoid misleading crazy people ;)
Needs also be fixed in the documentation at some places.
> + /* bitfields in fb mem if true color, else only */
> + /* length is significant */
> + struct fb_bitfield red;
> + struct fb_bitfield green;
> + struct fb_bitfield blue;
> + struct fb_bitfield transp; /* transparency */
> + };
> + struct { /* FOURCC-based format API */
> + __u32 fourcc; /* FOURCC format */
> + __u32 colorspace;
So we have again fields that are not always used. Okay, as we still have 11 left
that shouldn't be a big problem, I think.
> + __u32 reserved[11];
> + } format;
Ugh, if you want this union to have a name I suggest 'fourcc' and not 'format'
as the other struct contains format information as well and who knows, maybe in
10 or 20 years we'll have yet another format description that can do things none
of the existing can do.
> + };
>
> __u32 nonstd; /* != 0 Non standard pixel format */
>
Thanks,
Florian Tobias Schandinat
^ permalink raw reply
* Re: [PATCH/RFC v2 3/3] fbdev: sh_mobile_lcdc: Support FOURCC-based
From: Florian Tobias Schandinat @ 2011-08-26 17:24 UTC (permalink / raw)
To: Laurent Pinchart; +Cc: linux-fbdev, linux-media, magnus.damm
In-Reply-To: <1313746626-23845-4-git-send-email-laurent.pinchart@ideasonboard.com>
Hi Laurent,
On 08/19/2011 09:37 AM, Laurent Pinchart wrote:
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> arch/arm/mach-shmobile/board-ag5evm.c | 2 +-
> arch/arm/mach-shmobile/board-ap4evb.c | 4 +-
> arch/arm/mach-shmobile/board-mackerel.c | 4 +-
> drivers/video/sh_mobile_lcdcfb.c | 342 ++++++++++++++++++++-----------
> include/video/sh_mobile_lcdc.h | 4 +-
> 5 files changed, 230 insertions(+), 126 deletions(-)
>
> diff --git a/arch/arm/mach-shmobile/board-ag5evm.c b/arch/arm/mach-shmobile/board-ag5evm.c
> index ce5c251..e6dabaa 100644
> --- a/arch/arm/mach-shmobile/board-ag5evm.c
> +++ b/arch/arm/mach-shmobile/board-ag5evm.c
> @@ -270,7 +270,7 @@ static struct sh_mobile_lcdc_info lcdc0_info = {
> .flags = LCDC_FLAGS_DWPOL,
> .lcd_size_cfg.width = 44,
> .lcd_size_cfg.height = 79,
> - .bpp = 16,
> + .fourcc = V4L2_PIX_FMT_RGB565,
> .lcd_cfg = lcdc0_modes,
> .num_cfg = ARRAY_SIZE(lcdc0_modes),
> .board_cfg = {
> diff --git a/arch/arm/mach-shmobile/board-ap4evb.c b/arch/arm/mach-shmobile/board-ap4evb.c
> index 9e0856b..6f5db07 100644
> --- a/arch/arm/mach-shmobile/board-ap4evb.c
> +++ b/arch/arm/mach-shmobile/board-ap4evb.c
> @@ -489,7 +489,7 @@ static struct sh_mobile_lcdc_info lcdc_info = {
> .meram_dev = &meram_info,
> .ch[0] = {
> .chan = LCDC_CHAN_MAINLCD,
> - .bpp = 16,
> + .fourcc = V4L2_PIX_FMT_RGB565,
> .lcd_cfg = ap4evb_lcdc_modes,
> .num_cfg = ARRAY_SIZE(ap4evb_lcdc_modes),
> .meram_cfg = &lcd_meram_cfg,
> @@ -783,7 +783,7 @@ static struct sh_mobile_lcdc_info sh_mobile_lcdc1_info = {
> .meram_dev = &meram_info,
> .ch[0] = {
> .chan = LCDC_CHAN_MAINLCD,
> - .bpp = 16,
> + .fourcc = V4L2_PIX_FMT_RGB565,
> .interface_type = RGB24,
> .clock_divider = 1,
> .flags = LCDC_FLAGS_DWPOL,
> diff --git a/arch/arm/mach-shmobile/board-mackerel.c b/arch/arm/mach-shmobile/board-mackerel.c
> index 6e3c2df..6e36349 100644
> --- a/arch/arm/mach-shmobile/board-mackerel.c
> +++ b/arch/arm/mach-shmobile/board-mackerel.c
> @@ -387,7 +387,7 @@ static struct sh_mobile_lcdc_info lcdc_info = {
> .clock_source = LCDC_CLK_BUS,
> .ch[0] = {
> .chan = LCDC_CHAN_MAINLCD,
> - .bpp = 16,
> + .fourcc = V4L2_PIX_FMT_RGB565,
> .lcd_cfg = mackerel_lcdc_modes,
> .num_cfg = ARRAY_SIZE(mackerel_lcdc_modes),
> .interface_type = RGB24,
> @@ -450,7 +450,7 @@ static struct sh_mobile_lcdc_info hdmi_lcdc_info = {
> .clock_source = LCDC_CLK_EXTERNAL,
> .ch[0] = {
> .chan = LCDC_CHAN_MAINLCD,
> - .bpp = 16,
> + .fourcc = V4L2_PIX_FMT_RGB565,
> .interface_type = RGB24,
> .clock_divider = 1,
> .flags = LCDC_FLAGS_DWPOL,
> diff --git a/drivers/video/sh_mobile_lcdcfb.c b/drivers/video/sh_mobile_lcdcfb.c
> index 97ab8ba..ea3f619 100644
> --- a/drivers/video/sh_mobile_lcdcfb.c
> +++ b/drivers/video/sh_mobile_lcdcfb.c
> @@ -17,6 +17,7 @@
> #include <linux/platform_device.h>
> #include <linux/dma-mapping.h>
> #include <linux/interrupt.h>
> +#include <linux/videodev2.h>
> #include <linux/vmalloc.h>
> #include <linux/ioctl.h>
> #include <linux/slab.h>
> @@ -101,7 +102,7 @@ struct sh_mobile_lcdc_priv {
> struct sh_mobile_lcdc_chan ch[2];
> struct notifier_block notifier;
> int started;
> - int forced_bpp; /* 2 channel LCDC must share bpp setting */
> + int forced_fourcc; /* 2 channel LCDC must share fourcc setting */
> struct sh_mobile_meram_info *meram_dev;
> };
>
> @@ -214,6 +215,42 @@ struct sh_mobile_lcdc_sys_bus_ops sh_mobile_lcdc_sys_bus_ops = {
> lcdc_sys_read_data,
> };
>
> +static int sh_mobile_format_fourcc(const struct fb_var_screeninfo *var)
> +{
> + if (var->format.fourcc > 1)
> + return var->format.fourcc;
> +
> + switch (var->bits_per_pixel) {
> + case 16:
> + return V4L2_PIX_FMT_RGB565;
> + case 24:
> + return V4L2_PIX_FMT_BGR24;
> + case 32:
> + return V4L2_PIX_FMT_BGR32;
> + default:
> + return 0;
> + }
> +}
> +
> +static bool sh_mobile_format_yuv(const struct fb_var_screeninfo *var)
> +{
> + if (var->format.fourcc <= 1)
> + return false;
> +
> + switch (var->format.fourcc) {
> + case V4L2_PIX_FMT_NV12:
> + case V4L2_PIX_FMT_NV21:
> + case V4L2_PIX_FMT_NV16:
> + case V4L2_PIX_FMT_NV61:
> + case V4L2_PIX_FMT_NV24:
> + case V4L2_PIX_FMT_NV42:
> + return true;
> +
> + default:
> + return false;
> + }
> +}
> +
> static void sh_mobile_lcdc_clk_on(struct sh_mobile_lcdc_priv *priv)
> {
> if (atomic_inc_and_test(&priv->hw_usecnt)) {
> @@ -434,7 +471,6 @@ static void __sh_mobile_lcdc_start(struct sh_mobile_lcdc_priv *priv)
> {
> struct sh_mobile_lcdc_chan *ch;
> unsigned long tmp;
> - int bpp = 0;
> int k, m;
>
> /* Enable LCDC channels. Read data from external memory, avoid using the
> @@ -453,9 +489,6 @@ static void __sh_mobile_lcdc_start(struct sh_mobile_lcdc_priv *priv)
> if (!ch->enabled)
> continue;
>
> - if (!bpp)
> - bpp = ch->info->var.bits_per_pixel;
> -
> /* Power supply */
> lcdc_write_chan(ch, LDPMR, 0);
>
> @@ -486,31 +519,37 @@ static void __sh_mobile_lcdc_start(struct sh_mobile_lcdc_priv *priv)
>
> sh_mobile_lcdc_geometry(ch);
>
> - if (ch->info->var.nonstd) {
> - tmp = (ch->info->var.nonstd << 16);
> - switch (ch->info->var.bits_per_pixel) {
> - case 12:
> - tmp |= LDDFR_YF_420;
> - break;
> - case 16:
> - tmp |= LDDFR_YF_422;
> - break;
> - case 24:
> - default:
> - tmp |= LDDFR_YF_444;
> - break;
> - }
> - } else {
> - switch (ch->info->var.bits_per_pixel) {
> - case 16:
> - tmp = LDDFR_PKF_RGB16;
> - break;
> - case 24:
> - tmp = LDDFR_PKF_RGB24;
> + switch (sh_mobile_format_fourcc(&ch->info->var)) {
> + case V4L2_PIX_FMT_RGB565:
> + tmp = LDDFR_PKF_RGB16;
> + break;
> + case V4L2_PIX_FMT_BGR24:
> + tmp = LDDFR_PKF_RGB24;
> + break;
> + case V4L2_PIX_FMT_BGR32:
> + tmp = LDDFR_PKF_ARGB32;
> + break;
> + case V4L2_PIX_FMT_NV12:
> + case V4L2_PIX_FMT_NV21:
> + tmp = LDDFR_CC | LDDFR_YF_420;
> + break;
> + case V4L2_PIX_FMT_NV16:
> + case V4L2_PIX_FMT_NV61:
> + tmp = LDDFR_CC | LDDFR_YF_422;
> + break;
> + case V4L2_PIX_FMT_NV24:
> + case V4L2_PIX_FMT_NV42:
> + tmp = LDDFR_CC | LDDFR_YF_444;
> + break;
> + }
> +
> + if (sh_mobile_format_yuv(&ch->info->var)) {
> + switch (ch->info->var.format.colorspace) {
> + case V4L2_COLORSPACE_REC709:
> + tmp |= LDDFR_CF1;
> break;
> - case 32:
> - default:
> - tmp = LDDFR_PKF_ARGB32;
> + case V4L2_COLORSPACE_JPEG:
> + tmp |= LDDFR_CF0;
> break;
> }
> }
> @@ -518,7 +557,7 @@ static void __sh_mobile_lcdc_start(struct sh_mobile_lcdc_priv *priv)
> lcdc_write_chan(ch, LDDFR, tmp);
> lcdc_write_chan(ch, LDMLSR, ch->pitch);
> lcdc_write_chan(ch, LDSA1R, ch->base_addr_y);
> - if (ch->info->var.nonstd)
> + if (sh_mobile_format_yuv(&ch->info->var))
> lcdc_write_chan(ch, LDSA2R, ch->base_addr_c);
>
> /* When using deferred I/O mode, configure the LCDC for one-shot
> @@ -535,21 +574,23 @@ static void __sh_mobile_lcdc_start(struct sh_mobile_lcdc_priv *priv)
> }
>
> /* Word and long word swap. */
> - if (priv->ch[0].info->var.nonstd)
> + switch (sh_mobile_format_fourcc(&priv->ch[0].info->var)) {
> + case V4L2_PIX_FMT_RGB565:
> + case V4L2_PIX_FMT_NV21:
> + case V4L2_PIX_FMT_NV61:
> + case V4L2_PIX_FMT_NV42:
> + tmp = LDDDSR_LS | LDDDSR_WS;
> + break;
> + case V4L2_PIX_FMT_BGR24:
> + case V4L2_PIX_FMT_NV12:
> + case V4L2_PIX_FMT_NV16:
> + case V4L2_PIX_FMT_NV24:
> tmp = LDDDSR_LS | LDDDSR_WS | LDDDSR_BS;
> - else {
> - switch (bpp) {
> - case 16:
> - tmp = LDDDSR_LS | LDDDSR_WS;
> - break;
> - case 24:
> - tmp = LDDDSR_LS | LDDDSR_WS | LDDDSR_BS;
> - break;
> - case 32:
> - default:
> - tmp = LDDDSR_LS;
> - break;
> - }
> + break;
> + case V4L2_PIX_FMT_BGR32:
> + default:
> + tmp = LDDDSR_LS;
> + break;
> }
> lcdc_write(priv, _LDDDSR, tmp);
>
> @@ -621,12 +662,24 @@ static int sh_mobile_lcdc_start(struct sh_mobile_lcdc_priv *priv)
> ch->meram_enabled = 0;
> }
>
> - if (!ch->info->var.nonstd)
> - pixelformat = SH_MOBILE_MERAM_PF_RGB;
> - else if (ch->info->var.bits_per_pixel = 24)
> - pixelformat = SH_MOBILE_MERAM_PF_NV24;
> - else
> + switch (sh_mobile_format_fourcc(&ch->info->var)) {
> + case V4L2_PIX_FMT_NV12:
> + case V4L2_PIX_FMT_NV21:
> + case V4L2_PIX_FMT_NV16:
> + case V4L2_PIX_FMT_NV61:
> pixelformat = SH_MOBILE_MERAM_PF_NV;
> + break;
> + case V4L2_PIX_FMT_NV24:
> + case V4L2_PIX_FMT_NV42:
> + pixelformat = SH_MOBILE_MERAM_PF_NV24;
> + break;
> + case V4L2_PIX_FMT_RGB565:
> + case V4L2_PIX_FMT_BGR24:
> + case V4L2_PIX_FMT_BGR32:
> + default:
> + pixelformat = SH_MOBILE_MERAM_PF_RGB;
> + break;
> + }
>
> ret = mdev->ops->meram_register(mdev, cfg, ch->pitch,
> ch->info->var.yres, pixelformat,
> @@ -844,6 +897,7 @@ static struct fb_fix_screeninfo sh_mobile_lcdc_fix = {
> .xpanstep = 0,
> .ypanstep = 1,
> .ywrapstep = 0,
> + .capabilities = FB_CAP_FOURCC,
> };
>
> static void sh_mobile_lcdc_fillrect(struct fb_info *info,
> @@ -876,8 +930,9 @@ static int sh_mobile_fb_pan_display(struct fb_var_screeninfo *var,
> unsigned long new_pan_offset;
> unsigned long base_addr_y, base_addr_c;
> unsigned long c_offset;
> + bool yuv = sh_mobile_format_yuv(&info->var);
>
> - if (!info->var.nonstd)
> + if (!yuv)
> new_pan_offset = var->yoffset * info->fix.line_length
> + var->xoffset * (info->var.bits_per_pixel / 8);
> else
> @@ -891,7 +946,7 @@ static int sh_mobile_fb_pan_display(struct fb_var_screeninfo *var,
>
> /* Set the source address for the next refresh */
> base_addr_y = ch->dma_handle + new_pan_offset;
> - if (info->var.nonstd) {
> + if (yuv) {
> /* Set y offset */
> c_offset = var->yoffset * info->fix.line_length
> * (info->var.bits_per_pixel - 8) / 8;
> @@ -899,7 +954,7 @@ static int sh_mobile_fb_pan_display(struct fb_var_screeninfo *var,
> + info->var.xres * info->var.yres_virtual
> + c_offset;
> /* Set x offset */
> - if (info->var.bits_per_pixel = 24)
> + if (sh_mobile_format_fourcc(&info->var) = V4L2_PIX_FMT_NV24)
> base_addr_c += 2 * var->xoffset;
> else
> base_addr_c += var->xoffset;
> @@ -923,7 +978,7 @@ static int sh_mobile_fb_pan_display(struct fb_var_screeninfo *var,
> ch->base_addr_c = base_addr_c;
>
> lcdc_write_chan_mirror(ch, LDSA1R, base_addr_y);
> - if (info->var.nonstd)
> + if (yuv)
> lcdc_write_chan_mirror(ch, LDSA2R, base_addr_c);
>
> if (lcdc_chan_is_sublcd(ch))
> @@ -1099,51 +1154,78 @@ static int sh_mobile_check_var(struct fb_var_screeninfo *var, struct fb_info *in
> if (var->yres_virtual < var->yres)
> var->yres_virtual = var->yres;
>
> - if (var->bits_per_pixel <= 16) { /* RGB 565 */
> - var->bits_per_pixel = 16;
> - var->red.offset = 11;
> - var->red.length = 5;
> - var->green.offset = 5;
> - var->green.length = 6;
> - var->blue.offset = 0;
> - var->blue.length = 5;
> - var->transp.offset = 0;
> - var->transp.length = 0;
> - } else if (var->bits_per_pixel <= 24) { /* RGB 888 */
> - var->bits_per_pixel = 24;
> - var->red.offset = 16;
> - var->red.length = 8;
> - var->green.offset = 8;
> - var->green.length = 8;
> - var->blue.offset = 0;
> - var->blue.length = 8;
> - var->transp.offset = 0;
> - var->transp.length = 0;
> - } else if (var->bits_per_pixel <= 32) { /* RGBA 888 */
> - var->bits_per_pixel = 32;
> - var->red.offset = 16;
> - var->red.length = 8;
> - var->green.offset = 8;
> - var->green.length = 8;
> - var->blue.offset = 0;
> - var->blue.length = 8;
> - var->transp.offset = 24;
> - var->transp.length = 8;
> - } else
> - return -EINVAL;
> + if (var->format.fourcc > 1) {
> + switch (var->format.fourcc) {
> + case V4L2_PIX_FMT_NV12:
> + case V4L2_PIX_FMT_NV21:
> + var->bits_per_pixel = 12;
> + break;
> + case V4L2_PIX_FMT_RGB565:
> + case V4L2_PIX_FMT_NV16:
> + case V4L2_PIX_FMT_NV61:
> + var->bits_per_pixel = 16;
> + break;
> + case V4L2_PIX_FMT_BGR24:
> + case V4L2_PIX_FMT_NV24:
> + case V4L2_PIX_FMT_NV42:
> + var->bits_per_pixel = 24;
> + break;
> + case V4L2_PIX_FMT_BGR32:
> + var->bits_per_pixel = 32;
> + break;
> + default:
> + return -EINVAL;
> + }
> +
> + memset(var->format.reserved, 0, sizeof(var->format.reserved));
If we decide to use another of the reserved area this won't have the desired
behavior as the behavior of this driver will change even if it does not support
the new field. Probably the best thing is to get the desired behavior is zeroing
the whole struct and setting the supported fields to the actual values.
You should check and adjust colorspace here as well.
> + } else {
> + if (var->bits_per_pixel <= 16) { /* RGB 565 */
> + var->bits_per_pixel = 16;
> + var->red.offset = 11;
> + var->red.length = 5;
> + var->green.offset = 5;
> + var->green.length = 6;
> + var->blue.offset = 0;
> + var->blue.length = 5;
> + var->transp.offset = 0;
> + var->transp.length = 0;
> + } else if (var->bits_per_pixel <= 24) { /* RGB 888 */
> + var->bits_per_pixel = 24;
> + var->red.offset = 16;
> + var->red.length = 8;
> + var->green.offset = 8;
> + var->green.length = 8;
> + var->blue.offset = 0;
> + var->blue.length = 8;
> + var->transp.offset = 0;
> + var->transp.length = 0;
> + } else if (var->bits_per_pixel <= 32) { /* RGBA 888 */
> + var->bits_per_pixel = 32;
> + var->red.offset = 16;
> + var->red.length = 8;
> + var->green.offset = 8;
> + var->green.length = 8;
> + var->blue.offset = 0;
> + var->blue.length = 8;
> + var->transp.offset = 24;
> + var->transp.length = 8;
> + } else
> + return -EINVAL;
>
> - var->red.msb_right = 0;
> - var->green.msb_right = 0;
> - var->blue.msb_right = 0;
> - var->transp.msb_right = 0;
> + var->red.msb_right = 0;
> + var->green.msb_right = 0;
> + var->blue.msb_right = 0;
> + var->transp.msb_right = 0;
> + }
>
> /* Make sure we don't exceed our allocated memory. */
> if (var->xres_virtual * var->yres_virtual * var->bits_per_pixel / 8 >
> info->fix.smem_len)
> return -EINVAL;
>
> - /* only accept the forced_bpp for dual channel configurations */
> - if (p->forced_bpp && p->forced_bpp != var->bits_per_pixel)
> + /* only accept the forced_fourcc for dual channel configurations */
> + if (p->forced_fourcc &&
> + p->forced_fourcc != sh_mobile_format_fourcc(var))
> return -EINVAL;
>
> return 0;
> @@ -1157,7 +1239,7 @@ static int sh_mobile_set_par(struct fb_info *info)
>
> sh_mobile_lcdc_stop(ch->lcdc);
>
> - if (info->var.nonstd)
> + if (sh_mobile_format_yuv(&info->var))
> info->fix.line_length = info->var.xres;
> else
> info->fix.line_length = info->var.xres
> @@ -1169,6 +1251,11 @@ static int sh_mobile_set_par(struct fb_info *info)
> info->fix.line_length = line_length;
> }
>
> + if (info->var.format.fourcc > 1)
> + info->fix.visual = FB_VISUAL_FOURCC;
> + else
> + info->fix.visual = FB_VISUAL_TRUECOLOR;
> +
> return ret;
> }
>
> @@ -1463,9 +1550,9 @@ static int __devinit sh_mobile_lcdc_channel_init(struct sh_mobile_lcdc_chan *ch,
> for (i = 0, mode = cfg->lcd_cfg; i < cfg->num_cfg; i++, mode++) {
> unsigned int size = mode->yres * mode->xres;
>
> - /* NV12 buffers must have even number of lines */
> - if ((cfg->nonstd) && cfg->bpp = 12 &&
> - (mode->yres & 0x1)) {
> + /* NV12/NV21 buffers must have even number of lines */
> + if ((cfg->fourcc = V4L2_PIX_FMT_NV12 ||
> + cfg->fourcc = V4L2_PIX_FMT_NV21) && (mode->yres & 0x1)) {
> dev_err(dev, "yres must be multiple of 2 for YCbCr420 "
> "mode.\n");
> return -EINVAL;
> @@ -1483,14 +1570,6 @@ static int __devinit sh_mobile_lcdc_channel_init(struct sh_mobile_lcdc_chan *ch,
> dev_dbg(dev, "Found largest videomode %ux%u\n",
> max_mode->xres, max_mode->yres);
>
> - /* Initialize fixed screen information. Restrict pan to 2 lines steps
> - * for NV12.
> - */
> - info->fix = sh_mobile_lcdc_fix;
> - info->fix.smem_len = max_size * 2 * cfg->bpp / 8;
> - if (cfg->nonstd && cfg->bpp = 12)
> - info->fix.ypanstep = 2;
> -
> /* Create the mode list. */
> if (cfg->lcd_cfg = NULL) {
> mode = &default_720p;
> @@ -1508,19 +1587,38 @@ static int __devinit sh_mobile_lcdc_channel_init(struct sh_mobile_lcdc_chan *ch,
> */
> var = &info->var;
> fb_videomode_to_var(var, mode);
> - var->bits_per_pixel = cfg->bpp;
> var->width = cfg->lcd_size_cfg.width;
> var->height = cfg->lcd_size_cfg.height;
> var->yres_virtual = var->yres * 2;
> var->activate = FB_ACTIVATE_NOW;
>
> + switch (cfg->fourcc) {
> + case V4L2_PIX_FMT_RGB565:
> + var->bits_per_pixel = 16;
> + break;
> + case V4L2_PIX_FMT_BGR24:
> + var->bits_per_pixel = 24;
> + break;
> + case V4L2_PIX_FMT_BGR32:
> + var->bits_per_pixel = 32;
> + break;
> + default:
> + var->format.fourcc = cfg->fourcc;
> + break;
> + }
> +
> + /* Make sure the memory size check won't fail. smem_len is initialized
> + * later based on var.
> + */
> + info->fix.smem_len = UINT_MAX;
> ret = sh_mobile_check_var(var, info);
> if (ret)
> return ret;
>
> + max_size *= var->bits_per_pixel / 8 * 2;
> +
> /* Allocate frame buffer memory and color map. */
> - buf = dma_alloc_coherent(dev, info->fix.smem_len, &ch->dma_handle,
> - GFP_KERNEL);
> + buf = dma_alloc_coherent(dev, max_size, &ch->dma_handle, GFP_KERNEL);
> if (!buf) {
> dev_err(dev, "unable to allocate buffer\n");
> return -ENOMEM;
> @@ -1529,16 +1627,25 @@ static int __devinit sh_mobile_lcdc_channel_init(struct sh_mobile_lcdc_chan *ch,
> ret = fb_alloc_cmap(&info->cmap, PALETTE_NR, 0);
> if (ret < 0) {
> dev_err(dev, "unable to allocate cmap\n");
> - dma_free_coherent(dev, info->fix.smem_len,
> - buf, ch->dma_handle);
> + dma_free_coherent(dev, max_size, buf, ch->dma_handle);
> return ret;
> }
>
> + /* Initialize fixed screen information. Restrict pan to 2 lines steps
> + * for NV12 and NV21.
> + */
> + info->fix = sh_mobile_lcdc_fix;
> info->fix.smem_start = ch->dma_handle;
> - if (var->nonstd)
> + info->fix.smem_len = max_size * var->bits_per_pixel / 8 * 2;
> + if (cfg->fourcc = V4L2_PIX_FMT_NV12 ||
> + cfg->fourcc = V4L2_PIX_FMT_NV21)
> + info->fix.ypanstep = 2;
> +
> + if (sh_mobile_format_yuv(var))
> info->fix.line_length = var->xres;
> else
> - info->fix.line_length = var->xres * (cfg->bpp / 8);
> + info->fix.line_length = var->xres * var->bits_per_pixel
> + / 8;
>
> info->screen_base = buf;
> info->device = dev;
> @@ -1625,9 +1732,9 @@ static int __devinit sh_mobile_lcdc_probe(struct platform_device *pdev)
> goto err1;
> }
>
> - /* for dual channel LCDC (MAIN + SUB) force shared bpp setting */
> + /* for dual channel LCDC (MAIN + SUB) force shared format setting */
> if (num_channels = 2)
> - priv->forced_bpp = pdata->ch[0].bpp;
> + priv->forced_fourcc = pdata->ch[0].fourcc;
>
> priv->base = ioremap_nocache(res->start, resource_size(res));
> if (!priv->base)
> @@ -1674,13 +1781,10 @@ static int __devinit sh_mobile_lcdc_probe(struct platform_device *pdev)
> if (error < 0)
> goto err1;
>
> - dev_info(info->dev,
> - "registered %s/%s as %dx%d %dbpp.\n",
> - pdev->name,
> - (ch->cfg.chan = LCDC_CHAN_MAINLCD) ?
> - "mainlcd" : "sublcd",
> - info->var.xres, info->var.yres,
> - ch->cfg.bpp);
> + dev_info(info->dev, "registered %s/%s as %dx%d %dbpp.\n",
> + pdev->name, (ch->cfg.chan = LCDC_CHAN_MAINLCD) ?
> + "mainlcd" : "sublcd", info->var.xres, info->var.yres,
> + info->var.bits_per_pixel);
>
> /* deferred io mode: disable clock to save power */
> if (info->fbdefio || info->state = FBINFO_STATE_SUSPENDED)
> diff --git a/include/video/sh_mobile_lcdc.h b/include/video/sh_mobile_lcdc.h
> index 8101b72..fe30b75 100644
> --- a/include/video/sh_mobile_lcdc.h
> +++ b/include/video/sh_mobile_lcdc.h
> @@ -174,7 +174,8 @@ struct sh_mobile_lcdc_bl_info {
>
> struct sh_mobile_lcdc_chan_cfg {
> int chan;
> - int bpp;
> + int fourcc;
> + int colorspace;
> int interface_type; /* selects RGBn or SYSn I/F, see above */
> int clock_divider;
> unsigned long flags; /* LCDC_FLAGS_... */
> @@ -184,7 +185,6 @@ struct sh_mobile_lcdc_chan_cfg {
> struct sh_mobile_lcdc_board_cfg board_cfg;
> struct sh_mobile_lcdc_bl_info bl_info;
> struct sh_mobile_lcdc_sys_bus_cfg sys_bus_cfg; /* only for SYSn I/F */
> - int nonstd;
> struct sh_mobile_meram_cfg *meram_cfg;
> };
>
Thanks,
Florian Tobias Schandinat
^ permalink raw reply
* Re: [PATCH] fbdev: fix parsing of standard timings
From: Florian Tobias Schandinat @ 2011-08-26 18:02 UTC (permalink / raw)
To: linux-fbdev
In-Reply-To: <1314362328-30456-1-git-send-email-tomi.valkeinen@ti.com>
Hi Tomi,
On 08/26/2011 12:38 PM, Tomi Valkeinen wrote:
> The standard timings parses uses 1:1 dimensions when the ratio in the
> EDID data is 0. However, for EDID 1.3 and later the dimensions are 16:10
> when the ratio is 0.
>
> Pass the version and revision numbers to get_std_timing() which can then
> make the right decision about dimensions.
>
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Thanks, looks good to me.
I'd be happy if someone with access to the original EDID specs could confirm
this and add his reviewed by.
I also think adding a comment explaining this change would be helpful.
> ---
> drivers/video/fbmon.c | 20 ++++++++++++++------
> 1 files changed, 14 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/video/fbmon.c b/drivers/video/fbmon.c
> index 4f57485..6a6f92e 100644
> --- a/drivers/video/fbmon.c
> +++ b/drivers/video/fbmon.c
> @@ -493,7 +493,8 @@ static int get_est_timing(unsigned char *block, struct fb_videomode *mode)
> return num;
> }
>
> -static int get_std_timing(unsigned char *block, struct fb_videomode *mode)
> +static int get_std_timing(unsigned char *block, struct fb_videomode *mode,
> + int ver, int rev)
> {
> int xres, yres = 0, refresh, ratio, i;
>
> @@ -504,7 +505,10 @@ static int get_std_timing(unsigned char *block, struct fb_videomode *mode)
> ratio = (block[1] & 0xc0) >> 6;
> switch (ratio) {
> case 0:
> - yres = xres;
/* in EDID 1.3 the meaning of 0 changed to 16:10 (prior 1:1) */
> + if (ver < 1 || (ver = 1 && rev < 3))
> + yres = xres;
> + else
> + yres = (xres * 10)/16;
> break;
> case 1:
> yres = (xres * 3)/4;
> @@ -533,12 +537,12 @@ static int get_std_timing(unsigned char *block, struct fb_videomode *mode)
> }
>
> static int get_dst_timing(unsigned char *block,
> - struct fb_videomode *mode)
> + struct fb_videomode *mode, int ver, int rev)
> {
> int j, num = 0;
>
> for (j = 0; j < 6; j++, block += STD_TIMING_DESCRIPTION_SIZE)
> - num += get_std_timing(block, &mode[num]);
> + num += get_std_timing(block, &mode[num], ver, rev);
>
> return num;
> }
> @@ -599,6 +603,10 @@ static struct fb_videomode *fb_create_modedb(unsigned char *edid, int *dbsize)
> struct fb_videomode *mode, *m;
> unsigned char *block;
> int num = 0, i, first = 1;
> + int ver, rev;
> +
> + ver = edid[EDID_STRUCT_VERSION];
> + rev = edid[EDID_STRUCT_REVISION];
>
> mode = kzalloc(50 * sizeof(struct fb_videomode), GFP_KERNEL);
> if (mode = NULL)
> @@ -632,12 +640,12 @@ static struct fb_videomode *fb_create_modedb(unsigned char *edid, int *dbsize)
> DPRINTK(" Standard Timings\n");
> block = edid + STD_TIMING_DESCRIPTIONS_START;
> for (i = 0; i < STD_TIMING; i++, block += STD_TIMING_DESCRIPTION_SIZE)
> - num += get_std_timing(block, &mode[num]);
> + num += get_std_timing(block, &mode[num], ver, rev);
>
> block = edid + DETAILED_TIMING_DESCRIPTIONS_START;
> for (i = 0; i < 4; i++, block+= DETAILED_TIMING_DESCRIPTION_SIZE) {
> if (block[0] = 0x00 && block[1] = 0x00 && block[3] = 0xfa)
> - num += get_dst_timing(block + 5, &mode[num]);
> + num += get_dst_timing(block + 5, &mode[num], ver, rev);
> }
>
> /* Yikes, EDID data is totally useless */
Thanks,
Florian Tobias Schandinat
^ permalink raw reply
* Beloved
From: Sister Deborah Mannings @ 2011-08-27 1:49 UTC (permalink / raw)
To: linux-fbdev
Beloved,I am Deborah Mannings.I write this email to you on my sick bed
facing death.I have a substantial sum I would like you to help me
distribute to the needy and helpless.God bless you as you reply through
mann_deb@yahoo.cn
^ permalink raw reply
* Re: [PATCH 1/4] OMAP: OMAPFB: make omapfb start even when a display
From: Jaya Kumar @ 2011-08-27 10:28 UTC (permalink / raw)
To: Tomi Valkeinen; +Cc: linux-omap, linux-fbdev, archit
In-Reply-To: <1314001636-18036-2-git-send-email-tomi.valkeinen@ti.com>
On Mon, Aug 22, 2011 at 4:27 PM, Tomi Valkeinen <tomi.valkeinen@ti.com> wrote:
> Currently omapfb wants that all the display devices have a driver,
> otherwise omapfb refuses to start. There's no real requirement to act
> like that, and this patch will make omapfb give a warning and skip that
> device.
Hi Tomi,
Just a question, I am working with an out-of-tree hdmi driver for the
NXP TDA9984 with dm3730. This worked fine in 2.6.32 as a runtime
loaded dss display driver. That is:
+static struct omap_dss_device wiser2_hdmi_device = {
+ .type = OMAP_DISPLAY_TYPE_DPI,
+ .name = "hdmi",
+ .driver_name = "hdmi_panel",
+ .phy.dpi.data_lines = 24,
+ .platform_enable = wiser2_enable_hdmi,
+ .platform_disable = wiser2_disable_hdmi,
+};
+
+static struct omap_dss_device wiser2_tv_device = {
+ .name = "tv",
+ .driver_name = "venc",
+ .type = OMAP_DISPLAY_TYPE_VENC,
+ .phy.venc.type = OMAP_DSS_VENC_TYPE_SVIDEO,
+ .platform_enable = wiser2_panel_enable_tv,
+ .platform_disable = wiser2_panel_disable_tv,
+};
+
+static struct omap_dss_device *wiser2_dss_devices[] = {
+ &wiser2_dvi_device,
+ &wiser2_tv_device,
+ &wiser2_hdmi_device,
+};
so this hdmi_panel omap_dss_driver was being insmoded after init at
bootup and it worked fine, no problems with omaplfb so pvr stuff
worked fine.
I then switched to 2.6.37 (from TI devkit 2.1 gingerbread) and this
kernel wasn't so happy (panic at boot). I applied your patch below. I
also figured out that omap_vout had a similar problem as the one
you've fixed which was what was causing the panic (omap_vout tries to
call display->driver->update without checking if driver exists):
diff --git a/drivers/media/video/omap/omap_vout.c
b/drivers/media/video/omap/omap_vout.c
index 2aee372..36d69db 100644
--- a/drivers/media/video/omap/omap_vout.c
+++ b/drivers/media/video/omap/omap_vout.c
@@ -2574,24 +2591,32 @@ static int __init omap_vout_probe(struct
platform_device *pdev)
+ printk(KERN_INFO "%s:%d\n", __func__, __LINE__);
for (i = 0; i < vid_dev->num_displays; i++) {
struct omap_dss_device *display = vid_dev->displays[i];
- if (display->driver->update)
+ printk(KERN_INFO "%s:%d\n", __func__, __LINE__);
+ if ((display->driver) && (display->driver->update)) {
+ printk(KERN_INFO "%s:%d\n", __func__, __LINE__);
display->driver->update(display, 0, 0,
display->panel.timings.x_res,
display->panel.timings.y_res);
+ }
+ printk(KERN_INFO "%s:%d\n", __func__, __LINE__);
}
+ printk(KERN_INFO "%s:%d\n", __func__, __LINE__);
return 0;
After that change, it boots up cleanly but I don't get any display
output. I noticed that:
echo 1 > /sys/devices/omapdss/display2/enabled
no longer works. display2 stays enabled=0 rather than coming on.
I'm planning on debugging this some more when I have some free time.
But I figured I should ask first if this is a known problem, whether
anyone else is testing runtime loaded omap_dss_driver stuff and if
anyone has gotten it to work with kernels 2.6.37 and above.
Thanks,
jaya
>
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
> ---
> drivers/video/omap2/omapfb/omapfb-main.c | 5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/omap2/omapfb/omapfb-main.c b/drivers/video/omap2/omapfb/omapfb-main.c
> index e5a64b3..cd2cae8e 100644
> --- a/drivers/video/omap2/omapfb/omapfb-main.c
> +++ b/drivers/video/omap2/omapfb/omapfb-main.c
> @@ -2373,9 +2373,10 @@ static int omapfb_probe(struct platform_device *pdev)
> omap_dss_get_device(dssdev);
>
> if (!dssdev->driver) {
> - dev_err(&pdev->dev, "no driver for display: %s\n",
> + dev_warn(&pdev->dev, "no driver for display: %s\n",
> dssdev->name);
> - r = -ENODEV;
> + omap_dss_put_device(dssdev);
> + continue;
> }
>
> d = &fbdev->displays[fbdev->num_displays++];
> --
> 1.7.4.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply related
* [PATCH] MAINTAINERS: change framebuffer maintainer
From: Florian Tobias Schandinat @ 2011-08-27 19:32 UTC (permalink / raw)
To: Linus Torvalds
Cc: Paul Mundt, linux-fbdev, linux-kernel, Florian Tobias Schandinat
In-Reply-To: <4E4A1AB1.6040001@gmx.de>
As Paul has not much time for it I take over maintaining the
framebuffer subsystem.
Signed-off-by: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
---
MAINTAINERS | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 1d445f5..ac7e485 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2649,11 +2649,11 @@ F: drivers/net/wan/dlci.c
F: drivers/net/wan/sdla.c
FRAMEBUFFER LAYER
-M: Paul Mundt <lethal@linux-sh.org>
+M: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
L: linux-fbdev@vger.kernel.org
W: http://linux-fbdev.sourceforge.net/
Q: http://patchwork.kernel.org/project/linux-fbdev/list/
-T: git git://git.kernel.org/pub/scm/linux/kernel/git/lethal/fbdev-2.6.git
+T: git git://github.com/schandinat/linux-2.6.git fbdev-next
S: Maintained
F: Documentation/fb/
F: Documentation/devicetree/bindings/fb/
--
1.6.3.2
^ permalink raw reply related
* Re: [PATCH/RFC v2 1/3] fbdev: Add FOURCC-based format configuration API
From: Laurent Pinchart @ 2011-08-28 8:48 UTC (permalink / raw)
To: Florian Tobias Schandinat; +Cc: linux-fbdev, linux-media, magnus.damm
In-Reply-To: <4E57D2B5.7020604@gmx.de>
Hi Florian,
Thank you for the review.
On Friday 26 August 2011 19:07:01 Florian Tobias Schandinat wrote:
> Hi Laurent,
>
> hope we're close to the final thing now. Just a few minor issues.
I agree with all your comments, I'll fix the patches accordingly.
--
Regards,
Laurent Pinchart
^ permalink raw reply
* Re: [PATCH/RFC v2 3/3] fbdev: sh_mobile_lcdc: Support FOURCC-based format API
From: Laurent Pinchart @ 2011-08-28 8:59 UTC (permalink / raw)
To: Florian Tobias Schandinat; +Cc: linux-fbdev, linux-media, magnus.damm
In-Reply-To: <4E57D6B2.40001@gmx.de>
Hi Florian,
Thanks for the review.
On Friday 26 August 2011 19:24:02 Florian Tobias Schandinat wrote:
> On 08/19/2011 09:37 AM, Laurent Pinchart wrote:
[snip]
> > diff --git a/drivers/video/sh_mobile_lcdcfb.c
> > b/drivers/video/sh_mobile_lcdcfb.c index 97ab8ba..ea3f619 100644
> > --- a/drivers/video/sh_mobile_lcdcfb.c
> > +++ b/drivers/video/sh_mobile_lcdcfb.c
[snip]
> > @@ -1099,51 +1154,78 @@ static int sh_mobile_check_var(struct
[snip]
> > + if (var->format.fourcc > 1) {
> > + switch (var->format.fourcc) {
> > + case V4L2_PIX_FMT_NV12:
> > + case V4L2_PIX_FMT_NV21:
> > + var->bits_per_pixel = 12;
> > + break;
> > + case V4L2_PIX_FMT_RGB565:
> > + case V4L2_PIX_FMT_NV16:
> > + case V4L2_PIX_FMT_NV61:
> > + var->bits_per_pixel = 16;
> > + break;
> > + case V4L2_PIX_FMT_BGR24:
> > + case V4L2_PIX_FMT_NV24:
> > + case V4L2_PIX_FMT_NV42:
> > + var->bits_per_pixel = 24;
> > + break;
> > + case V4L2_PIX_FMT_BGR32:
> > + var->bits_per_pixel = 32;
> > + break;
> > + default:
> > + return -EINVAL;
> > + }
> > +
> > + memset(var->format.reserved, 0, sizeof(var->format.reserved));
>
> If we decide to use another of the reserved area this won't have the
> desired behavior as the behavior of this driver will change even if it
> does not support the new field. Probably the best thing is to get the
> desired behavior is zeroing the whole struct and setting the supported
> fields to the actual values. You should check and adjust colorspace here
> as well.
Agreed. I'll fix the patch accordingly.
--
Regards,
Laurent Pinchart
^ permalink raw reply
* Re: linux-next tree addition request (fbdev)
From: Stephen Rothwell @ 2011-08-28 16:19 UTC (permalink / raw)
To: Florian Tobias Schandinat
Cc: linux-next, linux-fbdev@vger.kernel.org, Paul Mundt
In-Reply-To: <20110825003353.e930fc7a664dd99c953b555c@canb.auug.org.au>
[-- Attachment #1: Type: text/plain, Size: 1206 bytes --]
Hi Florian,
On Thu, 25 Aug 2011 00:33:53 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> On Wed, 24 Aug 2011 13:40:46 +0000 Florian Tobias Schandinat <FlorianSchandinat@gmx.de> wrote:
> >
> > can you please add
> >
> > git://github.com/schandinat/linux-2.6.git fbdev-next
> >
> > to linux-next. It collects patches for the frame buffer subsystem.
> > Can you please add the linux-fbdev@vger.kernel.org mailing list as additional
> > contact for warnings/errors/problems?
> >
> > You probably want to drop Paul's fbdev branches as they contain some outdated
> > patches that will conflict with the newer versions.
>
> OK, Paul is still listed as the frame buffer subsystem maintainer, so I
> will need an Ack from him. When I get that, I will replace his tree with
> yours. I assume someone will update the MAINTAINERS file.
>
> I also have another tree from Paul (called fbdev-current) that contained
> fixes for Linus' current release. I also assume that that tree will be
> dropped (unless you have a new version of that as well).
Ping? Anyone?
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]
^ permalink raw reply
* Re: [PATCH/RFC v2 3/3] fbdev: sh_mobile_lcdc: Support FOURCC-based
From: Magnus Damm @ 2011-08-29 0:39 UTC (permalink / raw)
To: Laurent Pinchart; +Cc: linux-fbdev, linux-media
In-Reply-To: <1313746626-23845-4-git-send-email-laurent.pinchart@ideasonboard.com>
On Fri, Aug 19, 2011 at 6:37 PM, Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> arch/arm/mach-shmobile/board-ag5evm.c | 2 +-
> arch/arm/mach-shmobile/board-ap4evb.c | 4 +-
> arch/arm/mach-shmobile/board-mackerel.c | 4 +-
> drivers/video/sh_mobile_lcdcfb.c | 342 ++++++++++++++++++++-----------
> include/video/sh_mobile_lcdc.h | 4 +-
> 5 files changed, 230 insertions(+), 126 deletions(-)
Hi Laurent, thanks for the patch!
Since you're changing the LCDC platform data please make sure you also
update the 5 boards using the LCDC under arch/sh.
Thanks,
/ magnus
^ permalink raw reply
* Re: [PATCH] MAINTAINERS: change framebuffer maintainer
From: Paul Mundt @ 2011-08-29 6:01 UTC (permalink / raw)
To: Florian Tobias Schandinat; +Cc: Linus Torvalds, linux-fbdev, linux-kernel
In-Reply-To: <1314473554-3317-1-git-send-email-FlorianSchandinat@gmx.de>
On Sat, Aug 27, 2011 at 07:32:34PM +0000, Florian Tobias Schandinat wrote:
> As Paul has not much time for it I take over maintaining the
> framebuffer subsystem.
>
> Signed-off-by: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
Acked-by: Paul Mundt <lethal@linux-sh.org>
^ permalink raw reply
* Re: linux-next tree addition request (fbdev)
From: Paul Mundt @ 2011-08-29 6:02 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Florian Tobias Schandinat, linux-next,
linux-fbdev@vger.kernel.org
In-Reply-To: <20110829021930.0112cf98fbafd7380e09e164@canb.auug.org.au>
On Mon, Aug 29, 2011 at 02:19:30AM +1000, Stephen Rothwell wrote:
> Hi Florian,
>
> On Thu, 25 Aug 2011 00:33:53 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > On Wed, 24 Aug 2011 13:40:46 +0000 Florian Tobias Schandinat <FlorianSchandinat@gmx.de> wrote:
> > >
> > > can you please add
> > >
> > > git://github.com/schandinat/linux-2.6.git fbdev-next
> > >
> > > to linux-next. It collects patches for the frame buffer subsystem.
> > > Can you please add the linux-fbdev@vger.kernel.org mailing list as additional
> > > contact for warnings/errors/problems?
> > >
> > > You probably want to drop Paul's fbdev branches as they contain some outdated
> > > patches that will conflict with the newer versions.
> >
> > OK, Paul is still listed as the frame buffer subsystem maintainer, so I
> > will need an Ack from him. When I get that, I will replace his tree with
> > yours. I assume someone will update the MAINTAINERS file.
> >
> > I also have another tree from Paul (called fbdev-current) that contained
> > fixes for Linus' current release. I also assume that that tree will be
> > dropped (unless you have a new version of that as well).
>
> Ping? Anyone?
>
As long as Florian is taking care of the backlog of the stuff that is
already sitting in that branch, I have no problems with it being dropped.
I'm not planning on pushing any updates to it anyways.
^ permalink raw reply
* Re: [PATCH/RFC v2 1/3] fbdev: Add FOURCC-based format configuration API
From: Geert Uytterhoeven @ 2011-08-29 8:13 UTC (permalink / raw)
To: Laurent Pinchart; +Cc: linux-fbdev, linux-media, magnus.damm
In-Reply-To: <1313746626-23845-2-git-send-email-laurent.pinchart@ideasonboard.com>
Hi Laurent,
My comments are mainly about the documentation of the "legacy" bits.
On Fri, Aug 19, 2011 at 11:37, Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
> diff --git a/Documentation/fb/api.txt b/Documentation/fb/api.txt
> new file mode 100644
> index 0000000..6808492
> --- /dev/null
> +++ b/Documentation/fb/api.txt
> +2. Types and visuals
> +--------------------
> +
> +Pixels are stored in memory in hardware-dependent formats. Applications need
> +to be aware of the pixel storage format in order to write image data to the
> +frame buffer memory in the format expected by the hardware.
> +
> +Formats are described by frame buffer types and visuals. Some visuals require
> +additional information, which are stored in the variable screen information
> +bits_per_pixel, grayscale, fourcc, red, green, blue and transp fields.
> +
> +The following types and visuals are supported.
> +
> +- FB_TYPE_PACKED_PIXELS
> +
> +Color components (usually RGB or YUV) are packed together into macropixels
> +that are stored in a single plane. The exact color components layout is
> +described in a visual-dependent way.
> +
> +Frame buffer visuals that don't use multiple color components per pixel
> +(such as monochrome and pseudo-color visuals) are reported as packed frame
> +buffer types, even though they don't stricly speaking pack color components
> +into macropixels.
That's because the "packing" is not about the color components, but about the
bits that represent a single pixel.
I.e. the bits that make up the pixel (the macropixel) are stored next
to each other
in memory.
> +- FB_TYPE_PLANES
> +
> +Color components are stored in separate planes. Planes are located
> +contiguously in memory.
The bits that make up a pixel are stored in separate planes. Planes are located
contiguously in memory.
- FB_TYPE_INTERLEAVED_PLANES
The bits that make up a pixel are stored in separate planes. Planes
are interleaved.
The interleave factor (the distance in bytes between the planes in
memory) is stored
in the type_aux field.
> +- FB_VISUAL_MONO01
> +
> +Pixels are black or white and stored on one bit. A bit set to 1 represents a
> +black pixel and a bit set to 0 a white pixel. Pixels are packed together in
> +bytes with 8 pixels per byte.
Actually we do have drivers that use 8 bits per pixel for a monochrome visual.
Hence:
"Pixels are black or white. A black pixel is represented by all
(typically one) bits
set to ones, a white pixel by all bits set to zeroes."
> +FB_VISUAL_MONO01 is used with FB_TYPE_PACKED_PIXELS only.
... so this may also not be true (but it is for all current drivers, IIRC).
There's a strict orthogonality between type (how is a pixel stored in memory)
and visual (how the bits that represent the pixel are interpreted and converted
to a color value).
Same comments for FB_VISUAL_MONO10
> +- FB_VISUAL_TRUECOLOR
> +
> +Pixels are broken into red, green and blue components, and each component
> +indexes a read-only lookup table for the corresponding value. Lookup tables
> +are device-dependent, and provide linear or non-linear ramps.
> +
> +Each component is stored in memory according to the variable screen
> +information red, green, blue and transp fields.
"Each component is stored in a macropixel according to the variable screen
information red, green, blue and transp fields."
Storage format in memory is determined by the FB_TYPE_* value.
> +- FB_VISUAL_PSEUDOCOLOR and FB_VISUAL_STATIC_PSEUDOCOLOR
> +
> +Pixel values are encoded as indices into a colormap that stores red, green and
> +blue components. The colormap is read-only for FB_VISUAL_STATIC_PSEUDOCOLOR
> +and read-write for FB_VISUAL_PSEUDOCOLOR.
> +
> +Each pixel value is stored in the number of bits reported by the variable
> +screen information bits_per_pixel field. Pixels are contiguous in memory.
Whether pixels are contiguous in memory or not is determined by the
FB_TYPE_* value.
> +FB_VISUAL_PSEUDOCOLOR and FB_VISUAL_STATIC_PSEUDOCOLOR are used with
> +FB_TYPE_PACKED_PIXELS only.
Not true. Several drivers use bit planes or interleaved bitplanes.
> +- FB_VISUAL_DIRECTCOLOR
> +
> +Pixels are broken into red, green and blue components, and each component
> +indexes a programmable lookup table for the corresponding value.
> +
> +Each component is stored in memory according to the variable screen
> +information red, green, blue and transp fields.
"Each component is stored in a macropixel according to the variable screen
information red, green, blue and transp fields."
> +- FB_VISUAL_FOURCC
> +
> +Pixels are stored in memory as described by the format FOURCC identifier
> +stored in the variable screen information fourcc field.
... stored in memory and interpreted ...
> +struct fb_var_screeninfo {
> + __u32 xres; /* visible resolution */
> + __u32 yres;
> + __u32 xres_virtual; /* virtual resolution */
> + __u32 yres_virtual;
> + __u32 xoffset; /* offset from virtual to visible */
> + __u32 yoffset; /* resolution */
> +
> + __u32 bits_per_pixel; /* guess what */
> + union {
> + struct { /* Legacy format API */
> + __u32 grayscale; /* != 0 Graylevels instead of colors */
> + /* bitfields in fb mem if true color, else only */
> + /* length is significant */
> + struct fb_bitfield red;
> + struct fb_bitfield green;
> + struct fb_bitfield blue;
> + struct fb_bitfield transp; /* transparency */
> + };
> + struct { /* FOURCC-based format API */
> + __u32 fourcc; /* FOURCC format */
> + __u32 colorspace;
> + __u32 reserved[11];
> + } format;
> + };
> +
> + struct fb_bitfield red; /* bitfield in fb mem if true color, */
> + struct fb_bitfield green; /* else only length is significant */
> + struct fb_bitfield blue;
> + struct fb_bitfield transp; /* transparency */
These four are duplicated, cfr. the union above.
> + Pixel values are bits_per_pixel wide and are split in non-overlapping red,
> + green, blue and alpha (transparency) components. Location and size of each
> + component in the pixel value are described by the fb_bitfield offset and
> + length fields. Offset are computed from the right.
Offsets
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply
* Re: [PATCH/RFC v2 3/3] fbdev: sh_mobile_lcdc: Support FOURCC-based format API
From: Laurent Pinchart @ 2011-08-29 8:30 UTC (permalink / raw)
To: Magnus Damm; +Cc: linux-fbdev, linux-media
In-Reply-To: <CANqRtoSozX5cPs1c2eqy=mcNi_qzVaVYb9Xmmgv8OOJRdUwWqg@mail.gmail.com>
Hi Magnus,
On Monday 29 August 2011 02:39:06 Magnus Damm wrote:
> On Fri, Aug 19, 2011 at 6:37 PM, Laurent Pinchart wrote:
> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > ---
> > arch/arm/mach-shmobile/board-ag5evm.c | 2 +-
> > arch/arm/mach-shmobile/board-ap4evb.c | 4 +-
> > arch/arm/mach-shmobile/board-mackerel.c | 4 +-
> > drivers/video/sh_mobile_lcdcfb.c | 342
> > ++++++++++++++++++++----------- include/video/sh_mobile_lcdc.h
> > | 4 +-
> > 5 files changed, 230 insertions(+), 126 deletions(-)
>
> Hi Laurent, thanks for the patch!
>
> Since you're changing the LCDC platform data please make sure you also
> update the 5 boards using the LCDC under arch/sh.
Sure. Sorry for forgetting about that.
--
Regards,
Laurent Pinchart
^ permalink raw reply
* Re: [PATCH/RFC v2 1/3] fbdev: Add FOURCC-based format configuration API
From: Laurent Pinchart @ 2011-08-29 8:50 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: linux-fbdev, linux-media, magnus.damm
In-Reply-To: <CAMuHMdV-JxK1Pp1aHmEG7N8G8u_un-G7zGZa+KNzGx2D37EbKQ@mail.gmail.com>
Hi Geert,
Thanks for the review.
On Monday 29 August 2011 10:13:07 Geert Uytterhoeven wrote:
> On Fri, Aug 19, 2011 at 11:37, Laurent Pinchart wrote:
[snip]
> > +- FB_TYPE_PACKED_PIXELS
> > +
> > +Color components (usually RGB or YUV) are packed together into
> > macropixels +that are stored in a single plane. The exact color
> > components layout is +described in a visual-dependent way.
> > +
> > +Frame buffer visuals that don't use multiple color components per pixel
> > +(such as monochrome and pseudo-color visuals) are reported as packed
> > frame +buffer types, even though they don't stricly speaking pack color
> > components +into macropixels.
>
> That's because the "packing" is not about the color components, but about
> the bits that represent a single pixel.
>
> I.e. the bits that make up the pixel (the macropixel) are stored next
> to each other
> in memory.
OK, I've modified that last sentence to read
"Frame buffer visuals that don't use multiple color components per pixel (such
as monochrome and pseudo-color visuals) are also reported as packed frame
buffer types, as the bits that make up individual pixels are packed next to
each other in memory."
> > +- FB_TYPE_PLANES
> > +
> > +Color components are stored in separate planes. Planes are located
> > +contiguously in memory.
>
> The bits that make up a pixel are stored in separate planes. Planes are
> located contiguously in memory.
I'm not sure to agree with this. You make it sounds like FB_TYPE_PLANES stores
each bit in a different plane. Is that really the case ?
> - FB_TYPE_INTERLEAVED_PLANES
>
> The bits that make up a pixel are stored in separate planes. Planes
> are interleaved.
> The interleave factor (the distance in bytes between the planes in
> memory) is stored in the type_aux field.
That's a bit unclear to me. How are they interleaved ?
> > +- FB_VISUAL_MONO01
> > +
> > +Pixels are black or white and stored on one bit. A bit set to 1
> > represents a +black pixel and a bit set to 0 a white pixel. Pixels are
> > packed together in +bytes with 8 pixels per byte.
>
> Actually we do have drivers that use 8 bits per pixel for a monochrome
> visual. Hence:
>
> "Pixels are black or white. A black pixel is represented by all
> (typically one) bits set to ones, a white pixel by all bits set to zeroes."
OK. I've rephrased it as
"Pixels are black or white and stored on a number of bits (typically one)
specified by the variable screen information bpp field.
Black pixels are represented by all bits set to 1 and white pixels by all bits
set to 0. When the number of bits per pixel is smaller than 8, several pixels
are packed together in a byte."
> > +FB_VISUAL_MONO01 is used with FB_TYPE_PACKED_PIXELS only.
>
> ... so this may also not be true (but it is for all current drivers, IIRC).
> There's a strict orthogonality between type (how is a pixel stored in
> memory) and visual (how the bits that represent the pixel are interpreted
> and converted to a color value).
What about
"FB_VISUAL_MONO01 is currently used with FB_TYPE_PACKED_PIXELS only." ?
> Same comments for FB_VISUAL_MONO10
Fixed the same way.
> > +- FB_VISUAL_TRUECOLOR
> > +
> > +Pixels are broken into red, green and blue components, and each
> > component +indexes a read-only lookup table for the corresponding value.
> > Lookup tables +are device-dependent, and provide linear or non-linear
> > ramps.
> > +
> > +Each component is stored in memory according to the variable screen
> > +information red, green, blue and transp fields.
>
> "Each component is stored in a macropixel according to the variable screen
> information red, green, blue and transp fields."
>
> Storage format in memory is determined by the FB_TYPE_* value.
How so ? With FB_TYPE_PLANES and FB_VISUAL_TRUECOLOR for an RGB format, how
are the R, G and B planes ordered ? Are color components packed or padded
inside a plane ? I understand that the design goal was to have orthogonal
FB_TYPE_* and FB_VISUAL_* values, but we're missing too much information for
that to be truly generic.
> > +- FB_VISUAL_PSEUDOCOLOR and FB_VISUAL_STATIC_PSEUDOCOLOR
> > +
> > +Pixel values are encoded as indices into a colormap that stores red,
> > green and +blue components. The colormap is read-only for
> > FB_VISUAL_STATIC_PSEUDOCOLOR +and read-write for FB_VISUAL_PSEUDOCOLOR.
> > +
> > +Each pixel value is stored in the number of bits reported by the
> > variable +screen information bits_per_pixel field. Pixels are contiguous
> > in memory.
>
> Whether pixels are contiguous in memory or not is determined by the
> FB_TYPE_* value.
How can they not be contiguous in memory ? Can you please give an example ?
> > +FB_VISUAL_PSEUDOCOLOR and FB_VISUAL_STATIC_PSEUDOCOLOR are used with
> > +FB_TYPE_PACKED_PIXELS only.
>
> Not true. Several drivers use bit planes or interleaved bitplanes.
How does that work ?
> > +- FB_VISUAL_DIRECTCOLOR
> > +
> > +Pixels are broken into red, green and blue components, and each
> > component +indexes a programmable lookup table for the corresponding
> > value. +
> > +Each component is stored in memory according to the variable screen
> > +information red, green, blue and transp fields.
>
> "Each component is stored in a macropixel according to the variable screen
> information red, green, blue and transp fields."
>
> > +- FB_VISUAL_FOURCC
> > +
> > +Pixels are stored in memory as described by the format FOURCC identifier
> > +stored in the variable screen information fourcc field.
>
> ... stored in memory and interpreted ...
>
> > +struct fb_var_screeninfo {
> > + __u32 xres; /* visible resolution
> > */ + __u32 yres;
> > + __u32 xres_virtual; /* virtual resolution
> > */ + __u32 yres_virtual;
> > + __u32 xoffset; /* offset from virtual to visible
> > */ + __u32 yoffset; /* resolution
> > */ +
> > + __u32 bits_per_pixel; /* guess what
> > */ + union {
> > + struct { /* Legacy format API
> > */ + __u32 grayscale; /* != 0 Graylevels instead
> > of colors */ + /* bitfields in fb mem if true
> > color, else only */ + /* length is significant
> > */ + struct fb_bitfield red;
> > + struct fb_bitfield green;
> > + struct fb_bitfield blue;
> > + struct fb_bitfield transp; /* transparency
> > */ + };
> > + struct { /* FOURCC-based format API
> > */ + __u32 fourcc; /* FOURCC format
> > */ + __u32 colorspace;
> > + __u32 reserved[11];
> > + } format;
> > + };
> > +
> > + struct fb_bitfield red; /* bitfield in fb mem if true
> > color, */ + struct fb_bitfield green; /* else only length is
> > significant */ + struct fb_bitfield blue;
> > + struct fb_bitfield transp; /* transparency
> > */
>
> These four are duplicated, cfr. the union above.
Oops :-)
--
Regards,
Laurent Pinchart
^ permalink raw reply
* Re: [PATCH/RFC v2 1/3] fbdev: Add FOURCC-based format configuration API
From: Geert Uytterhoeven @ 2011-08-29 9:36 UTC (permalink / raw)
To: Laurent Pinchart; +Cc: linux-fbdev, linux-media, magnus.damm
In-Reply-To: <201108291050.59109.laurent.pinchart@ideasonboard.com>
Hi Laurent,
On Mon, Aug 29, 2011 at 10:50, Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
> On Monday 29 August 2011 10:13:07 Geert Uytterhoeven wrote:
>> On Fri, Aug 19, 2011 at 11:37, Laurent Pinchart wrote:
>
> [snip]
>
>> > +- FB_TYPE_PACKED_PIXELS
>> > +
>> > +Color components (usually RGB or YUV) are packed together into
>> > macropixels +that are stored in a single plane. The exact color
>> > components layout is +described in a visual-dependent way.
>> > +
>> > +Frame buffer visuals that don't use multiple color components per pixel
>> > +(such as monochrome and pseudo-color visuals) are reported as packed
>> > frame +buffer types, even though they don't stricly speaking pack color
>> > components +into macropixels.
>>
>> That's because the "packing" is not about the color components, but about
>> the bits that represent a single pixel.
>>
>> I.e. the bits that make up the pixel (the macropixel) are stored next
>> to each other
>> in memory.
>
> OK, I've modified that last sentence to read
>
> "Frame buffer visuals that don't use multiple color components per pixel (such
> as monochrome and pseudo-color visuals) are also reported as packed frame
> buffer types, as the bits that make up individual pixels are packed next to
> each other in memory."
Still not correct, as you don't grasp the concept of e.g. bitplanes
yet (see below).
The visual doesn't have anything to do with how the macropixels are stored in
memory.
>> > +- FB_TYPE_PLANES
>> > +
>> > +Color components are stored in separate planes. Planes are located
>> > +contiguously in memory.
>>
>> The bits that make up a pixel are stored in separate planes. Planes are
>> located contiguously in memory.
>
> I'm not sure to agree with this. You make it sounds like FB_TYPE_PLANES stores
> each bit in a different plane. Is that really the case ?
Yes.
First you store all "first" (fbdev does lack a way to specify little
or big endian here)
bits of each pixel in memory, contiguously. Then the second bit of
each pixel, and so on.
For 8 pixels (A - H) with 4 bits per pixel (0 - 3) (i.e. the first pixel is
[A0 A1 A2 A3]), that would be like:
A0 B0 C0 D0 E0 F0 G0 H0 A1 B1 C1 D1 E1 F1 G1 H1 A2 B2 C2 D2 E2 F2 G2 H2
A3 B3 C3 D3 E3 F3 G3 H3
http://en.wikipedia.org/wiki/Bit_plane
http://en.wikipedia.org/wiki/Planar_(computer_graphics)
http://en.wikipedia.org/wiki/Color_depth
>> - FB_TYPE_INTERLEAVED_PLANES
>>
>> The bits that make up a pixel are stored in separate planes. Planes
>> are interleaved.
>> The interleave factor (the distance in bytes between the planes in
>> memory) is stored in the type_aux field.
>
> That's a bit unclear to me. How are they interleaved ?
Instead of storing the same bits of all pixels contiguously into memory, they
are interleaved. Typically this is done per line (type_aux is the
length of a line in bytes),
or per word (Atari uses 2 bytes interleaving.
E.g. for a 320 x 200 display, with FB_TYPE_PLANES, you would store 320 x 200 64000 first bits, followed 64000 second bits, and so on.
With FB_TYPE_INTERLEAVED_PLANES and type_aux = 320 / 8 = 40,
you store the first line of the screen as 320 first bits, followed by
320 second bits, and so on.
Then the next line, as 320 first bits, followed by 320 second bits, and so on...
Hence the bits that make up a pixel are spread across memory. It was
useful in the days
computers couldn't show many colors, and allows things like 5 or 6
bits per pixels.
>> > +- FB_VISUAL_MONO01
>> > +
>> > +Pixels are black or white and stored on one bit. A bit set to 1
>> > represents a +black pixel and a bit set to 0 a white pixel. Pixels are
>> > packed together in +bytes with 8 pixels per byte.
>>
>> Actually we do have drivers that use 8 bits per pixel for a monochrome
>> visual. Hence:
>>
>> "Pixels are black or white. A black pixel is represented by all
>> (typically one) bits set to ones, a white pixel by all bits set to zeroes."
>
> OK. I've rephrased it as
>
> "Pixels are black or white and stored on a number of bits (typically one)
> specified by the variable screen information bpp field.
>
> Black pixels are represented by all bits set to 1 and white pixels by all bits
> set to 0. When the number of bits per pixel is smaller than 8, several pixels
> are packed together in a byte."
OK.
>> > +FB_VISUAL_MONO01 is used with FB_TYPE_PACKED_PIXELS only.
>>
>> ... so this may also not be true (but it is for all current drivers, IIRC).
>> There's a strict orthogonality between type (how is a pixel stored in
>> memory) and visual (how the bits that represent the pixel are interpreted
>> and converted to a color value).
>
> What about
>
> "FB_VISUAL_MONO01 is currently used with FB_TYPE_PACKED_PIXELS only." ?
stifb.c seems to use FB_TYPE_PLANES, but it uses bits_per_pixel is 1, so
FB_TYPE_PACKED_PIXELS, FB_TYPE_PLANES, and FB_TYPE_INTERLEAVED_PLANES
all degenerate to the same case anyway.
>> > +- FB_VISUAL_TRUECOLOR
>> > +
>> > +Pixels are broken into red, green and blue components, and each
>> > component +indexes a read-only lookup table for the corresponding value.
>> > Lookup tables +are device-dependent, and provide linear or non-linear
>> > ramps.
>> > +
>> > +Each component is stored in memory according to the variable screen
>> > +information red, green, blue and transp fields.
>>
>> "Each component is stored in a macropixel according to the variable screen
>> information red, green, blue and transp fields."
>>
>> Storage format in memory is determined by the FB_TYPE_* value.
>
> How so ? With FB_TYPE_PLANES and FB_VISUAL_TRUECOLOR for an RGB format, how
> are the R, G and B planes ordered ? Are color components packed or padded
That's specified by the fb_bitfield structs.
> inside a plane ? I understand that the design goal was to have orthogonal
> FB_TYPE_* and FB_VISUAL_* values, but we're missing too much information for
> that to be truly generic.
The visual specifies how to interprete the fields that make up a pixel (as color
components, indices, ...).
The fb_bitfield structs specify how the fields are laid out in a pixel of size
bits_per_pixel.
The frame buffer type specifies how pixels are laid out in memory.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply
* Re: [PATCH/RFC v2 1/3] fbdev: Add FOURCC-based format configuration API
From: Laurent Pinchart @ 2011-08-29 10:09 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: linux-fbdev, linux-media, magnus.damm
In-Reply-To: <CAMuHMdW9KPBJpTPYmCTmFG=G_7_tiFti-b3wzTM9Q5J7U9+JWg@mail.gmail.com>
Hi Geert,
On Monday 29 August 2011 11:36:07 Geert Uytterhoeven wrote:
> On Mon, Aug 29, 2011 at 10:50, Laurent Pinchart wrote:
> > On Monday 29 August 2011 10:13:07 Geert Uytterhoeven wrote:
> >> On Fri, Aug 19, 2011 at 11:37, Laurent Pinchart wrote:
> > [snip]
> >
> >> > +- FB_TYPE_PACKED_PIXELS
> >> > +
> >> > +Color components (usually RGB or YUV) are packed together into
> >> > macropixels +that are stored in a single plane. The exact color
> >> > components layout is +described in a visual-dependent way.
> >> > +
> >> > +Frame buffer visuals that don't use multiple color components per
> >> > pixel +(such as monochrome and pseudo-color visuals) are reported as
> >> > packed frame +buffer types, even though they don't stricly speaking
> >> > pack color components +into macropixels.
> >>
> >> That's because the "packing" is not about the color components, but
> >> about the bits that represent a single pixel.
> >>
> >> I.e. the bits that make up the pixel (the macropixel) are stored next
> >> to each other
> >> in memory.
> >
> > OK, I've modified that last sentence to read
> >
> > "Frame buffer visuals that don't use multiple color components per pixel
> > (such as monochrome and pseudo-color visuals) are also reported as
> > packed frame buffer types, as the bits that make up individual pixels
> > are packed next to each other in memory."
>
> Still not correct, as you don't grasp the concept of e.g. bitplanes
> yet (see below).
> The visual doesn't have anything to do with how the macropixels are stored
> in memory.
>
> >> > +- FB_TYPE_PLANES
> >> > +
> >> > +Color components are stored in separate planes. Planes are located
> >> > +contiguously in memory.
> >>
> >> The bits that make up a pixel are stored in separate planes. Planes are
> >> located contiguously in memory.
> >
> > I'm not sure to agree with this. You make it sounds like FB_TYPE_PLANES
> > stores each bit in a different plane. Is that really the case ?
>
> Yes.
>
> First you store all "first" (fbdev does lack a way to specify little
> or big endian here)
> bits of each pixel in memory, contiguously. Then the second bit of
> each pixel, and so on.
>
> For 8 pixels (A - H) with 4 bits per pixel (0 - 3) (i.e. the first pixel is
> [A0 A1 A2 A3]), that would be like:
>
> A0 B0 C0 D0 E0 F0 G0 H0 A1 B1 C1 D1 E1 F1 G1 H1 A2 B2 C2 D2 E2 F2 G2 H2
> A3 B3 C3 D3 E3 F3 G3 H3
>
> http://en.wikipedia.org/wiki/Bit_plane
> http://en.wikipedia.org/wiki/Planar_(computer_graphics)
> http://en.wikipedia.org/wiki/Color_depth
Thank you. That's clearer now. Planar formats in V4L2 are different, hence my
initial confusion.
If my understanding is now correct, a V4L2 planar YUV type where Y, U and V
components are stored in separate byte-oriented planes, with each plane
storing Y, U or V components packed (such as http://linuxtv.org/downloads/v4l-
dvb-apis/V4L2-PIX-FMT-YUV422P.html), would be of neither FB_TYPE_PLANES nor
FB_TYPE_PACKED. The same would be true for an RGB format where each component
is stored in a separate plane with each plane sotring R, G or B packed.
If the above is correct, what FB_TYPE_* should a driver report when using
FB_VISUAL_FOURCC with V4L2_PIX_FMT_YUV422P (http://linuxtv.org/downloads/v4l-
dvb-apis/V4L2-PIX-FMT-YUV422P.html) or V4L2_PIX_FMT_NV12
(http://linuxtv.org/downloads/v4l-dvb-apis/re25.html) for instance ?
> >> - FB_TYPE_INTERLEAVED_PLANES
> >>
> >> The bits that make up a pixel are stored in separate planes. Planes
> >> are interleaved.
> >> The interleave factor (the distance in bytes between the planes in
> >> memory) is stored in the type_aux field.
> >
> > That's a bit unclear to me. How are they interleaved ?
>
> Instead of storing the same bits of all pixels contiguously into memory,
> they are interleaved. Typically this is done per line (type_aux is the
> length of a line in bytes),
> or per word (Atari uses 2 bytes interleaving.
>
> E.g. for a 320 x 200 display, with FB_TYPE_PLANES, you would store 320 x
> 200 = 64000 first bits, followed 64000 second bits, and so on.
>
> With FB_TYPE_INTERLEAVED_PLANES and type_aux = 320 / 8 = 40,
> you store the first line of the screen as 320 first bits, followed by
> 320 second bits, and so on.
> Then the next line, as 320 first bits, followed by 320 second bits, and so
> on...
>
> Hence the bits that make up a pixel are spread across memory. It was
> useful in the days
> computers couldn't show many colors, and allows things like 5 or 6
> bits per pixels.
>
> >> > +- FB_VISUAL_MONO01
> >> > +
> >> > +Pixels are black or white and stored on one bit. A bit set to 1
> >> > represents a +black pixel and a bit set to 0 a white pixel. Pixels are
> >> > packed together in +bytes with 8 pixels per byte.
> >>
> >> Actually we do have drivers that use 8 bits per pixel for a monochrome
> >> visual. Hence:
> >>
> >> "Pixels are black or white. A black pixel is represented by all
> >> (typically one) bits set to ones, a white pixel by all bits set to
> >> zeroes."
> >
> > OK. I've rephrased it as
> >
> > "Pixels are black or white and stored on a number of bits (typically one)
> > specified by the variable screen information bpp field.
> >
> > Black pixels are represented by all bits set to 1 and white pixels by all
> > bits set to 0. When the number of bits per pixel is smaller than 8,
> > several pixels are packed together in a byte."
>
> OK.
>
> >> > +FB_VISUAL_MONO01 is used with FB_TYPE_PACKED_PIXELS only.
> >>
> >> ... so this may also not be true (but it is for all current drivers,
> >> IIRC). There's a strict orthogonality between type (how is a pixel
> >> stored in memory) and visual (how the bits that represent the pixel are
> >> interpreted and converted to a color value).
> >
> > What about
> >
> > "FB_VISUAL_MONO01 is currently used with FB_TYPE_PACKED_PIXELS only." ?
>
> stifb.c seems to use FB_TYPE_PLANES, but it uses bits_per_pixel is 1, so
> FB_TYPE_PACKED_PIXELS, FB_TYPE_PLANES, and FB_TYPE_INTERLEAVED_PLANES
> all degenerate to the same case anyway.
>
> >> > +- FB_VISUAL_TRUECOLOR
> >> > +
> >> > +Pixels are broken into red, green and blue components, and each
> >> > component +indexes a read-only lookup table for the corresponding
> >> > value. Lookup tables +are device-dependent, and provide linear or
> >> > non-linear ramps.
> >> > +
> >> > +Each component is stored in memory according to the variable screen
> >> > +information red, green, blue and transp fields.
> >>
> >> "Each component is stored in a macropixel according to the variable
> >> screen information red, green, blue and transp fields."
> >>
> >> Storage format in memory is determined by the FB_TYPE_* value.
> >
> > How so ? With FB_TYPE_PLANES and FB_VISUAL_TRUECOLOR for an RGB format,
> > how are the R, G and B planes ordered ? Are color components packed or
> > padded
>
> That's specified by the fb_bitfield structs.
>
> > inside a plane ? I understand that the design goal was to have orthogonal
> > FB_TYPE_* and FB_VISUAL_* values, but we're missing too much information
> > for that to be truly generic.
>
> The visual specifies how to interprete the fields that make up a pixel (as
> color components, indices, ...).
> The fb_bitfield structs specify how the fields are laid out in a pixel of
> size bits_per_pixel.
> The frame buffer type specifies how pixels are laid out in memory.
That's fine if the FB device uses bitplanes, but not if it uses a format such
as the ones described above.
--
Regards,
Laurent Pinchart
^ permalink raw reply
* Re: linux-next tree addition request (fbdev)
From: Florian Tobias Schandinat @ 2011-08-29 10:47 UTC (permalink / raw)
To: Paul Mundt; +Cc: Stephen Rothwell, linux-next, linux-fbdev@vger.kernel.org
In-Reply-To: <20110829060238.GB31809@linux-sh.org>
Hi Paul,
On 08/29/2011 06:02 AM, Paul Mundt wrote:
> On Mon, Aug 29, 2011 at 02:19:30AM +1000, Stephen Rothwell wrote:
>> Hi Florian,
>>
>> On Thu, 25 Aug 2011 00:33:53 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>>>
>>> On Wed, 24 Aug 2011 13:40:46 +0000 Florian Tobias Schandinat <FlorianSchandinat@gmx.de> wrote:
>>>>
>>>> can you please add
>>>>
>>>> git://github.com/schandinat/linux-2.6.git fbdev-next
>>>>
>>>> to linux-next. It collects patches for the frame buffer subsystem.
>>>> Can you please add the linux-fbdev@vger.kernel.org mailing list as additional
>>>> contact for warnings/errors/problems?
>>>>
>>>> You probably want to drop Paul's fbdev branches as they contain some outdated
>>>> patches that will conflict with the newer versions.
>>>
>>> OK, Paul is still listed as the frame buffer subsystem maintainer, so I
>>> will need an Ack from him. When I get that, I will replace his tree with
>>> yours. I assume someone will update the MAINTAINERS file.
>>>
>>> I also have another tree from Paul (called fbdev-current) that contained
>>> fixes for Linus' current release. I also assume that that tree will be
>>> dropped (unless you have a new version of that as well).
>>
>> Ping? Anyone?
>>
> As long as Florian is taking care of the backlog of the stuff that is
> already sitting in that branch, I have no problems with it being dropped.
> I'm not planning on pushing any updates to it anyways.
Merged the remaining patches of your branch.
Thanks,
Florian Tobias Schandinat
^ permalink raw reply
* Re: [PATCH/RFC v2 1/3] fbdev: Add FOURCC-based format configuration API
From: Geert Uytterhoeven @ 2011-08-29 11:04 UTC (permalink / raw)
To: Laurent Pinchart; +Cc: linux-fbdev, linux-media, magnus.damm
In-Reply-To: <201108291209.08349.laurent.pinchart@ideasonboard.com>
Hi Laurent,
On Mon, Aug 29, 2011 at 12:09, Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
> On Monday 29 August 2011 11:36:07 Geert Uytterhoeven wrote:
>> On Mon, Aug 29, 2011 at 10:50, Laurent Pinchart wrote:
[...]
> If my understanding is now correct, a V4L2 planar YUV type where Y, U and V
> components are stored in separate byte-oriented planes, with each plane
> storing Y, U or V components packed (such as http://linuxtv.org/downloads/v4l-
> dvb-apis/V4L2-PIX-FMT-YUV422P.html), would be of neither FB_TYPE_PLANES nor
> FB_TYPE_PACKED. The same would be true for an RGB format where each component
> is stored in a separate plane with each plane sotring R, G or B packed.
Indeed. Currently this cannot be represented.
For ideas from the past, see e.g.
http://comments.gmane.org/gmane.linux.fbdev.devel/10951.
> If the above is correct, what FB_TYPE_* should a driver report when using
> FB_VISUAL_FOURCC with V4L2_PIX_FMT_YUV422P (http://linuxtv.org/downloads/v4l-
> dvb-apis/V4L2-PIX-FMT-YUV422P.html) or V4L2_PIX_FMT_NV12
> (http://linuxtv.org/downloads/v4l-dvb-apis/re25.html) for instance ?
We need new types for those. Or always use FOURCC for them.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply
* Re: [PATCH/RFC v2 1/3] fbdev: Add FOURCC-based format configuration API
From: Laurent Pinchart @ 2011-08-29 11:08 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: linux-fbdev, linux-media, magnus.damm
In-Reply-To: <CAMuHMdU3eO34zmGVejUj4B7Z5JWiwM_pieoycfinSspSiL1reQ@mail.gmail.com>
Hi Geert,
On Monday 29 August 2011 13:04:15 Geert Uytterhoeven wrote:
> On Mon, Aug 29, 2011 at 12:09, Laurent Pinchart wrote:
> > On Monday 29 August 2011 11:36:07 Geert Uytterhoeven wrote:
> >> On Mon, Aug 29, 2011 at 10:50, Laurent Pinchart wrote:
> [...]
>
> > If my understanding is now correct, a V4L2 planar YUV type where Y, U and
> > V components are stored in separate byte-oriented planes, with each
> > plane storing Y, U or V components packed (such as
> > http://linuxtv.org/downloads/v4l- dvb-apis/V4L2-PIX-FMT-YUV422P.html),
> > would be of neither FB_TYPE_PLANES nor FB_TYPE_PACKED. The same would be
> > true for an RGB format where each component is stored in a separate
> > plane with each plane sotring R, G or B packed.
>
> Indeed. Currently this cannot be represented.
Good, at least I now understand the situation :-)
> For ideas from the past, see e.g.
> http://comments.gmane.org/gmane.linux.fbdev.devel/10951.
>
> > If the above is correct, what FB_TYPE_* should a driver report when using
> > FB_VISUAL_FOURCC with V4L2_PIX_FMT_YUV422P
> > (http://linuxtv.org/downloads/v4l- dvb-apis/V4L2-PIX-FMT-YUV422P.html)
> > or V4L2_PIX_FMT_NV12
> > (http://linuxtv.org/downloads/v4l-dvb-apis/re25.html) for instance ?
>
> We need new types for those. Or always use FOURCC for them.
My proposal currently defined FB_VISUAL_FOURCC. What about adding
FB_TYPE_FOURCC as well ?
--
Regards,
Laurent Pinchart
^ permalink raw reply
* Re: [PATCH/RFC v2 1/3] fbdev: Add FOURCC-based format configuration API
From: Geert Uytterhoeven @ 2011-08-29 11:20 UTC (permalink / raw)
To: Laurent Pinchart; +Cc: linux-fbdev, linux-media, magnus.damm
In-Reply-To: <201108291308.50244.laurent.pinchart@ideasonboard.com>
On Mon, Aug 29, 2011 at 13:08, Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
> On Monday 29 August 2011 13:04:15 Geert Uytterhoeven wrote:
>> On Mon, Aug 29, 2011 at 12:09, Laurent Pinchart wrote:
>> > On Monday 29 August 2011 11:36:07 Geert Uytterhoeven wrote:
>> >> On Mon, Aug 29, 2011 at 10:50, Laurent Pinchart wrote:
>> [...]
>>
>> > If my understanding is now correct, a V4L2 planar YUV type where Y, U and
>> > V components are stored in separate byte-oriented planes, with each
>> > plane storing Y, U or V components packed (such as
>> > http://linuxtv.org/downloads/v4l- dvb-apis/V4L2-PIX-FMT-YUV422P.html),
>> > would be of neither FB_TYPE_PLANES nor FB_TYPE_PACKED. The same would be
>> > true for an RGB format where each component is stored in a separate
>> > plane with each plane sotring R, G or B packed.
>>
>> Indeed. Currently this cannot be represented.
>
> Good, at least I now understand the situation :-)
>
>> For ideas from the past, see e.g.
>> http://comments.gmane.org/gmane.linux.fbdev.devel/10951.
>>
>> > If the above is correct, what FB_TYPE_* should a driver report when using
>> > FB_VISUAL_FOURCC with V4L2_PIX_FMT_YUV422P
>> > (http://linuxtv.org/downloads/v4l- dvb-apis/V4L2-PIX-FMT-YUV422P.html)
>> > or V4L2_PIX_FMT_NV12
>> > (http://linuxtv.org/downloads/v4l-dvb-apis/re25.html) for instance ?
>>
>> We need new types for those. Or always use FOURCC for them.
>
> My proposal currently defined FB_VISUAL_FOURCC. What about adding
> FB_TYPE_FOURCC as well ?
That may make sense.
When will the driver report FB_{TYPE,VISUAL}_FOURCC?
- When using a mode that cannot be represented in the legacy way,
- But what with modes that can be represented? Legacy software cannot
handle FB_{TYPE,VISUAL}_FOURCC.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply
* Re: [PATCH/RFC v2 1/3] fbdev: Add FOURCC-based format configuration API
From: Laurent Pinchart @ 2011-08-29 12:55 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: linux-fbdev, linux-media, magnus.damm
In-Reply-To: <CAMuHMdUheemZVb7cPAsyPrC9LLowr+XV_5A+H1EfWWbWHeCVFw@mail.gmail.com>
Hi Geert,
On Monday 29 August 2011 13:20:44 Geert Uytterhoeven wrote:
> On Mon, Aug 29, 2011 at 13:08, Laurent Pinchart wrote:
> > On Monday 29 August 2011 13:04:15 Geert Uytterhoeven wrote:
> >> On Mon, Aug 29, 2011 at 12:09, Laurent Pinchart wrote:
> >> > On Monday 29 August 2011 11:36:07 Geert Uytterhoeven wrote:
> >> >> On Mon, Aug 29, 2011 at 10:50, Laurent Pinchart wrote:
> >> [...]
> >>
> >> > If my understanding is now correct, a V4L2 planar YUV type where Y, U
> >> > and V components are stored in separate byte-oriented planes, with
> >> > each plane storing Y, U or V components packed (such as
> >> > http://linuxtv.org/downloads/v4l- dvb-apis/V4L2-PIX-FMT-YUV422P.html),
> >> > would be of neither FB_TYPE_PLANES nor FB_TYPE_PACKED. The same would
> >> > be true for an RGB format where each component is stored in a
> >> > separate plane with each plane sotring R, G or B packed.
> >>
> >> Indeed. Currently this cannot be represented.
> >
> > Good, at least I now understand the situation :-)
> >
> >> For ideas from the past, see e.g.
> >> http://comments.gmane.org/gmane.linux.fbdev.devel/10951.
> >>
> >> > If the above is correct, what FB_TYPE_* should a driver report when
> >> > using FB_VISUAL_FOURCC with V4L2_PIX_FMT_YUV422P
> >> > (http://linuxtv.org/downloads/v4l- dvb-apis/V4L2-PIX-FMT-YUV422P.html)
> >> > or V4L2_PIX_FMT_NV12
> >> > (http://linuxtv.org/downloads/v4l-dvb-apis/re25.html) for instance ?
> >>
> >> We need new types for those. Or always use FOURCC for them.
> >
> > My proposal currently defined FB_VISUAL_FOURCC. What about adding
> > FB_TYPE_FOURCC as well ?
>
> That may make sense.
> When will the driver report FB_{TYPE,VISUAL}_FOURCC?
> - When using a mode that cannot be represented in the legacy way,
Definitely.
> - But what with modes that can be represented? Legacy software cannot
> handle FB_{TYPE,VISUAL}_FOURCC.
My idea was to use FB_{TYPE,VISUAL}_FOURCC only when the mode is configured
using the FOURCC API. If FBIOPUT_VSCREENINFO is called with a non-FOURCC
format, the driver will report non-FOURCC types and visuals.
--
Regards,
Laurent Pinchart
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox