* Re: [PATCH 1/2] framebuffer: arkfb: Fix framebugger typo
From: Tomi Valkeinen @ 2013-09-26 9:47 UTC (permalink / raw)
To: Joe Perches; +Cc: Jean-Christophe Plagniol-Villard, linux-fbdev, linux-kernel
In-Reply-To: <c94f3e342947923f20d4c12932f382aa5200511b.1379641901.git.joe@perches.com>
[-- Attachment #1: Type: text/plain, Size: 803 bytes --]
On 20/09/13 04:53, Joe Perches wrote:
> s/framebugger/framebuffer/
>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
> drivers/video/arkfb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/arkfb.c b/drivers/video/arkfb.c
> index ee0f1a1..b13f3f2 100644
> --- a/drivers/video/arkfb.c
> +++ b/drivers/video/arkfb.c
> @@ -1048,7 +1048,7 @@ static int ark_pci_probe(struct pci_dev *dev, const struct pci_device_id *id)
>
> rc = register_framebuffer(info);
> if (rc < 0) {
> - dev_err(info->device, "cannot register framebugger\n");
> + dev_err(info->device, "cannot register framebuffer\n");
> goto err_reg_fb;
> }
>
>
Thanks, queued for 3.13. Although I have to say I kinda like the sound
of framebugger.
Tom
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]
^ permalink raw reply
* Re: [patch 1/2] backlight: lm3630: signedness bug in lm3630a_chip_init()
From: Tomi Valkeinen @ 2013-09-26 9:43 UTC (permalink / raw)
To: linux-fbdev
In-Reply-To: <20130925085451.GA6661@elgon.mountain>
[-- Attachment #1: Type: text/plain, Size: 811 bytes --]
On 25/09/13 11:54, Dan Carpenter wrote:
> "rval" needs to be signed for the error handling to work.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/video/backlight/lm3630a_bl.c b/drivers/video/backlight/lm3630a_bl.c
> index c63f918..65392f9 100644
> --- a/drivers/video/backlight/lm3630a_bl.c
> +++ b/drivers/video/backlight/lm3630a_bl.c
> @@ -105,7 +105,7 @@ static int lm3630a_chip_init(struct lm3630a_chip *pchip)
> /* interrupt handling */
> static void lm3630a_delayed_func(struct work_struct *work)
> {
> - unsigned int rval;
> + int rval;
> struct lm3630a_chip *pchip;
>
> pchip = container_of(work, struct lm3630a_chip, work.work);
>
There's no drivers/video/backlight/lm3630a_bl.c in v3.12. Which kernel
is this for?
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]
^ permalink raw reply
* Re: [PATCH 1/2] video: of: display_timing: correct display-timings node finding
From: Tomi Valkeinen @ 2013-09-26 9:37 UTC (permalink / raw)
To: Andrzej Hajda, FRAMEBUFFER LAYER
Cc: Kyungmin Park, Jean-Christophe Plagniol-Villard, dri-devel
In-Reply-To: <1380109892-13040-2-git-send-email-a.hajda@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 510 bytes --]
On 25/09/13 14:51, Andrzej Hajda wrote:
> of_get_display_timing(s) use of_find_node_by_name
> to get child node, this is incorrect, of_get_child_by_name
> should be used instead. The patch fixes it.
> Small typo is also corrected.
>
> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> drivers/video/of_display_timing.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Thanks, queuing for 3.12 fixes.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]
^ permalink raw reply
* Re: [PATCH 2/2] video: of: display_timing: remove broken of_display_timings_exist
From: Tomi Valkeinen @ 2013-09-26 9:37 UTC (permalink / raw)
To: Andrzej Hajda
Cc: FRAMEBUFFER LAYER, Jean-Christophe Plagniol-Villard,
Kyungmin Park, dri-devel
In-Reply-To: <1380109892-13040-3-git-send-email-a.hajda@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 1025 bytes --]
On 25/09/13 14:51, Andrzej Hajda wrote:
> of_display_timings_exist is implemented incorrectly.
> It tries to find property instead of node.
> The function is not used anyway so the patch removes it.
>
> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> drivers/video/of_display_timing.c | 20 --------------------
> include/video/of_display_timing.h | 1 -
> 2 files changed, 21 deletions(-)
Fix by removal? =).
Wouldn't it be better to fix the function? It's not used currently, but
the whole display-timings stuff is still quite new. One could use
of_get_display_timings() to check for the existence of timings, but that
function will print an error if no timings are found.
Then again, what would be the case where you want to check if the
timings exist... I'd presume that there either has to be timings or
there are no timings.
So, I don't know. Any else has opinions whether to remove or fix the
function?
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]
^ permalink raw reply
* Re: [PATCH 1/4] video: vfb: Remove incorrect check
From: Tomi Valkeinen @ 2013-09-26 9:10 UTC (permalink / raw)
To: linux-fbdev
In-Reply-To: <1380110579-3665-1-git-send-email-sachin.kamat@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 911 bytes --]
On 25/09/13 15:02, Sachin Kamat wrote:
> 'yoffset' is unsigned and hence cannot be less than 0.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
> drivers/video/vfb.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/video/vfb.c b/drivers/video/vfb.c
> index ee5985e..ea2b523 100644
> --- a/drivers/video/vfb.c
> +++ b/drivers/video/vfb.c
> @@ -390,9 +390,8 @@ static int vfb_pan_display(struct fb_var_screeninfo *var,
> struct fb_info *info)
> {
> if (var->vmode & FB_VMODE_YWRAP) {
> - if (var->yoffset < 0
> - || var->yoffset >= info->var.yres_virtual
> - || var->xoffset)
> + if (var->yoffset >= info->var.yres_virtual ||
> + var->xoffset)
> return -EINVAL;
> } else {
> if (var->xoffset + info->var.xres > info->var.xres_virtual ||
>
Thanks, queueng the series for 3.13.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]
^ permalink raw reply
* Re: [PATCH 1/6] video: udlfb: Use NULL instead of 0
From: Tomi Valkeinen @ 2013-09-26 8:50 UTC (permalink / raw)
To: linux-fbdev
In-Reply-To: <1380108594-19090-1-git-send-email-sachin.kamat@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 856 bytes --]
On 25/09/13 14:29, Sachin Kamat wrote:
> new_back is a pointer. Use NULL instead of 0.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Bernie Thompson <bernie@plugable.com>
> ---
> drivers/video/udlfb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/udlfb.c b/drivers/video/udlfb.c
> index d2e5bc3..025f14e 100644
> --- a/drivers/video/udlfb.c
> +++ b/drivers/video/udlfb.c
> @@ -1166,7 +1166,7 @@ static int dlfb_realloc_framebuffer(struct dlfb_data *dev, struct fb_info *info)
> int new_len;
> unsigned char *old_fb = info->screen_base;
> unsigned char *new_fb;
> - unsigned char *new_back = 0;
> + unsigned char *new_back = NULL;
>
> pr_warn("Reallocating framebuffer. Addresses will change!\n");
>
>
Thanks, queuing this series for 3.13.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]
^ permalink raw reply
* Re: [PATCH 1/2] backlight: l4f00242t03: Remove redundant spi_set_drvdata
From: Tomi Valkeinen @ 2013-09-26 8:48 UTC (permalink / raw)
To: linux-fbdev
In-Reply-To: <1379659133-18799-1-git-send-email-sachin.kamat@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 795 bytes --]
On 20/09/13 09:38, Sachin Kamat wrote:
> Driver core sets driver data to NULL upon failure or remove.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
> drivers/video/backlight/l4f00242t03.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/video/backlight/l4f00242t03.c b/drivers/video/backlight/l4f00242t03.c
> index a35a38c..59eebe0 100644
> --- a/drivers/video/backlight/l4f00242t03.c
> +++ b/drivers/video/backlight/l4f00242t03.c
> @@ -244,7 +244,6 @@ static int l4f00242t03_remove(struct spi_device *spi)
>
> l4f00242t03_lcd_power_set(priv->ld, FB_BLANK_POWERDOWN);
> lcd_device_unregister(priv->ld);
> - spi_set_drvdata(spi, NULL);
>
> return 0;
> }
>
Thanks, queuing this and the second patch for 3.13.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]
^ permalink raw reply
* Re: [PATCH] neofb: fix error return code in neofb_probe()
From: Tomi Valkeinen @ 2013-09-26 8:46 UTC (permalink / raw)
To: linux-fbdev
In-Reply-To: <CAPgLHd8sm1rhuuG7TJqAfWesiSDf6MaM4E4VCrrWXGziLEiYVA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1329 bytes --]
On 23/09/13 18:00, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
> drivers/video/neofb.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/video/neofb.c b/drivers/video/neofb.c
> index 891b0bf..2a3e5bd 100644
> --- a/drivers/video/neofb.c
> +++ b/drivers/video/neofb.c
> @@ -2075,6 +2075,7 @@ static int neofb_probe(struct pci_dev *dev, const struct pci_device_id *id)
> if (!fb_find_mode(&info->var, info, mode_option, NULL, 0,
> info->monspecs.modedb, 16)) {
> printk(KERN_ERR "neofb: Unable to find usable video mode.\n");
> + err = -EINVAL;
> goto err_map_video;
> }
>
> @@ -2097,7 +2098,8 @@ static int neofb_probe(struct pci_dev *dev, const struct pci_device_id *id)
> info->fix.smem_len >> 10, info->var.xres,
> info->var.yres, h_sync / 1000, h_sync % 1000, v_sync);
>
> - if (fb_alloc_cmap(&info->cmap, 256, 0) < 0)
> + err = fb_alloc_cmap(&info->cmap, 256, 0);
> + if (err < 0)
> goto err_map_video;
>
> err = register_framebuffer(info);
>
Thanks, queuing for 3.12 fixes.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]
^ permalink raw reply
* Re: [PATCH] s3fb: fix error return code in s3_pci_probe()
From: Tomi Valkeinen @ 2013-09-26 8:45 UTC (permalink / raw)
To: linux-fbdev
In-Reply-To: <CAPgLHd_wsqGQ2eSnKY6SzGan0fZLZJWyN03A+_aFmaQ51q73AQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1300 bytes --]
On 23/09/13 18:00, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Fix to return -EINVAL when virtual vertical size smaller than real
> instead of 0, as done elsewhere in this function. Also remove dup code.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
> drivers/video/s3fb.c | 9 +--------
> 1 file changed, 1 insertion(+), 8 deletions(-)
>
> diff --git a/drivers/video/s3fb.c b/drivers/video/s3fb.c
> index 47ca86c..d838ba8 100644
> --- a/drivers/video/s3fb.c
> +++ b/drivers/video/s3fb.c
> @@ -1336,14 +1336,7 @@ static int s3_pci_probe(struct pci_dev *dev, const struct pci_device_id *id)
> (info->var.bits_per_pixel * info->var.xres_virtual);
> if (info->var.yres_virtual < info->var.yres) {
> dev_err(info->device, "virtual vertical size smaller than real\n");
> - goto err_find_mode;
> - }
> -
> - /* maximize virtual vertical size for fast scrolling */
> - info->var.yres_virtual = info->fix.smem_len * 8 /
> - (info->var.bits_per_pixel * info->var.xres_virtual);
> - if (info->var.yres_virtual < info->var.yres) {
> - dev_err(info->device, "virtual vertical size smaller than real\n");
> + rc = -EINVAL;
> goto err_find_mode;
> }
>
>
Thanks, queuing for 3.12 fixes.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]
^ permalink raw reply
* Re: [PATCH] video: mmp: drop needless devm cleanup
From: Tomi Valkeinen @ 2013-09-26 8:43 UTC (permalink / raw)
To: linux-arm-kernel
In-Reply-To: <1379952790-13202-1-git-send-email-u.kleine-koenig@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 536 bytes --]
On 23/09/13 19:13, Uwe Kleine-König wrote:
> The nice thing about devm_* is that the driver doesn't need to free the
> resources but the driver core takes care about that. This also
> simplifies the error path quite a bit and removes the wrong check for a
> clock pointer being NULL.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> drivers/video/mmp/hw/mmp_ctrl.c | 17 ++---------------
> 1 file changed, 2 insertions(+), 15 deletions(-)
>
Thanks, queuing for 3.12 fixes.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]
^ permalink raw reply
* Re: [PATCH] OMAPDSS: Add missing dependency on backlight for DSI-CM panel drier
From: Tomi Valkeinen @ 2013-09-26 8:36 UTC (permalink / raw)
To: Mark Brown
Cc: Jean-Christophe Plagniol-Villard, linux-fbdev, linux-omap,
linaro-kernel, Mark Brown
In-Reply-To: <1380108661-22702-1-git-send-email-broonie@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 890 bytes --]
On 25/09/13 14:31, Mark Brown wrote:
> From: Mark Brown <broonie@linaro.org>
>
> The DSI-CM driver uses the backlight class so needs to build depend on it.
>
> Signed-off-by: Mark Brown <broonie@linaro.org>
> ---
> drivers/video/omap2/displays-new/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/video/omap2/displays-new/Kconfig b/drivers/video/omap2/displays-new/Kconfig
> index 6c90885..10b25e7 100644
> --- a/drivers/video/omap2/displays-new/Kconfig
> +++ b/drivers/video/omap2/displays-new/Kconfig
> @@ -35,6 +35,7 @@ config DISPLAY_PANEL_DPI
>
> config DISPLAY_PANEL_DSI_CM
> tristate "Generic DSI Command Mode Panel"
> + depends on BACKLIGHT_CLASS_DEVICE
> help
> Driver for generic DSI command mode panels.
>
>
Thanks, I'll queue for 3.12 fixes.
I wish we could "select" instead of "depends on"...
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]
^ permalink raw reply
* Re: [PATCH] OMAPDSS: Add missing dependency on backlight for DSI-CM panel drier
From: Jingoo Han @ 2013-09-26 0:59 UTC (permalink / raw)
To: 'Mark Brown', 'Tomi Valkeinen',
'Jean-Christophe Plagniol-Villard'
Cc: linux-fbdev, linux-omap, linaro-kernel, 'Mark Brown',
'Jingoo Han'
In-Reply-To: <1380108661-22702-1-git-send-email-broonie@kernel.org>
On Wednesday, September 25, 2013 8:31 PM, Mark Brown wrote:
>
> From: Mark Brown <broonie@linaro.org>
>
> The DSI-CM driver uses the backlight class so needs to build depend on it.
>
> Signed-off-by: Mark Brown <broonie@linaro.org>
Reviewed-by: Jingoo Han <jg1.han@samsung.com>
I checked that the following build errors are removed.
drivers/video/omap2/displays-new/panel-dsi-cm.c:1257: undefined reference to `backlight_device_register'
drivers/video/omap2/displays-new/panel-dsi-cm.c:1283: undefined reference to `backlight_device_unregister'
drivers/built-in.o: In function `dsicm_remove':
drivers/video/omap2/displays-new/panel-dsi-cm.c:1309: undefined reference to `backlight_device_unregister'
Thank you.
Best regards,
Jingoo Han
> ---
> drivers/video/omap2/displays-new/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/video/omap2/displays-new/Kconfig b/drivers/video/omap2/displays-new/Kconfig
> index 6c90885..10b25e7 100644
> --- a/drivers/video/omap2/displays-new/Kconfig
> +++ b/drivers/video/omap2/displays-new/Kconfig
> @@ -35,6 +35,7 @@ config DISPLAY_PANEL_DPI
>
> config DISPLAY_PANEL_DSI_CM
> tristate "Generic DSI Command Mode Panel"
> + depends on BACKLIGHT_CLASS_DEVICE
> help
> Driver for generic DSI command mode panels.
>
> --
> 1.8.4.rc3
^ permalink raw reply
* [PATCH 4/4] video: riva: Remove incorrect checks
From: Sachin Kamat @ 2013-09-25 12:14 UTC (permalink / raw)
To: linux-fbdev
'xoffset' and 'yoffset' are unsigned and hence cannot be less than 0.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
drivers/video/riva/fbdev.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/video/riva/fbdev.c b/drivers/video/riva/fbdev.c
index 9536715..a5514ac 100644
--- a/drivers/video/riva/fbdev.c
+++ b/drivers/video/riva/fbdev.c
@@ -1185,11 +1185,6 @@ static int rivafb_check_var(struct fb_var_screeninfo *var, struct fb_info *info)
if (rivafb_do_maximize(info, var, nom, den) < 0)
return -EINVAL;
- if (var->xoffset < 0)
- var->xoffset = 0;
- if (var->yoffset < 0)
- var->yoffset = 0;
-
/* truncate xoffset and yoffset to maximum if too high */
if (var->xoffset > var->xres_virtual - var->xres)
var->xoffset = var->xres_virtual - var->xres - 1;
--
1.7.9.5
^ permalink raw reply related
* [PATCH 3/4] video: aty: Remove incorrect checks
From: Sachin Kamat @ 2013-09-25 12:14 UTC (permalink / raw)
To: linux-fbdev
'xoffset' and 'yoffset' are unsigned and hence cannot be less than 0.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
drivers/video/aty/radeon_base.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/video/aty/radeon_base.c b/drivers/video/aty/radeon_base.c
index 1e30b2b..26d80a4 100644
--- a/drivers/video/aty/radeon_base.c
+++ b/drivers/video/aty/radeon_base.c
@@ -819,11 +819,6 @@ static int radeonfb_check_var (struct fb_var_screeninfo *var, struct fb_info *in
if (v.xres_virtual < v.xres)
v.xres = v.xres_virtual;
- if (v.xoffset < 0)
- v.xoffset = 0;
- if (v.yoffset < 0)
- v.yoffset = 0;
-
if (v.xoffset > v.xres_virtual - v.xres)
v.xoffset = v.xres_virtual - v.xres - 1;
--
1.7.9.5
^ permalink raw reply related
* [PATCH 2/4] video: cirrusfb: Remove incorrect checks
From: Sachin Kamat @ 2013-09-25 12:14 UTC (permalink / raw)
To: linux-fbdev
'xoffset' and 'yoffset' are unsigned and hence cannot be less than 0.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Jeff Garzik <jgarzik@redhat.com>
---
drivers/video/cirrusfb.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/video/cirrusfb.c b/drivers/video/cirrusfb.c
index b016746..5aab9b9 100644
--- a/drivers/video/cirrusfb.c
+++ b/drivers/video/cirrusfb.c
@@ -595,11 +595,6 @@ static int cirrusfb_check_var(struct fb_var_screeninfo *var,
return -EINVAL;
}
- if (var->xoffset < 0)
- var->xoffset = 0;
- if (var->yoffset < 0)
- var->yoffset = 0;
-
/* truncate xoffset and yoffset to maximum if too high */
if (var->xoffset > var->xres_virtual - var->xres)
var->xoffset = var->xres_virtual - var->xres - 1;
--
1.7.9.5
^ permalink raw reply related
* [PATCH 1/4] video: vfb: Remove incorrect check
From: Sachin Kamat @ 2013-09-25 12:14 UTC (permalink / raw)
To: linux-fbdev
'yoffset' is unsigned and hence cannot be less than 0.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
drivers/video/vfb.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/video/vfb.c b/drivers/video/vfb.c
index ee5985e..ea2b523 100644
--- a/drivers/video/vfb.c
+++ b/drivers/video/vfb.c
@@ -390,9 +390,8 @@ static int vfb_pan_display(struct fb_var_screeninfo *var,
struct fb_info *info)
{
if (var->vmode & FB_VMODE_YWRAP) {
- if (var->yoffset < 0
- || var->yoffset >= info->var.yres_virtual
- || var->xoffset)
+ if (var->yoffset >= info->var.yres_virtual ||
+ var->xoffset)
return -EINVAL;
} else {
if (var->xoffset + info->var.xres > info->var.xres_virtual ||
--
1.7.9.5
^ permalink raw reply related
* [PATCH 2/2] video: of: display_timing: remove broken of_display_timings_exist
From: Andrzej Hajda @ 2013-09-25 11:51 UTC (permalink / raw)
To: open list:FRAMEBUFFER LAYER
Cc: Andrzej Hajda, Kyungmin Park, Tomi Valkeinen,
Jean-Christophe Plagniol-Villard, dri-devel
In-Reply-To: <1380109892-13040-1-git-send-email-a.hajda@samsung.com>
of_display_timings_exist is implemented incorrectly.
It tries to find property instead of node.
The function is not used anyway so the patch removes it.
Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
drivers/video/of_display_timing.c | 20 --------------------
include/video/of_display_timing.h | 1 -
2 files changed, 21 deletions(-)
diff --git a/drivers/video/of_display_timing.c b/drivers/video/of_display_timing.c
index ba5b40f..b423bb9 100644
--- a/drivers/video/of_display_timing.c
+++ b/drivers/video/of_display_timing.c
@@ -247,23 +247,3 @@ dispfail:
return NULL;
}
EXPORT_SYMBOL_GPL(of_get_display_timings);
-
-/**
- * of_display_timings_exist - check if a display-timings node is provided
- * @np: device_node with the timing
- **/
-int of_display_timings_exist(struct device_node *np)
-{
- struct device_node *timings_np;
-
- if (!np)
- return -EINVAL;
-
- timings_np = of_parse_phandle(np, "display-timings", 0);
- if (!timings_np)
- return -EINVAL;
-
- of_node_put(timings_np);
- return 1;
-}
-EXPORT_SYMBOL_GPL(of_display_timings_exist);
diff --git a/include/video/of_display_timing.h b/include/video/of_display_timing.h
index 79e6697..16cde75 100644
--- a/include/video/of_display_timing.h
+++ b/include/video/of_display_timing.h
@@ -18,6 +18,5 @@ struct display_timings;
int of_get_display_timing(struct device_node *np, const char *name,
struct display_timing *dt);
struct display_timings *of_get_display_timings(struct device_node *np);
-int of_display_timings_exist(struct device_node *np);
#endif
--
1.8.1.2
^ permalink raw reply related
* [PATCH 1/2] video: of: display_timing: correct display-timings node finding
From: Andrzej Hajda @ 2013-09-25 11:51 UTC (permalink / raw)
To: open list:FRAMEBUFFER LAYER
Cc: Andrzej Hajda, Kyungmin Park, Tomi Valkeinen,
Jean-Christophe Plagniol-Villard, dri-devel
In-Reply-To: <1380109892-13040-1-git-send-email-a.hajda@samsung.com>
of_get_display_timing(s) use of_find_node_by_name
to get child node, this is incorrect, of_get_child_by_name
should be used instead. The patch fixes it.
Small typo is also corrected.
Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
drivers/video/of_display_timing.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/video/of_display_timing.c b/drivers/video/of_display_timing.c
index 171821d..ba5b40f 100644
--- a/drivers/video/of_display_timing.c
+++ b/drivers/video/of_display_timing.c
@@ -120,7 +120,7 @@ int of_get_display_timing(struct device_node *np, const char *name,
return -EINVAL;
}
- timing_np = of_find_node_by_name(np, name);
+ timing_np = of_get_child_by_name(np, name);
if (!timing_np) {
pr_err("%s: could not find node '%s'\n",
of_node_full_name(np), name);
@@ -143,11 +143,11 @@ struct display_timings *of_get_display_timings(struct device_node *np)
struct display_timings *disp;
if (!np) {
- pr_err("%s: no devicenode given\n", of_node_full_name(np));
+ pr_err("%s: no device node given\n", of_node_full_name(np));
return NULL;
}
- timings_np = of_find_node_by_name(np, "display-timings");
+ timings_np = of_get_child_by_name(np, "display-timings");
if (!timings_np) {
pr_err("%s: could not find display-timings node\n",
of_node_full_name(np));
--
1.8.1.2
^ permalink raw reply related
* [PATCH 0/2] video: of: display_timing: fixes
From: Andrzej Hajda @ 2013-09-25 11:51 UTC (permalink / raw)
To: open list:FRAMEBUFFER LAYER
Cc: Andrzej Hajda, Kyungmin Park, Tomi Valkeinen,
Jean-Christophe Plagniol-Villard, dri-devel
Hi,
Those two independent patches fixes DT display_timings related code.
The first patch replaces of_find_node_by_name by of_get_child_by_name.
Usage of of_find_node_by_name in such context is incorrect:
- we need only direct child, and this function looks for following nodes
on implementation internal list regardless of the hierarchy,
- there is no warranty that child nodes are after parent nodes in
this search order, it happens to be true for DT created from FDT,
but it is not true for dynamic DT.
The second patch just removes unused/broken function.
Regards
Andrzej
Andrzej Hajda (2):
video: of: display_timing: correct display-timings node finding
video: of: display_timing: remove broken of_display_timings_exist
drivers/video/of_display_timing.c | 26 +++-----------------------
include/video/of_display_timing.h | 1 -
2 files changed, 3 insertions(+), 24 deletions(-)
--
1.8.1.2
^ permalink raw reply
* [PATCH 6/6] video: uvesafb: Remove redundant NULL check
From: Sachin Kamat @ 2013-09-25 11:41 UTC (permalink / raw)
To: linux-fbdev
kfree on a NULL pointer is a no-op.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Michal Januszewski <spock@gentoo.org>
---
drivers/video/uvesafb.c | 19 +++++++------------
1 file changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/video/uvesafb.c b/drivers/video/uvesafb.c
index 7aec6f3..676a4b9 100644
--- a/drivers/video/uvesafb.c
+++ b/drivers/video/uvesafb.c
@@ -233,8 +233,7 @@ out:
static void uvesafb_free(struct uvesafb_ktask *task)
{
if (task) {
- if (task->done)
- kfree(task->done);
+ kfree(task->done);
kfree(task);
}
}
@@ -1332,8 +1331,8 @@ setmode:
FB_VISUAL_PSEUDOCOLOR : FB_VISUAL_TRUECOLOR;
info->fix.line_length = mode->bytes_per_scan_line;
-out: if (crtc != NULL)
- kfree(crtc);
+out:
+ kfree(crtc);
uvesafb_free(task);
return err;
@@ -1793,8 +1792,7 @@ out_mode:
fb_destroy_modedb(info->monspecs.modedb);
fb_dealloc_cmap(&info->cmap);
out:
- if (par->vbe_modes)
- kfree(par->vbe_modes);
+ kfree(par->vbe_modes);
framebuffer_release(info);
return err;
@@ -1817,12 +1815,9 @@ static int uvesafb_remove(struct platform_device *dev)
fb_dealloc_cmap(&info->cmap);
if (par) {
- if (par->vbe_modes)
- kfree(par->vbe_modes);
- if (par->vbe_state_orig)
- kfree(par->vbe_state_orig);
- if (par->vbe_state_saved)
- kfree(par->vbe_state_saved);
+ kfree(par->vbe_modes);
+ kfree(par->vbe_state_orig);
+ kfree(par->vbe_state_saved);
}
framebuffer_release(info);
--
1.7.9.5
^ permalink raw reply related
* [PATCH 5/6] video: kyro: Remove redundant break
From: Sachin Kamat @ 2013-09-25 11:41 UTC (permalink / raw)
To: linux-fbdev
'break' after return statement is redundant. Remove it.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Paul Mundt <lethal@linux-sh.org>
---
drivers/video/kyro/fbdev.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/video/kyro/fbdev.c b/drivers/video/kyro/fbdev.c
index c82f040..79bfb5c 100644
--- a/drivers/video/kyro/fbdev.c
+++ b/drivers/video/kyro/fbdev.c
@@ -623,7 +623,6 @@ static int kyrofb_ioctl(struct fb_info *info,
"command instead.\n");
return -EINVAL;
}
- break;
case KYRO_IOCTL_UVSTRIDE:
if (copy_to_user(argp, &deviceInfo.ulOverlayUVStride, sizeof(unsigned long)))
return -EFAULT;
--
1.7.9.5
^ permalink raw reply related
* [PATCH 4/6] video: aty: Remove redundant break
From: Sachin Kamat @ 2013-09-25 11:41 UTC (permalink / raw)
To: linux-fbdev
'break' after return statement is redundant. Remove it.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
drivers/video/aty/atyfb_base.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/video/aty/atyfb_base.c b/drivers/video/aty/atyfb_base.c
index 9b0f12c..28fafbf 100644
--- a/drivers/video/aty/atyfb_base.c
+++ b/drivers/video/aty/atyfb_base.c
@@ -1848,7 +1848,6 @@ static int atyfb_ioctl(struct fb_info *info, u_int cmd, u_long arg)
return aty_waitforvblank(par, crtc);
}
- break;
#if defined(DEBUG) && defined(CONFIG_FB_ATY_CT)
case ATYIO_CLKR:
--
1.7.9.5
^ permalink raw reply related
* [PATCH 3/6] video: da8xx-fb: Staticize reg_context
From: Sachin Kamat @ 2013-09-25 11:41 UTC (permalink / raw)
To: linux-fbdev
'reg_context' is local to this file. Make it static.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
drivers/video/da8xx-fb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/da8xx-fb.c b/drivers/video/da8xx-fb.c
index 70fc8e8..0670c85 100644
--- a/drivers/video/da8xx-fb.c
+++ b/drivers/video/da8xx-fb.c
@@ -1548,7 +1548,7 @@ err_pm_runtime_disable:
}
#ifdef CONFIG_PM
-struct lcdc_context {
+static struct lcdc_context {
u32 clk_enable;
u32 ctrl;
u32 dma_ctrl;
--
1.7.9.5
^ permalink raw reply related
* [PATCH 2/6] video: smscufx: Use NULL instead of 0
From: Sachin Kamat @ 2013-09-25 11:41 UTC (permalink / raw)
To: linux-fbdev
'info' is a pointer. Use NULL instead of 0.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Steve Glendinning <steve.glendinning@shawell.net>
---
drivers/video/smscufx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/smscufx.c b/drivers/video/smscufx.c
index e188ada..d513ed6 100644
--- a/drivers/video/smscufx.c
+++ b/drivers/video/smscufx.c
@@ -1147,7 +1147,7 @@ static void ufx_free_framebuffer_work(struct work_struct *work)
fb_destroy_modelist(&info->modelist);
- dev->info = 0;
+ dev->info = NULL;
/* Assume info structure is freed after this point */
framebuffer_release(info);
--
1.7.9.5
^ permalink raw reply related
* [PATCH 1/6] video: udlfb: Use NULL instead of 0
From: Sachin Kamat @ 2013-09-25 11:41 UTC (permalink / raw)
To: linux-fbdev
new_back is a pointer. Use NULL instead of 0.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Bernie Thompson <bernie@plugable.com>
---
drivers/video/udlfb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/udlfb.c b/drivers/video/udlfb.c
index d2e5bc3..025f14e 100644
--- a/drivers/video/udlfb.c
+++ b/drivers/video/udlfb.c
@@ -1166,7 +1166,7 @@ static int dlfb_realloc_framebuffer(struct dlfb_data *dev, struct fb_info *info)
int new_len;
unsigned char *old_fb = info->screen_base;
unsigned char *new_fb;
- unsigned char *new_back = 0;
+ unsigned char *new_back = NULL;
pr_warn("Reallocating framebuffer. Addresses will change!\n");
--
1.7.9.5
^ permalink raw reply related
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox