* [PATCH 13/13] video: omap: allow building on !MMU
From: Peter Griffin @ 2014-04-24 12:28 UTC (permalink / raw)
To: linux-kernel
Cc: linaro-kernel, Arnd Bergmann, Peter Griffin,
Jean-Christophe Plagniol-Villard, Tomi Valkeinen, linux-fbdev,
linux-omap
In-Reply-To: <1398342509-10243-1-git-send-email-peter.griffin@linaro.org>
From: Arnd Bergmann <arnd@arndb.de>
The omap lcdc driver has an elaborate mmap_kern function
to map the frame buffer into kernel address space as
write-combined. This uses functions that are only available
on MMU-enabled builds.
It does seem equivalent to ioremap_wc though, so we should
be able to just use that instead.
This patch is build-tested only, it needs to be run on real
hardware before applying.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: linux-fbdev@vger.kernel.org
Cc: linux-omap@vger.kernel.org
---
drivers/video/fbdev/omap/lcdc.c | 28 +++++-----------------------
1 file changed, 5 insertions(+), 23 deletions(-)
diff --git a/drivers/video/fbdev/omap/lcdc.c b/drivers/video/fbdev/omap/lcdc.c
index b52f625..40e8200 100644
--- a/drivers/video/fbdev/omap/lcdc.c
+++ b/drivers/video/fbdev/omap/lcdc.c
@@ -613,29 +613,11 @@ static void lcdc_dma_handler(u16 status, void *data)
static int mmap_kern(void)
{
- struct vm_struct *kvma;
- struct vm_area_struct vma;
- pgprot_t pgprot;
- unsigned long vaddr;
-
- kvma = get_vm_area(lcdc.vram_size, VM_IOREMAP);
- if (kvma = NULL) {
- dev_err(lcdc.fbdev->dev, "can't get kernel vm area\n");
+ void __iomem *vaddr;
+
+ vaddr = ioremap_wc(lcdc.vram_phys, lcdc.vram_size);
+ if (!vaddr)
return -ENOMEM;
- }
- vma.vm_mm = &init_mm;
-
- vaddr = (unsigned long)kvma->addr;
- vma.vm_start = vaddr;
- vma.vm_end = vaddr + lcdc.vram_size;
-
- pgprot = pgprot_writecombine(pgprot_kernel);
- if (io_remap_pfn_range(&vma, vaddr,
- lcdc.vram_phys >> PAGE_SHIFT,
- lcdc.vram_size, pgprot) < 0) {
- dev_err(lcdc.fbdev->dev, "kernel mmap for FB memory failed\n");
- return -EAGAIN;
- }
lcdc.vram_virt = (void *)vaddr;
@@ -644,7 +626,7 @@ static int mmap_kern(void)
static void unmap_kern(void)
{
- vunmap(lcdc.vram_virt);
+ iounmap(lcdc.vram_virt);
}
static int alloc_palette_ram(void)
--
1.7.9.5
^ permalink raw reply related
* Re: [PATCH 03/13] video: clarify I2C dependencies
From: Russell King - ARM Linux @ 2014-04-24 12:32 UTC (permalink / raw)
To: Peter Griffin
Cc: linux-kernel, linaro-kernel, Arnd Bergmann,
Jean-Christophe Plagniol-Villard, Tomi Valkeinen, linux-fbdev,
Anatolij Gustschin
In-Reply-To: <1398342509-10243-4-git-send-email-peter.griffin@linaro.org>
On Thu, Apr 24, 2014 at 01:28:19PM +0100, Peter Griffin wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> We can only use I2C support in frame buffer drivers if
> Either I2C is built-in, or both I2C and the driver itself
> are loadable modules.
Why?
--
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving, and getting towards what was expected from it.
^ permalink raw reply
* Re: [PATCHv3 19/41] OMAPDSS: panel-dpi: Add DT support
From: Laurent Pinchart @ 2014-04-24 12:44 UTC (permalink / raw)
To: linux-arm-kernel
In-Reply-To: <5358DEEA.1000506@ti.com>
[-- Attachment #1: Type: text/plain, Size: 1264 bytes --]
Hi Tomi,
On Thursday 24 April 2014 12:52:42 Tomi Valkeinen wrote:
> On 18/04/14 18:51, Tony Lindgren wrote:
> >> + gpio = of_get_gpio(node, 0);
> >> + if (gpio_is_valid(gpio) || gpio == -ENOENT) {
> >> + ddata->enable_gpio = gpio;
> >> + } else {
> >> + dev_err(&pdev->dev, "failed to parse enable gpio\n");
> >> + return gpio;
> >> + }
> >
> > We should set the GPIO polarity based on the OF_GPIO_ACTIVE_LOW like
> > gpio_backlight_probe_dt is doing.
>
> Instead of doing it with the old gpio API, and checking the 'active'
> flag everywhere, I think we can use the new gpiod API which handles the
> polarity automatically.
>
> I attached prototype patches (based on -rc2) for panel dpi using that
> approach. It's a bit messier than I'd like, because for non-DT boot we
> need to request the gpio using the old API, and then convert it to
> gpio_desc. We can remove that code when all the boards use DT.
Just FYI, you can use the gpiod API with non-DT platforms if you register GPIO
lookup entries in board code with gpiod_add_lookup_table().
> I've compiled tested this only, as I don't have DPI panels I could use.
> I did try similar approach for TFP410, and it seemed to work fine.
--
Regards,
Laurent Pinchart
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
^ permalink raw reply
* Re: [PATCH 03/13] video: clarify I2C dependencies
From: Arnd Bergmann @ 2014-04-24 12:48 UTC (permalink / raw)
To: Russell King - ARM Linux
Cc: Peter Griffin, linux-kernel, linaro-kernel,
Jean-Christophe Plagniol-Villard, Tomi Valkeinen, linux-fbdev,
Anatolij Gustschin
In-Reply-To: <20140424123235.GS26756@n2100.arm.linux.org.uk>
On Thursday 24 April 2014 13:32:35 Russell King - ARM Linux wrote:
> On Thu, Apr 24, 2014 at 01:28:19PM +0100, Peter Griffin wrote:
> > From: Arnd Bergmann <arnd@arndb.de>
> >
> > We can only use I2C support in frame buffer drivers if
> > Either I2C is built-in, or both I2C and the driver itself
> > are loadable modules.
>
> Why?
If I2C is a loadable module, and the I2C support of the framebuffer
driver is built-in, you get a link error when building vmlinux:
drivers/built-in.o: In function `cyberpro_pci_remove':
:(.text+0x1ea5c): undefined reference to `i2c_del_adapter'
drivers/built-in.o: In function `cyberpro_pci_probe':
:(.text+0x20224): undefined reference to `i2c_bit_add_bus'
:(.text+0x20240): undefined reference to `i2c_del_adapter'
make[2]: *** [vmlinux] Error 1
It's probably a good idea to mention that in the changeset
text.
Arnd
^ permalink raw reply
* Re: [PATCHv3 19/41] OMAPDSS: panel-dpi: Add DT support
From: Tomi Valkeinen @ 2014-04-24 13:12 UTC (permalink / raw)
To: linux-arm-kernel
In-Reply-To: <3615191.vG5AEQORWJ@avalon>
[-- Attachment #1: Type: text/plain, Size: 592 bytes --]
On 24/04/14 15:44, Laurent Pinchart wrote:
>> I attached prototype patches (based on -rc2) for panel dpi using that
>> approach. It's a bit messier than I'd like, because for non-DT boot we
>> need to request the gpio using the old API, and then convert it to
>> gpio_desc. We can remove that code when all the boards use DT.
>
> Just FYI, you can use the gpiod API with non-DT platforms if you register GPIO
> lookup entries in board code with gpiod_add_lookup_table().
Right, but as the board files are going away, I'd rather not touch them
at all if possible.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply
* Re: [PATCH 11/23] ARM: dts: omap5-uevm.dts: add tca6424a
From: Sergei Shtylyov @ 2014-04-24 13:49 UTC (permalink / raw)
To: linux-arm-kernel
In-Reply-To: <1398334639-14172-12-git-send-email-tomi.valkeinen@ti.com>
Hello.
On 24-04-2014 14:17, Tomi Valkeinen wrote:
> omap5-uevm has a tca6424a I/O expander. Add it to the .dts file.
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
> Cc: Tony Lindgren <tony@atomide.com>
> ---
> arch/arm/boot/dts/omap5-uevm.dts | 7 +++++++
> 1 file changed, 7 insertions(+)
> diff --git a/arch/arm/boot/dts/omap5-uevm.dts b/arch/arm/boot/dts/omap5-uevm.dts
> index 3b99ec25b748..9e7581eaeb23 100644
> --- a/arch/arm/boot/dts/omap5-uevm.dts
> +++ b/arch/arm/boot/dts/omap5-uevm.dts
> @@ -434,6 +434,13 @@
> pinctrl-0 = <&i2c5_pins>;
>
> clock-frequency = <400000>;
> +
> + tca6424a: tca6424a@22 {
The ePAPR standard [1] says: "The name of a node should be somewhat generic,
reflecting the function of the device and not its precise programming model.
If appropriate, the name should be one of the following choices:
[...]
- gpio;"
> + compatible = "ti,tca6424";
> + reg = <0x22>;
> + gpio-controller;
> + #gpio-cells = <2>;
> + };
> };
[1] http://www.power.org/resources/downloads/Power_ePAPR_APPROVED_v1.0.pdf
WBR, Sergei
^ permalink raw reply
* Re: [PATCH 11/23] ARM: dts: omap5-uevm.dts: add tca6424a
From: Tomi Valkeinen @ 2014-04-24 14:33 UTC (permalink / raw)
To: linux-arm-kernel
In-Reply-To: <53591669.7060502@cogentembedded.com>
[-- Attachment #1: Type: text/plain, Size: 1281 bytes --]
On 24/04/14 16:49, Sergei Shtylyov wrote:
> Hello.
>
> On 24-04-2014 14:17, Tomi Valkeinen wrote:
>
>> omap5-uevm has a tca6424a I/O expander. Add it to the .dts file.
>
>> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
>> Cc: Tony Lindgren <tony@atomide.com>
>> ---
>> arch/arm/boot/dts/omap5-uevm.dts | 7 +++++++
>> 1 file changed, 7 insertions(+)
>
>> diff --git a/arch/arm/boot/dts/omap5-uevm.dts
>> b/arch/arm/boot/dts/omap5-uevm.dts
>> index 3b99ec25b748..9e7581eaeb23 100644
>> --- a/arch/arm/boot/dts/omap5-uevm.dts
>> +++ b/arch/arm/boot/dts/omap5-uevm.dts
>> @@ -434,6 +434,13 @@
>> pinctrl-0 = <&i2c5_pins>;
>>
>> clock-frequency = <400000>;
>> +
>> + tca6424a: tca6424a@22 {
>
> The ePAPR standard [1] says: "The name of a node should be somewhat
> generic,
> reflecting the function of the device and not its precise programming
> model.
> If appropriate, the name should be one of the following choices:
> [...]
> - gpio;"
Right. I wonder what the name should be... "gpio" is out, as the name
should be more specific. We already have gpio1-8, which are the gpio
banks from the SoC. It could be 'gpio9', but that makes it sound it's
just one more SoC gpio bank. 'gpio-expander1'?
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply
* [PATCH] video/backlight: Fix string type mismatch in s6e63m0.c
From: Masanari Iida @ 2014-04-24 15:47 UTC (permalink / raw)
To: jg1.han, cooloney, lee.jones, linux-fbdev, linux-kernel; +Cc: Masanari Iida
Fix string type mismatch in s6e63m0_sysfs_show_gamma_table().
gamma_table_count is defined as unsigned int.
Signed-off-by: Masanari Iida <standby24x7@gmail.com>
---
drivers/video/backlight/s6e63m0.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/backlight/s6e63m0.c b/drivers/video/backlight/s6e63m0.c
index 510a1bc..2d6d481 100644
--- a/drivers/video/backlight/s6e63m0.c
+++ b/drivers/video/backlight/s6e63m0.c
@@ -703,7 +703,7 @@ static ssize_t s6e63m0_sysfs_show_gamma_table(struct device *dev,
struct s6e63m0 *lcd = dev_get_drvdata(dev);
char temp[3];
- sprintf(temp, "%d\n", lcd->gamma_table_count);
+ sprintf(temp, "%u\n", lcd->gamma_table_count);
strcpy(buf, temp);
return strlen(buf);
--
2.0.0.rc0.26.g779792a
^ permalink raw reply related
* Re: [PATCH v2 1/3] video: clps711x: Add new C =?UTF-8?B?aXJydXMgTG9naWMgQ
From: Alexander Shiyan @ 2014-04-24 16:35 UTC (permalink / raw)
To: linux-fbdev
In-Reply-To: <1398327006.501536964@f133.i.mail.ru>
VGh1LCAyNCBBcHIgMjAxNCAxMTozOToyMSArMDMwMCDQvtGCIFRvbWkgVmFsa2VpbmVuIDx0b21p
LnZhbGtlaW5lbkB0aS5jb20+Ogo+IE9uIDI0LzA0LzE0IDExOjEwLCBBbGV4YW5kZXIgU2hpeWFu
IHdyb3RlOgo+ID4gSGVsbG8uCj4gPiAKPiA+IFRodSwgMjQgQXByIDIwMTQgMTA6NTc6NTkgKzAz
MDAg0L7RgiBUb21pIFZhbGtlaW5lbiA8dG9taS52YWxrZWluZW5AdGkuY29tPjoKPiA+PiBIaSwK
PiA+Pgo+ID4+IE9uIDEyLzA0LzE0IDA5OjUzLCBBbGV4YW5kZXIgU2hpeWFuIHdyb3RlOgo+ID4+
PiBUaGlzIGFkZHMgc3VwcG9ydCBmb3IgdGhlIGZyYW1lYnVmZmVyIGF2YWlsYWJsZSBpbiB0aGUg
Q2lycnVzCj4gPj4+IExvZ2ljIENMUFM3MTFYIENQVXMuCj4gPj4+IEZCIGZlYXR1cmVzOgo+ID4+
PiAtIDEtMi00IGJpdHMgcGVyIHBpeGVsLgo+ID4+PiAtIFByb2dyYW1tYWJsZSBwYW5lbCBzaXpl
IHRvIGEgbWF4aW11bSBvZiAxMDI0eDI1NiBhdCA0IGJwcy4KPiA+Pj4gLSBSZWxvY2F0aWJsZSBG
cmFtZSBCdWZmZXIgKFNSQU0gb3IgU0RSQU0pLgo+ID4+PiAtIFByb2dyYW1tYWJsZSByZWZyZXNo
IHJhdGVzLgo+ID4+PiAtIDE2IGdyYXkgc2NhbGUgdmFsdWVzLgo+ID4+PiBUaGlzIG5ldyBkcml2
ZXIgc3VwcG9ydHMgdXNhZ2Ugd2l0aCBkZXZpY2V0cmVlIGFuZCBhcyBhIGdlbmVyYWwKPiA+Pj4g
Y2hhbmdlIGl0IHJlbW92ZXMgbGFzdCB1c2VyIG9mIDxtYWNoL2hhcmR3YXJlLmg+IGZvciBDTFBT
NzExWCB0YXJnZXRzLAo+ID4+PiBzbyB0aGlzIHN1YmFyY2ggd2lsbCBmdWxseSBwcmVwYXJlZCB0
byBzd2l0Y2ggdG8gbXVsdGlwbGF0Zm9ybS4KPiA+Pj4gVGhlIGRyaXZlciBoYXZlIGJlZW4gdGVz
dGVkIHdpdGggY3VzdG9tIGJvYXJkIGVxdWlwcGVkIENpcnJ1cyBMb2dpYwo+ID4+PiBFUDczMTIg
aW4gRFQgYW5kIG5vbi1EVCBtb2RlLgo+ID4+Cj4gPj4gTXkgb3JpZ2luYWwgY29tbWVudCBhYm91
dCB0aGlzIGlzIHN0aWxsIHVuYW5zd2VyZWQ6IHdoeSBhIHRvdGFsbHkgbmV3Cj4gPj4gZHJpdmVy
PyBUaGUgcHJvcGVyIHdheSB3b3VsZCBiZSB0byBncmFkdWFsbHkgY2hhbmdlIHRoZSBvbGQgZHJp
dmVyIHdpdGgKPiA+PiBhIHBhdGNoIHNlcmllcy4gVGhlbiBpdCdzIHBvc3NpYmxlIHRvIHJldmll
dyB0aGUgcGF0Y2hlcyBhbmQgc2VlIHdoYXQgaXMKPiA+PiBhY3R1YWxseSBjaGFuZ2VkLgo+ID4g
Cj4gPiBJIGhhdmUgdHJpZWQgdG8gYW5zd2VyIGhlcmU6Cj4gPiBodHRwOi8vd3d3LnNwaW5pY3Mu
bmV0L2xpc3RzL2xpbnV4LWZiZGV2L21zZzE0MjE4Lmh0bWwKPiAKPiBJZiB5b3VyIGFuc3dlciBt
ZWFucyAiaXQgd2lsbCBiZSB2ZXJ5IGRpZmZpY3VsdCB0byBzZWUgdGhlIGNoYW5nZXMgaWYKPiBh
bGwgdGhlIGNoYW5nZXMgYXJlIGluIG9uZSBwYXRjaCwgd2hpY2ggY2hhbmdlIHRoZSBvbGQgZHJp
dmVyIGluIG9uZQo+IGdvIiwgdGhlbiB5ZXMsIHZlcnkgdHJ1ZS4KPiAKPiBCdXQgdGhhdCdzIHdy
b25nIHdheSB0byBkbyBpdC4KPiAKPiBUaGUgcmlnaHQgd2F5IHRvIGRvIGl0IGlzLCBhcyBJIHdy
b3RlIGFib3ZlLCBieSBncmFkdWFsbHkgY2hhbmdpbmcgdGhlCj4gb2xkIGRyaXZlciB3aXRoIGEg
cGF0Y2ggc2VyaWVzLiBBbmQgbXkgcXVlc3Rpb24gaXMsIHdoeSBub3QgZG8gaXQgdGhhdAo+IHdh
eT8gVGhlbiBpdCB3b3VsZCBiZSBwb3NzaWJsZSB0byByZXZpZXcgdGhlIHBhdGNoZXMgb25lIGJ5
IG9uZSwgc2VlaW5nCj4gd2hhdCBoYXMgY2hhbmdlZC4KCiJncmFkdWFsbHkgY2hhbmdpbmciLi4u
CkkgcmVwZWF0IHRoYXQgdGhpcyBpcyBub3QgYW4gb2xkIG1vZGlmaWVkIGRyaXZlciwgYnV0IHdy
aXR0ZW4gbmV3LgppZiB5b3UgaW1hZ2luZSBhIG5ldyBmaWxlIGFzIGEgZGlmZiB0byB0aGUgb2xk
LCB0aGlzIGNhbiBiZSBjbGVhcmx5IHNlZW4uCgpUaGVyZSBpcyBubyByZWFzb24gdG8gd2FzdGUg
dGltZSBvbiBhIHNlcmllcyBvZiBjaGFuZ2VzIHNpbmNlIEkKY2FuIG5vdCBldmVuIGNoZWNrIHRo
ZXNlIGNoYW5nZXMgb24gcmVhbCBoYXJkd2FyZSwgYnV0IG9ubHkgaW4gdGhlCmxhc3Qgc3RhZ2Ug
d2hlbiB0aGUgZHJpdmVyIHdpbGwgYmUgdGhlIGN1cnJlbnQgdmVyc2lvbi4KCi0tLQoK
^ permalink raw reply
* Re: [PATCH] video/backlight: Fix string type mismatch in s6e63m0.c
From: Bryan Wu @ 2014-04-24 16:36 UTC (permalink / raw)
To: Masanari Iida; +Cc: Jingoo Han, Lee Jones, FBDEV list, lkml
In-Reply-To: <1398354436-25467-1-git-send-email-standby24x7@gmail.com>
On Thu, Apr 24, 2014 at 8:47 AM, Masanari Iida <standby24x7@gmail.com> wrote:
> Fix string type mismatch in s6e63m0_sysfs_show_gamma_table().
> gamma_table_count is defined as unsigned int.
>
Looks good to me,
Acked-by: Bryan Wu <cooloney@gmail.com>
> Signed-off-by: Masanari Iida <standby24x7@gmail.com>
> ---
> drivers/video/backlight/s6e63m0.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/backlight/s6e63m0.c b/drivers/video/backlight/s6e63m0.c
> index 510a1bc..2d6d481 100644
> --- a/drivers/video/backlight/s6e63m0.c
> +++ b/drivers/video/backlight/s6e63m0.c
> @@ -703,7 +703,7 @@ static ssize_t s6e63m0_sysfs_show_gamma_table(struct device *dev,
> struct s6e63m0 *lcd = dev_get_drvdata(dev);
> char temp[3];
>
> - sprintf(temp, "%d\n", lcd->gamma_table_count);
> + sprintf(temp, "%u\n", lcd->gamma_table_count);
> strcpy(buf, temp);
>
> return strlen(buf);
> --
> 2.0.0.rc0.26.g779792a
>
^ permalink raw reply
* Re: [PATCH 08/13] video/backlight: LM3630A needs PWM
From: Bryan Wu @ 2014-04-24 16:45 UTC (permalink / raw)
To: Peter Griffin
Cc: lkml, linaro-kernel, Arnd Bergmann, Jingoo Han, Lee Jones,
Jean-Christophe Plagniol-Villard, Tomi Valkeinen, FBDEV list
In-Reply-To: <1398342509-10243-9-git-send-email-peter.griffin@linaro.org>
On Thu, Apr 24, 2014 at 5:28 AM, Peter Griffin <peter.griffin@linaro.org> wrote:
> The LM3630A driver cannot be successfully built if we don't
> enable the PWM subsystem. This patch makes that dependency
> explicit in Kconfig and prevents broken randconfig builds.
>
> Based on Arnd Bergmann patch but split out into seperate
> commits per driver based on feedback.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
> Cc: Jingoo Han <jg1.han@samsung.com>
> Cc: Bryan Wu <cooloney@gmail.com>
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> Cc: linux-fbdev@vger.kernel.org
> ---
> drivers/video/backlight/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/backlight/Kconfig b/drivers/video/backlight/Kconfig
> index 5a3eb2e..4791af7 100644
> --- a/drivers/video/backlight/Kconfig
> +++ b/drivers/video/backlight/Kconfig
> @@ -370,7 +370,7 @@ config BACKLIGHT_AAT2870
>
> config BACKLIGHT_LM3630A
> tristate "Backlight Driver for LM3630A"
> - depends on BACKLIGHT_CLASS_DEVICE && I2C
> + depends on BACKLIGHT_CLASS_DEVICE && I2C && PWM
Looks good to me,
Acked-by: Bryan Wu <cooloney@gmail.com>
> select REGMAP_I2C
> help
> This supports TI LM3630A Backlight Driver
> --
> 1.7.9.5
>
^ permalink raw reply
* Re: [PATCH 09/13] video/backlight: LP8788 needs PWM
From: Bryan Wu @ 2014-04-24 16:45 UTC (permalink / raw)
To: Peter Griffin
Cc: lkml, linaro-kernel, Arnd Bergmann, Milo Kim, Jingoo Han,
Lee Jones, Jean-Christophe Plagniol-Villard, Tomi Valkeinen,
FBDEV list
In-Reply-To: <1398342509-10243-10-git-send-email-peter.griffin@linaro.org>
On Thu, Apr 24, 2014 at 5:28 AM, Peter Griffin <peter.griffin@linaro.org> wrote:
> The LP8788 driver cannot be successfully built if we don't
> enable the PWM subsystem. This patch makes that dependency
> explicit in Kconfig and prevents broken randconfig builds.
>
> Based on Arnd Bergmann patch but split out into seperate
> commits per driver based on feedback.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
> Cc: Milo Kim <milo.kim@ti.com>
> Cc: Jingoo Han <jg1.han@samsung.com>
> Cc: Bryan Wu <cooloney@gmail.com>
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> Cc: linux-fbdev@vger.kernel.org
> ---
> drivers/video/backlight/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/backlight/Kconfig b/drivers/video/backlight/Kconfig
> index 4791af7..ac6bc28 100644
> --- a/drivers/video/backlight/Kconfig
> +++ b/drivers/video/backlight/Kconfig
> @@ -393,7 +393,7 @@ config BACKLIGHT_LP855X
>
> config BACKLIGHT_LP8788
> tristate "Backlight driver for TI LP8788 MFD"
> - depends on BACKLIGHT_CLASS_DEVICE && MFD_LP8788
> + depends on BACKLIGHT_CLASS_DEVICE && MFD_LP8788 && PWM
Looks good to me,
Acked-by: Bryan Wu <cooloney@gmail.com>
> help
> This supports TI LP8788 backlight driver.
>
> --
> 1.7.9.5
>
^ permalink raw reply
* Re: [PATCH 10/13] video/pxa: LCD_CORGI needs BACKLIGHT_CLASS_DEVICE
From: Bryan Wu @ 2014-04-24 16:46 UTC (permalink / raw)
To: Peter Griffin
Cc: lkml, linaro-kernel, Arnd Bergmann, Jingoo Han, Lee Jones,
Jean-Christophe Plagniol-Villard, Tomi Valkeinen, FBDEV list
In-Reply-To: <1398342509-10243-11-git-send-email-peter.griffin@linaro.org>
On Thu, Apr 24, 2014 at 5:28 AM, Peter Griffin <peter.griffin@linaro.org> wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> This fixes a randconfig build error when BACKLIGHT_CLASS_DEVICE
> is disabled, by describing the dependency in Kconfig,
> as we do for the other drivers in this directory.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
> Cc: Jingoo Han <jg1.han@samsung.com>
> Cc: Bryan Wu <cooloney@gmail.com>
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> Cc: linux-fbdev@vger.kernel.org
> ---
> drivers/video/backlight/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/backlight/Kconfig b/drivers/video/backlight/Kconfig
> index ac6bc28..5675511 100644
> --- a/drivers/video/backlight/Kconfig
> +++ b/drivers/video/backlight/Kconfig
> @@ -29,7 +29,7 @@ if LCD_CLASS_DEVICE
>
> config LCD_CORGI
> tristate "LCD Panel support for SHARP corgi/spitz model"
> - depends on SPI_MASTER && PXA_SHARPSL
> + depends on SPI_MASTER && PXA_SHARPSL && BACKLIGHT_CLASS_DEVICE
Looks good to me,
Acked-by: Bryan Wu <cooloney@gmail.com>
> help
> Say y here to support the LCD panels usually found on SHARP
> corgi (C7x0) and spitz (Cxx00) models.
> --
> 1.7.9.5
>
^ permalink raw reply
* Re: [PATCH 12/13] video/backlight: LP855X needs PWM
From: Bryan Wu @ 2014-04-24 16:48 UTC (permalink / raw)
To: Peter Griffin
Cc: lkml, linaro-kernel, Arnd Bergmann, Jingoo Han, Milo Kim,
Lee Jones, Jean-Christophe Plagniol-Villard, Tomi Valkeinen,
FBDEV list
In-Reply-To: <1398342509-10243-13-git-send-email-peter.griffin@linaro.org>
On Thu, Apr 24, 2014 at 5:28 AM, Peter Griffin <peter.griffin@linaro.org> wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The LP855X driver cannot be successfully built if we don't
> enable the PWM subsystem. This patch makes that dependency
> explicit in Kconfig and prevents broken randconfig builds.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
> Cc: Jingoo Han <jg1.han@samsung.com>
> Cc: Milo Kim <milo.kim@ti.com>
> Cc: Bryan Wu <cooloney@gmail.com>
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> Cc: linux-fbdev@vger.kernel.org
> ---
> drivers/video/backlight/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/backlight/Kconfig b/drivers/video/backlight/Kconfig
> index 5675511..5d44905 100644
> --- a/drivers/video/backlight/Kconfig
> +++ b/drivers/video/backlight/Kconfig
> @@ -386,7 +386,7 @@ config BACKLIGHT_LM3639
>
> config BACKLIGHT_LP855X
> tristate "Backlight driver for TI LP855X"
> - depends on BACKLIGHT_CLASS_DEVICE && I2C
> + depends on BACKLIGHT_CLASS_DEVICE && I2C && PWM
Looks good to me,
Acked-by: Bryan Wu <cooloney@gmail.com>
> help
> This supports TI LP8550, LP8551, LP8552, LP8553, LP8555, LP8556 and
> LP8557 backlight driver.
> --
> 1.7.9.5
>
^ permalink raw reply
* Re: [PATCH 11/23] ARM: dts: omap5-uevm.dts: add tca6424a
From: Sergei Shtylyov @ 2014-04-24 16:53 UTC (permalink / raw)
To: linux-arm-kernel
In-Reply-To: <5359209F.7000308@ti.com>
Hello.
On 04/24/2014 06:33 PM, Tomi Valkeinen wrote:
>>> omap5-uevm has a tca6424a I/O expander. Add it to the .dts file.
>>> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
>>> Cc: Tony Lindgren <tony@atomide.com>
>>> ---
>>> arch/arm/boot/dts/omap5-uevm.dts | 7 +++++++
>>> 1 file changed, 7 insertions(+)
>>> diff --git a/arch/arm/boot/dts/omap5-uevm.dts
>>> b/arch/arm/boot/dts/omap5-uevm.dts
>>> index 3b99ec25b748..9e7581eaeb23 100644
>>> --- a/arch/arm/boot/dts/omap5-uevm.dts
>>> +++ b/arch/arm/boot/dts/omap5-uevm.dts
>>> @@ -434,6 +434,13 @@
>>> pinctrl-0 = <&i2c5_pins>;
>>>
>>> clock-frequency = <400000>;
>>> +
>>> + tca6424a: tca6424a@22 {
>> The ePAPR standard [1] says: "The name of a node should be somewhat
>> generic,
>> reflecting the function of the device and not its precise programming
>> model.
>> If appropriate, the name should be one of the following choices:
>> [...]
>> - gpio;"
> Right. I wonder what the name should be... "gpio" is out, as the name
> should be more specific.
No, it's not out. The name should be "gpio@22", I think it would be unique.
> We already have gpio1-8, which are the gpio
> banks from the SoC.
I don't understand why you are indexing the names while you probably have
the address part after @ that makes them unique already.
> Tomi
WBR, Sergei
^ permalink raw reply
* Re: [PATCH 09/13] video/backlight: LP8788 needs PWM
From: Milo Kim @ 2014-04-24 22:42 UTC (permalink / raw)
To: Peter Griffin
Cc: linux-kernel, linaro-kernel, Arnd Bergmann, Jingoo Han, Bryan Wu,
Lee Jones, Jean-Christophe Plagniol-Villard, Tomi Valkeinen,
linux-fbdev
In-Reply-To: <1398342509-10243-10-git-send-email-peter.griffin@linaro.org>
On 04/24/2014 09:28 PM, Peter Griffin wrote:
> The LP8788 driver cannot be successfully built if we don't
> enable the PWM subsystem. This patch makes that dependency
> explicit in Kconfig and prevents broken randconfig builds.
>
> Based on Arnd Bergmann patch but split out into seperate
> commits per driver based on feedback.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
Thanks!
Acked-by: Milo Kim <milo.kim@ti.com>
^ permalink raw reply
* Re: [PATCH 12/13] video/backlight: LP855X needs PWM
From: Milo Kim @ 2014-04-24 22:43 UTC (permalink / raw)
To: Peter Griffin
Cc: linux-kernel, linaro-kernel, Arnd Bergmann, Jingoo Han, Bryan Wu,
Lee Jones, Jean-Christophe Plagniol-Villard, Tomi Valkeinen,
linux-fbdev
In-Reply-To: <1398342509-10243-13-git-send-email-peter.griffin@linaro.org>
On 04/24/2014 09:28 PM, Peter Griffin wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The LP855X driver cannot be successfully built if we don't
> enable the PWM subsystem. This patch makes that dependency
> explicit in Kconfig and prevents broken randconfig builds.
>
Thanks!
Acked-by: Milo Kim <milo.kim@ti.com>
^ permalink raw reply
* Re: [PATCH 09/13] video/backlight: LP8788 needs PWM
From: Jingoo Han @ 2014-04-25 8:54 UTC (permalink / raw)
To: 'Peter Griffin', linux-kernel
Cc: linaro-kernel, 'Arnd Bergmann', 'Milo Kim',
'Bryan Wu', 'Lee Jones',
'Jean-Christophe Plagniol-Villard',
'Tomi Valkeinen', linux-fbdev, 'Jingoo Han'
In-Reply-To: <1398342509-10243-10-git-send-email-peter.griffin@linaro.org>
On Thursday, April 24, 2014 9:28 PM, Peter Griffin wrote:
>
> The LP8788 driver cannot be successfully built if we don't
> enable the PWM subsystem. This patch makes that dependency
> explicit in Kconfig and prevents broken randconfig builds.
>
> Based on Arnd Bergmann patch but split out into seperate
> commits per driver based on feedback.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
> Cc: Milo Kim <milo.kim@ti.com>
> Cc: Jingoo Han <jg1.han@samsung.com>
Acked-by: Jingoo Han <jg1.han@samsung.com>
Best regards,
Jingoo Han
> Cc: Bryan Wu <cooloney@gmail.com>
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> Cc: linux-fbdev@vger.kernel.org
> ---
> drivers/video/backlight/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/backlight/Kconfig b/drivers/video/backlight/Kconfig
> index 4791af7..ac6bc28 100644
> --- a/drivers/video/backlight/Kconfig
> +++ b/drivers/video/backlight/Kconfig
> @@ -393,7 +393,7 @@ config BACKLIGHT_LP855X
>
> config BACKLIGHT_LP8788
> tristate "Backlight driver for TI LP8788 MFD"
> - depends on BACKLIGHT_CLASS_DEVICE && MFD_LP8788
> + depends on BACKLIGHT_CLASS_DEVICE && MFD_LP8788 && PWM
> help
> This supports TI LP8788 backlight driver.
>
> --
> 1.7.9.5
^ permalink raw reply
* Re: [PATCH 10/13] video/pxa: LCD_CORGI needs BACKLIGHT_CLASS_DEVICE
From: Jingoo Han @ 2014-04-25 8:58 UTC (permalink / raw)
To: 'Peter Griffin', linux-kernel
Cc: linaro-kernel, 'Arnd Bergmann', 'Bryan Wu',
'Lee Jones', 'Jean-Christophe Plagniol-Villard',
'Tomi Valkeinen', linux-fbdev, 'Jingoo Han'
In-Reply-To: <1398342509-10243-11-git-send-email-peter.griffin@linaro.org>
On Thursday, April 24, 2014 9:28 PM, Peter Griffin wrote:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> This fixes a randconfig build error when BACKLIGHT_CLASS_DEVICE
> is disabled, by describing the dependency in Kconfig,
> as we do for the other drivers in this directory.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
> Cc: Jingoo Han <jg1.han@samsung.com>
Acked-by: Jingoo Han <jg1.han@samsung.com>
Best regards,
Jingoo Han
> Cc: Bryan Wu <cooloney@gmail.com>
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> Cc: linux-fbdev@vger.kernel.org
> ---
> drivers/video/backlight/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/backlight/Kconfig b/drivers/video/backlight/Kconfig
> index ac6bc28..5675511 100644
> --- a/drivers/video/backlight/Kconfig
> +++ b/drivers/video/backlight/Kconfig
> @@ -29,7 +29,7 @@ if LCD_CLASS_DEVICE
>
> config LCD_CORGI
> tristate "LCD Panel support for SHARP corgi/spitz model"
> - depends on SPI_MASTER && PXA_SHARPSL
> + depends on SPI_MASTER && PXA_SHARPSL && BACKLIGHT_CLASS_DEVICE
> help
> Say y here to support the LCD panels usually found on SHARP
> corgi (C7x0) and spitz (Cxx00) models.
> --
> 1.7.9.5
^ permalink raw reply
* Re: [PATCH 08/13] video/backlight: LM3630A needs PWM
From: Jingoo Han @ 2014-04-25 9:00 UTC (permalink / raw)
To: 'Peter Griffin', linux-kernel
Cc: linaro-kernel, 'Arnd Bergmann', 'Bryan Wu',
'Lee Jones', 'Jean-Christophe Plagniol-Villard',
'Tomi Valkeinen', linux-fbdev, 'Jingoo Han'
In-Reply-To: <1398342509-10243-9-git-send-email-peter.griffin@linaro.org>
On Thursday, April 24, 2014 9:28 PM, Peter Griffin wrote:
>
> The LM3630A driver cannot be successfully built if we don't
> enable the PWM subsystem. This patch makes that dependency
> explicit in Kconfig and prevents broken randconfig builds.
>
> Based on Arnd Bergmann patch but split out into seperate
> commits per driver based on feedback.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
> Cc: Jingoo Han <jg1.han@samsung.com>
Acked-by: Jingoo Han <jg1.han@samsung.com>
Best regards,
Jingoo Han
> Cc: Bryan Wu <cooloney@gmail.com>
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> Cc: linux-fbdev@vger.kernel.org
> ---
> drivers/video/backlight/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/backlight/Kconfig b/drivers/video/backlight/Kconfig
> index 5a3eb2e..4791af7 100644
> --- a/drivers/video/backlight/Kconfig
> +++ b/drivers/video/backlight/Kconfig
> @@ -370,7 +370,7 @@ config BACKLIGHT_AAT2870
>
> config BACKLIGHT_LM3630A
> tristate "Backlight Driver for LM3630A"
> - depends on BACKLIGHT_CLASS_DEVICE && I2C
> + depends on BACKLIGHT_CLASS_DEVICE && I2C && PWM
> select REGMAP_I2C
> help
> This supports TI LM3630A Backlight Driver
> --
> 1.7.9.5
^ permalink raw reply
* Re: [PATCH 12/13] video/backlight: LP855X needs PWM
From: Jingoo Han @ 2014-04-25 9:02 UTC (permalink / raw)
To: 'Peter Griffin', linux-kernel
Cc: linaro-kernel, 'Arnd Bergmann', 'Milo Kim',
'Bryan Wu', 'Lee Jones',
'Jean-Christophe Plagniol-Villard',
'Tomi Valkeinen', linux-fbdev, 'Jingoo Han'
In-Reply-To: <1398342509-10243-13-git-send-email-peter.griffin@linaro.org>
On Thursday, April 24, 2014 9:28 PM, Peter Griffin wrote:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> The LP855X driver cannot be successfully built if we don't
> enable the PWM subsystem. This patch makes that dependency
> explicit in Kconfig and prevents broken randconfig builds.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
> Cc: Jingoo Han <jg1.han@samsung.com>
Acked-by: Jingoo Han <jg1.han@samsung.com>
Best regards,
Jingoo Han
> Cc: Milo Kim <milo.kim@ti.com>
> Cc: Bryan Wu <cooloney@gmail.com>
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> Cc: linux-fbdev@vger.kernel.org
> ---
> drivers/video/backlight/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/backlight/Kconfig b/drivers/video/backlight/Kconfig
> index 5675511..5d44905 100644
> --- a/drivers/video/backlight/Kconfig
> +++ b/drivers/video/backlight/Kconfig
> @@ -386,7 +386,7 @@ config BACKLIGHT_LM3639
>
> config BACKLIGHT_LP855X
> tristate "Backlight driver for TI LP855X"
> - depends on BACKLIGHT_CLASS_DEVICE && I2C
> + depends on BACKLIGHT_CLASS_DEVICE && I2C && PWM
> help
> This supports TI LP8550, LP8551, LP8552, LP8553, LP8555, LP8556 and
> LP8557 backlight driver.
> --
> 1.7.9.5
^ permalink raw reply
* Re: [PATCH 01/23] OMAPDSS: HDMI: lane config support
From: Archit Taneja @ 2014-04-25 10:18 UTC (permalink / raw)
To: linux-arm-kernel
In-Reply-To: <1398334639-14172-2-git-send-email-tomi.valkeinen@ti.com>
Hi,
On Thursday 24 April 2014 03:46 PM, Tomi Valkeinen wrote:
> Add support to configure the pins used for the HDMI lanes. The order and
> polarity of the lanes can be defined in the DT data.
>
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
> ---
> +static void hdmi_phy_configure_lanes(struct hdmi_phy_data *phy)
> +{
> + static const u16 pad_cfg_list[] = {
> + 0x0123,
> + 0x0132,
> + 0x0312,
> + 0x0321,
> + 0x0231,
> + 0x0213,
> + 0x1023,
> + 0x1032,
> + 0x3012,
> + 0x3021,
> + 0x2031,
> + 0x2013,
> + 0x1203,
> + 0x1302,
> + 0x3102,
> + 0x3201,
> + 0x2301,
> + 0x2103,
> + 0x1230,
> + 0x1320,
> + 0x3120,
> + 0x3210,
> + 0x2310,
> + 0x2130,
> + };
> +
> + u16 lane_cfg = 0;
> + int i;
> + unsigned lane_cfg_val;
> + u16 pol_val = 0;
> +
> + for (i = 0; i < 4; ++i)
> + lane_cfg |= phy->lane_function[i] << ((3 - i) * 4);
> +
> + pol_val |= phy->lane_polarity[0] << 0;
> + pol_val |= phy->lane_polarity[1] << 3;
> + pol_val |= phy->lane_polarity[2] << 2;
> + pol_val |= phy->lane_polarity[3] << 1;
> +
> + for (i = 0; i < ARRAY_SIZE(pad_cfg_list); ++i)
> + if (pad_cfg_list[i] = lane_cfg)
> + break;
> +
> + if (WARN_ON(i = ARRAY_SIZE(pad_cfg_list)))
> + i = 0;
> +
> + lane_cfg_val = i;
I spent some time to see if we could get create lane_cfg_val without
having the table above, looks like there is no pattern at all in the
register field.
> +
> + REG_FLD_MOD(phy->base, HDMI_TXPHY_PAD_CFG_CTRL, lane_cfg_val, 26, 22);
> + REG_FLD_MOD(phy->base, HDMI_TXPHY_PAD_CFG_CTRL, pol_val, 30, 27);
> +}
> +
> int hdmi_phy_enable(struct hdmi_phy_data *phy, struct hdmi_wp_data *wp,
> struct hdmi_config *cfg)
> {
> @@ -92,8 +183,7 @@ int hdmi_phy_enable(struct hdmi_phy_data *phy, struct hdmi_wp_data *wp,
> /* Setup max LDO voltage */
> REG_FLD_MOD(phy->base, HDMI_TXPHY_POWER_CTRL, 0xB, 3, 0);
>
> - /* Write to phy address 3 to change the polarity control */
> - REG_FLD_MOD(phy->base, HDMI_TXPHY_PAD_CFG_CTRL, 0x1, 27, 27);
wow, didn't realize it was hardcoded like this.
Reviewed-by: Archit Taneja <archit@ti.com?
Archit
^ permalink raw reply
* Re: [PATCH 01/23] OMAPDSS: HDMI: lane config support
From: Tomi Valkeinen @ 2014-04-25 10:28 UTC (permalink / raw)
To: linux-arm-kernel
In-Reply-To: <535A3395.4050106@ti.com>
[-- Attachment #1: Type: text/plain, Size: 1225 bytes --]
On 25/04/14 13:06, Archit Taneja wrote:
> I spent some time to see if we could get create lane_cfg_val without
> having the table above, looks like there is no pattern at all in the
> register field.
There is a pattern, but I wasn't able to figure out a formula to model
it. And as the array was not very long, and was easy to create with copy
paste and search-replace from the TRM, I thought it's just simplest way
to do it.
>> +
>> + REG_FLD_MOD(phy->base, HDMI_TXPHY_PAD_CFG_CTRL, lane_cfg_val, 26,
>> 22);
>> + REG_FLD_MOD(phy->base, HDMI_TXPHY_PAD_CFG_CTRL, pol_val, 30, 27);
>> +}
>> +
>> int hdmi_phy_enable(struct hdmi_phy_data *phy, struct hdmi_wp_data *wp,
>> struct hdmi_config *cfg)
>> {
>> @@ -92,8 +183,7 @@ int hdmi_phy_enable(struct hdmi_phy_data *phy,
>> struct hdmi_wp_data *wp,
>> /* Setup max LDO voltage */
>> REG_FLD_MOD(phy->base, HDMI_TXPHY_POWER_CTRL, 0xB, 3, 0);
>>
>> - /* Write to phy address 3 to change the polarity control */
>> - REG_FLD_MOD(phy->base, HDMI_TXPHY_PAD_CFG_CTRL, 0x1, 27, 27);
>
> wow, didn't realize it was hardcoded like this.
>
> Reviewed-by: Archit Taneja <archit@ti.com?
Thanks!
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply
* Re: [PATCH 06/23] ARM: OMAP: add OMAP5 DSI muxing
From: Tomi Valkeinen @ 2014-04-25 11:18 UTC (permalink / raw)
To: linux-arm-kernel
In-Reply-To: <535A42D6.5090107@ti.com>
[-- Attachment #1: Type: text/plain, Size: 1210 bytes --]
On 25/04/14 14:11, Archit Taneja wrote:
> Hi,
>
> On Thursday 24 April 2014 03:47 PM, Tomi Valkeinen wrote:
>> Add support to set OMAP5 DSI pin muxing.
>>
>> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
>> Cc: Tony Lindgren <tony@atomide.com>
>> ---
>> arch/arm/mach-omap2/display.c | 35 ++++++++++++++++++++++++++++++++++-
>> 1 file changed, 34 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/mach-omap2/display.c
>> b/arch/arm/mach-omap2/display.c
>> index 16d33d831287..974461441fc3 100644
>> --- a/arch/arm/mach-omap2/display.c
>> +++ b/arch/arm/mach-omap2/display.c
>> @@ -137,11 +137,42 @@ static int omap4_dsi_mux_pads(int dsi_id,
>> unsigned lanes)
>> return 0;
>> }
>>
>> +#define CONTROL_PAD_BASE 0x4A002800
>> +#define CONTROL_DSIPHY 0x614
>> +
>
> I guess this is something we can move to our driver, and use sysconf to
> get the register from DT.
I just copied the same method as used for OMAP4.
I guess sysconf is an option. But I really dislike the idea of moving
omap control module code to a display driver... I'm not sure what other
options we have, though. Maybe an OMAP DSI specific pinctrl driver?
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply
* Re: [PATCH 06/23] ARM: OMAP: add OMAP5 DSI muxing
From: Archit Taneja @ 2014-04-25 11:23 UTC (permalink / raw)
To: linux-arm-kernel
In-Reply-To: <1398334639-14172-7-git-send-email-tomi.valkeinen@ti.com>
Hi,
On Thursday 24 April 2014 03:47 PM, Tomi Valkeinen wrote:
> Add support to set OMAP5 DSI pin muxing.
>
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
> Cc: Tony Lindgren <tony@atomide.com>
> ---
> arch/arm/mach-omap2/display.c | 35 ++++++++++++++++++++++++++++++++++-
> 1 file changed, 34 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-omap2/display.c b/arch/arm/mach-omap2/display.c
> index 16d33d831287..974461441fc3 100644
> --- a/arch/arm/mach-omap2/display.c
> +++ b/arch/arm/mach-omap2/display.c
> @@ -137,11 +137,42 @@ static int omap4_dsi_mux_pads(int dsi_id, unsigned lanes)
> return 0;
> }
>
> +#define CONTROL_PAD_BASE 0x4A002800
> +#define CONTROL_DSIPHY 0x614
> +
I guess this is something we can move to our driver, and use sysconf to
get the register from DT.
Archit
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox