* [PATCH 09/12] backlight: da9052_bl: Include <linux/mod_devicetable.h>
From: Thomas Zimmermann @ 2025-06-18 12:16 UTC (permalink / raw)
To: lee, danielt, jingoohan1, neil.armstrong, jessica.zhang,
maarten.lankhorst, mripard, airlied, simona, fnkl.kernel, j,
hdegoede, ilpo.jarvinen, sven, alyssa, neal, deller,
support.opensource, duje.mihanovic
Cc: dri-devel, asahi, platform-driver-x86, linux-arm-kernel,
linux-fbdev, Thomas Zimmermann
In-Reply-To: <20250618122436.379013-1-tzimmermann@suse.de>
Include <linux/mod_devicetable.h> to declare struct platform_device_id.
Avoids dependency on backlight header to include it.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/video/backlight/da9052_bl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/video/backlight/da9052_bl.c b/drivers/video/backlight/da9052_bl.c
index f41523d78121..2493138febfa 100644
--- a/drivers/video/backlight/da9052_bl.c
+++ b/drivers/video/backlight/da9052_bl.c
@@ -9,6 +9,7 @@
#include <linux/backlight.h>
#include <linux/delay.h>
+#include <linux/mod_devicetable.h>
#include <linux/module.h>
#include <linux/platform_device.h>
--
2.49.0
^ permalink raw reply related
* [PATCH 10/12] backlight: ktd2801: Include <linux/mod_devicetable.h>
From: Thomas Zimmermann @ 2025-06-18 12:16 UTC (permalink / raw)
To: lee, danielt, jingoohan1, neil.armstrong, jessica.zhang,
maarten.lankhorst, mripard, airlied, simona, fnkl.kernel, j,
hdegoede, ilpo.jarvinen, sven, alyssa, neal, deller,
support.opensource, duje.mihanovic
Cc: dri-devel, asahi, platform-driver-x86, linux-arm-kernel,
linux-fbdev, Thomas Zimmermann
In-Reply-To: <20250618122436.379013-1-tzimmermann@suse.de>
Include <linux/mod_devicetable.h> to declare struct of_device_id.
Avoids dependency on backlight header to include it.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/video/backlight/ktd2801-backlight.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/video/backlight/ktd2801-backlight.c b/drivers/video/backlight/ktd2801-backlight.c
index 0489b0615ceb..17eac1b3bce4 100644
--- a/drivers/video/backlight/ktd2801-backlight.c
+++ b/drivers/video/backlight/ktd2801-backlight.c
@@ -6,6 +6,7 @@
#include <linux/backlight.h>
#include <linux/gpio/consumer.h>
#include <linux/leds-expresswire.h>
+#include <linux/mod_devicetable.h>
#include <linux/platform_device.h>
#include <linux/property.h>
--
2.49.0
^ permalink raw reply related
* [PATCH 11/12] backlight: led_bl: Include <linux/of.h>
From: Thomas Zimmermann @ 2025-06-18 12:16 UTC (permalink / raw)
To: lee, danielt, jingoohan1, neil.armstrong, jessica.zhang,
maarten.lankhorst, mripard, airlied, simona, fnkl.kernel, j,
hdegoede, ilpo.jarvinen, sven, alyssa, neal, deller,
support.opensource, duje.mihanovic
Cc: dri-devel, asahi, platform-driver-x86, linux-arm-kernel,
linux-fbdev, Thomas Zimmermann
In-Reply-To: <20250618122436.379013-1-tzimmermann@suse.de>
Include <linux/of.h> to declare struct of_count_phandle_with_args().
Avoids dependency on backlight header to include it.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/video/backlight/led_bl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/video/backlight/led_bl.c b/drivers/video/backlight/led_bl.c
index d2db157b2c29..44aac5fb2663 100644
--- a/drivers/video/backlight/led_bl.c
+++ b/drivers/video/backlight/led_bl.c
@@ -9,6 +9,7 @@
#include <linux/backlight.h>
#include <linux/leds.h>
#include <linux/module.h>
+#include <linux/of.h>
#include <linux/platform_device.h>
struct led_bl_data {
--
2.49.0
^ permalink raw reply related
* [PATCH 12/12] backlight: Do not include <linux/fb.h> in header file
From: Thomas Zimmermann @ 2025-06-18 12:16 UTC (permalink / raw)
To: lee, danielt, jingoohan1, neil.armstrong, jessica.zhang,
maarten.lankhorst, mripard, airlied, simona, fnkl.kernel, j,
hdegoede, ilpo.jarvinen, sven, alyssa, neal, deller,
support.opensource, duje.mihanovic
Cc: dri-devel, asahi, platform-driver-x86, linux-arm-kernel,
linux-fbdev, Thomas Zimmermann
In-Reply-To: <20250618122436.379013-1-tzimmermann@suse.de>
The backlight interfaces don't require anything from <linux/fb.h>, so
don't include it.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
include/linux/backlight.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/linux/backlight.h b/include/linux/backlight.h
index 10e626db7eee..f29a9ef1052e 100644
--- a/include/linux/backlight.h
+++ b/include/linux/backlight.h
@@ -10,7 +10,6 @@
#define _LINUX_BACKLIGHT_H
#include <linux/device.h>
-#include <linux/fb.h>
#include <linux/mutex.h>
#include <linux/types.h>
--
2.49.0
^ permalink raw reply related
* Re: [PATCH 01/12] platform/x86: dell-uart-backlight: Use blacklight power constant
From: Hans de Goede @ 2025-06-18 13:01 UTC (permalink / raw)
To: Thomas Zimmermann, lee, danielt, jingoohan1, neil.armstrong,
jessica.zhang, maarten.lankhorst, mripard, airlied, simona,
fnkl.kernel, j, ilpo.jarvinen, sven, alyssa, neal, deller,
support.opensource, duje.mihanovic
Cc: dri-devel, asahi, platform-driver-x86, linux-arm-kernel,
linux-fbdev
In-Reply-To: <20250618122436.379013-2-tzimmermann@suse.de>
Hi,
On 18-Jun-25 2:16 PM, Thomas Zimmermann wrote:
> The backlight subsystem has gotten its own power constants. Replace
> FB_BLANK_UNBLANK with BACKLIGHT_POWER_ON.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede <hansg@kernel.org>
Regards,
Hans
> ---
> drivers/platform/x86/dell/dell-uart-backlight.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/dell/dell-uart-backlight.c b/drivers/platform/x86/dell/dell-uart-backlight.c
> index 8f868f845350..f323a667dc2d 100644
> --- a/drivers/platform/x86/dell/dell-uart-backlight.c
> +++ b/drivers/platform/x86/dell/dell-uart-backlight.c
> @@ -305,7 +305,7 @@ static int dell_uart_bl_serdev_probe(struct serdev_device *serdev)
> dev_dbg(dev, "Firmware version: %.*s\n", resp[RESP_LEN] - 3, resp + RESP_DATA);
>
> /* Initialize bl_power to a known value */
> - ret = dell_uart_set_bl_power(dell_bl, FB_BLANK_UNBLANK);
> + ret = dell_uart_set_bl_power(dell_bl, BACKLIGHT_POWER_ON);
> if (ret)
> return ret;
>
^ permalink raw reply
* Re: [PATCH 03/12] drm/panel: panel-samsung-s6e88a0-ams427ap24: Include <linux/of.h>
From: neil.armstrong @ 2025-06-18 13:42 UTC (permalink / raw)
To: Thomas Zimmermann, lee, danielt, jingoohan1, jessica.zhang,
maarten.lankhorst, mripard, airlied, simona, fnkl.kernel, j,
hdegoede, ilpo.jarvinen, sven, alyssa, neal, deller,
support.opensource, duje.mihanovic
Cc: dri-devel, asahi, platform-driver-x86, linux-arm-kernel,
linux-fbdev
In-Reply-To: <20250618122436.379013-4-tzimmermann@suse.de>
On 18/06/2025 14:16, Thomas Zimmermann wrote:
> Include <linux/of.h> to declare device_property_read_bool(). Avoids
> dependency on backlight header to include it.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/gpu/drm/panel/panel-samsung-s6e88a0-ams427ap24.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-samsung-s6e88a0-ams427ap24.c b/drivers/gpu/drm/panel/panel-samsung-s6e88a0-ams427ap24.c
> index e91f50662997..b6d04f8ad561 100644
> --- a/drivers/gpu/drm/panel/panel-samsung-s6e88a0-ams427ap24.c
> +++ b/drivers/gpu/drm/panel/panel-samsung-s6e88a0-ams427ap24.c
> @@ -8,6 +8,7 @@
> #include <linux/delay.h>
> #include <linux/gpio/consumer.h>
> #include <linux/module.h>
> +#include <linux/of.h>
> #include <linux/regulator/consumer.h>
>
> #include <video/mipi_display.h>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
^ permalink raw reply
* [PATCH] staging: sm750fb: rename 'proc_setBLANK'
From: Kisub Choe @ 2025-06-18 14:15 UTC (permalink / raw)
To: sudipm.mukherjee, teddy.wang, gregkh
Cc: linux-fbdev, linux-staging, linux-kernel, kisub.choe.0x1
Rename 'proc_setBLANK' to 'proc_setBLANK' to
conform with kernel style guidelines as reported by checkpatch.pl
CHECK: Avoid CamelCase: <proc_setBLANK>
Signed-off-by: Kisub Choe <kisub.choe.0x1@gmail.com>
---
drivers/staging/sm750fb/sm750.c | 4 ++--
drivers/staging/sm750fb/sm750.h | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
index 1d929aca399c..bb2ade6030c2 100644
--- a/drivers/staging/sm750fb/sm750.c
+++ b/drivers/staging/sm750fb/sm750.c
@@ -577,7 +577,7 @@ static int lynxfb_ops_blank(int blank, struct fb_info *info)
pr_debug("blank = %d.\n", blank);
par = info->par;
output = &par->output;
- return output->proc_setBLANK(output, blank);
+ return output->proc_set_blank(output, blank);
}
static int sm750fb_set_drv(struct lynxfb_par *par)
@@ -605,7 +605,7 @@ static int sm750fb_set_drv(struct lynxfb_par *par)
crtc->ypanstep = 1;
crtc->ywrapstep = 0;
- output->proc_setBLANK = (sm750_dev->revid == SM750LE_REVISION_ID) ?
+ output->proc_set_blank = (sm750_dev->revid == SM750LE_REVISION_ID) ?
hw_sm750le_set_blank : hw_sm750_set_blank;
/* chip specific phase */
sm750_dev->accel.de_wait = (sm750_dev->revid == SM750LE_REVISION_ID) ?
diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h
index 9cf8b3d30aac..40051798efbf 100644
--- a/drivers/staging/sm750fb/sm750.h
+++ b/drivers/staging/sm750fb/sm750.h
@@ -170,7 +170,7 @@ struct lynxfb_output {
*/
void *priv;
- int (*proc_setBLANK)(struct lynxfb_output *output, int blank);
+ int (*proc_set_blank)(struct lynxfb_output *output, int blank);
};
struct lynxfb_par {
--
2.34.1
^ permalink raw reply related
* Re: [PATCH] staging: sm750fb: rename 'proc_setBLANK'
From: Greg KH @ 2025-06-18 14:26 UTC (permalink / raw)
To: Kisub Choe
Cc: sudipm.mukherjee, teddy.wang, linux-fbdev, linux-staging,
linux-kernel
In-Reply-To: <20250618141555.5434-1-kisub.choe.0x1@gmail.com>
On Wed, Jun 18, 2025 at 11:15:55PM +0900, Kisub Choe wrote:
> Rename 'proc_setBLANK' to 'proc_setBLANK' to
That doesn't rename anything :(
> conform with kernel style guidelines as reported by checkpatch.pl
>
> CHECK: Avoid CamelCase: <proc_setBLANK>
>
> Signed-off-by: Kisub Choe <kisub.choe.0x1@gmail.com>
> ---
> drivers/staging/sm750fb/sm750.c | 4 ++--
> drivers/staging/sm750fb/sm750.h | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
> index 1d929aca399c..bb2ade6030c2 100644
> --- a/drivers/staging/sm750fb/sm750.c
> +++ b/drivers/staging/sm750fb/sm750.c
> @@ -577,7 +577,7 @@ static int lynxfb_ops_blank(int blank, struct fb_info *info)
> pr_debug("blank = %d.\n", blank);
> par = info->par;
> output = &par->output;
> - return output->proc_setBLANK(output, blank);
> + return output->proc_set_blank(output, blank);
> }
>
> static int sm750fb_set_drv(struct lynxfb_par *par)
> @@ -605,7 +605,7 @@ static int sm750fb_set_drv(struct lynxfb_par *par)
> crtc->ypanstep = 1;
> crtc->ywrapstep = 0;
>
> - output->proc_setBLANK = (sm750_dev->revid == SM750LE_REVISION_ID) ?
> + output->proc_set_blank = (sm750_dev->revid == SM750LE_REVISION_ID) ?
> hw_sm750le_set_blank : hw_sm750_set_blank;
Why do we even need this function pointer? Why not just do the check
above when it is called instead of this indirection?
thanks,
greg k-h
^ permalink raw reply
* [PATCH] staging: sm750fb: rename 'hwCursor'
From: Kisub Choe @ 2025-06-18 14:33 UTC (permalink / raw)
To: sudipm.mukherjee, teddy.wang, gregkh
Cc: linux-fbdev, linux-staging, linux-kernel, kisub.choe.0x1
Rename 'hwCursor' to 'hw_cursor' to
conform with kernel style guidelines as reported by checkpatch.pl
CHECK: Avoid CamelCase: <hwCursor>
Signed-off-by: Kisub Choe <kisub.choe.0x1@gmail.com>
---
drivers/staging/sm750fb/sm750.c | 2 +-
drivers/staging/sm750fb/sm750.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
index bb2ade6030c2..612c982bacd7 100644
--- a/drivers/staging/sm750fb/sm750.c
+++ b/drivers/staging/sm750fb/sm750.c
@@ -598,7 +598,7 @@ static int sm750fb_set_drv(struct lynxfb_par *par)
crtc->vidmem_size >>= 1;
/* setup crtc and output member */
- sm750_dev->hwCursor = g_hwcursor;
+ sm750_dev->hw_cursor = g_hwcursor;
crtc->line_pad = 16;
crtc->xpanstep = 8;
diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h
index 40051798efbf..d7e02ff3d6c6 100644
--- a/drivers/staging/sm750fb/sm750.h
+++ b/drivers/staging/sm750fb/sm750.h
@@ -113,7 +113,7 @@ struct sm750_dev {
* 2: secondary crtc hw cursor enabled
* 3: both ctrc hw cursor enabled
*/
- int hwCursor;
+ int hw_cursor;
};
struct lynx_cursor {
--
2.34.1
^ permalink raw reply related
* Re: [PATCH 10/12] backlight: ktd2801: Include <linux/mod_devicetable.h>
From: Nick Chan @ 2025-06-18 15:04 UTC (permalink / raw)
To: Thomas Zimmermann, lee, danielt, jingoohan1, neil.armstrong,
jessica.zhang, maarten.lankhorst, mripard, airlied, simona,
fnkl.kernel, j, hdegoede, ilpo.jarvinen, sven, alyssa, neal,
deller, support.opensource, duje.mihanovic
Cc: dri-devel, asahi, platform-driver-x86, linux-arm-kernel,
linux-fbdev
In-Reply-To: <20250618122436.379013-11-tzimmermann@suse.de>
On 18/6/2025 20:16, Thomas Zimmermann wrote:
> Include <linux/mod_devicetable.h> to declare struct of_device_id.
> Avoids dependency on backlight header to include it.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/video/backlight/ktd2801-backlight.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/video/backlight/ktd2801-backlight.c b/drivers/video/backlight/ktd2801-backlight.c
> index 0489b0615ceb..17eac1b3bce4 100644
> --- a/drivers/video/backlight/ktd2801-backlight.c
> +++ b/drivers/video/backlight/ktd2801-backlight.c
> @@ -6,6 +6,7 @@
> #include <linux/backlight.h>
> #include <linux/gpio/consumer.h>
> #include <linux/leds-expresswire.h>
> +#include <linux/mod_devicetable.h>
> #include <linux/platform_device.h>
> #include <linux/property.h>
>
Reviewed-by: Nick Chan <towinchenmi@gmail.com>
^ permalink raw reply
* Re: [PATCH 07/12] backlight: apple_dwi_bl: Include <linux/mod_devicetable.h>
From: Nick Chan @ 2025-06-18 15:08 UTC (permalink / raw)
To: Thomas Zimmermann, lee, danielt, jingoohan1, neil.armstrong,
jessica.zhang, maarten.lankhorst, mripard, airlied, simona,
fnkl.kernel, j, hdegoede, ilpo.jarvinen, sven, alyssa, neal,
deller, support.opensource, duje.mihanovic
Cc: dri-devel, asahi, platform-driver-x86, linux-arm-kernel,
linux-fbdev
In-Reply-To: <20250618122436.379013-8-tzimmermann@suse.de>
On 18/6/2025 20:16, Thomas Zimmermann wrote:
> Include <linux/mod_devicetable.h> to declare struct of_device_id.
> Avoids dependency on backlight header to include it.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/video/backlight/apple_dwi_bl.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/video/backlight/apple_dwi_bl.c b/drivers/video/backlight/apple_dwi_bl.c
> index 93bd744972d6..ed8bf13d3f51 100644
> --- a/drivers/video/backlight/apple_dwi_bl.c
> +++ b/drivers/video/backlight/apple_dwi_bl.c
> @@ -9,6 +9,7 @@
> #include <linux/bitfield.h>
> #include <linux/device.h>
> #include <linux/io.h>
> +#include <linux/mod_devicetable.h>
> #include <linux/module.h>
> #include <linux/platform_device.h>
>
Reviewed-by: Nick Chan <towinchenmi@gmail.com>
^ permalink raw reply
* Re: [PATCH 04/12] drm/panel: panel-summit: Include <linux/of.h>
From: Janne Grunau @ 2025-06-18 15:19 UTC (permalink / raw)
To: Thomas Zimmermann
Cc: lee, danielt, jingoohan1, neil.armstrong, jessica.zhang,
maarten.lankhorst, mripard, airlied, simona, fnkl.kernel,
hdegoede, ilpo.jarvinen, sven, alyssa, neal, deller,
support.opensource, duje.mihanovic, dri-devel, asahi,
platform-driver-x86, linux-arm-kernel, linux-fbdev
In-Reply-To: <20250618122436.379013-5-tzimmermann@suse.de>
On Wed, Jun 18, 2025 at 02:16:36PM +0200, Thomas Zimmermann wrote:
> Include <linux/of.h> to declare device_property_read_u32() and
> struct of_device_id. Avoids dependency on backlight header to include
> it.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/gpu/drm/panel/panel-summit.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-summit.c b/drivers/gpu/drm/panel/panel-summit.c
> index 4854437e2899..02aa1ec287d6 100644
> --- a/drivers/gpu/drm/panel/panel-summit.c
> +++ b/drivers/gpu/drm/panel/panel-summit.c
> @@ -1,6 +1,7 @@
> // SPDX-License-Identifier: GPL-2.0-only
>
> #include <linux/backlight.h>
> +#include <linux/of.h>
> #include <drm/drm_device.h>
> #include <drm/drm_mipi_dsi.h>
> #include <drm/drm_mode.h>
Reviewed-by: Janne Grunau <j@jannau.net>
^ permalink raw reply
* Re: [PATCH 12/12] backlight: Do not include <linux/fb.h> in header file
From: kernel test robot @ 2025-06-19 5:12 UTC (permalink / raw)
To: Thomas Zimmermann, lee, danielt, jingoohan1, neil.armstrong,
jessica.zhang, maarten.lankhorst, mripard, airlied, simona,
fnkl.kernel, j, hdegoede, ilpo.jarvinen, sven, alyssa, neal,
deller, support.opensource, duje.mihanovic
Cc: oe-kbuild-all, dri-devel, asahi, platform-driver-x86,
linux-arm-kernel, linux-fbdev, Thomas Zimmermann
In-Reply-To: <20250618122436.379013-13-tzimmermann@suse.de>
Hi Thomas,
kernel test robot noticed the following build errors:
[auto build test ERROR on drm-misc/drm-misc-next]
[also build test ERROR on v6.16-rc2 next-20250618]
[cannot apply to lee-backlight/for-backlight-next lee-leds/for-leds-next drm-exynos/exynos-drm-next linus/master lee-backlight/for-backlight-fixes drm-intel/for-linux-next drm-intel/for-linux-next-fixes]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Thomas-Zimmermann/platform-x86-dell-uart-backlight-Use-blacklight-power-constant/20250618-203011
base: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next
patch link: https://lore.kernel.org/r/20250618122436.379013-13-tzimmermann%40suse.de
patch subject: [PATCH 12/12] backlight: Do not include <linux/fb.h> in header file
config: riscv-randconfig-001-20250619 (https://download.01.org/0day-ci/archive/20250619/202506191230.WMfb29QM-lkp@intel.com/config)
compiler: riscv32-linux-gcc (GCC) 11.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250619/202506191230.WMfb29QM-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202506191230.WMfb29QM-lkp@intel.com/
All errors (new ones prefixed by >>):
>> drivers/video/backlight/rt4831-backlight.c:215:49: error: array type has incomplete element type 'struct of_device_id'
215 | static const struct of_device_id __maybe_unused rt4831_bl_of_match[] = {
| ^~~~~~~~~~~~~~~~~~
vim +215 drivers/video/backlight/rt4831-backlight.c
190ccab3185eee ChiYuan Huang 2021-05-17 214
190ccab3185eee ChiYuan Huang 2021-05-17 @215 static const struct of_device_id __maybe_unused rt4831_bl_of_match[] = {
190ccab3185eee ChiYuan Huang 2021-05-17 216 { .compatible = "richtek,rt4831-backlight", },
190ccab3185eee ChiYuan Huang 2021-05-17 217 {}
190ccab3185eee ChiYuan Huang 2021-05-17 218 };
190ccab3185eee ChiYuan Huang 2021-05-17 219 MODULE_DEVICE_TABLE(of, rt4831_bl_of_match);
190ccab3185eee ChiYuan Huang 2021-05-17 220
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply
* Re: [PATCH v2] staging: sm750fb: rename 'proc_setBLANK'
From: Kisub Choe @ 2025-06-19 13:12 UTC (permalink / raw)
To: Greg KH
Cc: sudipm.mukherjee, teddy.wang, linux-fbdev, linux-staging,
linux-kernel
In-Reply-To: <2025061817-jacket-nacho-50d6@gregkh>
On Wed, Jun 18, 2025 at 04:26:10PM +0200, Greg KH wrote:
> On Wed, Jun 18, 2025 at 11:15:55PM +0900, Kisub Choe wrote:
> > Rename 'proc_setBLANK' to 'proc_setBLANK' to
>
> That doesn't rename anything :(
Rename 'proc_setBLANK' to 'proc_set_blank' to
>
>
>
> > conform with kernel style guidelines as reported by checkpatch.pl
> >
> > CHECK: Avoid CamelCase: <proc_setBLANK>
> >
> > Signed-off-by: Kisub Choe <kisub.choe.0x1@gmail.com>
> > ---
> > drivers/staging/sm750fb/sm750.c | 4 ++--
> > drivers/staging/sm750fb/sm750.h | 2 +-
> > 2 files changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
> > index 1d929aca399c..bb2ade6030c2 100644
> > --- a/drivers/staging/sm750fb/sm750.c
> > +++ b/drivers/staging/sm750fb/sm750.c
> > @@ -577,7 +577,7 @@ static int lynxfb_ops_blank(int blank, struct fb_info *info)
> > pr_debug("blank = %d.\n", blank);
> > par = info->par;
> > output = &par->output;
> > - return output->proc_setBLANK(output, blank);
> > + return output->proc_set_blank(output, blank);
> > }
> >
> > static int sm750fb_set_drv(struct lynxfb_par *par)
> > @@ -605,7 +605,7 @@ static int sm750fb_set_drv(struct lynxfb_par *par)
> > crtc->ypanstep = 1;
> > crtc->ywrapstep = 0;
> >
> > - output->proc_setBLANK = (sm750_dev->revid == SM750LE_REVISION_ID) ?
> > + output->proc_set_blank = (sm750_dev->revid == SM750LE_REVISION_ID) ?
> > hw_sm750le_set_blank : hw_sm750_set_blank;
>
> Why do we even need this function pointer? Why not just do the check
> above when it is called instead of this indirection?
>
> thanks,
>
> greg k-h
Dear Greg,
Here is the updated patch with revised commit message. No code changes.
Regards,
Kisub Choe.
From 9c32c6f5091c8babe54bfde7b3a6de47d9026a55 Mon Sep 17 00:00:00 2001
From: Kisub Choe <kisub.choe.0x1@gmail.com>
Date: Wed, 18 Jun 2025 22:55:00 +0900
Subject: [PATCH] staging: sm750fb: rename 'proc_setBLANK'
Rename 'proc_setBLANK' to 'proc_set_blank' to
conform with kernel style guidelines as reported by checkpatch.pl
CHECK: Avoid CamelCase: <proc_setBLANK>
Signed-off-by: Kisub Choe <kisub.choe.0x1@gmail.com>
---
drivers/staging/sm750fb/sm750.c | 4 ++--
drivers/staging/sm750fb/sm750.h | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
index 1d929aca399c..bb2ade6030c2 100644
--- a/drivers/staging/sm750fb/sm750.c
+++ b/drivers/staging/sm750fb/sm750.c
@@ -577,7 +577,7 @@ static int lynxfb_ops_blank(int blank, struct fb_info *info)
pr_debug("blank = %d.\n", blank);
par = info->par;
output = &par->output;
- return output->proc_setBLANK(output, blank);
+ return output->proc_set_blank(output, blank);
}
static int sm750fb_set_drv(struct lynxfb_par *par)
@@ -605,7 +605,7 @@ static int sm750fb_set_drv(struct lynxfb_par *par)
crtc->ypanstep = 1;
crtc->ywrapstep = 0;
- output->proc_setBLANK = (sm750_dev->revid == SM750LE_REVISION_ID) ?
+ output->proc_set_blank = (sm750_dev->revid == SM750LE_REVISION_ID) ?
hw_sm750le_set_blank : hw_sm750_set_blank;
/* chip specific phase */
sm750_dev->accel.de_wait = (sm750_dev->revid == SM750LE_REVISION_ID) ?
diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h
index 9cf8b3d30aac..40051798efbf 100644
--- a/drivers/staging/sm750fb/sm750.h
+++ b/drivers/staging/sm750fb/sm750.h
@@ -170,7 +170,7 @@ struct lynxfb_output {
*/
void *priv;
- int (*proc_setBLANK)(struct lynxfb_output *output, int blank);
+ int (*proc_set_blank)(struct lynxfb_output *output, int blank);
};
struct lynxfb_par {
--
2.34.1
^ permalink raw reply related
* Re: [PATCH v2] staging: sm750fb: rename 'proc_setBLANK'
From: Greg KH @ 2025-06-19 13:24 UTC (permalink / raw)
To: Kisub Choe
Cc: sudipm.mukherjee, teddy.wang, linux-fbdev, linux-staging,
linux-kernel
In-Reply-To: <aFQMrXRzui58krqA@zinc>
On Thu, Jun 19, 2025 at 10:12:13PM +0900, Kisub Choe wrote:
> On Wed, Jun 18, 2025 at 04:26:10PM +0200, Greg KH wrote:
> > On Wed, Jun 18, 2025 at 11:15:55PM +0900, Kisub Choe wrote:
> > > Rename 'proc_setBLANK' to 'proc_setBLANK' to
> >
> > That doesn't rename anything :(
> Rename 'proc_setBLANK' to 'proc_set_blank' to
> >
> >
> >
> > > conform with kernel style guidelines as reported by checkpatch.pl
> > >
> > > CHECK: Avoid CamelCase: <proc_setBLANK>
> > >
> > > Signed-off-by: Kisub Choe <kisub.choe.0x1@gmail.com>
> > > ---
> > > drivers/staging/sm750fb/sm750.c | 4 ++--
> > > drivers/staging/sm750fb/sm750.h | 2 +-
> > > 2 files changed, 3 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
> > > index 1d929aca399c..bb2ade6030c2 100644
> > > --- a/drivers/staging/sm750fb/sm750.c
> > > +++ b/drivers/staging/sm750fb/sm750.c
> > > @@ -577,7 +577,7 @@ static int lynxfb_ops_blank(int blank, struct fb_info *info)
> > > pr_debug("blank = %d.\n", blank);
> > > par = info->par;
> > > output = &par->output;
> > > - return output->proc_setBLANK(output, blank);
> > > + return output->proc_set_blank(output, blank);
> > > }
> > >
> > > static int sm750fb_set_drv(struct lynxfb_par *par)
> > > @@ -605,7 +605,7 @@ static int sm750fb_set_drv(struct lynxfb_par *par)
> > > crtc->ypanstep = 1;
> > > crtc->ywrapstep = 0;
> > >
> > > - output->proc_setBLANK = (sm750_dev->revid == SM750LE_REVISION_ID) ?
> > > + output->proc_set_blank = (sm750_dev->revid == SM750LE_REVISION_ID) ?
> > > hw_sm750le_set_blank : hw_sm750_set_blank;
> >
> > Why do we even need this function pointer? Why not just do the check
> > above when it is called instead of this indirection?
> >
> > thanks,
> >
> > greg k-h
>
> Dear Greg,
>
> Here is the updated patch with revised commit message. No code changes.
Please read the documentation for how to send an updated patch (hint, it
needs to be a new version).
Also, see my comments above about what you should do here instead of
just renaming the variable. Please make that change which will remove
the variable entirely.
thanks,
greg k-h
^ permalink raw reply
* Re: [PATCH v2] staging: sm750fb: rename 'proc_setBLANK'
From: Kisub Choe @ 2025-06-19 13:49 UTC (permalink / raw)
To: Greg KH
Cc: Kisub Choe, sudipm.mukherjee, teddy.wang, linux-fbdev,
linux-staging, linux-kernel
In-Reply-To: <2025061927-pushpin-scholar-a898@gregkh>
On Thu, Jun 19, 2025 at 03:24:26PM +0200, Greg KH wrote:
> On Thu, Jun 19, 2025 at 10:12:13PM +0900, Kisub Choe wrote:
> > On Wed, Jun 18, 2025 at 04:26:10PM +0200, Greg KH wrote:
> > > On Wed, Jun 18, 2025 at 11:15:55PM +0900, Kisub Choe wrote:
> > > > Rename 'proc_setBLANK' to 'proc_setBLANK' to
> > >
> > > That doesn't rename anything :(
> > Rename 'proc_setBLANK' to 'proc_set_blank' to
> > >
> > >
> > >
> > > > conform with kernel style guidelines as reported by checkpatch.pl
> > > >
> > > > CHECK: Avoid CamelCase: <proc_setBLANK>
> > > >
> > > > Signed-off-by: Kisub Choe <kisub.choe.0x1@gmail.com>
> > > > ---
> > > > drivers/staging/sm750fb/sm750.c | 4 ++--
> > > > drivers/staging/sm750fb/sm750.h | 2 +-
> > > > 2 files changed, 3 insertions(+), 3 deletions(-)
> > > >
> > > > diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
> > > > index 1d929aca399c..bb2ade6030c2 100644
> > > > --- a/drivers/staging/sm750fb/sm750.c
> > > > +++ b/drivers/staging/sm750fb/sm750.c
> > > > @@ -577,7 +577,7 @@ static int lynxfb_ops_blank(int blank, struct fb_info *info)
> > > > pr_debug("blank = %d.\n", blank);
> > > > par = info->par;
> > > > output = &par->output;
> > > > - return output->proc_setBLANK(output, blank);
> > > > + return output->proc_set_blank(output, blank);
> > > > }
> > > >
> > > > static int sm750fb_set_drv(struct lynxfb_par *par)
> > > > @@ -605,7 +605,7 @@ static int sm750fb_set_drv(struct lynxfb_par *par)
> > > > crtc->ypanstep = 1;
> > > > crtc->ywrapstep = 0;
> > > >
> > > > - output->proc_setBLANK = (sm750_dev->revid == SM750LE_REVISION_ID) ?
> > > > + output->proc_set_blank = (sm750_dev->revid == SM750LE_REVISION_ID) ?
> > > > hw_sm750le_set_blank : hw_sm750_set_blank;
> > >
> > > Why do we even need this function pointer? Why not just do the check
> > > above when it is called instead of this indirection?
> > >
> > > thanks,
> > >
> > > greg k-h
> >
> > Dear Greg,
> >
> > Here is the updated patch with revised commit message. No code changes.
>
> Please read the documentation for how to send an updated patch (hint, it
> needs to be a new version).
>
> Also, see my comments above about what you should do here instead of
> just renaming the variable. Please make that change which will remove
> the variable entirely.
>
> thanks,
>
> greg k-h
Thank you for feedback.
I was wondering if you could share additional feedback regarding
pros and cons calling a function directly based on the condition instead of the
current implementation?
Regards,
Kisub Choe.
^ permalink raw reply
* Re: [PATCH v2] staging: sm750fb: rename 'proc_setBLANK'
From: Greg KH @ 2025-06-19 13:52 UTC (permalink / raw)
To: Kisub Choe
Cc: sudipm.mukherjee, teddy.wang, linux-fbdev, linux-staging,
linux-kernel
In-Reply-To: <aFQVZIXoS43iu0o5@zinc>
On Thu, Jun 19, 2025 at 10:49:24PM +0900, Kisub Choe wrote:
> On Thu, Jun 19, 2025 at 03:24:26PM +0200, Greg KH wrote:
> > On Thu, Jun 19, 2025 at 10:12:13PM +0900, Kisub Choe wrote:
> > > On Wed, Jun 18, 2025 at 04:26:10PM +0200, Greg KH wrote:
> > > > On Wed, Jun 18, 2025 at 11:15:55PM +0900, Kisub Choe wrote:
> > > > > Rename 'proc_setBLANK' to 'proc_setBLANK' to
> > > >
> > > > That doesn't rename anything :(
> > > Rename 'proc_setBLANK' to 'proc_set_blank' to
> > > >
> > > >
> > > >
> > > > > conform with kernel style guidelines as reported by checkpatch.pl
> > > > >
> > > > > CHECK: Avoid CamelCase: <proc_setBLANK>
> > > > >
> > > > > Signed-off-by: Kisub Choe <kisub.choe.0x1@gmail.com>
> > > > > ---
> > > > > drivers/staging/sm750fb/sm750.c | 4 ++--
> > > > > drivers/staging/sm750fb/sm750.h | 2 +-
> > > > > 2 files changed, 3 insertions(+), 3 deletions(-)
> > > > >
> > > > > diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
> > > > > index 1d929aca399c..bb2ade6030c2 100644
> > > > > --- a/drivers/staging/sm750fb/sm750.c
> > > > > +++ b/drivers/staging/sm750fb/sm750.c
> > > > > @@ -577,7 +577,7 @@ static int lynxfb_ops_blank(int blank, struct fb_info *info)
> > > > > pr_debug("blank = %d.\n", blank);
> > > > > par = info->par;
> > > > > output = &par->output;
> > > > > - return output->proc_setBLANK(output, blank);
> > > > > + return output->proc_set_blank(output, blank);
> > > > > }
> > > > >
> > > > > static int sm750fb_set_drv(struct lynxfb_par *par)
> > > > > @@ -605,7 +605,7 @@ static int sm750fb_set_drv(struct lynxfb_par *par)
> > > > > crtc->ypanstep = 1;
> > > > > crtc->ywrapstep = 0;
> > > > >
> > > > > - output->proc_setBLANK = (sm750_dev->revid == SM750LE_REVISION_ID) ?
> > > > > + output->proc_set_blank = (sm750_dev->revid == SM750LE_REVISION_ID) ?
> > > > > hw_sm750le_set_blank : hw_sm750_set_blank;
> > > >
> > > > Why do we even need this function pointer? Why not just do the check
> > > > above when it is called instead of this indirection?
> > > >
> > > > thanks,
> > > >
> > > > greg k-h
> > >
> > > Dear Greg,
> > >
> > > Here is the updated patch with revised commit message. No code changes.
> >
> > Please read the documentation for how to send an updated patch (hint, it
> > needs to be a new version).
> >
> > Also, see my comments above about what you should do here instead of
> > just renaming the variable. Please make that change which will remove
> > the variable entirely.
> >
> > thanks,
> >
> > greg k-h
>
> Thank you for feedback.
>
> I was wondering if you could share additional feedback regarding
> pros and cons calling a function directly based on the condition instead of the
> current implementation?
I'll leave that as an exercise for the reader to complete :)
have fun!
greg k-h
^ permalink raw reply
* Re: [PATCH v2] staging: sm750fb: rename 'proc_setBLANK'
From: Kisub Choe @ 2025-06-19 14:22 UTC (permalink / raw)
To: Greg KH
Cc: Kisub Choe, sudipm.mukherjee, teddy.wang, linux-fbdev,
linux-staging, linux-kernel
In-Reply-To: <2025061933-dispersal-employer-0e12@gregkh>
On Thu, Jun 19, 2025 at 03:52:53PM +0200, Greg KH wrote:
> On Thu, Jun 19, 2025 at 10:49:24PM +0900, Kisub Choe wrote:
> > On Thu, Jun 19, 2025 at 03:24:26PM +0200, Greg KH wrote:
> > > On Thu, Jun 19, 2025 at 10:12:13PM +0900, Kisub Choe wrote:
> > > > On Wed, Jun 18, 2025 at 04:26:10PM +0200, Greg KH wrote:
> > > > > On Wed, Jun 18, 2025 at 11:15:55PM +0900, Kisub Choe wrote:
> > > > > > Rename 'proc_setBLANK' to 'proc_setBLANK' to
> > > > >
> > > > > That doesn't rename anything :(
> > > > Rename 'proc_setBLANK' to 'proc_set_blank' to
> > > > >
> > > > >
> > > > >
> > > > > > conform with kernel style guidelines as reported by checkpatch.pl
> > > > > >
> > > > > > CHECK: Avoid CamelCase: <proc_setBLANK>
> > > > > >
> > > > > > Signed-off-by: Kisub Choe <kisub.choe.0x1@gmail.com>
> > > > > > ---
> > > > > > drivers/staging/sm750fb/sm750.c | 4 ++--
> > > > > > drivers/staging/sm750fb/sm750.h | 2 +-
> > > > > > 2 files changed, 3 insertions(+), 3 deletions(-)
> > > > > >
> > > > > > diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
> > > > > > index 1d929aca399c..bb2ade6030c2 100644
> > > > > > --- a/drivers/staging/sm750fb/sm750.c
> > > > > > +++ b/drivers/staging/sm750fb/sm750.c
> > > > > > @@ -577,7 +577,7 @@ static int lynxfb_ops_blank(int blank, struct fb_info *info)
> > > > > > pr_debug("blank = %d.\n", blank);
> > > > > > par = info->par;
> > > > > > output = &par->output;
> > > > > > - return output->proc_setBLANK(output, blank);
> > > > > > + return output->proc_set_blank(output, blank);
> > > > > > }
> > > > > >
> > > > > > static int sm750fb_set_drv(struct lynxfb_par *par)
> > > > > > @@ -605,7 +605,7 @@ static int sm750fb_set_drv(struct lynxfb_par *par)
> > > > > > crtc->ypanstep = 1;
> > > > > > crtc->ywrapstep = 0;
> > > > > >
> > > > > > - output->proc_setBLANK = (sm750_dev->revid == SM750LE_REVISION_ID) ?
> > > > > > + output->proc_set_blank = (sm750_dev->revid == SM750LE_REVISION_ID) ?
> > > > > > hw_sm750le_set_blank : hw_sm750_set_blank;
> > > > >
> > > > > Why do we even need this function pointer? Why not just do the check
> > > > > above when it is called instead of this indirection?
> > > > >
> > > > > thanks,
> > > > >
> > > > > greg k-h
> > > >
> > > > Dear Greg,
> > > >
> > > > Here is the updated patch with revised commit message. No code changes.
> > >
> > > Please read the documentation for how to send an updated patch (hint, it
> > > needs to be a new version).
> > >
> > > Also, see my comments above about what you should do here instead of
> > > just renaming the variable. Please make that change which will remove
> > > the variable entirely.
> > >
> > > thanks,
> > >
> > > greg k-h
> >
> > Thank you for feedback.
> >
> > I was wondering if you could share additional feedback regarding
> > pros and cons calling a function directly based on the condition instead of the
> > current implementation?
>
> I'll leave that as an exercise for the reader to complete :)
>
> have fun!
>
> greg k-h
Thank you!
Let me try to make changes and update.
Regards,
Kisub Choe.
^ permalink raw reply
* Re: [PATCH 1/6] staging: sm750fb: rename `sBase` parameter
From: Greg KH @ 2025-06-19 15:29 UTC (permalink / raw)
To: Eric Florin
Cc: teddy.wang, sudipm.mukherjee, linux-fbdev, linux-staging,
linux-kernel
In-Reply-To: <61e6984331cc7ff88a9f8207e187cd5b9ffd9c63.1748365488.git.ericflorin@google.com>
On Tue, May 27, 2025 at 10:11:23AM -0700, Eric Florin wrote:
> Rename `sBase` to `s_base` in `sm750_hw_copyarea` to conform with style
> guidelines as reported by checkpatch.pl
>
> CHECK: Avoid CamelCase: <sBase>
>
> Signed-off-by: Eric Florin <ericflorin@google.com>
> ---
> drivers/staging/sm750fb/sm750_accel.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c
> index 44b9e3fe3a41..74e4be8103ac 100644
> --- a/drivers/staging/sm750fb/sm750_accel.c
> +++ b/drivers/staging/sm750fb/sm750_accel.c
> @@ -132,7 +132,7 @@ int sm750_hw_fillrect(struct lynx_accel *accel,
> /**
> * sm750_hw_copyarea
> * @accel: Acceleration device data
> - * @sBase: Address of source: offset in frame buffer
> + * @s_base: Address of source: offset in frame buffer
Wouldn't a better name be "source_base"?
thanks,
greg k-h
^ permalink raw reply
* Re: [PATCH 2/6] staging: sm750fb: rename `sPitch` parameter
From: Greg KH @ 2025-06-19 15:29 UTC (permalink / raw)
To: Eric Florin
Cc: teddy.wang, sudipm.mukherjee, linux-fbdev, linux-staging,
linux-kernel
In-Reply-To: <0ee15444dc0f9430b1c7836c565e305b6dab823a.1748365488.git.ericflorin@google.com>
On Tue, May 27, 2025 at 10:11:24AM -0700, Eric Florin wrote:
> Rename `sPitch` to `s_pitch` in `sm750_hw_copyarea` to conform with
> kernel style guidelines as reported by checkpatch.pl
>
> CHECK: Avoid CamelCase: <sPitch>
>
> Signed-off-by: Eric Florin <ericflorin@google.com>
> ---
> drivers/staging/sm750fb/sm750_accel.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c
> index 74e4be8103ac..029f5c013d91 100644
> --- a/drivers/staging/sm750fb/sm750_accel.c
> +++ b/drivers/staging/sm750fb/sm750_accel.c
> @@ -133,7 +133,7 @@ int sm750_hw_fillrect(struct lynx_accel *accel,
> * sm750_hw_copyarea
> * @accel: Acceleration device data
> * @s_base: Address of source: offset in frame buffer
> - * @sPitch: Pitch value of source surface in BYTE
> + * @s_pitch: Pitch value of source surface in BYTE
"source_pitch"?
^ permalink raw reply
* Re: [PATCH 4/6] staging: sm750fb: rename `dPitch` parameter
From: Greg KH @ 2025-06-19 15:29 UTC (permalink / raw)
To: Eric Florin
Cc: teddy.wang, sudipm.mukherjee, linux-fbdev, linux-staging,
linux-kernel
In-Reply-To: <5250c76b824f133c04135b0d82b18d85cd958852.1748365488.git.ericflorin@google.com>
On Tue, May 27, 2025 at 10:11:26AM -0700, Eric Florin wrote:
> Rename `dPitch` to `d_pitch` in `sm750_hw_copyarea` to conform with
> kernel style guidelines as reported by checkpatch.pl
>
> CHECK: Avoid CamelCase: <dPitch>
>
> Signed-off-by: Eric Florin <ericflorin@google.com>
> ---
> drivers/staging/sm750fb/sm750_accel.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c
> index e5f1f021768b..ea64e10d4814 100644
> --- a/drivers/staging/sm750fb/sm750_accel.c
> +++ b/drivers/staging/sm750fb/sm750_accel.c
> @@ -137,7 +137,7 @@ int sm750_hw_fillrect(struct lynx_accel *accel,
> * @sx: Starting x coordinate of source surface
> * @sy: Starting y coordinate of source surface
> * @d_base: Address of destination: offset in frame buffer
> - * @dPitch: Pitch value of destination surface in BYTE
> + * @d_pitch: Pitch value of destination surface in BYTE
"dest_pitch"?
^ permalink raw reply
* Re: [PATCH 5/6] staging: sm750fb: rename `Bpp` parameter
From: Greg KH @ 2025-06-19 15:30 UTC (permalink / raw)
To: Eric Florin
Cc: teddy.wang, sudipm.mukherjee, linux-fbdev, linux-staging,
linux-kernel
In-Reply-To: <5f9c28d0dc0f48151837f11d5f6e7b82f84978ef.1748365488.git.ericflorin@google.com>
On Tue, May 27, 2025 at 10:11:27AM -0700, Eric Florin wrote:
> Rename `Bpp` to `bpp` in `sm750_hw_copyarea` to conform with kernel
> style guidelines.
>
> Signed-off-by: Eric Florin <ericflorin@google.com>
> ---
> drivers/staging/sm750fb/sm750_accel.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c
> index ea64e10d4814..a34d8f6a033d 100644
> --- a/drivers/staging/sm750fb/sm750_accel.c
> +++ b/drivers/staging/sm750fb/sm750_accel.c
> @@ -138,7 +138,7 @@ int sm750_hw_fillrect(struct lynx_accel *accel,
> * @sy: Starting y coordinate of source surface
> * @d_base: Address of destination: offset in frame buffer
> * @d_pitch: Pitch value of destination surface in BYTE
> - * @Bpp: Color depth of destination surface
> + * @bpp: Color depth of destination surface
What does "bpp" mean here? How about "dest_depth"?
^ permalink raw reply
* Re: [PATCH 6/6] staging: sm750fb: Rename local var `nDirection`
From: Greg KH @ 2025-06-19 15:30 UTC (permalink / raw)
To: Eric Florin
Cc: teddy.wang, sudipm.mukherjee, linux-fbdev, linux-staging,
linux-kernel
In-Reply-To: <f247ceee80387ece536aa5657f105321809470f1.1748365488.git.ericflorin@google.com>
On Tue, May 27, 2025 at 10:11:28AM -0700, Eric Florin wrote:
> Rename local variable `nDirection` to `n_direction` in
> `sm750_hw_copyarea` to conform with kernel style guidelines as reported
> by checkpatch.pl
>
> CHECK: Avoid CamelCase: <nDirection>
>
> Signed-off-by: Eric Florin <ericflorin@google.com>
> ---
> drivers/staging/sm750fb/sm750_accel.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c
> index a34d8f6a033d..b9f90c934b7d 100644
> --- a/drivers/staging/sm750fb/sm750_accel.c
> +++ b/drivers/staging/sm750fb/sm750_accel.c
> @@ -153,9 +153,9 @@ int sm750_hw_copyarea(struct lynx_accel *accel,
> unsigned int width, unsigned int height,
> unsigned int rop2)
> {
> - unsigned int nDirection, de_ctrl;
> + unsigned int n_direction, de_ctrl;
Why keep the "n" at all?
^ permalink raw reply
* Re: [PATCH 3/6] staging: sm750fb: rename `dBase` parameter
From: Greg KH @ 2025-06-19 15:30 UTC (permalink / raw)
To: Eric Florin
Cc: teddy.wang, sudipm.mukherjee, linux-fbdev, linux-staging,
linux-kernel
In-Reply-To: <b46e54ed9006f7a5b4439b8d4bb1fc36bd9c3ca0.1748365488.git.ericflorin@google.com>
On Tue, May 27, 2025 at 10:11:25AM -0700, Eric Florin wrote:
> Rename `dBase` to `d_base` in `sm750_hw_copyarea` to conform with kernel
> style guidelines as reported by checkpatch.pl
>
> CHECK: Avoid CamelCase: <dBase>
>
> Signed-off-by: Eric Florin <ericflorin@google.com>
> ---
> drivers/staging/sm750fb/sm750_accel.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c
> index 029f5c013d91..e5f1f021768b 100644
> --- a/drivers/staging/sm750fb/sm750_accel.c
> +++ b/drivers/staging/sm750fb/sm750_accel.c
> @@ -136,7 +136,7 @@ int sm750_hw_fillrect(struct lynx_accel *accel,
> * @s_pitch: Pitch value of source surface in BYTE
> * @sx: Starting x coordinate of source surface
> * @sy: Starting y coordinate of source surface
> - * @dBase: Address of destination: offset in frame buffer
> + * @d_base: Address of destination: offset in frame buffer
"dest_base"?
^ permalink raw reply
* Re: [PATCH 1/1] staging: sm750fb: convert CamelCase function names to snake_case
From: Greg KH @ 2025-06-19 15:32 UTC (permalink / raw)
To: khalid.datamax
Cc: sudipm.mukherjee, teddy.wang, linux-fbdev, linux-staging,
linux-kernel
In-Reply-To: <20250531211319.55682-3-khalid.datamax@gmail.com>
On Sun, Jun 01, 2025 at 02:41:03AM +0530, khalid.datamax@gmail.com wrote:
> From: Khalid Faisal <khalid.datamax@gmail.com>
>
> This patch converts function names in the sm750fb driver from CamelCase to
> snake_case to comply with Linux kernel coding style.
>
> No functional changes.
>
> Signed-off-by: Khalid Faisal <khalid.datamax@gmail.com>
> ---
> drivers/staging/sm750fb/ddk750_dvi.c | 16 +++++------
> drivers/staging/sm750fb/ddk750_sii164.c | 38 ++++++++++++-------------
> drivers/staging/sm750fb/ddk750_sii164.h | 16 +++++------
> 3 files changed, 35 insertions(+), 35 deletions(-)
Are you sure this file is still in the tree? I don't see it anymore :(
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox