* Re: [PATCH 2/3] Documentation: fb: Retitle driver docs
From: Randy Dunlap @ 2025-09-21 4:08 UTC (permalink / raw)
To: Bagas Sanjaya, Linux Kernel Mailing List, Linux Documentation,
Linux Framebuffer, Linux DRI Development
Cc: Helge Deller, Jonathan Corbet, Sudip Mukherjee, Teddy Wang,
Bernie Thompson, Mauro Carvalho Chehab, Ard Biesheuvel,
Arvind Sankar
In-Reply-To: <20250919003640.14867-3-bagasdotme@gmail.com>
Hi,
I would change a couple of the headings, but otherwise
looks good.
On 9/18/25 5:36 PM, Bagas Sanjaya wrote:
> Many framebuffer driver docs are copied from vesafb docs as their
> template, including "What is <driver name>" title. Such title
> implies the introductory section, however, and not the whole docs.
>
> Retitle them.
>
> Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com>
> ---
> Documentation/fb/aty128fb.rst | 8 +++-----
> Documentation/fb/efifb.rst | 6 +++---
> Documentation/fb/gxfb.rst | 8 +++-----
> Documentation/fb/lxfb.rst | 9 +++------
> Documentation/fb/matroxfb.rst | 9 +++------
> Documentation/fb/pvr2fb.rst | 6 +++---
> Documentation/fb/sa1100fb.rst | 9 +++------
> Documentation/fb/sisfb.rst | 6 +++---
> Documentation/fb/sm712fb.rst | 6 +++---
> Documentation/fb/tgafb.rst | 6 +++---
> Documentation/fb/udlfb.rst | 6 +++---
> Documentation/fb/vesafb.rst | 6 +++---
> 12 files changed, 36 insertions(+), 49 deletions(-)
>
> diff --git a/Documentation/fb/aty128fb.rst b/Documentation/fb/aty128fb.rst
> index 3f107718f933fc..0da8070a552165 100644
> --- a/Documentation/fb/aty128fb.rst
> +++ b/Documentation/fb/aty128fb.rst
> @@ -1,8 +1,6 @@
> -=================
> -What is aty128fb?
> -=================
> -
> -.. [This file is cloned from VesaFB/matroxfb]
> +=========================================
> +aty128fb - ATI Rage128 framebuffer driver
> +=========================================
>
> This is a driver for a graphic framebuffer for ATI Rage128 based devices
> on Intel and PPC boxes.
> diff --git a/Documentation/fb/efifb.rst b/Documentation/fb/efifb.rst
> index 6badff64756f49..3d4aab406dee0a 100644
> --- a/Documentation/fb/efifb.rst
> +++ b/Documentation/fb/efifb.rst
> @@ -1,6 +1,6 @@
> -==============
> -What is efifb?
> -==============
> +===================================
> +efifb - Generic EFI platform driver
> +===================================
>
> This is a generic EFI platform driver for systems with UEFI firmware. The
> system must be booted via the EFI stub for this to be usable. efifb supports
> diff --git a/Documentation/fb/gxfb.rst b/Documentation/fb/gxfb.rst
> index 5738709bccbbf3..3fda485606bdc1 100644
> --- a/Documentation/fb/gxfb.rst
> +++ b/Documentation/fb/gxfb.rst
> @@ -1,8 +1,6 @@
> -=============
> -What is gxfb?
> -=============
> -
> -.. [This file is cloned from VesaFB/aty128fb]
> +=======================================
> +gxfb - AMD Geode GX2 framebuffer driver
> +=======================================
>
> This is a graphics framebuffer driver for AMD Geode GX2 based processors.
>
> diff --git a/Documentation/fb/lxfb.rst b/Documentation/fb/lxfb.rst
> index 863e6b98fbae55..0a176ab376e30e 100644
> --- a/Documentation/fb/lxfb.rst
> +++ b/Documentation/fb/lxfb.rst
> @@ -1,9 +1,6 @@
> -=============
> -What is lxfb?
> -=============
> -
> -.. [This file is cloned from VesaFB/aty128fb]
> -
> +======================================
> +lxfb - AMD Geode LX framebuffer driver
> +======================================
>
> This is a graphics framebuffer driver for AMD Geode LX based processors.
>
> diff --git a/Documentation/fb/matroxfb.rst b/Documentation/fb/matroxfb.rst
> index 6158c49c857148..34cafaa00bab19 100644
> --- a/Documentation/fb/matroxfb.rst
> +++ b/Documentation/fb/matroxfb.rst
> @@ -1,9 +1,6 @@
> -=================
> -What is matroxfb?
> -=================
> -
> -.. [This file is cloned from VesaFB. Thanks go to Gerd Knorr]
> -
> +==================================
> +matroxfb driver for Matrox devices
> +==================================
Add a '-' after matroxfb
>
> This is a driver for a graphic framebuffer for Matrox devices on
> Alpha, Intel and PPC boxes.
> diff --git a/Documentation/fb/pvr2fb.rst b/Documentation/fb/pvr2fb.rst
> index fcf2c21c8fcfeb..315ce085a5855b 100644
> --- a/Documentation/fb/pvr2fb.rst
> +++ b/Documentation/fb/pvr2fb.rst
> @@ -1,6 +1,6 @@
> -===============
> -What is pvr2fb?
> -===============
> +===============================================
> +pvr2fb - PowerVR 2 graphics frame buffer driver
> +===============================================
>
> This is a driver for PowerVR 2 based graphics frame buffers, such as the
> one found in the Dreamcast.
> diff --git a/Documentation/fb/sa1100fb.rst b/Documentation/fb/sa1100fb.rst
> index 67e2650e017d12..c5ca019b361a94 100644
> --- a/Documentation/fb/sa1100fb.rst
> +++ b/Documentation/fb/sa1100fb.rst
> @@ -1,9 +1,6 @@
> -=================
> -What is sa1100fb?
> -=================
> -
> -.. [This file is cloned from VesaFB/matroxfb]
> -
> +=================================================
> +sa1100fb - SA-1100 LCD graphic framebuffer driver
> +=================================================
>
> This is a driver for a graphic framebuffer for the SA-1100 LCD
> controller.
> diff --git a/Documentation/fb/sisfb.rst b/Documentation/fb/sisfb.rst
> index 8f4e502ea12ea7..9982f5ee05601b 100644
> --- a/Documentation/fb/sisfb.rst
> +++ b/Documentation/fb/sisfb.rst
> @@ -1,6 +1,6 @@
> -==============
> -What is sisfb?
> -==============
> +=====================================
> +sisfb - SiS framebuffer device driver
> +=====================================
>
> sisfb is a framebuffer device driver for SiS (Silicon Integrated Systems)
> graphics chips. Supported are:
> diff --git a/Documentation/fb/sm712fb.rst b/Documentation/fb/sm712fb.rst
> index 8e000f80b5bc6d..abbc6efae25f46 100644
> --- a/Documentation/fb/sm712fb.rst
> +++ b/Documentation/fb/sm712fb.rst
> @@ -1,6 +1,6 @@
> -================
> -What is sm712fb?
> -================
> +==========================================================
> +sm712fb - Silicon Motion SM712 graphics framebuffer driver
> +==========================================================
>
> This is a graphics framebuffer driver for Silicon Motion SM712 based processors.
>
> diff --git a/Documentation/fb/tgafb.rst b/Documentation/fb/tgafb.rst
> index 0c50d2134aa433..f0944da1ea5ef1 100644
> --- a/Documentation/fb/tgafb.rst
> +++ b/Documentation/fb/tgafb.rst
> @@ -1,6 +1,6 @@
> -==============
> -What is tgafb?
> -==============
> +=======================================
> +tgafb - TGA graphics framebuffer driver
> +=======================================
>
> This is a driver for DECChip 21030 based graphics framebuffers, a.k.a. TGA
> cards, which are usually found in older Digital Alpha systems. The
> diff --git a/Documentation/fb/udlfb.rst b/Documentation/fb/udlfb.rst
> index 99cfbb7a192238..9e75ac6b07c36a 100644
> --- a/Documentation/fb/udlfb.rst
> +++ b/Documentation/fb/udlfb.rst
> @@ -1,6 +1,6 @@
> -==============
> -What is udlfb?
> -==============
> +==================================
> +udlfb - DisplayLink USB 2.0 driver
> +==================================
>
> This is a driver for DisplayLink USB 2.0 era graphics chips.
>
> diff --git a/Documentation/fb/vesafb.rst b/Documentation/fb/vesafb.rst
> index f890a4f5623b45..5ffb35efd4538a 100644
> --- a/Documentation/fb/vesafb.rst
> +++ b/Documentation/fb/vesafb.rst
> @@ -1,6 +1,6 @@
> -===============
> -What is vesafb?
> -===============
> +===========================================
> +Generic graphic framebuffer driver (vesafb)
> +===========================================
vesafb - Generic graphic framebuffer driver
>
> This is a generic driver for a graphic framebuffer on intel boxes.
>
Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
Tested-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
--
~Randy
^ permalink raw reply
* Re: [PATCH 3/3] Documentation: fb: Split toctree
From: Randy Dunlap @ 2025-09-21 4:08 UTC (permalink / raw)
To: Bagas Sanjaya, Linux Kernel Mailing List, Linux Documentation,
Linux Framebuffer, Linux DRI Development
Cc: Helge Deller, Jonathan Corbet, Sudip Mukherjee, Teddy Wang,
Bernie Thompson, Mauro Carvalho Chehab, Ard Biesheuvel,
Arvind Sankar
In-Reply-To: <20250919003640.14867-4-bagasdotme@gmail.com>
On 9/18/25 5:36 PM, Bagas Sanjaya wrote:
> Framebuffer docs toctree consists of driver-independent docs
> (e.g. API docs) and driver-specific docs. The latter has much
> more entries.
>
> Group the docs into separate toctrees.
>
> Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com>
LGTM. Thanks.
Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
Tested-by: Randy Dunlap <rdunlap@infradead.org>
> ---
> Documentation/fb/index.rst | 80 +++++++++++++++++++++-----------------
> 1 file changed, 45 insertions(+), 35 deletions(-)
>
> diff --git a/Documentation/fb/index.rst b/Documentation/fb/index.rst
> index 33e3c49f885695..e2f7488b6e2e42 100644
> --- a/Documentation/fb/index.rst
> +++ b/Documentation/fb/index.rst
> @@ -4,42 +4,52 @@
> Frame Buffer
> ============
>
> -.. toctree::
> - :maxdepth: 1
> +General information
> +===================
>
> - api
> - arkfb
> - aty128fb
> - cirrusfb
> - cmap_xfbdev
> - deferred_io
> - efifb
> - ep93xx-fb
> - fbcon
> - framebuffer
> - gxfb
> - intel810
> - internals
> - lxfb
> - matroxfb
> - metronomefb
> - modedb
> - pvr2fb
> - pxafb
> - s3fb
> - sa1100fb
> - sh7760fb
> - sisfb
> - sm501
> - sm712fb
> - sstfb
> - tgafb
> - tridentfb
> - udlfb
> - uvesafb
> - vesafb
> - viafb
> - vt8623fb
> +.. toctree::
> + :maxdepth: 1
> +
> + api
> + cmap_xfbdev
> + deferred_io
> + fbcon
> + framebuffer
> + internals
> + modedb
> +
> +Driver documentation
> +====================
> +
> +.. toctree::
> + :maxdepth: 1
> +
> + arkfb
> + aty128fb
> + cirrusfb
> + efifb
> + ep93xx-fb
> + gxfb
> + intel810
> + lxfb
> + matroxfb
> + metronomefb
> + pvr2fb
> + pxafb
> + s3fb
> + sa1100fb
> + sh7760fb
> + sisfb
> + sm501
> + sm712fb
> + sstfb
> + tgafb
> + tridentfb
> + udlfb
> + uvesafb
> + vesafb
> + viafb
> + vt8623fb
>
> .. only:: subproject and html
>
--
~Randy
^ permalink raw reply
* [PATCH] staging: sm750fb: rename camel case identifiers
From: Ahmet Sezgin Duran @ 2025-09-20 15:55 UTC (permalink / raw)
To: sudipm.mukherjee, teddy.wang, gregkh
Cc: linux-fbdev, linux-staging, linux-kernel, Ahmet Sezgin Duran
Rename two identifiers from camel case to snake case, in order to follow
kernel coding style.
Changes:
- Local variable `deCtrl` to `de_ctrl`
- Function `deGetTransparency` to `de_get_transparency`
Signed-off-by: Ahmet Sezgin Duran <ahmet@sezginduran.net>
---
drivers/staging/sm750fb/sm750_accel.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c
index b07c1aa68621..046b9282b24a 100644
--- a/drivers/staging/sm750fb/sm750_accel.c
+++ b/drivers/staging/sm750fb/sm750_accel.c
@@ -89,7 +89,7 @@ int sm750_hw_fillrect(struct lynx_accel *accel,
u32 x, u32 y, u32 width, u32 height,
u32 color, u32 rop)
{
- u32 deCtrl;
+ u32 de_ctrl;
if (accel->de_wait() != 0) {
/*
@@ -121,11 +121,11 @@ int sm750_hw_fillrect(struct lynx_accel *accel,
((width << DE_DIMENSION_X_SHIFT) & DE_DIMENSION_X_MASK) |
(height & DE_DIMENSION_Y_ET_MASK)); /* dpr8 */
- deCtrl = DE_CONTROL_STATUS | DE_CONTROL_LAST_PIXEL |
+ de_ctrl = DE_CONTROL_STATUS | DE_CONTROL_LAST_PIXEL |
DE_CONTROL_COMMAND_RECTANGLE_FILL | DE_CONTROL_ROP_SELECT |
(rop & DE_CONTROL_ROP_MASK); /* dpr0xc */
- write_dpr(accel, DE_CONTROL, deCtrl);
+ write_dpr(accel, DE_CONTROL, de_ctrl);
return 0;
}
@@ -284,7 +284,7 @@ int sm750_hw_copyarea(struct lynx_accel *accel,
return 0;
}
-static unsigned int deGetTransparency(struct lynx_accel *accel)
+static unsigned int de_get_transparency(struct lynx_accel *accel)
{
unsigned int de_ctrl;
@@ -391,7 +391,7 @@ int sm750_hw_imageblit(struct lynx_accel *accel, const char *pSrcbuf,
DE_CONTROL_ROP_SELECT | DE_CONTROL_COMMAND_HOST_WRITE |
DE_CONTROL_HOST | DE_CONTROL_STATUS;
- write_dpr(accel, DE_CONTROL, de_ctrl | deGetTransparency(accel));
+ write_dpr(accel, DE_CONTROL, de_ctrl | de_get_transparency(accel));
/* Write MONO data (line by line) to 2D Engine data port */
for (i = 0; i < height; i++) {
--
2.51.0
^ permalink raw reply related
* Re: [PATCH] staging: fbtft: fix macro usage and style warnings
From: kernel test robot @ 2025-09-20 8:37 UTC (permalink / raw)
To: DeepanshuPratik, andy
Cc: llvm, oe-kbuild-all, gregkh, dri-devel, linux-fbdev,
DeepanshuPratik
In-Reply-To: <20250919212938.822374-1-deepanshu.pratik@gmail.com>
Hi DeepanshuPratik,
kernel test robot noticed the following build errors:
[auto build test ERROR on staging/staging-testing]
url: https://github.com/intel-lab-lkp/linux/commits/DeepanshuPratik/staging-fbtft-fix-macro-usage-and-style-warnings/20250920-053248
base: staging/staging-testing
patch link: https://lore.kernel.org/r/20250919212938.822374-1-deepanshu.pratik%40gmail.com
patch subject: [PATCH] staging: fbtft: fix macro usage and style warnings
config: x86_64-buildonly-randconfig-002-20250920 (https://download.01.org/0day-ci/archive/20250920/202509201601.hTKUjeIe-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250920/202509201601.hTKUjeIe-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202509201601.hTKUjeIe-lkp@intel.com/
All errors (new ones prefixed by >>):
>> drivers/staging/fbtft/fbtft-bus.c:15:2: error: '#' is not followed by a macro parameter
15 | #define define_fbtft_write_reg(func, buffer_type, data_type, modifier) \
| ^
>> drivers/staging/fbtft/fbtft-bus.c:66:47: error: unexpected type name 'u8': expected identifier
66 | define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8, NOOP)
| ^
drivers/staging/fbtft/fbtft-bus.c:66:51: error: unexpected type name 'u8': expected identifier
66 | define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8, NOOP)
| ^
>> drivers/staging/fbtft/fbtft-bus.c:66:51: error: redefinition of parameter 'u8'
>> drivers/staging/fbtft/fbtft-bus.c:67:1: error: expected function body after function declarator
67 | define_fbtft_write_reg(fbtft_write_reg16_bus8, __be16, u16, cpu_to_be16)
| ^
5 errors generated.
vim +15 drivers/staging/fbtft/fbtft-bus.c
c296d5f9957c039 Thomas Petazzoni 2014-12-31 7
c296d5f9957c039 Thomas Petazzoni 2014-12-31 8 /*****************************************************************************
c296d5f9957c039 Thomas Petazzoni 2014-12-31 9 *
c296d5f9957c039 Thomas Petazzoni 2014-12-31 10 * void (*write_reg)(struct fbtft_par *par, int len, ...);
c296d5f9957c039 Thomas Petazzoni 2014-12-31 11 *
c296d5f9957c039 Thomas Petazzoni 2014-12-31 12 *****************************************************************************/
c296d5f9957c039 Thomas Petazzoni 2014-12-31 13
49f31092c55579e DeepanshuPratik 2025-09-20 14 #define NOOP(x) (x) \
8d8825b420ffb37 Alfonso Lima Astor 2017-10-17 @15 #define define_fbtft_write_reg(func, buffer_type, data_type, modifier) \
c296d5f9957c039 Thomas Petazzoni 2014-12-31 16 void func(struct fbtft_par *par, int len, ...) \
c296d5f9957c039 Thomas Petazzoni 2014-12-31 17 { \
c296d5f9957c039 Thomas Petazzoni 2014-12-31 18 va_list args; \
c296d5f9957c039 Thomas Petazzoni 2014-12-31 19 int i, ret; \
c296d5f9957c039 Thomas Petazzoni 2014-12-31 20 int offset = 0; \
8d8825b420ffb37 Alfonso Lima Astor 2017-10-17 21 buffer_type *buf = (buffer_type *)par->buf; \
c296d5f9957c039 Thomas Petazzoni 2014-12-31 22 \
c296d5f9957c039 Thomas Petazzoni 2014-12-31 23 if (unlikely(par->debug & DEBUG_WRITE_REGISTER)) { \
c296d5f9957c039 Thomas Petazzoni 2014-12-31 24 va_start(args, len); \
c296d5f9957c039 Thomas Petazzoni 2014-12-31 25 for (i = 0; i < len; i++) { \
cc1c0eea8527bd2 Renato Soma 2018-04-17 26 buf[i] = modifier((data_type)va_arg(args, \
cc1c0eea8527bd2 Renato Soma 2018-04-17 27 unsigned int)); \
c296d5f9957c039 Thomas Petazzoni 2014-12-31 28 } \
c296d5f9957c039 Thomas Petazzoni 2014-12-31 29 va_end(args); \
cc1c0eea8527bd2 Renato Soma 2018-04-17 30 fbtft_par_dbg_hex(DEBUG_WRITE_REGISTER, par, \
cc1c0eea8527bd2 Renato Soma 2018-04-17 31 par->info->device, buffer_type, buf, len, \
cc1c0eea8527bd2 Renato Soma 2018-04-17 32 "%s: ", __func__); \
c296d5f9957c039 Thomas Petazzoni 2014-12-31 33 } \
c296d5f9957c039 Thomas Petazzoni 2014-12-31 34 \
c296d5f9957c039 Thomas Petazzoni 2014-12-31 35 va_start(args, len); \
c296d5f9957c039 Thomas Petazzoni 2014-12-31 36 \
c296d5f9957c039 Thomas Petazzoni 2014-12-31 37 if (par->startbyte) { \
c296d5f9957c039 Thomas Petazzoni 2014-12-31 38 *(u8 *)par->buf = par->startbyte; \
8d8825b420ffb37 Alfonso Lima Astor 2017-10-17 39 buf = (buffer_type *)(par->buf + 1); \
c296d5f9957c039 Thomas Petazzoni 2014-12-31 40 offset = 1; \
c296d5f9957c039 Thomas Petazzoni 2014-12-31 41 } \
c296d5f9957c039 Thomas Petazzoni 2014-12-31 42 \
8d8825b420ffb37 Alfonso Lima Astor 2017-10-17 43 *buf = modifier((data_type)va_arg(args, unsigned int)); \
cc1c0eea8527bd2 Renato Soma 2018-04-17 44 ret = fbtft_write_buf_dc(par, par->buf, sizeof(data_type) + offset, \
cc1c0eea8527bd2 Renato Soma 2018-04-17 45 0); \
e70065fdc11d86f Heiner Kallweit 2017-03-02 46 if (ret < 0) \
e70065fdc11d86f Heiner Kallweit 2017-03-02 47 goto out; \
c296d5f9957c039 Thomas Petazzoni 2014-12-31 48 len--; \
c296d5f9957c039 Thomas Petazzoni 2014-12-31 49 \
c296d5f9957c039 Thomas Petazzoni 2014-12-31 50 if (par->startbyte) \
c296d5f9957c039 Thomas Petazzoni 2014-12-31 51 *(u8 *)par->buf = par->startbyte | 0x2; \
c296d5f9957c039 Thomas Petazzoni 2014-12-31 52 \
c296d5f9957c039 Thomas Petazzoni 2014-12-31 53 if (len) { \
c296d5f9957c039 Thomas Petazzoni 2014-12-31 54 i = len; \
e70065fdc11d86f Heiner Kallweit 2017-03-02 55 while (i--) \
cc1c0eea8527bd2 Renato Soma 2018-04-17 56 *buf++ = modifier((data_type)va_arg(args, \
cc1c0eea8527bd2 Renato Soma 2018-04-17 57 unsigned int)); \
e70065fdc11d86f Heiner Kallweit 2017-03-02 58 fbtft_write_buf_dc(par, par->buf, \
8d8825b420ffb37 Alfonso Lima Astor 2017-10-17 59 len * (sizeof(data_type) + offset), 1); \
c296d5f9957c039 Thomas Petazzoni 2014-12-31 60 } \
e70065fdc11d86f Heiner Kallweit 2017-03-02 61 out: \
c296d5f9957c039 Thomas Petazzoni 2014-12-31 62 va_end(args); \
c296d5f9957c039 Thomas Petazzoni 2014-12-31 63 } \
c296d5f9957c039 Thomas Petazzoni 2014-12-31 64 EXPORT_SYMBOL(func);
c296d5f9957c039 Thomas Petazzoni 2014-12-31 65
49f31092c55579e DeepanshuPratik 2025-09-20 @66 define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8, NOOP)
8d8825b420ffb37 Alfonso Lima Astor 2017-10-17 @67 define_fbtft_write_reg(fbtft_write_reg16_bus8, __be16, u16, cpu_to_be16)
49f31092c55579e DeepanshuPratik 2025-09-20 68 define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16, NOOP)
c296d5f9957c039 Thomas Petazzoni 2014-12-31 69
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply
* [PATCH] staging: fbtft: fix macro usage and style warnings
From: DeepanshuPratik @ 2025-09-19 21:29 UTC (permalink / raw)
To: andy; +Cc: gregkh, dri-devel, linux-fbdev, DeepanshuPratik
This patch fixes the trailing comma issue in the
define_fbtft_write_reg() macro calls, which caused
checkpatch.pl to complain with:
ERROR: space prohibited before that close parenthesis ')'
The affected macro invocations were updated to pass an
identity modifier instead of leaving the argument empty.
This resolves build errors while ensuring compliance
with kernel coding style.
No functional changes are introduced; this patch only
addresses build and style issues.
Signed-off-by: DeepanshuPratik <deepanshu.pratik@gmail.com>
---
drivers/staging/fbtft/fbtft-bus.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/fbtft/fbtft-bus.c b/drivers/staging/fbtft/fbtft-bus.c
index 30e436ff1..60846185d 100644
--- a/drivers/staging/fbtft/fbtft-bus.c
+++ b/drivers/staging/fbtft/fbtft-bus.c
@@ -11,6 +11,7 @@
*
*****************************************************************************/
+#define NOOP(x) (x) \
#define define_fbtft_write_reg(func, buffer_type, data_type, modifier) \
void func(struct fbtft_par *par, int len, ...) \
{ \
@@ -62,9 +63,9 @@ out: \
} \
EXPORT_SYMBOL(func);
-define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8, )
+define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8, NOOP)
define_fbtft_write_reg(fbtft_write_reg16_bus8, __be16, u16, cpu_to_be16)
-define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16, )
+define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16, NOOP)
void fbtft_write_reg8_bus9(struct fbtft_par *par, int len, ...)
{
--
2.43.0
^ permalink raw reply related
* [PATCH 3/3] Documentation: fb: Split toctree
From: Bagas Sanjaya @ 2025-09-19 0:36 UTC (permalink / raw)
To: Linux Kernel Mailing List, Linux Documentation, Linux Framebuffer,
Linux DRI Development
Cc: Helge Deller, Jonathan Corbet, Sudip Mukherjee, Teddy Wang,
Bernie Thompson, Bagas Sanjaya, Mauro Carvalho Chehab,
Ard Biesheuvel, Arvind Sankar
In-Reply-To: <20250919003640.14867-1-bagasdotme@gmail.com>
Framebuffer docs toctree consists of driver-independent docs
(e.g. API docs) and driver-specific docs. The latter has much
more entries.
Group the docs into separate toctrees.
Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com>
---
Documentation/fb/index.rst | 80 +++++++++++++++++++++-----------------
1 file changed, 45 insertions(+), 35 deletions(-)
diff --git a/Documentation/fb/index.rst b/Documentation/fb/index.rst
index 33e3c49f885695..e2f7488b6e2e42 100644
--- a/Documentation/fb/index.rst
+++ b/Documentation/fb/index.rst
@@ -4,42 +4,52 @@
Frame Buffer
============
-.. toctree::
- :maxdepth: 1
+General information
+===================
- api
- arkfb
- aty128fb
- cirrusfb
- cmap_xfbdev
- deferred_io
- efifb
- ep93xx-fb
- fbcon
- framebuffer
- gxfb
- intel810
- internals
- lxfb
- matroxfb
- metronomefb
- modedb
- pvr2fb
- pxafb
- s3fb
- sa1100fb
- sh7760fb
- sisfb
- sm501
- sm712fb
- sstfb
- tgafb
- tridentfb
- udlfb
- uvesafb
- vesafb
- viafb
- vt8623fb
+.. toctree::
+ :maxdepth: 1
+
+ api
+ cmap_xfbdev
+ deferred_io
+ fbcon
+ framebuffer
+ internals
+ modedb
+
+Driver documentation
+====================
+
+.. toctree::
+ :maxdepth: 1
+
+ arkfb
+ aty128fb
+ cirrusfb
+ efifb
+ ep93xx-fb
+ gxfb
+ intel810
+ lxfb
+ matroxfb
+ metronomefb
+ pvr2fb
+ pxafb
+ s3fb
+ sa1100fb
+ sh7760fb
+ sisfb
+ sm501
+ sm712fb
+ sstfb
+ tgafb
+ tridentfb
+ udlfb
+ uvesafb
+ vesafb
+ viafb
+ vt8623fb
.. only:: subproject and html
--
An old man doll... just what I always wanted! - Clara
^ permalink raw reply related
* [PATCH 0/3] framebuffer docs toctree index refactoring
From: Bagas Sanjaya @ 2025-09-19 0:36 UTC (permalink / raw)
To: Linux Kernel Mailing List, Linux Documentation, Linux Framebuffer,
Linux DRI Development
Cc: Helge Deller, Jonathan Corbet, Sudip Mukherjee, Teddy Wang,
Bernie Thompson, Bagas Sanjaya, Mauro Carvalho Chehab,
Ard Biesheuvel, Arvind Sankar
Hi,
Here is simple toctree refactoring for framebuffer documentation,
based on docs-next tree. Simple because it only splits the toctree
in patch [3/3] into two sections.
Enjoy!
Bagas Sanjaya (3):
Documentation: fb: ep93xx: Demote section headings
Documentation: fb: Retitle driver docs
Documentation: fb: Split toctree
Documentation/fb/aty128fb.rst | 8 ++--
Documentation/fb/efifb.rst | 6 +--
Documentation/fb/ep93xx-fb.rst | 4 --
Documentation/fb/gxfb.rst | 8 ++--
Documentation/fb/index.rst | 80 +++++++++++++++++++---------------
Documentation/fb/lxfb.rst | 9 ++--
Documentation/fb/matroxfb.rst | 9 ++--
Documentation/fb/pvr2fb.rst | 6 +--
Documentation/fb/sa1100fb.rst | 9 ++--
Documentation/fb/sisfb.rst | 6 +--
Documentation/fb/sm712fb.rst | 6 +--
Documentation/fb/tgafb.rst | 6 +--
Documentation/fb/udlfb.rst | 6 +--
Documentation/fb/vesafb.rst | 6 +--
14 files changed, 81 insertions(+), 88 deletions(-)
base-commit: 348011753d99b146c190aae262ee361d03cb0c5e
--
An old man doll... just what I always wanted! - Clara
^ permalink raw reply
* [PATCH 1/3] Documentation: fb: ep93xx: Demote section headings
From: Bagas Sanjaya @ 2025-09-19 0:36 UTC (permalink / raw)
To: Linux Kernel Mailing List, Linux Documentation, Linux Framebuffer,
Linux DRI Development
Cc: Helge Deller, Jonathan Corbet, Sudip Mukherjee, Teddy Wang,
Bernie Thompson, Bagas Sanjaya, Mauro Carvalho Chehab,
Ard Biesheuvel, Arvind Sankar
In-Reply-To: <20250919003640.14867-1-bagasdotme@gmail.com>
Section headings are formatted the same as title heading, thus
increasing number of entries in framebuffer toctree. Demote them.
Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com>
---
Documentation/fb/ep93xx-fb.rst | 4 ----
1 file changed, 4 deletions(-)
diff --git a/Documentation/fb/ep93xx-fb.rst b/Documentation/fb/ep93xx-fb.rst
index 1dd67f4688c751..93b3494f530979 100644
--- a/Documentation/fb/ep93xx-fb.rst
+++ b/Documentation/fb/ep93xx-fb.rst
@@ -41,7 +41,6 @@ your board initialisation function::
ep93xx_register_fb(&some_board_fb_info);
-=====================
Video Attribute Flags
=====================
@@ -79,7 +78,6 @@ EP93XXFB_USE_SDCSN2 Use SDCSn[2] for the framebuffer.
EP93XXFB_USE_SDCSN3 Use SDCSn[3] for the framebuffer.
=============================== ======================================
-==================
Platform callbacks
==================
@@ -101,7 +99,6 @@ obtained as follows::
/* Board specific framebuffer setup */
}
-======================
Setting the video mode
======================
@@ -119,7 +116,6 @@ set when the module is installed::
modprobe ep93xx-fb video=320x240
-==============
Screenpage bug
==============
--
An old man doll... just what I always wanted! - Clara
^ permalink raw reply related
* [PATCH 2/3] Documentation: fb: Retitle driver docs
From: Bagas Sanjaya @ 2025-09-19 0:36 UTC (permalink / raw)
To: Linux Kernel Mailing List, Linux Documentation, Linux Framebuffer,
Linux DRI Development
Cc: Helge Deller, Jonathan Corbet, Sudip Mukherjee, Teddy Wang,
Bernie Thompson, Bagas Sanjaya, Mauro Carvalho Chehab,
Ard Biesheuvel, Arvind Sankar
In-Reply-To: <20250919003640.14867-1-bagasdotme@gmail.com>
Many framebuffer driver docs are copied from vesafb docs as their
template, including "What is <driver name>" title. Such title
implies the introductory section, however, and not the whole docs.
Retitle them.
Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com>
---
Documentation/fb/aty128fb.rst | 8 +++-----
Documentation/fb/efifb.rst | 6 +++---
Documentation/fb/gxfb.rst | 8 +++-----
Documentation/fb/lxfb.rst | 9 +++------
Documentation/fb/matroxfb.rst | 9 +++------
Documentation/fb/pvr2fb.rst | 6 +++---
Documentation/fb/sa1100fb.rst | 9 +++------
Documentation/fb/sisfb.rst | 6 +++---
Documentation/fb/sm712fb.rst | 6 +++---
Documentation/fb/tgafb.rst | 6 +++---
Documentation/fb/udlfb.rst | 6 +++---
Documentation/fb/vesafb.rst | 6 +++---
12 files changed, 36 insertions(+), 49 deletions(-)
diff --git a/Documentation/fb/aty128fb.rst b/Documentation/fb/aty128fb.rst
index 3f107718f933fc..0da8070a552165 100644
--- a/Documentation/fb/aty128fb.rst
+++ b/Documentation/fb/aty128fb.rst
@@ -1,8 +1,6 @@
-=================
-What is aty128fb?
-=================
-
-.. [This file is cloned from VesaFB/matroxfb]
+=========================================
+aty128fb - ATI Rage128 framebuffer driver
+=========================================
This is a driver for a graphic framebuffer for ATI Rage128 based devices
on Intel and PPC boxes.
diff --git a/Documentation/fb/efifb.rst b/Documentation/fb/efifb.rst
index 6badff64756f49..3d4aab406dee0a 100644
--- a/Documentation/fb/efifb.rst
+++ b/Documentation/fb/efifb.rst
@@ -1,6 +1,6 @@
-==============
-What is efifb?
-==============
+===================================
+efifb - Generic EFI platform driver
+===================================
This is a generic EFI platform driver for systems with UEFI firmware. The
system must be booted via the EFI stub for this to be usable. efifb supports
diff --git a/Documentation/fb/gxfb.rst b/Documentation/fb/gxfb.rst
index 5738709bccbbf3..3fda485606bdc1 100644
--- a/Documentation/fb/gxfb.rst
+++ b/Documentation/fb/gxfb.rst
@@ -1,8 +1,6 @@
-=============
-What is gxfb?
-=============
-
-.. [This file is cloned from VesaFB/aty128fb]
+=======================================
+gxfb - AMD Geode GX2 framebuffer driver
+=======================================
This is a graphics framebuffer driver for AMD Geode GX2 based processors.
diff --git a/Documentation/fb/lxfb.rst b/Documentation/fb/lxfb.rst
index 863e6b98fbae55..0a176ab376e30e 100644
--- a/Documentation/fb/lxfb.rst
+++ b/Documentation/fb/lxfb.rst
@@ -1,9 +1,6 @@
-=============
-What is lxfb?
-=============
-
-.. [This file is cloned from VesaFB/aty128fb]
-
+======================================
+lxfb - AMD Geode LX framebuffer driver
+======================================
This is a graphics framebuffer driver for AMD Geode LX based processors.
diff --git a/Documentation/fb/matroxfb.rst b/Documentation/fb/matroxfb.rst
index 6158c49c857148..34cafaa00bab19 100644
--- a/Documentation/fb/matroxfb.rst
+++ b/Documentation/fb/matroxfb.rst
@@ -1,9 +1,6 @@
-=================
-What is matroxfb?
-=================
-
-.. [This file is cloned from VesaFB. Thanks go to Gerd Knorr]
-
+==================================
+matroxfb driver for Matrox devices
+==================================
This is a driver for a graphic framebuffer for Matrox devices on
Alpha, Intel and PPC boxes.
diff --git a/Documentation/fb/pvr2fb.rst b/Documentation/fb/pvr2fb.rst
index fcf2c21c8fcfeb..315ce085a5855b 100644
--- a/Documentation/fb/pvr2fb.rst
+++ b/Documentation/fb/pvr2fb.rst
@@ -1,6 +1,6 @@
-===============
-What is pvr2fb?
-===============
+===============================================
+pvr2fb - PowerVR 2 graphics frame buffer driver
+===============================================
This is a driver for PowerVR 2 based graphics frame buffers, such as the
one found in the Dreamcast.
diff --git a/Documentation/fb/sa1100fb.rst b/Documentation/fb/sa1100fb.rst
index 67e2650e017d12..c5ca019b361a94 100644
--- a/Documentation/fb/sa1100fb.rst
+++ b/Documentation/fb/sa1100fb.rst
@@ -1,9 +1,6 @@
-=================
-What is sa1100fb?
-=================
-
-.. [This file is cloned from VesaFB/matroxfb]
-
+=================================================
+sa1100fb - SA-1100 LCD graphic framebuffer driver
+=================================================
This is a driver for a graphic framebuffer for the SA-1100 LCD
controller.
diff --git a/Documentation/fb/sisfb.rst b/Documentation/fb/sisfb.rst
index 8f4e502ea12ea7..9982f5ee05601b 100644
--- a/Documentation/fb/sisfb.rst
+++ b/Documentation/fb/sisfb.rst
@@ -1,6 +1,6 @@
-==============
-What is sisfb?
-==============
+=====================================
+sisfb - SiS framebuffer device driver
+=====================================
sisfb is a framebuffer device driver for SiS (Silicon Integrated Systems)
graphics chips. Supported are:
diff --git a/Documentation/fb/sm712fb.rst b/Documentation/fb/sm712fb.rst
index 8e000f80b5bc6d..abbc6efae25f46 100644
--- a/Documentation/fb/sm712fb.rst
+++ b/Documentation/fb/sm712fb.rst
@@ -1,6 +1,6 @@
-================
-What is sm712fb?
-================
+==========================================================
+sm712fb - Silicon Motion SM712 graphics framebuffer driver
+==========================================================
This is a graphics framebuffer driver for Silicon Motion SM712 based processors.
diff --git a/Documentation/fb/tgafb.rst b/Documentation/fb/tgafb.rst
index 0c50d2134aa433..f0944da1ea5ef1 100644
--- a/Documentation/fb/tgafb.rst
+++ b/Documentation/fb/tgafb.rst
@@ -1,6 +1,6 @@
-==============
-What is tgafb?
-==============
+=======================================
+tgafb - TGA graphics framebuffer driver
+=======================================
This is a driver for DECChip 21030 based graphics framebuffers, a.k.a. TGA
cards, which are usually found in older Digital Alpha systems. The
diff --git a/Documentation/fb/udlfb.rst b/Documentation/fb/udlfb.rst
index 99cfbb7a192238..9e75ac6b07c36a 100644
--- a/Documentation/fb/udlfb.rst
+++ b/Documentation/fb/udlfb.rst
@@ -1,6 +1,6 @@
-==============
-What is udlfb?
-==============
+==================================
+udlfb - DisplayLink USB 2.0 driver
+==================================
This is a driver for DisplayLink USB 2.0 era graphics chips.
diff --git a/Documentation/fb/vesafb.rst b/Documentation/fb/vesafb.rst
index f890a4f5623b45..5ffb35efd4538a 100644
--- a/Documentation/fb/vesafb.rst
+++ b/Documentation/fb/vesafb.rst
@@ -1,6 +1,6 @@
-===============
-What is vesafb?
-===============
+===========================================
+Generic graphic framebuffer driver (vesafb)
+===========================================
This is a generic driver for a graphic framebuffer on intel boxes.
--
An old man doll... just what I always wanted! - Clara
^ permalink raw reply related
* Re: [PATCH 0/3] Documentation: fbcon: formatting cleanup and improvements
From: Jonathan Corbet @ 2025-09-18 16:37 UTC (permalink / raw)
To: Bagas Sanjaya, Linux Kernel Mailing List, Linux Documentation,
Linux Framebuffer, Linux DRI Development
Cc: Helge Deller, Bagas Sanjaya
In-Reply-To: <20250909063744.30053-1-bagasdotme@gmail.com>
Bagas Sanjaya <bagasdotme@gmail.com> writes:
> Hi,
>
> Here are reST formatting cleanup and improvements for fbcon documentation.
> The shortlog below should be self-explanatory.
>
> This series is based on docs-next tree.
>
> Enjoy!
>
> Bagas Sanjaya (3):
> Documentation: fbcon: Add boot options and attach/detach/unload
> section headings
> Documentation: fbcon: Reindent 8th step of attach/detach/unload
> Documentation: fbcon: Use admonition directives
>
> Documentation/fb/fbcon.rst | 42 ++++++++++++++++++++++----------------
> 1 file changed, 24 insertions(+), 18 deletions(-)
It looks like nobody has picked these up yet, so I've applied them.
Thanks,
jon
^ permalink raw reply
* Re: [PATCH 2/2] MAINTAINERS: Mark hyperv_fb driver Obsolete
From: Saurabh Singh Sengar @ 2025-09-18 8:05 UTC (permalink / raw)
To: Prasanna Kumar T S M
Cc: dri-devel, linux-hyperv, linux-fbdev, linux-kernel, mhklinux,
rdunlap, bartosz.golaszewski, gonzalo.silvalde, arnd, tzimmermann,
decui, wei.liu, deller, kys, haiyangz
In-Reply-To: <1758117804-20798-1-git-send-email-ptsm@linux.microsoft.com>
On Wed, Sep 17, 2025 at 07:03:24AM -0700, Prasanna Kumar T S M wrote:
> The hyperv_fb driver is deprecated in favor of Hyper-V DRM driver. Split
> the hyperv_fb entry from the hyperv drivers list, mark it obsolete.
>
> Signed-off-by: Prasanna Kumar T S M <ptsm@linux.microsoft.com>
> ---
> MAINTAINERS | 11 ++++++++++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index f6206963efbf..aa9d0fa6020b 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -11424,7 +11424,6 @@ F: drivers/pci/controller/pci-hyperv-intf.c
> F: drivers/pci/controller/pci-hyperv.c
> F: drivers/scsi/storvsc_drv.c
> F: drivers/uio/uio_hv_generic.c
> -F: drivers/video/fbdev/hyperv_fb.c
> F: include/asm-generic/mshyperv.h
> F: include/clocksource/hyperv_timer.h
> F: include/hyperv/hvgdk.h
> @@ -11438,6 +11437,16 @@ F: include/uapi/linux/hyperv.h
> F: net/vmw_vsock/hyperv_transport.c
> F: tools/hv/
>
> +HYPER-V FRAMEBUFFER DRIVER
> +M: "K. Y. Srinivasan" <kys@microsoft.com>
> +M: Haiyang Zhang <haiyangz@microsoft.com>
> +M: Wei Liu <wei.liu@kernel.org>
> +M: Dexuan Cui <decui@microsoft.com>
> +L: linux-hyperv@vger.kernel.org
> +S: Obsolete
> +T: git git://git.kernel.org/pub/scm/linux/kernel/git/hyperv/linux.git
> +F: drivers/video/fbdev/hyperv_fb.c
> +
> HYPERBUS SUPPORT
> M: Vignesh Raghavendra <vigneshr@ti.com>
> R: Tudor Ambarus <tudor.ambarus@linaro.org>
> --
> 2.49.0
Reviewed-by: Saurabh Sengar <ssengar@linux.microsoft.com>
^ permalink raw reply
* Re: [PATCH 1/2] fbdev/hyperv_fb: deprecate this in favor of Hyper-V DRM driver
From: Saurabh Singh Sengar @ 2025-09-18 8:04 UTC (permalink / raw)
To: Prasanna Kumar T S M
Cc: dri-devel, linux-hyperv, linux-fbdev, linux-kernel, mhklinux,
rdunlap, bartosz.golaszewski, gonzalo.silvalde, arnd, tzimmermann,
decui, wei.liu, deller, kys, haiyangz
In-Reply-To: <1758117785-20653-1-git-send-email-ptsm@linux.microsoft.com>
On Wed, Sep 17, 2025 at 07:03:05AM -0700, Prasanna Kumar T S M wrote:
> The Hyper-V DRM driver is available since kernel version 5.14 and it
> provides full KMS support and fbdev emulation via the DRM fbdev helpers.
> Deprecate this driver in favor of Hyper-V DRM driver.
>
> Signed-off-by: Prasanna Kumar T S M <ptsm@linux.microsoft.com>
> ---
> drivers/video/fbdev/Kconfig | 5 ++++-
> drivers/video/fbdev/hyperv_fb.c | 2 ++
> 2 files changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
> index c21484d15f0c..48c1c7417f6d 100644
> --- a/drivers/video/fbdev/Kconfig
> +++ b/drivers/video/fbdev/Kconfig
> @@ -1773,13 +1773,16 @@ config FB_BROADSHEET
> a bridge adapter.
>
> config FB_HYPERV
> - tristate "Microsoft Hyper-V Synthetic Video support"
> + tristate "Microsoft Hyper-V Synthetic Video support (DEPRECATED)"
> depends on FB && HYPERV
> select DMA_CMA if HAVE_DMA_CONTIGUOUS && CMA
> select FB_IOMEM_HELPERS_DEFERRED
> help
> This framebuffer driver supports Microsoft Hyper-V Synthetic Video.
>
> + This driver is deprecated, please use the Hyper-V DRM driver at
> + drivers/gpu/drm/hyperv (CONFIG_DRM_HYPERV) instead.
> +
> config FB_SIMPLE
> tristate "Simple framebuffer support"
> depends on FB
> diff --git a/drivers/video/fbdev/hyperv_fb.c b/drivers/video/fbdev/hyperv_fb.c
> index 75338ffc703f..c99e2ea4b3de 100644
> --- a/drivers/video/fbdev/hyperv_fb.c
> +++ b/drivers/video/fbdev/hyperv_fb.c
> @@ -1357,6 +1357,8 @@ static int __init hvfb_drv_init(void)
> {
> int ret;
>
> + pr_warn("Deprecated: use Hyper-V DRM driver instead\n");
> +
> if (fb_modesetting_disabled("hyper_fb"))
> return -ENODEV;
>
> --
> 2.49.0
Thanks for the patch. I hope it makes to the next LTS as planned.
Reviewed-by: Saurabh Sengar <ssengar@linux.microsoft.com>
^ permalink raw reply
* RE: [PATCH 2/2] MAINTAINERS: Mark hyperv_fb driver Obsolete
From: Michael Kelley @ 2025-09-18 4:03 UTC (permalink / raw)
To: Prasanna Kumar T S M, dri-devel@lists.freedesktop.org,
linux-hyperv@vger.kernel.org, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org, ssengar@linux.microsoft.com,
rdunlap@infradead.org, bartosz.golaszewski@linaro.org,
gonzalo.silvalde@gmail.com, arnd@arndb.de, tzimmermann@suse.de,
decui@microsoft.com, wei.liu@kernel.org, deller@gmx.de,
kys@microsoft.com, haiyangz@microsoft.com
In-Reply-To: <1758117804-20798-1-git-send-email-ptsm@linux.microsoft.com>
From: Prasanna Kumar T S M <ptsm@linux.microsoft.com> Sent: Wednesday, September 17, 2025 7:03 AM
>
> The hyperv_fb driver is deprecated in favor of Hyper-V DRM driver. Split
> the hyperv_fb entry from the hyperv drivers list, mark it obsolete.
>
> Signed-off-by: Prasanna Kumar T S M <ptsm@linux.microsoft.com>
> ---
> MAINTAINERS | 11 ++++++++++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index f6206963efbf..aa9d0fa6020b 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -11424,7 +11424,6 @@ F: drivers/pci/controller/pci-hyperv-intf.c
> F: drivers/pci/controller/pci-hyperv.c
> F: drivers/scsi/storvsc_drv.c
> F: drivers/uio/uio_hv_generic.c
> -F: drivers/video/fbdev/hyperv_fb.c
> F: include/asm-generic/mshyperv.h
> F: include/clocksource/hyperv_timer.h
> F: include/hyperv/hvgdk.h
> @@ -11438,6 +11437,16 @@ F: include/uapi/linux/hyperv.h
> F: net/vmw_vsock/hyperv_transport.c
> F: tools/hv/
>
> +HYPER-V FRAMEBUFFER DRIVER
> +M: "K. Y. Srinivasan" <kys@microsoft.com>
> +M: Haiyang Zhang <haiyangz@microsoft.com>
> +M: Wei Liu <wei.liu@kernel.org>
> +M: Dexuan Cui <decui@microsoft.com>
> +L: linux-hyperv@vger.kernel.org
> +S: Obsolete
> +T: git git://git.kernel.org/pub/scm/linux/kernel/git/hyperv/linux.git
> +F: drivers/video/fbdev/hyperv_fb.c
> +
> HYPERBUS SUPPORT
> M: Vignesh Raghavendra <vigneshr@ti.com>
> R: Tudor Ambarus <tudor.ambarus@linaro.org>
> --
> 2.49.0
Reviewed-by: Michael Kelley <mhklinux@outlook.com>
^ permalink raw reply
* RE: [PATCH 1/2] fbdev/hyperv_fb: deprecate this in favor of Hyper-V DRM driver
From: Michael Kelley @ 2025-09-18 4:01 UTC (permalink / raw)
To: Prasanna Kumar T S M, dri-devel@lists.freedesktop.org,
linux-hyperv@vger.kernel.org, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org, ssengar@linux.microsoft.com,
rdunlap@infradead.org, bartosz.golaszewski@linaro.org,
gonzalo.silvalde@gmail.com, arnd@arndb.de, tzimmermann@suse.de,
decui@microsoft.com, wei.liu@kernel.org, deller@gmx.de,
kys@microsoft.com, haiyangz@microsoft.com
In-Reply-To: <1758117785-20653-1-git-send-email-ptsm@linux.microsoft.com>
From: Prasanna Kumar T S M <ptsm@linux.microsoft.com> Sent: Wednesday, September 17, 2025 7:03 AM
>
> The Hyper-V DRM driver is available since kernel version 5.14 and it
> provides full KMS support and fbdev emulation via the DRM fbdev helpers.
> Deprecate this driver in favor of Hyper-V DRM driver.
>
> Signed-off-by: Prasanna Kumar T S M <ptsm@linux.microsoft.com>
> ---
> drivers/video/fbdev/Kconfig | 5 ++++-
> drivers/video/fbdev/hyperv_fb.c | 2 ++
> 2 files changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
> index c21484d15f0c..48c1c7417f6d 100644
> --- a/drivers/video/fbdev/Kconfig
> +++ b/drivers/video/fbdev/Kconfig
> @@ -1773,13 +1773,16 @@ config FB_BROADSHEET
> a bridge adapter.
>
> config FB_HYPERV
> - tristate "Microsoft Hyper-V Synthetic Video support"
> + tristate "Microsoft Hyper-V Synthetic Video support (DEPRECATED)"
> depends on FB && HYPERV
> select DMA_CMA if HAVE_DMA_CONTIGUOUS && CMA
> select FB_IOMEM_HELPERS_DEFERRED
> help
> This framebuffer driver supports Microsoft Hyper-V Synthetic Video.
>
> + This driver is deprecated, please use the Hyper-V DRM driver at
> + drivers/gpu/drm/hyperv (CONFIG_DRM_HYPERV) instead.
> +
> config FB_SIMPLE
> tristate "Simple framebuffer support"
> depends on FB
> diff --git a/drivers/video/fbdev/hyperv_fb.c b/drivers/video/fbdev/hyperv_fb.c
> index 75338ffc703f..c99e2ea4b3de 100644
> --- a/drivers/video/fbdev/hyperv_fb.c
> +++ b/drivers/video/fbdev/hyperv_fb.c
> @@ -1357,6 +1357,8 @@ static int __init hvfb_drv_init(void)
> {
> int ret;
>
> + pr_warn("Deprecated: use Hyper-V DRM driver instead\n");
> +
> if (fb_modesetting_disabled("hyper_fb"))
> return -ENODEV;
>
> --
> 2.49.0
Reviewed-by: Michael Kelley <mhklinux@outlook.com>
^ permalink raw reply
* Re: [PATCH 2/2] MAINTAINERS: Mark hyperv_fb driver Obsolete
From: Thomas Zimmermann @ 2025-09-17 14:42 UTC (permalink / raw)
To: Prasanna Kumar T S M, dri-devel, linux-hyperv, linux-fbdev,
linux-kernel, ssengar, mhklinux, rdunlap, bartosz.golaszewski,
gonzalo.silvalde, arnd, decui, wei.liu, deller, kys, haiyangz
In-Reply-To: <1758117804-20798-1-git-send-email-ptsm@linux.microsoft.com>
Am 17.09.25 um 16:03 schrieb Prasanna Kumar T S M:
> The hyperv_fb driver is deprecated in favor of Hyper-V DRM driver. Split
> the hyperv_fb entry from the hyperv drivers list, mark it obsolete.
>
> Signed-off-by: Prasanna Kumar T S M <ptsm@linux.microsoft.com>
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> MAINTAINERS | 11 ++++++++++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index f6206963efbf..aa9d0fa6020b 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -11424,7 +11424,6 @@ F: drivers/pci/controller/pci-hyperv-intf.c
> F: drivers/pci/controller/pci-hyperv.c
> F: drivers/scsi/storvsc_drv.c
> F: drivers/uio/uio_hv_generic.c
> -F: drivers/video/fbdev/hyperv_fb.c
> F: include/asm-generic/mshyperv.h
> F: include/clocksource/hyperv_timer.h
> F: include/hyperv/hvgdk.h
> @@ -11438,6 +11437,16 @@ F: include/uapi/linux/hyperv.h
> F: net/vmw_vsock/hyperv_transport.c
> F: tools/hv/
>
> +HYPER-V FRAMEBUFFER DRIVER
> +M: "K. Y. Srinivasan" <kys@microsoft.com>
> +M: Haiyang Zhang <haiyangz@microsoft.com>
> +M: Wei Liu <wei.liu@kernel.org>
> +M: Dexuan Cui <decui@microsoft.com>
> +L: linux-hyperv@vger.kernel.org
> +S: Obsolete
> +T: git git://git.kernel.org/pub/scm/linux/kernel/git/hyperv/linux.git
> +F: drivers/video/fbdev/hyperv_fb.c
> +
> HYPERBUS SUPPORT
> M: Vignesh Raghavendra <vigneshr@ti.com>
> R: Tudor Ambarus <tudor.ambarus@linaro.org>
--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)
^ permalink raw reply
* Re: [PATCH 1/2] fbdev/hyperv_fb: deprecate this in favor of Hyper-V DRM driver
From: Thomas Zimmermann @ 2025-09-17 14:41 UTC (permalink / raw)
To: Prasanna Kumar T S M, dri-devel, linux-hyperv, linux-fbdev,
linux-kernel, ssengar, mhklinux, rdunlap, bartosz.golaszewski,
gonzalo.silvalde, arnd, decui, wei.liu, deller, kys, haiyangz
In-Reply-To: <1758117785-20653-1-git-send-email-ptsm@linux.microsoft.com>
Am 17.09.25 um 16:03 schrieb Prasanna Kumar T S M:
> The Hyper-V DRM driver is available since kernel version 5.14 and it
> provides full KMS support and fbdev emulation via the DRM fbdev helpers.
> Deprecate this driver in favor of Hyper-V DRM driver.
>
> Signed-off-by: Prasanna Kumar T S M <ptsm@linux.microsoft.com>
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/video/fbdev/Kconfig | 5 ++++-
> drivers/video/fbdev/hyperv_fb.c | 2 ++
> 2 files changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
> index c21484d15f0c..48c1c7417f6d 100644
> --- a/drivers/video/fbdev/Kconfig
> +++ b/drivers/video/fbdev/Kconfig
> @@ -1773,13 +1773,16 @@ config FB_BROADSHEET
> a bridge adapter.
>
> config FB_HYPERV
> - tristate "Microsoft Hyper-V Synthetic Video support"
> + tristate "Microsoft Hyper-V Synthetic Video support (DEPRECATED)"
> depends on FB && HYPERV
> select DMA_CMA if HAVE_DMA_CONTIGUOUS && CMA
> select FB_IOMEM_HELPERS_DEFERRED
> help
> This framebuffer driver supports Microsoft Hyper-V Synthetic Video.
>
> + This driver is deprecated, please use the Hyper-V DRM driver at
> + drivers/gpu/drm/hyperv (CONFIG_DRM_HYPERV) instead.
> +
> config FB_SIMPLE
> tristate "Simple framebuffer support"
> depends on FB
> diff --git a/drivers/video/fbdev/hyperv_fb.c b/drivers/video/fbdev/hyperv_fb.c
> index 75338ffc703f..c99e2ea4b3de 100644
> --- a/drivers/video/fbdev/hyperv_fb.c
> +++ b/drivers/video/fbdev/hyperv_fb.c
> @@ -1357,6 +1357,8 @@ static int __init hvfb_drv_init(void)
> {
> int ret;
>
> + pr_warn("Deprecated: use Hyper-V DRM driver instead\n");
> +
> if (fb_modesetting_disabled("hyper_fb"))
> return -ENODEV;
>
--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)
^ permalink raw reply
* [PATCH 2/2] MAINTAINERS: Mark hyperv_fb driver Obsolete
From: Prasanna Kumar T S M @ 2025-09-17 14:03 UTC (permalink / raw)
To: dri-devel, linux-hyperv, linux-fbdev, linux-kernel, ssengar,
mhklinux, ptsm, rdunlap, bartosz.golaszewski, gonzalo.silvalde,
arnd, tzimmermann, decui, wei.liu, deller, kys, haiyangz
In-Reply-To: <E5C2A201B1BD>
The hyperv_fb driver is deprecated in favor of Hyper-V DRM driver. Split
the hyperv_fb entry from the hyperv drivers list, mark it obsolete.
Signed-off-by: Prasanna Kumar T S M <ptsm@linux.microsoft.com>
---
MAINTAINERS | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index f6206963efbf..aa9d0fa6020b 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -11424,7 +11424,6 @@ F: drivers/pci/controller/pci-hyperv-intf.c
F: drivers/pci/controller/pci-hyperv.c
F: drivers/scsi/storvsc_drv.c
F: drivers/uio/uio_hv_generic.c
-F: drivers/video/fbdev/hyperv_fb.c
F: include/asm-generic/mshyperv.h
F: include/clocksource/hyperv_timer.h
F: include/hyperv/hvgdk.h
@@ -11438,6 +11437,16 @@ F: include/uapi/linux/hyperv.h
F: net/vmw_vsock/hyperv_transport.c
F: tools/hv/
+HYPER-V FRAMEBUFFER DRIVER
+M: "K. Y. Srinivasan" <kys@microsoft.com>
+M: Haiyang Zhang <haiyangz@microsoft.com>
+M: Wei Liu <wei.liu@kernel.org>
+M: Dexuan Cui <decui@microsoft.com>
+L: linux-hyperv@vger.kernel.org
+S: Obsolete
+T: git git://git.kernel.org/pub/scm/linux/kernel/git/hyperv/linux.git
+F: drivers/video/fbdev/hyperv_fb.c
+
HYPERBUS SUPPORT
M: Vignesh Raghavendra <vigneshr@ti.com>
R: Tudor Ambarus <tudor.ambarus@linaro.org>
--
2.49.0
^ permalink raw reply related
* [PATCH 1/2] fbdev/hyperv_fb: deprecate this in favor of Hyper-V DRM driver
From: Prasanna Kumar T S M @ 2025-09-17 14:03 UTC (permalink / raw)
To: dri-devel, linux-hyperv, linux-fbdev, linux-kernel, ssengar,
mhklinux, ptsm, rdunlap, bartosz.golaszewski, gonzalo.silvalde,
arnd, tzimmermann, decui, wei.liu, deller, kys, haiyangz
In-Reply-To: <E5C2A201B1BD>
The Hyper-V DRM driver is available since kernel version 5.14 and it
provides full KMS support and fbdev emulation via the DRM fbdev helpers.
Deprecate this driver in favor of Hyper-V DRM driver.
Signed-off-by: Prasanna Kumar T S M <ptsm@linux.microsoft.com>
---
drivers/video/fbdev/Kconfig | 5 ++++-
drivers/video/fbdev/hyperv_fb.c | 2 ++
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
index c21484d15f0c..48c1c7417f6d 100644
--- a/drivers/video/fbdev/Kconfig
+++ b/drivers/video/fbdev/Kconfig
@@ -1773,13 +1773,16 @@ config FB_BROADSHEET
a bridge adapter.
config FB_HYPERV
- tristate "Microsoft Hyper-V Synthetic Video support"
+ tristate "Microsoft Hyper-V Synthetic Video support (DEPRECATED)"
depends on FB && HYPERV
select DMA_CMA if HAVE_DMA_CONTIGUOUS && CMA
select FB_IOMEM_HELPERS_DEFERRED
help
This framebuffer driver supports Microsoft Hyper-V Synthetic Video.
+ This driver is deprecated, please use the Hyper-V DRM driver at
+ drivers/gpu/drm/hyperv (CONFIG_DRM_HYPERV) instead.
+
config FB_SIMPLE
tristate "Simple framebuffer support"
depends on FB
diff --git a/drivers/video/fbdev/hyperv_fb.c b/drivers/video/fbdev/hyperv_fb.c
index 75338ffc703f..c99e2ea4b3de 100644
--- a/drivers/video/fbdev/hyperv_fb.c
+++ b/drivers/video/fbdev/hyperv_fb.c
@@ -1357,6 +1357,8 @@ static int __init hvfb_drv_init(void)
{
int ret;
+ pr_warn("Deprecated: use Hyper-V DRM driver instead\n");
+
if (fb_modesetting_disabled("hyper_fb"))
return -ENODEV;
--
2.49.0
^ permalink raw reply related
* [PATCH 0/2] deprecate Hyper-V fb driver in favor of Hyper-V DRM driver
From: Prasanna Kumar T S M @ 2025-09-17 14:02 UTC (permalink / raw)
To: dri-devel, linux-hyperv, linux-fbdev, linux-kernel, ssengar,
mhklinux, ptsm, rdunlap, bartosz.golaszewski, gonzalo.silvalde,
arnd, tzimmermann, decui, wei.liu, deller, kys, haiyangz
The Hyper-V DRM driver is available since kernel version 5.14 and it
provides full KMS support and fbdev emulation via the DRM fbdev helpers.
Deprecate this driver in favor of Hyper-V DRM driver.
Prasanna Kumar T S M (2):
fbdev/hyperv_fb: deprecate this in favor of Hyper-V DRM driver
MAINTAINERS: Mark hyperv_fb driver Obsolete
MAINTAINERS | 11 ++++++++++-
drivers/video/fbdev/Kconfig | 5 ++++-
drivers/video/fbdev/hyperv_fb.c | 2 ++
3 files changed, 16 insertions(+), 2 deletions(-)
--
2.49.0
^ permalink raw reply
* Re: [PATCH v2 1/9] panic: Introduce helper functions for panic state
From: Jinchao Wang @ 2025-09-17 2:09 UTC (permalink / raw)
To: Petr Mladek
Cc: Andrew Morton, Baoquan He, Yury Norov, Qianqiang Liu,
Simona Vetter, Helge Deller, Steven Rostedt, John Ogness,
Sergey Senozhatsky, Vivek Goyal, Dave Young, Kees Cook, Tony Luck,
Guilherme G. Piccoli, Thomas Zimmermann, Ville Syrjälä,
Shixiong Ou, Zsolt Kajtar, Ingo Molnar, Nam Cao, Jonathan Cameron,
Joel Fernandes, Joel Granados, Jason Gunthorpe, Sohil Mehta,
Feng Tang, Sravan Kumar Gundu, Douglas Anderson, Thomas Gleixner,
Anna Schumaker, Darrick J. Wong, Max Kellermann, Yunhui Cui,
Tejun Heo, Luo Gengkun, Li Huafei, Thorsten Blum, Yicong Yang,
linux-fbdev, dri-devel, kexec, linux-hardening, linux-kernel
In-Reply-To: <aMk0d5JO_4YECYGY@pathway.suse.cz>
On Tue, Sep 16, 2025 at 11:57:11AM +0200, Petr Mladek wrote:
> On Mon 2025-08-25 10:29:29, Jinchao Wang wrote:
> > This patch introduces four new helper functions to abstract the
> > management of the panic_cpu variable. These functions will be used in
> > subsequent patches to refactor existing code.
> >
> > The direct use of panic_cpu can be error-prone and ambiguous, as it
> > requires manual checks to determine which CPU is handling the panic.
> > The new helpers clarify intent:
> >
> > panic_try_start():
> > Atomically sets the current CPU as the panicking CPU.
> >
> > panic_reset():
> > Reset panic_cpu to PANIC_CPU_INVALID.
> >
> > panic_in_progress():
> > Checks if a panic has been triggered.
> >
> > panic_on_this_cpu():
> > Returns true if the current CPU is the panic originator.
> >
> > panic_on_other_cpu():
> > Returns true if a panic is on another CPU.
> >
> > This change lays the groundwork for improved code readability
> > and robustness in the panic handling subsystem.
> >
> > Signed-off-by: Jinchao Wang <wangjinchao600@gmail.com>
> > ---
> > include/linux/panic.h | 6 +++++
> > kernel/panic.c | 53 ++++++++++++++++++++++++++++++++++++++++++
> > kernel/printk/printk.c | 5 ----
> > 3 files changed, 59 insertions(+), 5 deletions(-)
> >
> > diff --git a/include/linux/panic.h b/include/linux/panic.h
> > index 7be742628c25..6f972a66c13e 100644
> > --- a/include/linux/panic.h
> > +++ b/include/linux/panic.h
> > @@ -43,6 +43,12 @@ void abort(void);
> > extern atomic_t panic_cpu;
> > #define PANIC_CPU_INVALID -1
> >
> > +bool panic_try_start(void);
> > +void panic_reset(void);
> > +bool panic_in_progress(void);
> > +bool panic_on_this_cpu(void);
> > +bool panic_on_other_cpu(void);
> > +
> > /*
> > * Only to be used by arch init code. If the user over-wrote the default
> > * CONFIG_PANIC_TIMEOUT, honor it.
> > diff --git a/kernel/panic.c b/kernel/panic.c
> > index 72fcbb5a071b..eacb0c972110 100644
> > --- a/kernel/panic.c
> > +++ b/kernel/panic.c
> > @@ -294,6 +294,59 @@ void __weak crash_smp_send_stop(void)
> >
> > atomic_t panic_cpu = ATOMIC_INIT(PANIC_CPU_INVALID);
> >
> > +bool panic_try_start(void)
> > +{
> > + int old_cpu, this_cpu;
> > +
> > + /*
> > + * Only one CPU is allowed to execute the crash_kexec() code as with
> > + * panic(). Otherwise parallel calls of panic() and crash_kexec()
> > + * may stop each other. To exclude them, we use panic_cpu here too.
> > + */
> > + old_cpu = PANIC_CPU_INVALID;
> > + this_cpu = raw_smp_processor_id();
> > +
> > + return atomic_try_cmpxchg(&panic_cpu, &old_cpu, this_cpu);
> > +}
> > +EXPORT_SYMBOL(panic_try_start);
> > +
> > +void panic_reset(void)
> > +{
> > + atomic_set(&panic_cpu, PANIC_CPU_INVALID);
> > +}
> > +EXPORT_SYMBOL(panic_reset);
> > +
> > +bool panic_in_progress(void)
> > +{
> > + return unlikely(atomic_read(&panic_cpu) != PANIC_CPU_INVALID);
> > +}
> > +EXPORT_SYMBOL(panic_in_progress);
> > +
> > +/* Return true if a panic is in progress on the current CPU. */
> > +bool panic_on_this_cpu(void)
> > +{
> > + /*
> > + * We can use raw_smp_processor_id() here because it is impossible for
> > + * the task to be migrated to the panic_cpu, or away from it. If
> > + * panic_cpu has already been set, and we're not currently executing on
> > + * that CPU, then we never will be.
> > + */
> > + return unlikely(atomic_read(&panic_cpu) == raw_smp_processor_id());
> > +}
> > +EXPORT_SYMBOL(panic_on_this_cpu);
> > +
> > +/*
> > + * Return true if a panic is in progress on a remote CPU.
> > + *
> > + * On true, the local CPU should immediately release any printing resources
> > + * that may be needed by the panic CPU.
> > + */
> > +bool panic_on_other_cpu(void)
> > +{
> > + return (panic_in_progress() && !this_cpu_in_panic());
> > +}
> > +EXPORT_SYMBOL(panic_on_other_cpu);
> > +
> > /*
> > * A variant of panic() called from NMI context. We return if we've already
> > * panicked on this CPU. If another CPU already panicked, loop in
> > diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
> > index 0efbcdda9aab..5fe35f377b79 100644
> > --- a/kernel/printk/printk.c
> > +++ b/kernel/printk/printk.c
> > @@ -345,11 +345,6 @@ static void __up_console_sem(unsigned long ip)
> > }
> > #define up_console_sem() __up_console_sem(_RET_IP_)
> >
> > -static bool panic_in_progress(void)
> > -{
> > - return unlikely(atomic_read(&panic_cpu) != PANIC_CPU_INVALID);
> > -}
> > -
> > /* Return true if a panic is in progress on the current CPU. */
> > bool this_cpu_in_panic(void)
> > {
>
> All the functions are trivial. It would make sense to define
> them in linux/panic.h. Then the callers would benefit
> from the (unlikely) prediction macro...
>
> It can be done in a followup path.
Thanks for feedback, I will do it later.
BTW, this series was merged to -mm branch already.
>
> Otherwise, the patch looks good. I think that it is too late
> but feel free to use:
>
> Reviewed-by: Petr Mladek <pmladek@suse.com>
>
> Best Regards,
> Petr
--
Jinchao
^ permalink raw reply
* Re: (subset) [PATCH v2 00/15] backlight: Do not include <linux/fb.h> in header file
From: Lee Jones @ 2025-09-16 16:05 UTC (permalink / raw)
To: lee, danielt, jingoohan1, neil.armstrong, jessica.zhang, deller,
maarten.lankhorst, mripard, airlied, simona, fnkl.kernel, j,
ilpo.jarvinen, sven, alyssa, neal, support.opensource,
Hans de Goede, duje, Thomas Zimmermann
Cc: dri-devel, asahi, platform-driver-x86, linux-arm-kernel,
linux-fbdev
In-Reply-To: <20250715122643.137027-1-tzimmermann@suse.de>
On Tue, 15 Jul 2025 14:24:37 +0200, Thomas Zimmermann wrote:
> Remove the final dependencies on fbdev from the backlight subsystem.
> This is really just the include of <linux/fb.h> in backlight, but it
> has some fallout in other code.
>
> Patches 1 to 14 fix all the implicit includes that come from fb.h
> throughout the kernel. It's all trivial, but touches various drivers.
> Maintainers are in CC. Patch 15 fixes the backlight header.
>
> [...]
Applied, thanks!
[06/15] backlight: Include <linux/of.h>
commit: b12224c28d84d054dfb680c05cda61d1e2584bf5
[07/15] backlight: apple_dwi_bl: Include <linux/mod_devicetable.h>
commit: 945e411acde3800234d506f4304203a9b11890f8
[08/15] backlight: as3711_bl: Include <linux/of.h>
commit: 6789cd935a57464deaacdd14c84bc026aa228e72
[09/15] backlight: da9052_bl: Include <linux/mod_devicetable.h>
commit: e2e76f67bdbbc7b8df608e3dd1028059d838871e
[10/15] backlight: jornada720: Include <linux/io.h>
commit: ce4bb1a2f1cbcd5f6471f74ee5c7e1443a4cfd84
[11/15] backlight: ktd2801: Include <linux/mod_devicetable.h>
commit: 5f60004f152b432c6ae5dbacc172adc1fa215825
[12/15] backlight: led_bl: Include <linux/of.h>
commit: b38ed7c05a35f3a029c2fc5e43a94aa81e2ac843
[13/15] backlight: rave-sp: Include <linux/of.h> and <linux/mod_devicetable.h>
commit: 246da2b48e2ce973db255fc4b6faf42f73c03114
[14/15] backlight: rt4831: Include <linux/mod_devicetable.h>
commit: ba3b29a639fe5173033914db6ee58d8d9bb86aba
[15/15] backlight: Do not include <linux/fb.h> in header file
commit: 9f218f9bb9d274b9d5d48a4c95e1b199141fc1f2
--
Lee Jones [李琼斯]
^ permalink raw reply
* Re: (subset) [PATCH v1 1/1] video: backlight: lp855x_bl: set correct eprom start for LP8556
From: Lee Jones @ 2025-09-16 15:51 UTC (permalink / raw)
To: Lee Jones, Daniel Thompson, Jingoo Han, Helge Deller,
Svyatoslav Ryhel
Cc: dri-devel, linux-fbdev, linux-kernel
In-Reply-To: <20250909074304.92135-2-clamor95@gmail.com>
On Tue, 09 Sep 2025 10:43:04 +0300, Svyatoslav Ryhel wrote:
> According to LP8556 datasheet eprom region starts at 0x98 so adjust value
> in the driver accordingly.
>
>
Applied, thanks!
[1/1] video: backlight: lp855x_bl: set correct eprom start for LP8556
commit: 07c7efda24453e05951fb2879f5452b720b91169
--
Lee Jones [李琼斯]
^ permalink raw reply
* Re: [PATCH v2 1/2] Driver: hv: Add CONFIG_HYPERV_VMBUS option
From: Bjorn Helgaas @ 2025-09-16 15:50 UTC (permalink / raw)
To: Mukesh Rathor
Cc: dri-devel, linux-kernel, linux-input, linux-hyperv, netdev,
linux-pci, linux-scsi, linux-fbdev, linux-arch, virtualization,
maarten.lankhorst, mripard, tzimmermann, airlied, simona, jikos,
bentiss, kys, haiyangz, wei.liu, decui, dmitry.torokhov,
andrew+netdev, davem, edumazet, kuba, pabeni, bhelgaas,
James.Bottomley, martin.petersen, gregkh, deller, arnd, sgarzare,
horms
In-Reply-To: <20250915234604.3256611-2-mrathor@linux.microsoft.com>
On Mon, Sep 15, 2025 at 04:46:03PM -0700, Mukesh Rathor wrote:
> At present VMBus driver is hinged off of CONFIG_HYPERV which entails
> lot of builtin code and encompasses too much. It's not always clear
> what depends on builtin hv code and what depends on VMBus. Setting
> CONFIG_HYPERV as a module and fudging the Makefile to switch to builtin
> adds even more confusion. VMBus is an independent module and should have
> its own config option. Also, there are scenarios like baremetal dom0/root
> where support is built in with CONFIG_HYPERV but without VMBus. Lastly,
> there are more features coming down that use CONFIG_HYPERV and add more
> dependencies on it.
>
> So, create a fine grained HYPERV_VMBUS option and update Kconfigs for
> dependency on VMBus.
>
> Signed-off-by: Mukesh Rathor <mrathor@linux.microsoft.com>
Acked-by: Bjorn Helgaas <bhelgaas@google.com> # drivers/pci
> ---
> drivers/gpu/drm/Kconfig | 2 +-
> drivers/hid/Kconfig | 2 +-
> drivers/hv/Kconfig | 11 +++++++++--
> drivers/hv/Makefile | 2 +-
> drivers/input/serio/Kconfig | 4 ++--
> drivers/net/hyperv/Kconfig | 2 +-
> drivers/pci/Kconfig | 2 +-
> drivers/scsi/Kconfig | 2 +-
> drivers/uio/Kconfig | 2 +-
> drivers/video/fbdev/Kconfig | 2 +-
> include/asm-generic/mshyperv.h | 8 +++++---
> net/vmw_vsock/Kconfig | 2 +-
> 12 files changed, 25 insertions(+), 16 deletions(-)
>
> diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
> index f7ea8e895c0c..58f34da061c6 100644
> --- a/drivers/gpu/drm/Kconfig
> +++ b/drivers/gpu/drm/Kconfig
> @@ -398,7 +398,7 @@ source "drivers/gpu/drm/imagination/Kconfig"
>
> config DRM_HYPERV
> tristate "DRM Support for Hyper-V synthetic video device"
> - depends on DRM && PCI && HYPERV
> + depends on DRM && PCI && HYPERV_VMBUS
> select DRM_CLIENT_SELECTION
> select DRM_KMS_HELPER
> select DRM_GEM_SHMEM_HELPER
> diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
> index a57901203aeb..fe3dc8c0db99 100644
> --- a/drivers/hid/Kconfig
> +++ b/drivers/hid/Kconfig
> @@ -1162,7 +1162,7 @@ config GREENASIA_FF
>
> config HID_HYPERV_MOUSE
> tristate "Microsoft Hyper-V mouse driver"
> - depends on HYPERV
> + depends on HYPERV_VMBUS
> help
> Select this option to enable the Hyper-V mouse driver.
>
> diff --git a/drivers/hv/Kconfig b/drivers/hv/Kconfig
> index e24f6299c376..29f8637f441a 100644
> --- a/drivers/hv/Kconfig
> +++ b/drivers/hv/Kconfig
> @@ -45,18 +45,25 @@ config HYPERV_TIMER
>
> config HYPERV_UTILS
> tristate "Microsoft Hyper-V Utilities driver"
> - depends on HYPERV && CONNECTOR && NLS
> + depends on HYPERV_VMBUS && CONNECTOR && NLS
> depends on PTP_1588_CLOCK_OPTIONAL
> help
> Select this option to enable the Hyper-V Utilities.
>
> config HYPERV_BALLOON
> tristate "Microsoft Hyper-V Balloon driver"
> - depends on HYPERV
> + depends on HYPERV_VMBUS
> select PAGE_REPORTING
> help
> Select this option to enable Hyper-V Balloon driver.
>
> +config HYPERV_VMBUS
> + tristate "Microsoft Hyper-V VMBus driver"
> + depends on HYPERV
> + default HYPERV
> + help
> + Select this option to enable Hyper-V Vmbus driver.
> +
> config MSHV_ROOT
> tristate "Microsoft Hyper-V root partition support"
> depends on HYPERV && (X86_64 || ARM64)
> diff --git a/drivers/hv/Makefile b/drivers/hv/Makefile
> index 976189c725dc..4bb41663767d 100644
> --- a/drivers/hv/Makefile
> +++ b/drivers/hv/Makefile
> @@ -1,5 +1,5 @@
> # SPDX-License-Identifier: GPL-2.0
> -obj-$(CONFIG_HYPERV) += hv_vmbus.o
> +obj-$(CONFIG_HYPERV_VMBUS) += hv_vmbus.o
> obj-$(CONFIG_HYPERV_UTILS) += hv_utils.o
> obj-$(CONFIG_HYPERV_BALLOON) += hv_balloon.o
> obj-$(CONFIG_MSHV_ROOT) += mshv_root.o
> diff --git a/drivers/input/serio/Kconfig b/drivers/input/serio/Kconfig
> index 17edc1597446..c7ef347a4dff 100644
> --- a/drivers/input/serio/Kconfig
> +++ b/drivers/input/serio/Kconfig
> @@ -276,8 +276,8 @@ config SERIO_OLPC_APSP
>
> config HYPERV_KEYBOARD
> tristate "Microsoft Synthetic Keyboard driver"
> - depends on HYPERV
> - default HYPERV
> + depends on HYPERV_VMBUS
> + default HYPERV_VMBUS
> help
> Select this option to enable the Hyper-V Keyboard driver.
>
> diff --git a/drivers/net/hyperv/Kconfig b/drivers/net/hyperv/Kconfig
> index c8cbd85adcf9..982964c1a9fb 100644
> --- a/drivers/net/hyperv/Kconfig
> +++ b/drivers/net/hyperv/Kconfig
> @@ -1,7 +1,7 @@
> # SPDX-License-Identifier: GPL-2.0-only
> config HYPERV_NET
> tristate "Microsoft Hyper-V virtual network driver"
> - depends on HYPERV
> + depends on HYPERV_VMBUS
> select UCS2_STRING
> select NLS
> help
> diff --git a/drivers/pci/Kconfig b/drivers/pci/Kconfig
> index 9a249c65aedc..7065a8e5f9b1 100644
> --- a/drivers/pci/Kconfig
> +++ b/drivers/pci/Kconfig
> @@ -221,7 +221,7 @@ config PCI_LABEL
>
> config PCI_HYPERV
> tristate "Hyper-V PCI Frontend"
> - depends on ((X86 && X86_64) || ARM64) && HYPERV && PCI_MSI && SYSFS
> + depends on ((X86 && X86_64) || ARM64) && HYPERV_VMBUS && PCI_MSI && SYSFS
> select PCI_HYPERV_INTERFACE
> select IRQ_MSI_LIB
> help
> diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
> index 5522310bab8d..19d0884479a2 100644
> --- a/drivers/scsi/Kconfig
> +++ b/drivers/scsi/Kconfig
> @@ -589,7 +589,7 @@ config XEN_SCSI_FRONTEND
>
> config HYPERV_STORAGE
> tristate "Microsoft Hyper-V virtual storage driver"
> - depends on SCSI && HYPERV
> + depends on SCSI && HYPERV_VMBUS
> depends on m || SCSI_FC_ATTRS != m
> default HYPERV
> help
> diff --git a/drivers/uio/Kconfig b/drivers/uio/Kconfig
> index b060dcd7c635..6f86a61231e6 100644
> --- a/drivers/uio/Kconfig
> +++ b/drivers/uio/Kconfig
> @@ -140,7 +140,7 @@ config UIO_MF624
>
> config UIO_HV_GENERIC
> tristate "Generic driver for Hyper-V VMBus"
> - depends on HYPERV
> + depends on HYPERV_VMBUS
> help
> Generic driver that you can bind, dynamically, to any
> Hyper-V VMBus device. It is useful to provide direct access
> diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
> index c21484d15f0c..72c63eaeb983 100644
> --- a/drivers/video/fbdev/Kconfig
> +++ b/drivers/video/fbdev/Kconfig
> @@ -1774,7 +1774,7 @@ config FB_BROADSHEET
>
> config FB_HYPERV
> tristate "Microsoft Hyper-V Synthetic Video support"
> - depends on FB && HYPERV
> + depends on FB && HYPERV_VMBUS
> select DMA_CMA if HAVE_DMA_CONTIGUOUS && CMA
> select FB_IOMEM_HELPERS_DEFERRED
> help
> diff --git a/include/asm-generic/mshyperv.h b/include/asm-generic/mshyperv.h
> index dbd4c2f3aee3..64ba6bc807d9 100644
> --- a/include/asm-generic/mshyperv.h
> +++ b/include/asm-generic/mshyperv.h
> @@ -163,6 +163,7 @@ static inline u64 hv_generate_guest_id(u64 kernel_version)
> return guest_id;
> }
>
> +#if IS_ENABLED(CONFIG_HYPERV_VMBUS)
> /* Free the message slot and signal end-of-message if required */
> static inline void vmbus_signal_eom(struct hv_message *msg, u32 old_msg_type)
> {
> @@ -198,6 +199,10 @@ static inline void vmbus_signal_eom(struct hv_message *msg, u32 old_msg_type)
> }
> }
>
> +extern int vmbus_interrupt;
> +extern int vmbus_irq;
> +#endif /* CONFIG_HYPERV_VMBUS */
> +
> int hv_get_hypervisor_version(union hv_hypervisor_version_info *info);
>
> void hv_setup_vmbus_handler(void (*handler)(void));
> @@ -211,9 +216,6 @@ void hv_setup_crash_handler(void (*handler)(struct pt_regs *regs));
> void hv_remove_crash_handler(void);
> void hv_setup_mshv_handler(void (*handler)(void));
>
> -extern int vmbus_interrupt;
> -extern int vmbus_irq;
> -
> #if IS_ENABLED(CONFIG_HYPERV)
> /*
> * Hypervisor's notion of virtual processor ID is different from
> diff --git a/net/vmw_vsock/Kconfig b/net/vmw_vsock/Kconfig
> index 56356d2980c8..8e803c4828c4 100644
> --- a/net/vmw_vsock/Kconfig
> +++ b/net/vmw_vsock/Kconfig
> @@ -72,7 +72,7 @@ config VIRTIO_VSOCKETS_COMMON
>
> config HYPERV_VSOCKETS
> tristate "Hyper-V transport for Virtual Sockets"
> - depends on VSOCKETS && HYPERV
> + depends on VSOCKETS && HYPERV_VMBUS
> help
> This module implements a Hyper-V transport for Virtual Sockets.
>
> --
> 2.36.1.vfs.0.0
>
^ permalink raw reply
* Re: [PATCH v2 8/9] panic/printk: replace other_cpu_in_panic() with panic_on_other_cpu()
From: Petr Mladek @ 2025-09-16 11:23 UTC (permalink / raw)
To: Jinchao Wang
Cc: Andrew Morton, Baoquan He, Yury Norov, Qianqiang Liu,
Simona Vetter, Helge Deller, Steven Rostedt, John Ogness,
Sergey Senozhatsky, Vivek Goyal, Dave Young, Kees Cook, Tony Luck,
Guilherme G. Piccoli, Thomas Zimmermann, Ville Syrjälä,
Shixiong Ou, Zsolt Kajtar, Ingo Molnar, Nam Cao, Jonathan Cameron,
Joel Fernandes, Joel Granados, Jason Gunthorpe, Sohil Mehta,
Feng Tang, Sravan Kumar Gundu, Douglas Anderson, Thomas Gleixner,
Anna Schumaker, Darrick J. Wong, Max Kellermann, Yunhui Cui,
Tejun Heo, Luo Gengkun, Li Huafei, Thorsten Blum, Yicong Yang,
linux-fbdev, dri-devel, kexec, linux-hardening, linux-kernel
In-Reply-To: <20250825022947.1596226-9-wangjinchao600@gmail.com>
On Mon 2025-08-25 10:29:36, Jinchao Wang wrote:
> The helper other_cpu_in_panic() duplicated logic already provided by
> panic_on_other_cpu().
>
> Remove other_cpu_in_panic() and update all users to call
> panic_on_other_cpu() instead.
>
> This removes redundant code and makes panic handling consistent.
>
> Signed-off-by: Jinchao Wang <wangjinchao600@gmail.com>
Looks good:
Reviewed-by: Petr Mladek <pmladek@suse.com>
Best Regards,
Petr
^ permalink raw reply
* Re: [PATCH v2 7/9] panic/printk: replace this_cpu_in_panic() with panic_on_this_cpu()
From: Petr Mladek @ 2025-09-16 11:22 UTC (permalink / raw)
To: Jinchao Wang
Cc: Andrew Morton, Baoquan He, Yury Norov, Qianqiang Liu,
Simona Vetter, Helge Deller, Steven Rostedt, John Ogness,
Sergey Senozhatsky, Vivek Goyal, Dave Young, Kees Cook, Tony Luck,
Guilherme G. Piccoli, Thomas Zimmermann, Ville Syrjälä,
Shixiong Ou, Zsolt Kajtar, Ingo Molnar, Nam Cao, Jonathan Cameron,
Joel Fernandes, Joel Granados, Jason Gunthorpe, Sohil Mehta,
Feng Tang, Sravan Kumar Gundu, Douglas Anderson, Thomas Gleixner,
Anna Schumaker, Darrick J. Wong, Max Kellermann, Yunhui Cui,
Tejun Heo, Luo Gengkun, Li Huafei, Thorsten Blum, Yicong Yang,
linux-fbdev, dri-devel, kexec, linux-hardening, linux-kernel
In-Reply-To: <20250825022947.1596226-8-wangjinchao600@gmail.com>
On Mon 2025-08-25 10:29:35, Jinchao Wang wrote:
> The helper this_cpu_in_panic() duplicated logic already provided by
> panic_on_this_cpu().
>
> Remove this_cpu_in_panic() and switch all users to panic_on_this_cpu().
>
> This simplifies the code and avoids having two helpers for the same check.
>
> Signed-off-by: Jinchao Wang <wangjinchao600@gmail.com>
It is great that the helper functions were consolidated and moved
from printk to panic code.
Reviewed-by: Petr Mladek <pmladek@suse.com>
Best Regards,
Petr
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox