From: Takashi Iwai <tiwai@suse.de>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-fbdev@vger.kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
dri-devel@lists.freedesktop.org, linux-spi@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-media@vger.kernel.org
Subject: Re: [alsa-devel] [PATCH 4/8] sound: hpios: don't pass GFP_DMA32 to dma_alloc_coherent
Date: Sat, 13 Oct 2018 16:18:28 +0000 [thread overview]
Message-ID: <s5hpnwdn7l7.wl-tiwai@suse.de> (raw)
In-Reply-To: <20181013151707.32210-5-hch@lst.de>
On Sat, 13 Oct 2018 17:17:03 +0200,
Christoph Hellwig wrote:
>
> The DMA API does its own zone decisions based on the coherent_dma_mask.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Takashi Iwai <tiwai@suse.de>
Would you like to take this as a series, or shall I take individually
through sound tree?
thanks,
Takashi
> ---
> sound/pci/asihpi/hpios.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/pci/asihpi/hpios.c b/sound/pci/asihpi/hpios.c
> index 5ef4fe964366..7c91330af719 100644
> --- a/sound/pci/asihpi/hpios.c
> +++ b/sound/pci/asihpi/hpios.c
> @@ -49,7 +49,7 @@ u16 hpios_locked_mem_alloc(struct consistent_dma_area *p_mem_area, u32 size,
> /*?? any benefit in using managed dmam_alloc_coherent? */
> p_mem_area->vaddr > dma_alloc_coherent(&pdev->dev, size, &p_mem_area->dma_handle,
> - GFP_DMA32 | GFP_KERNEL);
> + GFP_KERNEL);
>
> if (p_mem_area->vaddr) {
> HPI_DEBUG_LOG(DEBUG, "allocated %d bytes, dma 0x%x vma %p\n",
> --
> 2.19.1
>
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>
next prev parent reply other threads:[~2018-10-13 16:18 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-13 15:16 remove bogus GFP_DMA32 flags for dma allocations Christoph Hellwig
2018-10-13 15:17 ` [PATCH 1/8] cpufreq: tegra186: don't pass GFP_DMA32 to dma_alloc_coherent Christoph Hellwig
2018-10-15 7:43 ` Rafael J. Wysocki
2018-10-17 7:19 ` Christoph Hellwig
2018-10-17 7:22 ` Rafael J. Wysocki
2018-10-13 15:17 ` [PATCH 2/8] firmware: tegra: " Christoph Hellwig
2018-10-13 15:17 ` [PATCH 3/8] spi: pic32-sqi: " Christoph Hellwig
2018-10-17 11:55 ` Applied "spi: pic32-sqi: don't pass GFP_DMA32 to dma_alloc_coherent" to the spi tree Mark Brown
2018-10-13 15:17 ` [PATCH 4/8] sound: hpios: don't pass GFP_DMA32 to dma_alloc_coherent Christoph Hellwig
2018-10-13 16:18 ` Takashi Iwai [this message]
2018-10-13 16:35 ` [alsa-devel] " Christoph Hellwig
2018-10-13 18:10 ` Takashi Iwai
2018-10-13 15:17 ` [PATCH 5/8] sound: intel/sst: " Christoph Hellwig
2018-10-13 16:20 ` [alsa-devel] " Takashi Iwai
2018-10-17 11:54 ` Applied "ASoC: intel: don't pass GFP_DMA32 to dma_alloc_coherent" to the asoc tree Mark Brown
2018-10-13 15:17 ` [PATCH 6/8] drm: sti: don't pass GFP_DMA32 to dma_alloc_wc Christoph Hellwig
2018-10-15 9:12 ` Benjamin Gaignard
2018-10-16 12:41 ` Benjamin Gaignard
2018-10-17 7:19 ` Christoph Hellwig
2018-10-18 11:59 ` Benjamin Gaignard
2018-10-13 15:17 ` [PATCH 7/8] media: sti/bdisp: don't pass GFP_DMA32 to dma_alloc_attrs Christoph Hellwig
2018-10-15 9:12 ` Benjamin Gaignard
2018-10-17 7:20 ` Christoph Hellwig
2018-10-18 12:00 ` Benjamin Gaignard
2018-12-05 10:31 ` Mauro Carvalho Chehab
2018-10-13 15:17 ` [PATCH 8/8] fsl-diu-fb: don't pass GFP_DMA32 to dmam_alloc_coherent Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hpnwdn7l7.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hch@lst.de \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).