From mboxrd@z Thu Jan 1 00:00:00 1970 From: Timur Tabi Date: Fri, 30 Apr 2010 18:29:11 +0000 Subject: Re: [PATCH 3/5] powerpc/mpc5121: shared DIU framebuffer support Message-Id: List-Id: References: <1272584978-19063-1-git-send-email-agust@denx.de> <1272584978-19063-4-git-send-email-agust@denx.de> <20100430121947.1d265ca6@wker> <20100430190051.3a5ba058@wker> In-Reply-To: <20100430190051.3a5ba058@wker> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Anatolij Gustschin Cc: linux-fbdev@vger.kernel.org, wd@denx.de, dzu@denx.de, John Rigby , devicetree-discuss@lists.ozlabs.org, linuxppc-dev@ozlabs.org, yorksun@freescale.com On Fri, Apr 30, 2010 at 12:00 PM, Anatolij Gustschin wrote: > Thanks. Sorry for my wrong answer above, now I remember the logic > behind this and will try to explain. Actually the reason I do not > use kmalloc() here is that I do not want to _copy_ bitmap data to > newly allocated frame buffer area (It will negatively affect boot > time). Instead I reserve the already configured frame buffer area > so that it won't be destroyed. The starting address of the area > to reserve and also the lenght is passed to reserve_bootmem(). > This is the real reason for using reserve_bootmem() here. > I could alloc new bitmap area using allocators, but then I have > to copy the bitmap data (splash image) to newly allocated area > and have to re-configure the descriptors to display from new > bitmap buffer. Ok, I understand. Please add this comment to the code, so that no one else will wonder what you're doing. -- Timur Tabi Linux kernel developer at Freescale