Linux-Firmware Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Nick Morrow <usbwifi2024@gmail.com>
To: Ping-Ke Shih <pkshih@realtek.com>,
	"linux-firmware@kernel.org" <linux-firmware@kernel.org>
Cc: Bitterblue Smith <rtl8821cerfe2@gmail.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH V2] linux-firmware: Add firmware for RTL8812AU device
Date: Sat, 24 Aug 2024 14:18:33 -0500	[thread overview]
Message-ID: <db84ee3a-1aed-4721-ac27-8c6d116979bf@gmail.com> (raw)
In-Reply-To: <774a7dd01718448da4048e966f5430f1@realtek.com>

On 8/22/24 19:58, Ping-Ke Shih wrote:
> +linux-wireless
> 
> Hi Nick,
> 
> Please always Cc linux-wireless for rtw88 firmware.
> 
> And subject prefix would be "rtw88: ..."

Hi Ping-Ke, I am trying to resolve what you are asking for vs. the instructions at linux-firmware. Should the subject for V3 be:

  [PATCH V3] linux-firmware: rtw88: Add firmware for RTL8812AU device

> 
> Nick Morrow <usbwifi2024@gmail.com> wrote:
>> This firmware was extracted from the  20210708 - v5.13.6-23 release of
>> the vendor driver for this device and is believed to be the latest
>> release by Realtek. Testing of the new driver has been accomplished
>> using this firmware. Numerous testers have been involved.
>>
>> Signed-off-by: Nick Morrow <USBWiFi2024@gmail.com>
>> ---
>> v2:
>>     - No change. Resubmitted now that the driver is in review.
>> ---
>>    WHENCE                |   1 +
>>    rtw88/README          |   3 +++
>>    rtw88/rtw8812a_fw.bin | Bin 0 -> 27030 bytes
>>    3 files changed, 4 insertions(+)
>>    create mode 100644 rtw88/rtw8812a_fw.bin
>>
>> diff --git a/WHENCE b/WHENCE
>> index 8aebe56b..d6bd4814 100644
>> --- a/WHENCE
>> +++ b/WHENCE
>> @@ -3270,6 +3270,7 @@ Licence: Redistributable. See LICENCE.rtlwifi_firmware.txt for details.
>>    Driver: rtw88 - Realtek 802.11ac WLAN driver for RTL8822BE and RTL8822CE
>>
>>    Info: Sent to Larry Finger by Realtek engineer Yan-Hsuan Chuang <yhchuang@realtek.com>
>> +File: rtw88/rtw8812a_fw.bin
>>    File: rtw88/rtw8821a_fw.bin
> 
> I failed to apply this patch, even this textual part.
> 
> Two leading spaces before "File: rtw88/rtw8821a_fw.bin", but actually this
> should be only one. Not sure what is wrong.

I am carefully going over this patch again... while preparing a new version of the patch. I do not recall editing the line that has two leading spaces.


  reply	other threads:[~2024-08-24 19:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-22 18:53 [PATCH V2] linux-firmware: Add firmware for RTL8812AU device Nick Morrow
2024-08-23  0:58 ` Ping-Ke Shih
2024-08-24 19:18   ` Nick Morrow [this message]
2024-08-26  0:54     ` Ping-Ke Shih

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=db84ee3a-1aed-4721-ac27-8c6d116979bf@gmail.com \
    --to=usbwifi2024@gmail.com \
    --cc=linux-firmware@kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=pkshih@realtek.com \
    --cc=rtl8821cerfe2@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox