From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8817AC433DB for ; Mon, 8 Feb 2021 21:39:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 445AC64DA1 for ; Mon, 8 Feb 2021 21:39:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236873AbhBHVjP (ORCPT ); Mon, 8 Feb 2021 16:39:15 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:52879 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235456AbhBHVif (ORCPT ); Mon, 8 Feb 2021 16:38:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612820228; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ycwoDuRmQSUAa02t2T1lCK2l3ab7oXwofcurbg2I9u0=; b=JQ3ahV2Wu1PGEAvTGC7nz14IRpdEu6v7o5O4s+lVeqHcZ+G4aUe5WMfr6Ur9tWoujF35kX Z8V1arTRRyCWug2Dm6GaYY6IcGv0QGLcN0CBDTx2TclMBMRCcKTa+7uvR5MVnyILkdtuwy FUD1qX08AM5nkZ9PhsLqv9s5Wf6p23Q= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-440-PGEMc-RvNpOZUajp6RMRDw-1; Mon, 08 Feb 2021 16:37:05 -0500 X-MC-Unique: PGEMc-RvNpOZUajp6RMRDw-1 Received: by mail-qk1-f200.google.com with SMTP id r15so4777084qke.5 for ; Mon, 08 Feb 2021 13:37:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=ycwoDuRmQSUAa02t2T1lCK2l3ab7oXwofcurbg2I9u0=; b=PkGCIDUHDv3+sdT1zbW1I3RaZrPYuXpl6Tofzy0+Pxp7K2J6b/s33Rm76CIcZH63wq pw+vpXk1Gk7U+nAj/MOBhDeBMJ5Q3z/o/eFK37MVku7YvcHYMz84EbwfuQZ8+LphHqNY PKU4GkO8PukEWERhTR4Ha+Ki4sR6+sK6dnmioxRLilwKfAPVglZydRlLUd7WAJVUseaO xTIEWU0lbm3uPgHiER2Yfhiy+bjwpdBzofTAx+YCifkbb52p7QtQVHJtWviALa/X+gfI ToIAjE7uJu/y+fLguLlK7o9pd1rY6Pl73pGqjNGxhP281U6Twxp5fWxIihL8a5m2u5VV iE7A== X-Gm-Message-State: AOAM533mUhFgNwWae6ZOepJzWKuqKxNx2ISihHTLPZb9gybgTLQtbjlJ PsYSWVDe5B8EVzDGb8vcykmpP62NwNa2nhbnbGY2ZcvL4/+a25gszszAPYMUrtFALZ1iXqBeIuZ BoGfE2vGCL3mNBUcVSsT6TA== X-Received: by 2002:a37:5ac6:: with SMTP id o189mr19494969qkb.96.1612820225065; Mon, 08 Feb 2021 13:37:05 -0800 (PST) X-Google-Smtp-Source: ABdhPJw5GchTOU3t6fseJcEECu+jS0BmO8fmB4mOulTf4QlzBCOjAv4JWxEpF8n7UZZEJd6pOsbMtA== X-Received: by 2002:a37:5ac6:: with SMTP id o189mr19494953qkb.96.1612820224888; Mon, 08 Feb 2021 13:37:04 -0800 (PST) Received: from trix.remote.csb (075-142-250-213.res.spectrum.com. [75.142.250.213]) by smtp.gmail.com with ESMTPSA id h8sm10824699qtp.56.2021.02.08.13.37.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Feb 2021 13:37:04 -0800 (PST) Subject: Re: [PATCH v9 1/2] uio: uio_dfl: add userspace i/o driver for DFL bus To: Moritz Fischer Cc: Xu Yilun , gregkh@linuxfoundation.org, linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org, lgoncalv@redhat.com, hao.wu@intel.com References: <1611564563-9665-1-git-send-email-yilun.xu@intel.com> <1611564563-9665-2-git-send-email-yilun.xu@intel.com> From: Tom Rix Message-ID: <03ffff75-31d6-24c5-03bf-190a64ab9627@redhat.com> Date: Mon, 8 Feb 2021 13:37:02 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-fpga@vger.kernel.org On 1/25/21 6:22 PM, Moritz Fischer wrote: > On Mon, Jan 25, 2021 at 11:00:38AM -0800, Tom Rix wrote: Snip >> >>> + depends on FPGA_DFL >>> + help >>> + Generic DFL (Device Feature List) driver for Userspace I/O devices. >>> + It is useful to provide direct access to DFL devices from userspace. >>> + A sample userspace application using this driver is available for >>> + download in a git repository: >>> + >>> + git clone https://github.com/OPAE/opae-sdk.git >>> + >>> + If you compile this as a module, it will be called uio_dfl. > I'm not sure KConfig is the right place for this. More than half of the other configs do this. ex/ config UIO_MF624     tristate "Humusoft MF624 DAQ PCI card driver"     depends on PCI     help       Userspace I/O interface for the Humusoft MF624 PCI card.       A sample userspace application using this driver is available       (among other MF624 related information and software components)       for download in a git repository:         git clone git://rtime.felk.cvut.cz/mf6xx.git       If you compile this as a module, it will be called uio_mf624. Tom >> opae-sdk is pretty large and uncovered in the Documentation/fpga/dfl.rst. >> >> Where in opae-sdk is this example ? >> >> If you can point me at the example, I will turn it into a selftest. >> >> Tom >> >>> endif >>> diff --git a/drivers/uio/Makefile b/drivers/uio/Makefile >>> index c285dd2..f2f416a1 100644 >>> --- a/drivers/uio/Makefile >>> +++ b/drivers/uio/Makefile >>> @@ -11,3 +11,4 @@ obj-$(CONFIG_UIO_PRUSS) += uio_pruss.o >>> obj-$(CONFIG_UIO_MF624) += uio_mf624.o >>> obj-$(CONFIG_UIO_FSL_ELBC_GPCM) += uio_fsl_elbc_gpcm.o >>> obj-$(CONFIG_UIO_HV_GENERIC) += uio_hv_generic.o >>> +obj-$(CONFIG_UIO_DFL) += uio_dfl.o >>> diff --git a/drivers/uio/uio_dfl.c b/drivers/uio/uio_dfl.c >>> new file mode 100644 >>> index 0000000..89c0fc7 >>> --- /dev/null >>> +++ b/drivers/uio/uio_dfl.c >>> @@ -0,0 +1,66 @@ >>> +// SPDX-License-Identifier: GPL-2.0 >>> +/* >>> + * Generic DFL driver for Userspace I/O devicess >>> + * >>> + * Copyright (C) 2021 Intel Corporation, Inc. >>> + */ >>> +#include >>> +#include >>> +#include >>> +#include >>> + >>> +#define DRIVER_NAME "uio_dfl" >>> + >>> +static int uio_dfl_probe(struct dfl_device *ddev) >>> +{ >>> + struct resource *r = &ddev->mmio_res; >>> + struct device *dev = &ddev->dev; >>> + struct uio_info *uioinfo; >>> + struct uio_mem *uiomem; >>> + int ret; >>> + >>> + uioinfo = devm_kzalloc(dev, sizeof(struct uio_info), GFP_KERNEL); >>> + if (!uioinfo) >>> + return -ENOMEM; >>> + >>> + uioinfo->name = DRIVER_NAME; >>> + uioinfo->version = "0"; >>> + >>> + uiomem = &uioinfo->mem[0]; >>> + uiomem->memtype = UIO_MEM_PHYS; >>> + uiomem->addr = r->start & PAGE_MASK; >>> + uiomem->offs = r->start & ~PAGE_MASK; >>> + uiomem->size = (uiomem->offs + resource_size(r) >>> + + PAGE_SIZE - 1) & PAGE_MASK; >>> + uiomem->name = r->name; >>> + >>> + /* Irq is yet to be supported */ >>> + uioinfo->irq = UIO_IRQ_NONE; >>> + >>> + ret = devm_uio_register_device(dev, uioinfo); >>> + if (ret) >>> + dev_err(dev, "unable to register uio device\n"); >>> + >>> + return ret; >>> +} >>> + >>> +#define FME_FEATURE_ID_ETH_GROUP 0x10 >>> + >>> +static const struct dfl_device_id uio_dfl_ids[] = { >>> + { FME_ID, FME_FEATURE_ID_ETH_GROUP }, >>> + { } >>> +}; >>> +MODULE_DEVICE_TABLE(dfl, uio_dfl_ids); >>> + >>> +static struct dfl_driver uio_dfl_driver = { >>> + .drv = { >>> + .name = DRIVER_NAME, >>> + }, >>> + .id_table = uio_dfl_ids, >>> + .probe = uio_dfl_probe, >>> +}; >>> +module_dfl_driver(uio_dfl_driver); >>> + >>> +MODULE_DESCRIPTION("Generic DFL driver for Userspace I/O devices"); >>> +MODULE_AUTHOR("Intel Corporation"); >>> +MODULE_LICENSE("GPL v2");