From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F878C43334 for ; Wed, 13 Jul 2022 22:01:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237341AbiGMV7d (ORCPT ); Wed, 13 Jul 2022 17:59:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41496 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232125AbiGMV7b (ORCPT ); Wed, 13 Jul 2022 17:59:31 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 5ADF9B4B7 for ; Wed, 13 Jul 2022 14:59:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1657749569; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=guTnNvlqH6K4wA2UCt8wsczuHAK4rJrHvdvd+slq1vY=; b=PaJL5TCXeuePAPaMSss7rA+geG0YxgpL9PwxTe1vBujK4FUBrIBkbVJdn8mjxI92NIFy1s jP1veKpKRmN6XwWqYHYpC5Pb5IMfSNEhCpWnH0MvGdi+BuxsYrybx/qEPivNL8jT2HBWqB AguXnGK4iLq10k2OkTwjMNuTOan5d6k= Received: from mail-oi1-f200.google.com (mail-oi1-f200.google.com [209.85.167.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-297-HhkOwSh2MC6ltnCOuBydJw-1; Wed, 13 Jul 2022 17:59:27 -0400 X-MC-Unique: HhkOwSh2MC6ltnCOuBydJw-1 Received: by mail-oi1-f200.google.com with SMTP id o9-20020acaf009000000b0032f4e886b80so97764oih.5 for ; Wed, 13 Jul 2022 14:59:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=guTnNvlqH6K4wA2UCt8wsczuHAK4rJrHvdvd+slq1vY=; b=RaMKG4FBYIE1Wd/WXsK6VgUoN/IhyitaCF6MLaT93Pw5R/449tXWsKHsixDmadbwmA Z6kOCLp9zmCbpylAcoKPX3xNSvpY2MqqB8WzCPjfKdbC7YunM95GWfFqKY8ceYiat0QS TIzN+9y6fqFg4fTMSu8LCZpOIdTZZPpIyZs+0fUWAdzYLxhBW9Iv149iX62GcorSImo5 gxVulwNzZYZBfFHkzA8WywinmnDqJ2p81YNU/UYaWua3WnsTxIcWlftoE2Qk3FImrOf1 kzDWsoDwLHkcLx4TYNP3FkxryXbqfUMkPyuUupaQS3EUN2zlDuhqJ1lus1tNBub0xY3R wQ5g== X-Gm-Message-State: AJIora8CjqTdvlUzTSp+SAJPigCE69E7V6Iw/+8bmlrVIAERZi/grqk8 ilol2karu2PQVrlSL1SXZNZzW6wHrNGDrRodxX5SRECVNvQRDQU1JNh5v+FH//SnnBo1/dcFEIf WjxER89OVAITAQZiNvI9kYA== X-Received: by 2002:a05:6870:56a9:b0:10b:fca8:b578 with SMTP id p41-20020a05687056a900b0010bfca8b578mr3019404oao.78.1657749567193; Wed, 13 Jul 2022 14:59:27 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vXUp0wlYWszzuHD0u8u82/GNIF0Dw1ziwn/JICNJZfYCbi3V26XmDeIVoOS/Lkfl6sMd8o8w== X-Received: by 2002:a05:6870:56a9:b0:10b:fca8:b578 with SMTP id p41-20020a05687056a900b0010bfca8b578mr3019398oao.78.1657749567008; Wed, 13 Jul 2022 14:59:27 -0700 (PDT) Received: from localhost.localdomain (024-205-208-113.res.spectrum.com. [24.205.208.113]) by smtp.gmail.com with ESMTPSA id x13-20020a056870b40d00b001089aef1815sm32984oap.20.2022.07.13.14.59.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Jul 2022 14:59:26 -0700 (PDT) Subject: Re: [PATCH v3 2/2] fpga: dfl-pci: Add IDs for Intel N6000, N6001 and C6100 cards To: matthew.gerlach@linux.intel.com, hao.wu@intel.com, yilun.xu@intel.com, russell.h.weight@intel.com, basheer.ahmed.muddebihal@intel.com, mdf@kernel.org, corbet@lwn.net, linux-fpga@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, tianfei.zhang@intel.com References: <20220707150549.265621-1-matthew.gerlach@linux.intel.com> <20220707150549.265621-3-matthew.gerlach@linux.intel.com> From: Tom Rix Message-ID: <0c2affef-9a62-3422-ecdb-a8f196ce739c@redhat.com> Date: Wed, 13 Jul 2022 14:59:24 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20220707150549.265621-3-matthew.gerlach@linux.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-fpga@vger.kernel.org On 7/7/22 8:05 AM, matthew.gerlach@linux.intel.com wrote: > From: Matthew Gerlach > > Add pci_dev_table entries supporting the Intel N6000, N6001 > and C6100 cards to the dfl-pci driver. > > Signed-off-by: Matthew Gerlach > Signed-off-by: Tianfei Zhang > --- > v3: added necessary subdevice ids > removed 'drivers: ' from title > > v2: changed names from INTEL_OFS to INTEL_DFL > --- > drivers/fpga/dfl-pci.c | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/drivers/fpga/dfl-pci.c b/drivers/fpga/dfl-pci.c > index fd1fa55c9113..94eabdf1d2f7 100644 > --- a/drivers/fpga/dfl-pci.c > +++ b/drivers/fpga/dfl-pci.c > @@ -77,12 +77,19 @@ static void cci_pci_free_irq(struct pci_dev *pcidev) > #define PCIE_DEVICE_ID_INTEL_PAC_D5005 0x0B2B > #define PCIE_DEVICE_ID_SILICOM_PAC_N5010 0x1000 > #define PCIE_DEVICE_ID_SILICOM_PAC_N5011 0x1001 > +#define PCIE_DEVICE_ID_INTEL_DFL 0xbcce > > /* VF Device */ > #define PCIE_DEVICE_ID_VF_INT_5_X 0xBCBF > #define PCIE_DEVICE_ID_VF_INT_6_X 0xBCC1 > #define PCIE_DEVICE_ID_VF_DSC_1_X 0x09C5 > #define PCIE_DEVICE_ID_INTEL_PAC_D5005_VF 0x0B2C > +#define PCIE_DEVICE_ID_INTEL_DFL_VF 0xbccf > + > +/* PCI Subdevice ID */ > +#define PCIE_SUBDEVICE_ID_INTEL_N6000 0x1770 > +#define PCIE_SUBDEVICE_ID_INTEL_N6001 0x1771 > +#define PCIE_SUBDEVICE_ID_INTEL_C6100 0x17d4 > > static struct pci_device_id cci_pcie_id_tbl[] = { > {PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCIE_DEVICE_ID_PF_INT_5_X),}, > @@ -96,6 +103,18 @@ static struct pci_device_id cci_pcie_id_tbl[] = { > {PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCIE_DEVICE_ID_INTEL_PAC_D5005_VF),}, > {PCI_DEVICE(PCI_VENDOR_ID_SILICOM_DENMARK, PCIE_DEVICE_ID_SILICOM_PAC_N5010),}, > {PCI_DEVICE(PCI_VENDOR_ID_SILICOM_DENMARK, PCIE_DEVICE_ID_SILICOM_PAC_N5011),}, > + {PCI_DEVICE_SUB(PCI_VENDOR_ID_INTEL, PCIE_DEVICE_ID_INTEL_DFL, > + PCI_VENDOR_ID_INTEL, PCIE_SUBDEVICE_ID_INTEL_N6000),}, > + {PCI_DEVICE_SUB(PCI_VENDOR_ID_INTEL, PCIE_DEVICE_ID_INTEL_DFL_VF, > + PCI_VENDOR_ID_INTEL, PCIE_SUBDEVICE_ID_INTEL_N6000),}, > + {PCI_DEVICE_SUB(PCI_VENDOR_ID_INTEL, PCIE_DEVICE_ID_INTEL_DFL, > + PCI_VENDOR_ID_INTEL, PCIE_SUBDEVICE_ID_INTEL_N6001),}, > + {PCI_DEVICE_SUB(PCI_VENDOR_ID_INTEL, PCIE_DEVICE_ID_INTEL_DFL_VF, > + PCI_VENDOR_ID_INTEL, PCIE_SUBDEVICE_ID_INTEL_N6001),}, > + {PCI_DEVICE_SUB(PCI_VENDOR_ID_INTEL, PCIE_DEVICE_ID_INTEL_DFL, > + PCI_VENDOR_ID_INTEL, PCIE_SUBDEVICE_ID_INTEL_C6100),}, > + {PCI_DEVICE_SUB(PCI_VENDOR_ID_INTEL, PCIE_DEVICE_ID_INTEL_DFL_VF, > + PCI_VENDOR_ID_INTEL, PCIE_SUBDEVICE_ID_INTEL_C6100),}, Matt, Thanks for making this change, this addresses my concerns with the earlier patch. Reviewed-by: Tom Rix > {0,} > }; > MODULE_DEVICE_TABLE(pci, cci_pcie_id_tbl);