From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 98B58202625 for ; Fri, 18 Oct 2024 10:52:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729248745; cv=none; b=Bw6srnorh82uMx9QlpNqACNg4cQuA/e4o+GkqFCSQZO52W8kNyWXoHV1pdpJlz0fnLUT5FL2mDjK4UTJxtLzA8B14HEX/cq/gvMkRdS1LuuuRXB482Dq98cAQ+IPTqvgwsbqt5kegzmGwClx5c74gMYhftdPhRWuNkK42QGUb+U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729248745; c=relaxed/simple; bh=hlo66ijJb/Cdj770+zC+26WFSb2kI1W9QVwVBxx18DQ=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=mctjxPn4W4K+PvRkx0Q/HIsD4Eyr3v4ejqUOJUb7wnNBeajxKqvczQhUaW8IVtynRemzw1sVLFzh6M0rODusKr0U42ZzTQxw8UgW74UhunJuXNN+W6O/vKPg/0bpTaf4rTApzuFMIBNqEH+D0B0C61o3jZQmduPHH60AKhIEgaI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=bmEbsZcN; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="bmEbsZcN" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1729248742; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hlo66ijJb/Cdj770+zC+26WFSb2kI1W9QVwVBxx18DQ=; b=bmEbsZcN86sM4xyrCE0ADC98o7Xzw/M+FWFOi8bF+fFVf4xzzCCN+nUsiO1Bpl/KwLR4y0 ho7LupfUqO2lHOdSraGX8P+TzXiNuuBSB/3Ot3n/Zjs1pj+RuNnl6aWkwJxbX0sIrTubFs Nd9F7zzdPeHiapYDbRoBkDzRvFbGNRc= Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-131-y1N7A1VmMwaBHKlmuPVKEQ-1; Fri, 18 Oct 2024 06:52:21 -0400 X-MC-Unique: y1N7A1VmMwaBHKlmuPVKEQ-1 Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-4608a1a8d3eso41581151cf.1 for ; Fri, 18 Oct 2024 03:52:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729248740; x=1729853540; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=hlo66ijJb/Cdj770+zC+26WFSb2kI1W9QVwVBxx18DQ=; b=Ma17b+YJ1ph5zWIrw4GlfvzewXPZX+PMtuYNX2k3QDrDWNwMbhzqwKXlGI8WCOKMUb 1XmGbBs/Hs/nWrn2aVCBAg0sxmD2n8uRSV1dDatq0nUMMhygDm11nIgymT4BLfpmEbrG 7ns/LHrseGYfvGo3hi262uUUPHZmGYdsUxJTXDD9FRJwTypA5Q5hP14RoZ2bm0xKZJO5 o7MtkzwUN+Q1015HKbgySWALIAJUjQYld0HjPI6YtB8D4BuRXv2cDc5+8+MT5BVB21ZS MaJwC1tE0bV2V6ip3bJ/s2htMmUvBUwfQ85oOwlu7QSUm9VLUsceM7Ab62ytiPb/igVM MAjQ== X-Forwarded-Encrypted: i=1; AJvYcCUvtUZqWlJxqwE2pnnhhWvXAumGaBQ5lsHQWqWe2ScdcmZUpEhwouCi2ADOOY3nidquXCx4CAcOnC3D@vger.kernel.org X-Gm-Message-State: AOJu0YxliCT439bkC3ql+QxcZrzVG0Q3NZ/zlViv6kAzfsrgy4CSh+x7 yjylR1cReGHjnbb8L/KJDISBogKHHJWm2neOccp0XWcONeCFY/pBoIjhG76dC5RgyhF0gUWxVm2 k68U8WsEmATP6cPq+7ZdlW/vyz1pJt/NTnGXVtwKamHDQkxpc6cxjmo3SyYU= X-Received: by 2002:a05:622a:4c6:b0:460:927e:c245 with SMTP id d75a77b69052e-460aee14cfbmr30643951cf.4.1729248740434; Fri, 18 Oct 2024 03:52:20 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEItGrt1ABtCJZWw3PgN20DLJ0r2+a0t2Y2RjfBNB5gtKNiYltQvcJbpnnnEkYFE0v3Vlk5hw== X-Received: by 2002:a05:622a:4c6:b0:460:927e:c245 with SMTP id d75a77b69052e-460aee14cfbmr30643441cf.4.1729248740071; Fri, 18 Oct 2024 03:52:20 -0700 (PDT) Received: from dhcp-64-16.muc.redhat.com (nat-pool-muc-t.redhat.com. [149.14.88.26]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-460ae971993sm6164351cf.38.2024.10.18.03.52.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Oct 2024 03:52:19 -0700 (PDT) Message-ID: <0cf0ffed63a8645c49f043877c526b2ab0abf96e.camel@redhat.com> Subject: Re: [PATCH v8 2/6] PCI: Deprecate pcim_iounmap_regions() From: Philipp Stanner To: Andy Shevchenko Cc: Jens Axboe , Wu Hao , Tom Rix , Moritz Fischer , Xu Yilun , Linus Walleij , Bartosz Golaszewski , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Bjorn Helgaas , Richard Cochran , Damien Le Moal , Hannes Reinecke , Chaitanya Kulkarni , Al Viro , Li Zetao , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fpga@vger.kernel.org, linux-gpio@vger.kernel.org, netdev@vger.kernel.org, linux-pci@vger.kernel.org Date: Fri, 18 Oct 2024 12:52:15 +0200 In-Reply-To: References: <20241016094911.24818-2-pstanner@redhat.com> <20241016094911.24818-4-pstanner@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.52.4 (3.52.4-1.fc40) Precedence: bulk X-Mailing-List: linux-fpga@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Wed, 2024-10-16 at 13:38 +0300, Andy Shevchenko wrote: > On Wed, Oct 16, 2024 at 11:49:05AM +0200, Philipp Stanner wrote: > > pcim_ionumap_region() has recently been made a public function and > > does > > not have the disadvantage of having to deal with the legacy iomap > > table, > > as pcim_iounmap_regions() does. > >=20 > > Deprecate pcim_iounmap_regions(). >=20 > ... >=20 > > + * This function is DEPRECATED. Do not use it in new code. >=20 > Interestingly that the syntax of the DEPRECATED is not documented > (yet?), > however the sphinx parser hints us about **DEPRECATED** format =E2=80=94 = see > Documentation/sphinx/parse-headers.pl:251. In any case the above > seems > like second used (in a form of the full sentence) and will be updated > in accordance with the above mentioned script. Can't completely follow =E2=80=93 so one should always write "**DEPRECATED*= *", correct? Is that a blocker for you? All the docstrings in pci/pci.c and pci/devres.c so far just use "DEPRECATED". P.