From: Wei Yongjun <weiyongjun1@huawei.com>
To: Wu Hao <hao.wu@intel.com>, Alan Tull <atull@kernel.org>,
Moritz Fischer <mdf@kernel.org>,
Kang Luwei <luwei.kang@intel.com>
Cc: Wei Yongjun <weiyongjun1@huawei.com>,
linux-fpga@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [PATCH -next] fpga: dfl: fme: fix return value check in in pr_mgmt_init()
Date: Thu, 19 Jul 2018 13:16:54 +0000 [thread overview]
Message-ID: <1532006214-104930-1-git-send-email-weiyongjun1@huawei.com> (raw)
In case of error, the function dfl_fme_create_region() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check should
be replaced with IS_ERR().
Fixes: 29de76240e86 ("fpga: dfl: fme: add partial reconfiguration sub feature support")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/fpga/dfl-fme-pr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/fpga/dfl-fme-pr.c b/drivers/fpga/dfl-fme-pr.c
index fc9fd2d..0b84053 100644
--- a/drivers/fpga/dfl-fme-pr.c
+++ b/drivers/fpga/dfl-fme-pr.c
@@ -420,7 +420,7 @@ static int pr_mgmt_init(struct platform_device *pdev,
/* Create region for each port */
fme_region = dfl_fme_create_region(pdata, mgr,
fme_br->br, i);
- if (!fme_region) {
+ if (IS_ERR(fme_region)) {
ret = PTR_ERR(fme_region);
goto destroy_region;
}
next reply other threads:[~2018-07-19 13:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-19 13:16 Wei Yongjun [this message]
2018-07-19 13:42 ` [PATCH -next] fpga: dfl: fme: fix return value check in in pr_mgmt_init() Wu Hao
2018-07-19 15:19 ` Moritz Fischer
2018-07-19 15:28 ` Alan Tull
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1532006214-104930-1-git-send-email-weiyongjun1@huawei.com \
--to=weiyongjun1@huawei.com \
--cc=atull@kernel.org \
--cc=hao.wu@intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-fpga@vger.kernel.org \
--cc=luwei.kang@intel.com \
--cc=mdf@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).