* [PATCH v2] fpga: dfl: pci: add device id for Intel FPGA PAC N3000
@ 2020-07-13 1:47 Xu Yilun
2020-07-13 2:02 ` Moritz Fischer
2020-07-13 14:36 ` Tom Rix
0 siblings, 2 replies; 4+ messages in thread
From: Xu Yilun @ 2020-07-13 1:47 UTC (permalink / raw)
To: mdf, linux-fpga, linux-kernel
Cc: trix, lgoncalv, yilun.xu, Wu Hao, Matthew Gerlach, Russ Weight
Add PCIe Device ID for Intel FPGA PAC N3000.
Signed-off-by: Wu Hao <hao.wu@intel.com>
Signed-off-by: Xu Yilun <yilun.xu@intel.com>
Signed-off-by: Matthew Gerlach <matthew.gerlach@linux.intel.com>
Signed-off-by: Russ Weight <russell.h.weight@intel.com>
Reviewed-by: Wu Hao <hao.wu@intel.com>
Reviewed-by: Tom Rix <trix@redhat.com>
---
drivers/fpga/dfl-pci.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/fpga/dfl-pci.c b/drivers/fpga/dfl-pci.c
index 73b5153..e220bec 100644
--- a/drivers/fpga/dfl-pci.c
+++ b/drivers/fpga/dfl-pci.c
@@ -64,6 +64,7 @@ static void cci_pci_free_irq(struct pci_dev *pcidev)
#define PCIE_DEVICE_ID_PF_INT_5_X 0xBCBD
#define PCIE_DEVICE_ID_PF_INT_6_X 0xBCC0
#define PCIE_DEVICE_ID_PF_DSC_1_X 0x09C4
+#define PCIE_DEVICE_ID_INTEL_PAC_N3000 0x0B30
/* VF Device */
#define PCIE_DEVICE_ID_VF_INT_5_X 0xBCBF
#define PCIE_DEVICE_ID_VF_INT_6_X 0xBCC1
@@ -76,6 +77,7 @@ static struct pci_device_id cci_pcie_id_tbl[] = {
{PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCIE_DEVICE_ID_VF_INT_6_X),},
{PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCIE_DEVICE_ID_PF_DSC_1_X),},
{PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCIE_DEVICE_ID_VF_DSC_1_X),},
+ {PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCIE_DEVICE_ID_INTEL_PAC_N3000),},
{0,}
};
MODULE_DEVICE_TABLE(pci, cci_pcie_id_tbl);
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v2] fpga: dfl: pci: add device id for Intel FPGA PAC N3000
2020-07-13 1:47 [PATCH v2] fpga: dfl: pci: add device id for Intel FPGA PAC N3000 Xu Yilun
@ 2020-07-13 2:02 ` Moritz Fischer
2020-07-13 14:36 ` Tom Rix
1 sibling, 0 replies; 4+ messages in thread
From: Moritz Fischer @ 2020-07-13 2:02 UTC (permalink / raw)
To: Xu Yilun
Cc: mdf, linux-fpga, linux-kernel, trix, lgoncalv, Wu Hao,
Matthew Gerlach, Russ Weight
On Mon, Jul 13, 2020 at 09:47:46AM +0800, Xu Yilun wrote:
> Add PCIe Device ID for Intel FPGA PAC N3000.
>
> Signed-off-by: Wu Hao <hao.wu@intel.com>
> Signed-off-by: Xu Yilun <yilun.xu@intel.com>
> Signed-off-by: Matthew Gerlach <matthew.gerlach@linux.intel.com>
> Signed-off-by: Russ Weight <russell.h.weight@intel.com>
> Reviewed-by: Wu Hao <hao.wu@intel.com>
> Reviewed-by: Tom Rix <trix@redhat.com>
> ---
> drivers/fpga/dfl-pci.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/fpga/dfl-pci.c b/drivers/fpga/dfl-pci.c
> index 73b5153..e220bec 100644
> --- a/drivers/fpga/dfl-pci.c
> +++ b/drivers/fpga/dfl-pci.c
> @@ -64,6 +64,7 @@ static void cci_pci_free_irq(struct pci_dev *pcidev)
> #define PCIE_DEVICE_ID_PF_INT_5_X 0xBCBD
> #define PCIE_DEVICE_ID_PF_INT_6_X 0xBCC0
> #define PCIE_DEVICE_ID_PF_DSC_1_X 0x09C4
> +#define PCIE_DEVICE_ID_INTEL_PAC_N3000 0x0B30
> /* VF Device */
> #define PCIE_DEVICE_ID_VF_INT_5_X 0xBCBF
> #define PCIE_DEVICE_ID_VF_INT_6_X 0xBCC1
> @@ -76,6 +77,7 @@ static struct pci_device_id cci_pcie_id_tbl[] = {
> {PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCIE_DEVICE_ID_VF_INT_6_X),},
> {PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCIE_DEVICE_ID_PF_DSC_1_X),},
> {PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCIE_DEVICE_ID_VF_DSC_1_X),},
> + {PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCIE_DEVICE_ID_INTEL_PAC_N3000),},
> {0,}
> };
> MODULE_DEVICE_TABLE(pci, cci_pcie_id_tbl);
> --
> 2.7.4
>
Applied to for-next,
Thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2] fpga: dfl: pci: add device id for Intel FPGA PAC N3000
2020-07-13 1:47 [PATCH v2] fpga: dfl: pci: add device id for Intel FPGA PAC N3000 Xu Yilun
2020-07-13 2:02 ` Moritz Fischer
@ 2020-07-13 14:36 ` Tom Rix
2020-07-14 6:01 ` Xu Yilun
1 sibling, 1 reply; 4+ messages in thread
From: Tom Rix @ 2020-07-13 14:36 UTC (permalink / raw)
To: Xu Yilun, mdf, linux-fpga, linux-kernel
Cc: lgoncalv, Wu Hao, Matthew Gerlach, Russ Weight
> @@ -64,6 +64,7 @@ static void cci_pci_free_irq(struct pci_dev *pcidev)
> #define PCIE_DEVICE_ID_PF_INT_5_X 0xBCBD
> #define PCIE_DEVICE_ID_PF_INT_6_X 0xBCC0
> #define PCIE_DEVICE_ID_PF_DSC_1_X 0x09C4
> +#define PCIE_DEVICE_ID_INTEL_PAC_N3000 0x0B30
My point about consistency. These are all intel and all should have their pf parts removed.
#define PCIE_DEVICE_ID_INTEL_INT_5_X 0xBCBD
#define PCIE_DEVICE_ID_INTEL_INT_6_X 0xBCC0
#define PCIE_DEVICE_ID_INTEL_DSC_1_X 0x09C4
Let's revisit this for the d5005.
trix
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] fpga: dfl: pci: add device id for Intel FPGA PAC N3000
2020-07-13 14:36 ` Tom Rix
@ 2020-07-14 6:01 ` Xu Yilun
0 siblings, 0 replies; 4+ messages in thread
From: Xu Yilun @ 2020-07-14 6:01 UTC (permalink / raw)
To: Tom Rix
Cc: mdf, linux-fpga, linux-kernel, lgoncalv, Wu Hao, Matthew Gerlach,
Russ Weight
On Mon, Jul 13, 2020 at 07:36:26AM -0700, Tom Rix wrote:
>
> > @@ -64,6 +64,7 @@ static void cci_pci_free_irq(struct pci_dev *pcidev)
> > #define PCIE_DEVICE_ID_PF_INT_5_X 0xBCBD
> > #define PCIE_DEVICE_ID_PF_INT_6_X 0xBCC0
> > #define PCIE_DEVICE_ID_PF_DSC_1_X 0x09C4
> > +#define PCIE_DEVICE_ID_INTEL_PAC_N3000 0x0B30
>
> My point about consistency.� These are all intel� and all should have their pf parts removed.
>
> #define PCIE_DEVICE_ID_INTEL_INT_5_X 0xBCBD
> #define PCIE_DEVICE_ID_INTEL_INT_6_X 0xBCC0
> #define PCIE_DEVICE_ID_INTEL_DSC_1_X 0x09C4
>
> Let's revisit this for the d5005.
I agree that we should be consistent on the naming. I think we could
reconsider the naming of previous cards and submit a new patch for them.
>
> trix
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-07-14 6:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-07-13 1:47 [PATCH v2] fpga: dfl: pci: add device id for Intel FPGA PAC N3000 Xu Yilun
2020-07-13 2:02 ` Moritz Fischer
2020-07-13 14:36 ` Tom Rix
2020-07-14 6:01 ` Xu Yilun
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).