From: Tom Rix <trix@redhat.com>
To: Russ Weight <russell.h.weight@intel.com>,
mdf@kernel.org, linux-fpga@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: lgoncalv@redhat.com, yilun.xu@intel.com, hao.wu@intel.com,
matthew.gerlach@intel.com
Subject: Re: [PATCH v3 1/1] fpga: dfl: afu: harden port enable logic
Date: Wed, 3 Feb 2021 07:25:41 -0800 [thread overview]
Message-ID: <15f90871-170c-3487-0f99-47cf54163bb7@redhat.com> (raw)
In-Reply-To: <20210202230631.198950-1-russell.h.weight@intel.com>
..snip..
On 2/2/21 3:06 PM, Russ Weight wrote:
> diff --git a/drivers/fpga/dfl-afu.h b/drivers/fpga/dfl-afu.h
> index 576e94960086..e5020e2b1f3d 100644
> --- a/drivers/fpga/dfl-afu.h
> +++ b/drivers/fpga/dfl-afu.h
> @@ -80,7 +80,7 @@ struct dfl_afu {
> };
>
> /* hold pdata->lock when call __afu_port_enable/disable */
> -void __afu_port_enable(struct platform_device *pdev);
> +int __afu_port_enable(struct platform_device *pdev);
> int __afu_port_disable(struct platform_device *pdev);
>
Should the '__' prefix be removed from __afu_port* ?
This would make the function names consistent with the other decls
Tom
> void afu_mmio_region_init(struct dfl_feature_platform_data *pdata);
next prev parent reply other threads:[~2021-02-03 15:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-02 23:06 [PATCH v3 1/1] fpga: dfl: afu: harden port enable logic Russ Weight
2021-02-03 9:01 ` Wu, Hao
2021-02-03 22:55 ` Russ Weight
2021-02-04 1:38 ` Wu, Hao
2021-02-04 17:59 ` Russ Weight
2021-02-03 15:25 ` Tom Rix [this message]
2021-02-03 23:06 ` Russ Weight
2021-02-04 14:24 ` Tom Rix
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15f90871-170c-3487-0f99-47cf54163bb7@redhat.com \
--to=trix@redhat.com \
--cc=hao.wu@intel.com \
--cc=lgoncalv@redhat.com \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.gerlach@intel.com \
--cc=mdf@kernel.org \
--cc=russell.h.weight@intel.com \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).