From: Rob Herring <robh@kernel.org>
To: Nava kishore Manne <nava.manne@xilinx.com>
Cc: Appana Durga Kedareswara rao <appana.durga.rao@xilinx.com>,
linux-kernel@vger.kernel.org, mdf@kernel.org, robh+dt@kernel.org,
trix@redhat.com, devicetree@vger.kernel.org, git@xilinx.com,
linux-fpga@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
chinnikishore369@gmail.com, michal.simek@xilinx.com
Subject: Re: [PATCH 2/3] dt-bindings: fpga: Add binding doc for versal fpga manager
Date: Mon, 18 Jan 2021 09:47:02 -0600 [thread overview]
Message-ID: <1610984822.721524.3984438.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <20210118024318.9530-2-nava.manne@xilinx.com>
On Mon, 18 Jan 2021 08:13:17 +0530, Nava kishore Manne wrote:
> From: Appana Durga Kedareswara rao <appana.durga.rao@xilinx.com>
>
> This patch adds binding doc for versal fpga manager driver.
>
> Signed-off-by: Nava kishore Manne <nava.manne@xilinx.com>
> Signed-off-by: Appana Durga Kedareswara rao <appana.durga.rao@xilinx.com>
> ---
> .../bindings/fpga/xlnx,versal-fpga.yaml | 33 +++++++++++++++++++
> 1 file changed, 33 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/fpga/xlnx,versal-fpga.yaml
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
./Documentation/devicetree/bindings/fpga/xlnx,versal-fpga.yaml:15:1: [error] syntax error: could not find expected ':' (syntax)
dtschema/dtc warnings/errors:
make[1]: *** Deleting file 'Documentation/devicetree/bindings/fpga/xlnx,versal-fpga.example.dts'
Traceback (most recent call last):
File "/usr/local/bin/dt-extract-example", line 45, in <module>
binding = yaml.load(open(args.yamlfile, encoding='utf-8').read())
File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/main.py", line 343, in load
return constructor.get_single_data()
File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/constructor.py", line 111, in get_single_data
node = self.composer.get_single_node()
File "_ruamel_yaml.pyx", line 706, in _ruamel_yaml.CParser.get_single_node
File "_ruamel_yaml.pyx", line 724, in _ruamel_yaml.CParser._compose_document
File "_ruamel_yaml.pyx", line 775, in _ruamel_yaml.CParser._compose_node
File "_ruamel_yaml.pyx", line 891, in _ruamel_yaml.CParser._compose_mapping_node
File "_ruamel_yaml.pyx", line 904, in _ruamel_yaml.CParser._parse_next_event
ruamel.yaml.scanner.ScannerError: while scanning a simple key
in "<unicode string>", line 14, column 1
could not find expected ':'
in "<unicode string>", line 15, column 1
make[1]: *** [Documentation/devicetree/bindings/Makefile:20: Documentation/devicetree/bindings/fpga/xlnx,versal-fpga.example.dts] Error 1
make[1]: *** Waiting for unfinished jobs....
./Documentation/devicetree/bindings/fpga/xlnx,versal-fpga.yaml: while scanning a simple key
in "<unicode string>", line 14, column 1
could not find expected ':'
in "<unicode string>", line 15, column 1
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/fpga/xlnx,versal-fpga.yaml: ignoring, error parsing file
warning: no schema found in file: ./Documentation/devicetree/bindings/fpga/xlnx,versal-fpga.yaml
make: *** [Makefile:1370: dt_binding_check] Error 2
See https://patchwork.ozlabs.org/patch/1427979
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
next prev parent reply other threads:[~2021-01-18 15:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-18 2:43 [PATCH 1/3] drivers: firmware: Add Pdi load API support Nava kishore Manne
2021-01-18 2:43 ` [PATCH 2/3] dt-bindings: fpga: Add binding doc for versal fpga manager Nava kishore Manne
2021-01-18 8:52 ` Michal Simek
2021-01-22 9:44 ` Nava kishore Manne
2021-01-18 15:47 ` Rob Herring [this message]
2021-01-18 2:43 ` [PATCH 3/3] fpga: versal-fpga: Add versal fpga manager driver Nava kishore Manne
2021-01-19 0:33 ` Moritz Fischer
2021-01-22 10:34 ` Nava kishore Manne
2021-01-23 23:33 ` Moritz Fischer
2021-01-27 8:57 ` Nava kishore Manne
2021-01-27 9:16 ` Michal Simek
2021-01-27 21:44 ` Moritz Fischer
2021-02-03 9:26 ` Nava kishore Manne
2021-01-23 23:35 ` [PATCH 1/3] drivers: firmware: Add Pdi load API support Moritz Fischer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1610984822.721524.3984438.nullmailer@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=appana.durga.rao@xilinx.com \
--cc=chinnikishore369@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=git@xilinx.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mdf@kernel.org \
--cc=michal.simek@xilinx.com \
--cc=nava.manne@xilinx.com \
--cc=robh+dt@kernel.org \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).