* [PATCH -next] fpga: region: fix kernel-doc
@ 2021-12-03 2:44 Yang Li
2021-12-03 3:02 ` Randy Dunlap
0 siblings, 1 reply; 3+ messages in thread
From: Yang Li @ 2021-12-03 2:44 UTC (permalink / raw)
To: mdf
Cc: hao.wu, yilun.xu, trix, nathan, ndesaulniers, linux-fpga,
linux-kernel, llvm, Yang Li
Fix function name in of-fpga-region.c kernel-doc comment
to remove a warning found by clang(make W=1 LLVM=1).
drivers/fpga/of-fpga-region.c:451: warning: expecting prototype for
fpga_region_init(). Prototype was for of_fpga_region_init() instead.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
drivers/fpga/of-fpga-region.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/fpga/of-fpga-region.c b/drivers/fpga/of-fpga-region.c
index 9c662db..50b8305 100644
--- a/drivers/fpga/of-fpga-region.c
+++ b/drivers/fpga/of-fpga-region.c
@@ -444,7 +444,7 @@ static int of_fpga_region_remove(struct platform_device *pdev)
};
/**
- * fpga_region_init - init function for fpga_region class
+ * of_fpga_region_init - init function for fpga_region class
* Creates the fpga_region class and registers a reconfig notifier.
*/
static int __init of_fpga_region_init(void)
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] fpga: region: fix kernel-doc
2021-12-03 2:44 [PATCH -next] fpga: region: fix kernel-doc Yang Li
@ 2021-12-03 3:02 ` Randy Dunlap
2021-12-03 4:11 ` Moritz Fischer
0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2021-12-03 3:02 UTC (permalink / raw)
To: Yang Li, mdf
Cc: hao.wu, yilun.xu, trix, nathan, ndesaulniers, linux-fpga,
linux-kernel, llvm
Hi--
On 12/2/21 18:44, Yang Li wrote:
> Fix function name in of-fpga-region.c kernel-doc comment
> to remove a warning found by clang(make W=1 LLVM=1).
The patch below looks good, but the commit message about
"found by clang" is not correct. Using 'make W=1' causes
scripts/kernel-doc to run, and this warning message is from kernel-doc,
not from clang.
> drivers/fpga/of-fpga-region.c:451: warning: expecting prototype for
> fpga_region_init(). Prototype was for of_fpga_region_init() instead.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
> drivers/fpga/of-fpga-region.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/fpga/of-fpga-region.c b/drivers/fpga/of-fpga-region.c
> index 9c662db..50b8305 100644
> --- a/drivers/fpga/of-fpga-region.c
> +++ b/drivers/fpga/of-fpga-region.c
> @@ -444,7 +444,7 @@ static int of_fpga_region_remove(struct platform_device *pdev)
> };
>
> /**
> - * fpga_region_init - init function for fpga_region class
> + * of_fpga_region_init - init function for fpga_region class
> * Creates the fpga_region class and registers a reconfig notifier.
> */
> static int __init of_fpga_region_init(void)
>
thanks.
--
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] fpga: region: fix kernel-doc
2021-12-03 3:02 ` Randy Dunlap
@ 2021-12-03 4:11 ` Moritz Fischer
0 siblings, 0 replies; 3+ messages in thread
From: Moritz Fischer @ 2021-12-03 4:11 UTC (permalink / raw)
To: Randy Dunlap
Cc: Yang Li, mdf, hao.wu, yilun.xu, trix, nathan, ndesaulniers,
linux-fpga, linux-kernel, llvm
Hi Yang,
On Thu, Dec 02, 2021 at 07:02:16PM -0800, Randy Dunlap wrote:
> Hi--
>
> On 12/2/21 18:44, Yang Li wrote:
> > Fix function name in of-fpga-region.c kernel-doc comment
> > to remove a warning found by clang(make W=1 LLVM=1).
>
> The patch below looks good, but the commit message about
> "found by clang" is not correct. Using 'make W=1' causes
> scripts/kernel-doc to run, and this warning message is from kernel-doc,
> not from clang.
>
> > drivers/fpga/of-fpga-region.c:451: warning: expecting prototype for
> > fpga_region_init(). Prototype was for of_fpga_region_init() instead.
> >
> > Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> > ---
> > drivers/fpga/of-fpga-region.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/fpga/of-fpga-region.c b/drivers/fpga/of-fpga-region.c
> > index 9c662db..50b8305 100644
> > --- a/drivers/fpga/of-fpga-region.c
> > +++ b/drivers/fpga/of-fpga-region.c
> > @@ -444,7 +444,7 @@ static int of_fpga_region_remove(struct platform_device *pdev)
> > };
> >
> > /**
> > - * fpga_region_init - init function for fpga_region class
> > + * of_fpga_region_init - init function for fpga_region class
> > * Creates the fpga_region class and registers a reconfig notifier.
> > */
> > static int __init of_fpga_region_init(void)
> >
>
> thanks.
> --
> ~Randy
Can you resend with these addressed?
Thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-12-03 4:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-03 2:44 [PATCH -next] fpga: region: fix kernel-doc Yang Li
2021-12-03 3:02 ` Randy Dunlap
2021-12-03 4:11 ` Moritz Fischer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).