From: Anatolij Gustschin <agust@denx.de>
To: Moritz Fischer <mdf@kernel.org>
Cc: linux-fpga@vger.kernel.org,
Devicetree List <devicetree@vger.kernel.org>,
Alan Tull <atull@opensource.altera.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH v2 2/2] fpga manager: Add Xilinx slave serial SPI driver
Date: Mon, 20 Feb 2017 21:05:04 +0100 [thread overview]
Message-ID: <20170220210504.2473ce90@crub> (raw)
In-Reply-To: <CAAtXAHeO_+6ZXP51nxFgyLYR9cjqLrqmoYEniqXmZudF=3uhFA@mail.gmail.com>
Hi Moritz,
On Mon, 20 Feb 2017 09:27:35 -0800
Moritz Fischer mdf@kernel.org wrote:
>Anatolij,
>
>small nits inline.
...
>> + gpiod_set_value(conf->prog_b, 1);
>> +
>> + udelay(1); /* min is 500 ns */
>
>Maybe make this a named constant.
Okay, I can add
const size_t prog_pulse_us = 1;
...
udelay(prog_pulse_us);
...
>> + gpiod_set_value(conf->prog_b, 0);
>> +
>> + if (gpiod_get_value(conf->done)) {
>> + dev_err(&mgr->dev, "Unexpected DONE pin state...\n");
>> + return -EIO;
>> + }
>> +
>> + /* program latency */
>> + usleep_range(1000, 1500);
>
>Same here.
Okay, will change here as well.
Thanks for review! I'll wait some time for more comments and
will submit v3 then.
Anatolij
parent reply other threads:[~2017-02-20 20:05 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <CAAtXAHeO_+6ZXP51nxFgyLYR9cjqLrqmoYEniqXmZudF=3uhFA@mail.gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170220210504.2473ce90@crub \
--to=agust@denx.de \
--cc=atull@opensource.altera.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-fpga@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mdf@kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).