From: Anatolij Gustschin <agust@denx.de>
To: Alan Tull <atull@kernel.org>
Cc: linux-fpga@vger.kernel.org, Moritz Fischer <mdf@kernel.org>,
Joshua Clayton <stillcompiling@gmail.com>
Subject: Re: [PATCH] fpga-manager: altera-ps-spi: enable usage on non-dt platforms
Date: Mon, 12 Feb 2018 17:49:02 +0100 [thread overview]
Message-ID: <20180212174902.2ecb2eed@crub> (raw)
In-Reply-To: <CANk1AXQ7-caSN=7Xtqokpq80Rh77XTZhP7d7P4L7d9V6mgoq4w@mail.gmail.com>
Hi Alan,
On Mon, 12 Feb 2018 10:19:06 -0600
Alan Tull atull@kernel.org wrote:
...
>> + if (spi->dev.of_node) {
>> + of_id = of_match_device(of_ef_match, &spi->dev);
>> + if (!of_id)
>> + return -ENODEV;
>> +
>> + conf->data = of_id->data;
>> + } else {
>> + id = spi_get_device_id(spi);
>> + if (!id)
>> + return -ENODEV;
>
>Is it actually possible for !id at this point? Seems like if we are
>in this probe function and we get this far, this would always succeed.
Yes, !id should be always false here. I'll drop this check then.
Thanks,
Anatolij
prev parent reply other threads:[~2018-02-12 16:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-01 22:31 [PATCH] fpga-manager: altera-ps-spi: enable usage on non-dt platforms Anatolij Gustschin
2018-02-12 16:19 ` Alan Tull
2018-02-12 16:49 ` Anatolij Gustschin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180212174902.2ecb2eed@crub \
--to=agust@denx.de \
--cc=atull@kernel.org \
--cc=linux-fpga@vger.kernel.org \
--cc=mdf@kernel.org \
--cc=stillcompiling@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox