* [PATCH 1/2] fpga: of-fpga-region: Use platform_set_drvdata
@ 2018-08-24 15:25 Moritz Fischer
2018-08-24 15:25 ` [PATCH 2/2] fpga: dfl-fme-region: Use platform_get_drvdata() Moritz Fischer
2018-08-26 21:20 ` [PATCH 1/2] fpga: of-fpga-region: Use platform_set_drvdata Alan Tull
0 siblings, 2 replies; 5+ messages in thread
From: Moritz Fischer @ 2018-08-24 15:25 UTC (permalink / raw)
To: hao.wu, atull; +Cc: linux-fpga, linux-kernel, Moritz Fischer
Use platform_set_drvdata rather than dev_set_drvdata
to match the platform_get_drvdata in the _remove()
function of the platform driver.
Signed-off-by: Moritz Fischer <mdf@kernel.org>
---
drivers/fpga/of-fpga-region.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/fpga/of-fpga-region.c b/drivers/fpga/of-fpga-region.c
index 35fabb8083fb..8c6120e30930 100644
--- a/drivers/fpga/of-fpga-region.c
+++ b/drivers/fpga/of-fpga-region.c
@@ -421,7 +421,7 @@ static int of_fpga_region_probe(struct platform_device *pdev)
goto eprobe_free;
of_platform_populate(np, fpga_region_of_match, NULL, ®ion->dev);
- dev_set_drvdata(dev, region);
+ platform_set_drvdata(pdev, region);
dev_info(dev, "FPGA Region probed\n");
--
2.18.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] fpga: dfl-fme-region: Use platform_get_drvdata()
2018-08-24 15:25 [PATCH 1/2] fpga: of-fpga-region: Use platform_set_drvdata Moritz Fischer
@ 2018-08-24 15:25 ` Moritz Fischer
2018-08-24 18:16 ` Wu Hao
2018-08-26 21:21 ` Alan Tull
2018-08-26 21:20 ` [PATCH 1/2] fpga: of-fpga-region: Use platform_set_drvdata Alan Tull
1 sibling, 2 replies; 5+ messages in thread
From: Moritz Fischer @ 2018-08-24 15:25 UTC (permalink / raw)
To: hao.wu, atull; +Cc: linux-fpga, linux-kernel, Moritz Fischer
Use platform_get_drvdata() in remove() function of
the platform driver rather than dev_get_drvdata()
to match the platform_set_drvdata in the probe().
Signed-off-by: Moritz Fischer <mdf@kernel.org>
---
drivers/fpga/dfl-fme-region.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/fpga/dfl-fme-region.c b/drivers/fpga/dfl-fme-region.c
index 0b7e19c27c6d..11d3c23a8936 100644
--- a/drivers/fpga/dfl-fme-region.c
+++ b/drivers/fpga/dfl-fme-region.c
@@ -65,7 +65,7 @@ static int fme_region_probe(struct platform_device *pdev)
static int fme_region_remove(struct platform_device *pdev)
{
- struct fpga_region *region = dev_get_drvdata(&pdev->dev);
+ struct fpga_region *region = platform_get_drvdata(pdev);
fpga_region_unregister(region);
fpga_mgr_put(region->mgr);
--
2.18.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH 2/2] fpga: dfl-fme-region: Use platform_get_drvdata()
2018-08-24 15:25 ` [PATCH 2/2] fpga: dfl-fme-region: Use platform_get_drvdata() Moritz Fischer
@ 2018-08-24 18:16 ` Wu Hao
2018-08-26 21:21 ` Alan Tull
1 sibling, 0 replies; 5+ messages in thread
From: Wu Hao @ 2018-08-24 18:16 UTC (permalink / raw)
To: Moritz Fischer; +Cc: atull, linux-fpga, linux-kernel
On Fri, Aug 24, 2018 at 08:25:13AM -0700, Moritz Fischer wrote:
> Use platform_get_drvdata() in remove() function of
> the platform driver rather than dev_get_drvdata()
> to match the platform_set_drvdata in the probe().
Hi Moritz,
Thanks for this patch, it looks good to me. : )
Hao
>
> Signed-off-by: Moritz Fischer <mdf@kernel.org>
> ---
> drivers/fpga/dfl-fme-region.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/fpga/dfl-fme-region.c b/drivers/fpga/dfl-fme-region.c
> index 0b7e19c27c6d..11d3c23a8936 100644
> --- a/drivers/fpga/dfl-fme-region.c
> +++ b/drivers/fpga/dfl-fme-region.c
> @@ -65,7 +65,7 @@ static int fme_region_probe(struct platform_device *pdev)
>
> static int fme_region_remove(struct platform_device *pdev)
> {
> - struct fpga_region *region = dev_get_drvdata(&pdev->dev);
> + struct fpga_region *region = platform_get_drvdata(pdev);
>
> fpga_region_unregister(region);
> fpga_mgr_put(region->mgr);
> --
> 2.18.0
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 2/2] fpga: dfl-fme-region: Use platform_get_drvdata()
2018-08-24 15:25 ` [PATCH 2/2] fpga: dfl-fme-region: Use platform_get_drvdata() Moritz Fischer
2018-08-24 18:16 ` Wu Hao
@ 2018-08-26 21:21 ` Alan Tull
1 sibling, 0 replies; 5+ messages in thread
From: Alan Tull @ 2018-08-26 21:21 UTC (permalink / raw)
To: Moritz Fischer; +Cc: Wu Hao, linux-fpga, linux-kernel
On Fri, Aug 24, 2018 at 10:26 AM Moritz Fischer <mdf@kernel.org> wrote:
>
> Use platform_get_drvdata() in remove() function of
> the platform driver rather than dev_get_drvdata()
> to match the platform_set_drvdata in the probe().
>
> Signed-off-by: Moritz Fischer <mdf@kernel.org>
Acked-by: Alan Tull <atull@kernel.org>
Thanks,
Alan
> ---
> drivers/fpga/dfl-fme-region.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/fpga/dfl-fme-region.c b/drivers/fpga/dfl-fme-region.c
> index 0b7e19c27c6d..11d3c23a8936 100644
> --- a/drivers/fpga/dfl-fme-region.c
> +++ b/drivers/fpga/dfl-fme-region.c
> @@ -65,7 +65,7 @@ static int fme_region_probe(struct platform_device *pdev)
>
> static int fme_region_remove(struct platform_device *pdev)
> {
> - struct fpga_region *region = dev_get_drvdata(&pdev->dev);
> + struct fpga_region *region = platform_get_drvdata(pdev);
>
> fpga_region_unregister(region);
> fpga_mgr_put(region->mgr);
> --
> 2.18.0
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] fpga: of-fpga-region: Use platform_set_drvdata
2018-08-24 15:25 [PATCH 1/2] fpga: of-fpga-region: Use platform_set_drvdata Moritz Fischer
2018-08-24 15:25 ` [PATCH 2/2] fpga: dfl-fme-region: Use platform_get_drvdata() Moritz Fischer
@ 2018-08-26 21:20 ` Alan Tull
1 sibling, 0 replies; 5+ messages in thread
From: Alan Tull @ 2018-08-26 21:20 UTC (permalink / raw)
To: Moritz Fischer; +Cc: Wu Hao, linux-fpga, linux-kernel
On Fri, Aug 24, 2018 at 10:26 AM Moritz Fischer <mdf@kernel.org> wrote:
Hi Moritz,
Looks good. Thanks for the patches!
>
> Use platform_set_drvdata rather than dev_set_drvdata
> to match the platform_get_drvdata in the _remove()
> function of the platform driver.
>
> Signed-off-by: Moritz Fischer <mdf@kernel.org>
Acked-by: Alan Tull <atull@kernel.org>
> ---
> drivers/fpga/of-fpga-region.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/fpga/of-fpga-region.c b/drivers/fpga/of-fpga-region.c
> index 35fabb8083fb..8c6120e30930 100644
> --- a/drivers/fpga/of-fpga-region.c
> +++ b/drivers/fpga/of-fpga-region.c
> @@ -421,7 +421,7 @@ static int of_fpga_region_probe(struct platform_device *pdev)
> goto eprobe_free;
>
> of_platform_populate(np, fpga_region_of_match, NULL, ®ion->dev);
> - dev_set_drvdata(dev, region);
> + platform_set_drvdata(pdev, region);
>
> dev_info(dev, "FPGA Region probed\n");
>
> --
> 2.18.0
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-08-26 21:21 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-24 15:25 [PATCH 1/2] fpga: of-fpga-region: Use platform_set_drvdata Moritz Fischer
2018-08-24 15:25 ` [PATCH 2/2] fpga: dfl-fme-region: Use platform_get_drvdata() Moritz Fischer
2018-08-24 18:16 ` Wu Hao
2018-08-26 21:21 ` Alan Tull
2018-08-26 21:20 ` [PATCH 1/2] fpga: of-fpga-region: Use platform_set_drvdata Alan Tull
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).