* [PATCH -next] fpga: dfl: fme: remove set but not used variable 'priv'
@ 2018-09-14 1:33 YueHaibing
2018-09-14 10:23 ` Wu Hao
0 siblings, 1 reply; 4+ messages in thread
From: YueHaibing @ 2018-09-14 1:33 UTC (permalink / raw)
To: Wu Hao, Alan Tull, Moritz Fischer; +Cc: YueHaibing, linux-fpga, kernel-janitors
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/fpga/dfl-fme-pr.c: In function 'pr_mgmt_uinit':
drivers/fpga/dfl-fme-pr.c:447:18: warning:
variable 'priv' set but not used [-Wunused-but-set-variable]
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/fpga/dfl-fme-pr.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/fpga/dfl-fme-pr.c b/drivers/fpga/dfl-fme-pr.c
index 0b84053..fe5a557 100644
--- a/drivers/fpga/dfl-fme-pr.c
+++ b/drivers/fpga/dfl-fme-pr.c
@@ -444,10 +444,8 @@ static void pr_mgmt_uinit(struct platform_device *pdev,
struct dfl_feature *feature)
{
struct dfl_feature_platform_data *pdata = dev_get_platdata(&pdev->dev);
- struct dfl_fme *priv;
mutex_lock(&pdata->lock);
- priv = dfl_fpga_pdata_get_private(pdata);
dfl_fme_destroy_regions(pdata);
dfl_fme_destroy_bridges(pdata);
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH -next] fpga: dfl: fme: remove set but not used variable 'priv'
2018-09-14 1:33 [PATCH -next] fpga: dfl: fme: remove set but not used variable 'priv' YueHaibing
@ 2018-09-14 10:23 ` Wu Hao
2018-09-14 16:18 ` Moritz Fischer
0 siblings, 1 reply; 4+ messages in thread
From: Wu Hao @ 2018-09-14 10:23 UTC (permalink / raw)
To: YueHaibing; +Cc: Alan Tull, Moritz Fischer, linux-fpga, kernel-janitors
On Fri, Sep 14, 2018 at 01:33:36AM +0000, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/fpga/dfl-fme-pr.c: In function 'pr_mgmt_uinit':
> drivers/fpga/dfl-fme-pr.c:447:18: warning:
> variable 'priv' set but not used [-Wunused-but-set-variable]
Looks good to me, thanks for this fixing.
Thanks
Hao
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/fpga/dfl-fme-pr.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/fpga/dfl-fme-pr.c b/drivers/fpga/dfl-fme-pr.c
> index 0b84053..fe5a557 100644
> --- a/drivers/fpga/dfl-fme-pr.c
> +++ b/drivers/fpga/dfl-fme-pr.c
> @@ -444,10 +444,8 @@ static void pr_mgmt_uinit(struct platform_device *pdev,
> struct dfl_feature *feature)
> {
> struct dfl_feature_platform_data *pdata = dev_get_platdata(&pdev->dev);
> - struct dfl_fme *priv;
>
> mutex_lock(&pdata->lock);
> - priv = dfl_fpga_pdata_get_private(pdata);
>
> dfl_fme_destroy_regions(pdata);
> dfl_fme_destroy_bridges(pdata);
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH -next] fpga: dfl: fme: remove set but not used variable 'priv'
2018-09-14 10:23 ` Wu Hao
@ 2018-09-14 16:18 ` Moritz Fischer
2018-09-15 1:52 ` Wu Hao
0 siblings, 1 reply; 4+ messages in thread
From: Moritz Fischer @ 2018-09-14 16:18 UTC (permalink / raw)
To: Wu Hao; +Cc: YueHaibing, Alan Tull, linux-fpga, kernel-janitors
Hi,
On Fri, Sep 14, 2018 at 3:23 AM, Wu Hao <hao.wu@intel.com> wrote:
> On Fri, Sep 14, 2018 at 01:33:36AM +0000, YueHaibing wrote:
>> Fixes gcc '-Wunused-but-set-variable' warning:
>>
>> drivers/fpga/dfl-fme-pr.c: In function 'pr_mgmt_uinit':
>> drivers/fpga/dfl-fme-pr.c:447:18: warning:
>> variable 'priv' set but not used [-Wunused-but-set-variable]
>
> Looks good to me, thanks for this fixing.
Hao, is this an Acked-by? :)
>
> Thanks
> Hao
>
>>
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Acked-by: Moritz Fischer <mdf@kernel.org>
>> ---
>> drivers/fpga/dfl-fme-pr.c | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/fpga/dfl-fme-pr.c b/drivers/fpga/dfl-fme-pr.c
>> index 0b84053..fe5a557 100644
>> --- a/drivers/fpga/dfl-fme-pr.c
>> +++ b/drivers/fpga/dfl-fme-pr.c
>> @@ -444,10 +444,8 @@ static void pr_mgmt_uinit(struct platform_device *pdev,
>> struct dfl_feature *feature)
>> {
>> struct dfl_feature_platform_data *pdata = dev_get_platdata(&pdev->dev);
>> - struct dfl_fme *priv;
>>
>> mutex_lock(&pdata->lock);
>> - priv = dfl_fpga_pdata_get_private(pdata);
>>
>> dfl_fme_destroy_regions(pdata);
>> dfl_fme_destroy_bridges(pdata);
Thanks for the patch,
Moritz
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH -next] fpga: dfl: fme: remove set but not used variable 'priv'
2018-09-14 16:18 ` Moritz Fischer
@ 2018-09-15 1:52 ` Wu Hao
0 siblings, 0 replies; 4+ messages in thread
From: Wu Hao @ 2018-09-15 1:52 UTC (permalink / raw)
To: Moritz Fischer; +Cc: YueHaibing, Alan Tull, linux-fpga, kernel-janitors
On Fri, Sep 14, 2018 at 09:18:12AM -0700, Moritz Fischer wrote:
> Hi,
>
> On Fri, Sep 14, 2018 at 3:23 AM, Wu Hao <hao.wu@intel.com> wrote:
> > On Fri, Sep 14, 2018 at 01:33:36AM +0000, YueHaibing wrote:
> >> Fixes gcc '-Wunused-but-set-variable' warning:
> >>
> >> drivers/fpga/dfl-fme-pr.c: In function 'pr_mgmt_uinit':
> >> drivers/fpga/dfl-fme-pr.c:447:18: warning:
> >> variable 'priv' set but not used [-Wunused-but-set-variable]
> >
> > Looks good to me, thanks for this fixing.
>
> Hao, is this an Acked-by? :)
Sure.. thanks for reminding. :)
Acked-by: Wu Hao <hao.wu@intel.com>
Hao
> >
> > Thanks
> > Hao
> >
> >>
> >> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> Acked-by: Moritz Fischer <mdf@kernel.org>
> >> ---
> >> drivers/fpga/dfl-fme-pr.c | 2 --
> >> 1 file changed, 2 deletions(-)
> >>
> >> diff --git a/drivers/fpga/dfl-fme-pr.c b/drivers/fpga/dfl-fme-pr.c
> >> index 0b84053..fe5a557 100644
> >> --- a/drivers/fpga/dfl-fme-pr.c
> >> +++ b/drivers/fpga/dfl-fme-pr.c
> >> @@ -444,10 +444,8 @@ static void pr_mgmt_uinit(struct platform_device *pdev,
> >> struct dfl_feature *feature)
> >> {
> >> struct dfl_feature_platform_data *pdata = dev_get_platdata(&pdev->dev);
> >> - struct dfl_fme *priv;
> >>
> >> mutex_lock(&pdata->lock);
> >> - priv = dfl_fpga_pdata_get_private(pdata);
> >>
> >> dfl_fme_destroy_regions(pdata);
> >> dfl_fme_destroy_bridges(pdata);
>
> Thanks for the patch,
>
> Moritz
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-09-15 7:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-14 1:33 [PATCH -next] fpga: dfl: fme: remove set but not used variable 'priv' YueHaibing
2018-09-14 10:23 ` Wu Hao
2018-09-14 16:18 ` Moritz Fischer
2018-09-15 1:52 ` Wu Hao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).