From: Wu Hao <hao.wu@intel.com>
To: Moritz Fischer <moritz.fischer@ettus.com>
Cc: YueHaibing <yuehaibing@huawei.com>, Alan Tull <atull@kernel.org>,
linux-fpga@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH -next] fpga: dfl: fme: remove set but not used variable 'priv'
Date: Sat, 15 Sep 2018 09:52:49 +0800 [thread overview]
Message-ID: <20180915015249.GA25204@hao-dev> (raw)
In-Reply-To: <CAAtXAHeWQ-QsD833ugV6Uqk=FOn8mxvg25FY4tyBJVe0bAf38g@mail.gmail.com>
On Fri, Sep 14, 2018 at 09:18:12AM -0700, Moritz Fischer wrote:
> Hi,
>
> On Fri, Sep 14, 2018 at 3:23 AM, Wu Hao <hao.wu@intel.com> wrote:
> > On Fri, Sep 14, 2018 at 01:33:36AM +0000, YueHaibing wrote:
> >> Fixes gcc '-Wunused-but-set-variable' warning:
> >>
> >> drivers/fpga/dfl-fme-pr.c: In function 'pr_mgmt_uinit':
> >> drivers/fpga/dfl-fme-pr.c:447:18: warning:
> >> variable 'priv' set but not used [-Wunused-but-set-variable]
> >
> > Looks good to me, thanks for this fixing.
>
> Hao, is this an Acked-by? :)
Sure.. thanks for reminding. :)
Acked-by: Wu Hao <hao.wu@intel.com>
Hao
> >
> > Thanks
> > Hao
> >
> >>
> >> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> Acked-by: Moritz Fischer <mdf@kernel.org>
> >> ---
> >> drivers/fpga/dfl-fme-pr.c | 2 --
> >> 1 file changed, 2 deletions(-)
> >>
> >> diff --git a/drivers/fpga/dfl-fme-pr.c b/drivers/fpga/dfl-fme-pr.c
> >> index 0b84053..fe5a557 100644
> >> --- a/drivers/fpga/dfl-fme-pr.c
> >> +++ b/drivers/fpga/dfl-fme-pr.c
> >> @@ -444,10 +444,8 @@ static void pr_mgmt_uinit(struct platform_device *pdev,
> >> struct dfl_feature *feature)
> >> {
> >> struct dfl_feature_platform_data *pdata = dev_get_platdata(&pdev->dev);
> >> - struct dfl_fme *priv;
> >>
> >> mutex_lock(&pdata->lock);
> >> - priv = dfl_fpga_pdata_get_private(pdata);
> >>
> >> dfl_fme_destroy_regions(pdata);
> >> dfl_fme_destroy_bridges(pdata);
>
> Thanks for the patch,
>
> Moritz
prev parent reply other threads:[~2018-09-15 7:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-14 1:33 [PATCH -next] fpga: dfl: fme: remove set but not used variable 'priv' YueHaibing
2018-09-14 10:23 ` Wu Hao
2018-09-14 16:18 ` Moritz Fischer
2018-09-15 1:52 ` Wu Hao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180915015249.GA25204@hao-dev \
--to=hao.wu@intel.com \
--cc=atull@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-fpga@vger.kernel.org \
--cc=moritz.fischer@ettus.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).