Re: [PATCH] Add RIFFA PCIe driver to staging tree

Re: [PATCH] Add RIFFA PCIe driver to staging tree

[gregkh]

On Tue, Oct 16, 2018 at 07:41:45AM +0000, Cheng Fei Phung wrote:
> Patch changelog content:
> 
> Add a PCIe linux driver called RIFFA to the linux staging tree. It has full duplex capability compared to the original RIFFA linux driver that you can easily find from https://github.com/KastnerRG/riffa/tree/master/driver/linux
> 
> For more context, please refer to https://github.com/promach/riffa/tree/full_duplex/driver/linux
> 
> 
> 
> phung@UbuntuHW15:~/linux$ cat patches/0001-Added-a-full-duplex-riffa-PCIe-linux-staging-driver..patch
> >From 7c3050c7e86017d85c75c640ea38376f505b2763 Mon Sep 17 00:00:00 2001
> From: promach <feiphung@hotmail.com>
> Date: Mon, 15 Oct 2018 18:28:16 +0800
> Subject: [PATCH] Added a full duplex riffa PCIe linux staging driver.
> �Signed-off-by: PHUNG CHENG FEI (feiphung@hotmail.com)
> 

This whole format is very odd.  Please look at how other patches are
posted to the list.  I need a proper changelog and signed-off-by line in
the correct place.

Also, no need to 'cat' the file here, just use git send-email to send
the patch correctly.

Because of this, all of your tabs got converted to spaces, so the patch
you sent here is corrupted.

Try sending it to yourself first, run the result of that email through
scripts/checkpatch.pl and apply it to the tree to verify that it really
does work.

Also, for staging drivers I need a TODO file that lists the remaining
tasks that are left to be done in order to get the driver out of the
staging portion of the kernel tree.

Look at the patch that was sent today that added a new driver to the
staging portion of the kernel as an example of how to do all of this
correctly.

thanks,

greg k-h

Re: [PATCH] Staging : Add RIFFA PCIe driver

[gregkh]

On Tue, Oct 16, 2018 at 10:54:28AM +0000, Cheng Fei Phung wrote:
> This patch adds RIFFA PCIe linux driver for https://github.com/promach/riffa/tree/full_duplex/driver/linux
> 
> TODO:
> 
> 1) this driver needs further speed optimization although it can now achieve defined PCIe speed grade
> 2) solve all the coding style errors from scripts/checkpatch.pl

Can you please wrap your lines at 72 columns like your editor wanted you
to?  :)

> 
> Signed-off-by: PHUNG CHENG FEI (feiphung@hotmail.com)

So close, you need to use '<' and '>' here, not '(' and ')'

> 
> ---
> Changes in v1:
> � - added full-duplex capability
> 
> �drivers/staging/riffa/Makefile������ |� 157 +++
> �drivers/staging/riffa/README.txt���� |�� 38 +
> �drivers/staging/riffa/circ_queue.c�� |� 188 +++
> �drivers/staging/riffa/circ_queue.h�� |�� 96 ++
> �drivers/staging/riffa/riffa.c������� |� 152 +++
> �drivers/staging/riffa/riffa.h������� |� 121 ++
> �drivers/staging/riffa/riffa_driver.c | 1633 ++++++++++++++++++++++++++
> �drivers/staging/riffa/riffa_driver.h |� 131 +++
> �8 files changed, 2516 insertions(+)
> �create mode 100644 drivers/staging/riffa/Makefile
> �create mode 100644 drivers/staging/riffa/README.txt
> �create mode 100644 drivers/staging/riffa/circ_queue.c
> �create mode 100644 drivers/staging/riffa/circ_queue.h
> �create mode 100644 drivers/staging/riffa/riffa.c
> �create mode 100644 drivers/staging/riffa/riffa.h
> �create mode 100644 drivers/staging/riffa/riffa_driver.c
> �create mode 100644 drivers/staging/riffa/riffa_driver.h

This does not actually add the driver to the kernel build process at
all.  How are you testing this?  You need to hook it up by adding a
Kconfig file and touching the drivers/staging/Kconfig and
drivers/staging/Makefile files to add your code to the build system.

As it is, this doesn't work at all :(

And none of your code has any tabs in it at all.  You should at least
fix that up first, otherwise the very first patch people are going to
be forced to send will be to replace all lines in all of these files
with that type of modification.  It is better if you do that first.

thanks,

greg k-h

Re: [PATCH] Staging : Add RIFFA PCIe driver

[Dan Carpenter]

Please make the subject be:

[PATCH] Staging: riffa: Add new RIFFA PCIe driver

On Tue, Oct 16, 2018 at 10:54:28AM +0000, Cheng Fei Phung wrote:
> This patch adds RIFFA PCIe linux driver for https://github.com/promach/riffa/tree/full_duplex/driver/linux

Line wrap the commit message at 75 characters or less.

> 
> TODO:
> 
> 1) this driver needs further speed optimization although it can now achieve defined PCIe speed grade
> 2) solve all the coding style errors from scripts/checkpatch.pl

Greg means that it needs a file named drivers/staging/riffa/TODO

> 
> Signed-off-by: PHUNG CHENG FEI (feiphung@hotmail.com)

Please use:

Signed-off-by: Cheng Fei Phung <feiphung@hotmail.com>

It's really unusual for any driver to not use the kernel build system
but to come with its own makefile like an out of tree driver...  I don't
care too much about that because this is staging and we will fix it, but
I had wanted to read the Kconfig entry but it's not there...

Anyway, this is a staging drive so we're not picky at all.

regards,
dan carpenter