From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: Received: from userp2120.oracle.com ([156.151.31.85]:45240 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726595AbeJPTo6 (ORCPT ); Tue, 16 Oct 2018 15:44:58 -0400 Date: Tue, 16 Oct 2018 14:54:26 +0300 From: Dan Carpenter Subject: Re: [PATCH] Staging : Add RIFFA PCIe driver Message-ID: <20181016115426.io5ejmshwlxt752x@mwanda> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-fpga-owner@vger.kernel.org List-Id: linux-fpga@vger.kernel.org To: Cheng Fei Phung Cc: "gregkh@linuxfoundation.org" , "devel@driverdev.osuosl.org" , "linux-fpga@vger.kernel.org" Please make the subject be: [PATCH] Staging: riffa: Add new RIFFA PCIe driver On Tue, Oct 16, 2018 at 10:54:28AM +0000, Cheng Fei Phung wrote: > This patch adds RIFFA PCIe linux driver for https://github.com/promach/riffa/tree/full_duplex/driver/linux Line wrap the commit message at 75 characters or less. > > TODO: > > 1) this driver needs further speed optimization although it can now achieve defined PCIe speed grade > 2) solve all the coding style errors from scripts/checkpatch.pl Greg means that it needs a file named drivers/staging/riffa/TODO > > Signed-off-by: PHUNG CHENG FEI (feiphung@hotmail.com) Please use: Signed-off-by: Cheng Fei Phung It's really unusual for any driver to not use the kernel build system but to come with its own makefile like an out of tree driver... I don't care too much about that because this is staging and we will fix it, but I had wanted to read the Kconfig entry but it's not there... Anyway, this is a staging drive so we're not picky at all. regards, dan carpenter