linux-fpga.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Anatolij Gustschin <agust@denx.de>
To: Alan Tull <atull@kernel.org>
Cc: linux-fpga@vger.kernel.org, Moritz Fischer <mdf@kernel.org>
Subject: Re: [PATCH] fpga: altera-cvp: fix probing for multiple FPGAs on the bus
Date: Wed, 7 Nov 2018 23:11:36 +0100	[thread overview]
Message-ID: <20181107231136.4e9da738@crub> (raw)
In-Reply-To: <CANk1AXSAN1ywxR6AkP9EsodP73GY+CON76pTUCzMe8G-OHnkxQ@mail.gmail.com>

Hi Alan,

On Wed, 7 Nov 2018 10:05:21 -0600
Alan Tull atull@kernel.org wrote:
...
>> > >> +       if (!altera_cvp_cnt++) {
>> > >> +               ret = driver_create_file(&altera_cvp_driver.driver,
>> > >> +                                        &driver_attr_chkcfg);  
>
>Please consider whether moving this to the module init would solve
>your problem without having to add a counter.

This should work and it is a better idea, thanks.

Anatolij

      reply	other threads:[~2018-11-07 22:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-06 20:35 [PATCH] fpga: altera-cvp: fix probing for multiple FPGAs on the bus Anatolij Gustschin
2018-11-06 21:54 ` Alan Tull
2018-11-06 23:56   ` Anatolij Gustschin
2018-11-07 15:53     ` Alan Tull
2018-11-07 16:05       ` Alan Tull
2018-11-07 22:11         ` Anatolij Gustschin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181107231136.4e9da738@crub \
    --to=agust@denx.de \
    --cc=atull@kernel.org \
    --cc=linux-fpga@vger.kernel.org \
    --cc=mdf@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).