From: Daniel Jordan <daniel.m.jordan@oracle.com>
To: akpm@linux-foundation.org
Cc: daniel.m.jordan@oracle.com, Alan Tull <atull@kernel.org>,
Alexey Kardashevskiy <aik@ozlabs.ru>,
Alex Williamson <alex.williamson@redhat.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Christoph Lameter <cl@linux.com>,
Davidlohr Bueso <dave@stgolabs.net>,
Michael Ellerman <mpe@ellerman.id.au>,
Moritz Fischer <mdf@kernel.org>,
Paul Mackerras <paulus@ozlabs.org>, Wu Hao <hao.wu@intel.com>,
linux-mm@kvack.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-fpga@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 0/6] convert locked_vm from unsigned long to atomic64_t
Date: Tue, 2 Apr 2019 16:41:52 -0400 [thread overview]
Message-ID: <20190402204158.27582-1-daniel.m.jordan@oracle.com> (raw)
Hi,
From patch 1:
Taking and dropping mmap_sem to modify a single counter, locked_vm, is
overkill when the counter could be synchronized separately.
Make mmap_sem a little less coarse by changing locked_vm to an atomic,
the 64-bit variety to avoid issues with overflow on 32-bit systems.
This is a more conservative alternative to [1] with no user-visible
effects. Thanks to Alexey Kardashevskiy for pointing out the racy
atomics and to Alex Williamson, Christoph Lameter, Ira Weiny, and Jason
Gunthorpe for their comments on [1].
Davidlohr Bueso recently did a similar conversion for pinned_vm[2].
Testing
1. passes LTP mlock[all], munlock[all], fork, mmap, and mremap tests in an
x86 kvm guest
2. a VFIO-enabled x86 kvm guest shows the same VmLck in
/proc/pid/status before and after this change
3. cross-compiles on powerpc
The series is based on v5.1-rc3. Please consider for 5.2.
Daniel
[1] https://lore.kernel.org/linux-mm/20190211224437.25267-1-daniel.m.jordan@oracle.com/
[2] https://lore.kernel.org/linux-mm/20190206175920.31082-1-dave@stgolabs.net/
Daniel Jordan (6):
mm: change locked_vm's type from unsigned long to atomic64_t
vfio/type1: drop mmap_sem now that locked_vm is atomic
vfio/spapr_tce: drop mmap_sem now that locked_vm is atomic
fpga/dlf/afu: drop mmap_sem now that locked_vm is atomic
powerpc/mmu: drop mmap_sem now that locked_vm is atomic
kvm/book3s: drop mmap_sem now that locked_vm is atomic
arch/powerpc/kvm/book3s_64_vio.c | 34 ++++++++++--------------
arch/powerpc/mm/mmu_context_iommu.c | 28 +++++++++-----------
drivers/fpga/dfl-afu-dma-region.c | 40 ++++++++++++-----------------
drivers/vfio/vfio_iommu_spapr_tce.c | 37 ++++++++++++--------------
drivers/vfio/vfio_iommu_type1.c | 31 +++++++++-------------
fs/proc/task_mmu.c | 2 +-
include/linux/mm_types.h | 2 +-
kernel/fork.c | 2 +-
mm/debug.c | 5 ++--
mm/mlock.c | 4 +--
mm/mmap.c | 18 ++++++-------
mm/mremap.c | 6 ++---
12 files changed, 89 insertions(+), 120 deletions(-)
base-commit: 79a3aaa7b82e3106be97842dedfd8429248896e6
--
2.21.0
next reply other threads:[~2019-04-02 20:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-02 20:41 Daniel Jordan [this message]
2019-04-02 20:41 ` [PATCH 1/6] mm: change locked_vm's type from unsigned long to atomic64_t Daniel Jordan
2019-04-02 22:04 ` Andrew Morton
2019-04-02 23:43 ` Davidlohr Bueso
2019-04-03 16:07 ` Daniel Jordan
2019-04-03 15:58 ` Daniel Jordan
2019-04-03 4:46 ` Christophe Leroy
2019-04-03 16:09 ` Daniel Jordan
2019-04-11 4:22 ` Alexey Kardashevskiy
2019-04-11 9:55 ` Mark Rutland
2019-04-11 20:28 ` Daniel Jordan
2019-04-16 23:33 ` Andrew Morton
2019-04-22 15:54 ` Daniel Jordan
2019-04-02 20:41 ` [PATCH 4/6] fpga/dlf/afu: drop mmap_sem now that locked_vm is atomic Daniel Jordan
2019-04-03 12:51 ` [PATCH 0/6] convert locked_vm from unsigned long to atomic64_t Steven Sistare
2019-04-03 16:52 ` Daniel Jordan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190402204158.27582-1-daniel.m.jordan@oracle.com \
--to=daniel.m.jordan@oracle.com \
--cc=aik@ozlabs.ru \
--cc=akpm@linux-foundation.org \
--cc=alex.williamson@redhat.com \
--cc=atull@kernel.org \
--cc=benh@kernel.crashing.org \
--cc=cl@linux.com \
--cc=dave@stgolabs.net \
--cc=hao.wu@intel.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mdf@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).