From: Dan Carpenter <dan.carpenter@oracle.com>
To: nava.manne@xilinx.com
Cc: linux-fpga@vger.kernel.org
Subject: [bug report] fpga manager: Adding FPGA Manager support for Xilinx zynqmp
Date: Thu, 2 May 2019 10:31:43 +0300 [thread overview]
Message-ID: <20190502073143.GA18363@mwanda> (raw)
Hello Nava kishore Manne,
The patch c09f7471127e: "fpga manager: Adding FPGA Manager support
for Xilinx zynqmp" from Apr 15, 2019, leads to the following static
checker warning:
drivers/fpga/zynqmp-fpga.c:50 zynqmp_fpga_ops_write()
error: 'eemi_ops' dereferencing possible ERR_PTR()
drivers/fpga/zynqmp-fpga.c
40 static int zynqmp_fpga_ops_write(struct fpga_manager *mgr,
41 const char *buf, size_t size)
42 {
43 const struct zynqmp_eemi_ops *eemi_ops = zynqmp_pm_get_eemi_ops();
44 struct zynqmp_fpga_priv *priv;
45 dma_addr_t dma_addr;
46 u32 eemi_flags = 0;
47 char *kbuf;
48 int ret;
49
50 if (!eemi_ops || !eemi_ops->fpga_load)
^^^^^^^^
This is an error pointer. Possibly you want to handle EPROBE_DEFER in
a special way?
51 return -ENXIO;
52
See also:
drivers/fpga/zynqmp-fpga.c:84 zynqmp_fpga_ops_state() error: 'eemi_ops' dereferencing possible ERR_PTR()
regards,
dan carpenter
reply other threads:[~2019-05-02 7:31 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190502073143.GA18363@mwanda \
--to=dan.carpenter@oracle.com \
--cc=linux-fpga@vger.kernel.org \
--cc=nava.manne@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox