From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Tue, 7 May 2019 10:25:45 -0700 From: Moritz Fischer Subject: Re: [PATCH v2 02/18] fpga: dfl: fme: remove copy_to_user() in ioctl for PR Message-ID: <20190507172545.GA26690@archbox> References: <1556528151-17221-1-git-send-email-hao.wu@intel.com> <1556528151-17221-3-git-send-email-hao.wu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1556528151-17221-3-git-send-email-hao.wu@intel.com> To: Wu Hao Cc: atull@kernel.org, mdf@kernel.org, linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, Xu Yilun List-ID: On Mon, Apr 29, 2019 at 04:55:35PM +0800, Wu Hao wrote: > This patch removes copy_to_user() code in partial reconfiguration > ioctl, as it's useless as user never needs to read the data > structure after ioctl. > > Signed-off-by: Xu Yilun > Signed-off-by: Wu Hao Acked-by: Moritz Fischer > --- > v2: clean up code split from patch 2 in v1 patchset. > --- > drivers/fpga/dfl-fme-pr.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/fpga/dfl-fme-pr.c b/drivers/fpga/dfl-fme-pr.c > index d9ca955..6ec0f09 100644 > --- a/drivers/fpga/dfl-fme-pr.c > +++ b/drivers/fpga/dfl-fme-pr.c > @@ -159,9 +159,6 @@ static int fme_pr(struct platform_device *pdev, unsigned long arg) > mutex_unlock(&pdata->lock); > free_exit: > vfree(buf); > - if (copy_to_user((void __user *)arg, &port_pr, minsz)) > - return -EFAULT; > - > return ret; > } > > -- > 1.8.3.1 >