From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: From: Alan Tull Subject: [PATCH 2/4] fpga: dfl: afu: Pass the correct device to dma_mapping_error() Date: Thu, 9 May 2019 16:08:27 -0500 Message-Id: <20190509210829.31815-3-atull@kernel.org> In-Reply-To: <20190509210829.31815-1-atull@kernel.org> References: <20190509210829.31815-1-atull@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit To: Greg Kroah-Hartman Cc: Moritz Fischer , Alan Tull , linux-kernel@vger.kernel.org, linux-fpga@vger.kernel.org, Scott Wood , Wu Hao List-ID: From: Scott Wood dma_mapping_error() was being called on a different device struct than what was passed to map/unmap. Besides rendering the error checking ineffective, it caused a debug splat with CONFIG_DMA_API_DEBUG. Signed-off-by: Scott Wood Acked-by: Wu Hao Acked-by: Moritz Fischer Acked-by: Alan Tull --- drivers/fpga/dfl-afu-dma-region.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/fpga/dfl-afu-dma-region.c b/drivers/fpga/dfl-afu-dma-region.c index 0bbc7142f1dc..f7d268f45df0 100644 --- a/drivers/fpga/dfl-afu-dma-region.c +++ b/drivers/fpga/dfl-afu-dma-region.c @@ -391,7 +391,7 @@ int afu_dma_map_region(struct dfl_feature_platform_data *pdata, region->pages[0], 0, region->length, DMA_BIDIRECTIONAL); - if (dma_mapping_error(&pdata->dev->dev, region->iova)) { + if (dma_mapping_error(dfl_fpga_pdata_to_parent(pdata), region->iova)) { dev_err(&pdata->dev->dev, "failed to map for dma\n"); ret = -EFAULT; goto unpin_pages; -- 2.21.0