From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: Received: from mail.kernel.org ([198.145.29.99]:35582 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726119AbfFWT06 (ORCPT ); Sun, 23 Jun 2019 15:26:58 -0400 Date: Sun, 23 Jun 2019 15:26:52 -0400 From: Sasha Levin Subject: Re: [PATCH AUTOSEL 5.1 17/59] fpga: dfl: expand minor range when registering chrdev region Message-ID: <20190623192652.GM2226@sasha-vm> References: <20190614202843.26941-1-sashal@kernel.org> <20190614202843.26941-17-sashal@kernel.org> <20190615054806.GB23883@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20190615054806.GB23883@kroah.com> Sender: linux-fpga-owner@vger.kernel.org List-Id: linux-fpga@vger.kernel.org To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Chengguang Xu , Wu Hao , Alan Tull , linux-fpga@vger.kernel.org On Sat, Jun 15, 2019 at 07:48:06AM +0200, Greg Kroah-Hartman wrote: >On Fri, Jun 14, 2019 at 04:28:01PM -0400, Sasha Levin wrote: >> From: Chengguang Xu >> >> [ Upstream commit de9a7f6f5f1967d275311cca9163b4a3ffe9b0ae ] >> >> Actually, total amount of available minor number >> for a single major is MINORMASK + 1. So expand >> minor range when registering chrdev region. >> >> Signed-off-by: Chengguang Xu >> Acked-by: Wu Hao >> Acked-by: Alan Tull >> Signed-off-by: Greg Kroah-Hartman >> Signed-off-by: Sasha Levin >> --- >> drivers/fpga/dfl.c | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/fpga/dfl.c b/drivers/fpga/dfl.c >> index c25217cde5ca..4b66aaa32b5a 100644 >> --- a/drivers/fpga/dfl.c >> +++ b/drivers/fpga/dfl.c >> @@ -322,7 +322,7 @@ static void dfl_chardev_uinit(void) >> for (i = 0; i < DFL_FPGA_DEVT_MAX; i++) >> if (MAJOR(dfl_chrdevs[i].devt)) { >> unregister_chrdev_region(dfl_chrdevs[i].devt, >> - MINORMASK); >> + MINORMASK + 1); >> dfl_chrdevs[i].devt = MKDEV(0, 0); >> } >> } >> @@ -332,8 +332,8 @@ static int dfl_chardev_init(void) >> int i, ret; >> >> for (i = 0; i < DFL_FPGA_DEVT_MAX; i++) { >> - ret = alloc_chrdev_region(&dfl_chrdevs[i].devt, 0, MINORMASK, >> - dfl_chrdevs[i].name); >> + ret = alloc_chrdev_region(&dfl_chrdevs[i].devt, 0, >> + MINORMASK + 1, dfl_chrdevs[i].name); >> if (ret) >> goto exit; >> } > >Not a bugfix, so not needed for stable kernels, thanks. Dropped, thanks! -- Thanks, Sasha