[GIT PULL] FPGA Manager fix for 5.3

[GIT PULL] FPGA Manager fix for 5.3

[Moritz Fischer]

The following changes since commit 5f9e832c137075045d15cd6899ab0505cfb2ca4b:

  Linus 5.3-rc1 (2019-07-21 14:05:38 -0700)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/mdf/linux-fpga.git tags/fixes-for-5.3

for you to fetch changes up to c3aefa0b8f54e8c7967191e546a11019bc060fe6:

  fpga-manager: altera-ps-spi: Fix build error (2019-07-23 17:29:17 -0700)

----------------------------------------------------------------
FPGA Manager fixes for 5.3

Hi Greg,

this is only one (late) bugfix for 5.3 that fixes a build error,
when altera-ps-spi is built as builtin while a dependency is built as a
module.

This has been on the list for a while and I've reviewed it.

Signed-off-by: Moritz Fischer <mdf@kernel.org>

----------------------------------------------------------------
YueHaibing (1):
      fpga-manager: altera-ps-spi: Fix build error

 drivers/fpga/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Re: [GIT PULL] FPGA Manager fix for 5.3

[Greg KH]

On Tue, Jul 23, 2019 at 10:20:12PM -0700, Moritz Fischer wrote:
> The following changes since commit 5f9e832c137075045d15cd6899ab0505cfb2ca4b:
> 
>   Linus 5.3-rc1 (2019-07-21 14:05:38 -0700)
> 
> are available in the Git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/mdf/linux-fpga.git tags/fixes-for-5.3
> 
> for you to fetch changes up to c3aefa0b8f54e8c7967191e546a11019bc060fe6:
> 
>   fpga-manager: altera-ps-spi: Fix build error (2019-07-23 17:29:17 -0700)
> 
> ----------------------------------------------------------------
> FPGA Manager fixes for 5.3
> 
> Hi Greg,
> 
> this is only one (late) bugfix for 5.3 that fixes a build error,
> when altera-ps-spi is built as builtin while a dependency is built as a
> module.
> 
> This has been on the list for a while and I've reviewed it.
> 
> Signed-off-by: Moritz Fischer <mdf@kernel.org>

This message is not in the signed tag in the repo, are you sure you make
this correctly?  All I see is the first line:
	FPGA Manager fixes for 5.3

And it's a singluar "fix" :)

Care to fix this up and resend, or, just send the single patch as email,
as that's probably easier here.

thanks,

greg k-h

Re: [GIT PULL] FPGA Manager fix for 5.3

[Moritz Fischer]

On Wed, Jul 24, 2019 at 09:20:56AM +0200, Greg KH wrote:
> On Tue, Jul 23, 2019 at 10:20:12PM -0700, Moritz Fischer wrote:
> > The following changes since commit 5f9e832c137075045d15cd6899ab0505cfb2ca4b:
> > 
> >   Linus 5.3-rc1 (2019-07-21 14:05:38 -0700)
> > 
> > are available in the Git repository at:
> > 
> >   git://git.kernel.org/pub/scm/linux/kernel/git/mdf/linux-fpga.git tags/fixes-for-5.3
> > 
> > for you to fetch changes up to c3aefa0b8f54e8c7967191e546a11019bc060fe6:
> > 
> >   fpga-manager: altera-ps-spi: Fix build error (2019-07-23 17:29:17 -0700)
> > 
> > ----------------------------------------------------------------
> > FPGA Manager fixes for 5.3
> > 
> > Hi Greg,
> > 
> > this is only one (late) bugfix for 5.3 that fixes a build error,
> > when altera-ps-spi is built as builtin while a dependency is built as a
> > module.
> > 
> > This has been on the list for a while and I've reviewed it.
> > 
> > Signed-off-by: Moritz Fischer <mdf@kernel.org>
> 
> This message is not in the signed tag in the repo, are you sure you make
> this correctly?  All I see is the first line:
> 	FPGA Manager fixes for 5.3
> 
> And it's a singluar "fix" :)

Yeah, over the top. I wanted to figure out the workflow with an easy
example ... and ... learned something again :)

So basically the message above is what is supposed to go into the tag
message?

> Care to fix this up and resend, or, just send the single patch as email,
> as that's probably easier here.

I've seen you've queued it up the patch by hand, so next time.

Thanks,
Moritz

Re: [GIT PULL] FPGA Manager fix for 5.3

[Greg KH]

On Wed, Jul 24, 2019 at 07:55:13AM -0700, Moritz Fischer wrote:
> On Wed, Jul 24, 2019 at 09:20:56AM +0200, Greg KH wrote:
> > On Tue, Jul 23, 2019 at 10:20:12PM -0700, Moritz Fischer wrote:
> > > The following changes since commit 5f9e832c137075045d15cd6899ab0505cfb2ca4b:
> > > 
> > >   Linus 5.3-rc1 (2019-07-21 14:05:38 -0700)
> > > 
> > > are available in the Git repository at:
> > > 
> > >   git://git.kernel.org/pub/scm/linux/kernel/git/mdf/linux-fpga.git tags/fixes-for-5.3
> > > 
> > > for you to fetch changes up to c3aefa0b8f54e8c7967191e546a11019bc060fe6:
> > > 
> > >   fpga-manager: altera-ps-spi: Fix build error (2019-07-23 17:29:17 -0700)
> > > 
> > > ----------------------------------------------------------------
> > > FPGA Manager fixes for 5.3
> > > 
> > > Hi Greg,
> > > 
> > > this is only one (late) bugfix for 5.3 that fixes a build error,
> > > when altera-ps-spi is built as builtin while a dependency is built as a
> > > module.
> > > 
> > > This has been on the list for a while and I've reviewed it.
> > > 
> > > Signed-off-by: Moritz Fischer <mdf@kernel.org>
> > 
> > This message is not in the signed tag in the repo, are you sure you make
> > this correctly?  All I see is the first line:
> > 	FPGA Manager fixes for 5.3
> > 
> > And it's a singluar "fix" :)
> 
> Yeah, over the top. I wanted to figure out the workflow with an easy
> example ... and ... learned something again :)
> 
> So basically the message above is what is supposed to go into the tag
> message?

Yes, and then git pull-request takes that and puts it into the message
to send me.

thanks,

greg k-h