* [PATCH] fpga-manager: altera-ps-spi: Fix build error
@ 2019-07-08 7:13 YueHaibing
2019-07-09 0:05 ` Moritz Fischer
0 siblings, 1 reply; 3+ messages in thread
From: YueHaibing @ 2019-07-08 7:13 UTC (permalink / raw)
To: mdf, stillcompiling, atull, gregkh; +Cc: linux-kernel, linux-fpga, YueHaibing
If BITREVERSE is m and FPGA_MGR_ALTERA_PS_SPI is y,
build fails:
drivers/fpga/altera-ps-spi.o: In function `altera_ps_write':
altera-ps-spi.c:(.text+0x4ec): undefined reference to `byte_rev_table'
Select BITREVERSE to fix this.
Reported-by: Hulk Robot <hulkci@huawei.com>
Fixes: fcfe18f885f6 ("fpga-manager: altera-ps-spi: use bitrev8x4")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/fpga/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig
index 474f304..cdd4f73 100644
--- a/drivers/fpga/Kconfig
+++ b/drivers/fpga/Kconfig
@@ -40,6 +40,7 @@ config ALTERA_PR_IP_CORE_PLAT
config FPGA_MGR_ALTERA_PS_SPI
tristate "Altera FPGA Passive Serial over SPI"
depends on SPI
+ select BITREVERSE
help
FPGA manager driver support for Altera Arria/Cyclone/Stratix
using the passive serial interface over SPI.
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] fpga-manager: altera-ps-spi: Fix build error
2019-07-08 7:13 [PATCH] fpga-manager: altera-ps-spi: Fix build error YueHaibing
@ 2019-07-09 0:05 ` Moritz Fischer
2019-07-24 9:29 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Moritz Fischer @ 2019-07-09 0:05 UTC (permalink / raw)
To: YueHaibing; +Cc: mdf, stillcompiling, atull, gregkh, linux-kernel, linux-fpga
On Mon, Jul 08, 2019 at 03:13:56PM +0800, YueHaibing wrote:
> If BITREVERSE is m and FPGA_MGR_ALTERA_PS_SPI is y,
> build fails:
>
> drivers/fpga/altera-ps-spi.o: In function `altera_ps_write':
> altera-ps-spi.c:(.text+0x4ec): undefined reference to `byte_rev_table'
>
> Select BITREVERSE to fix this.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: fcfe18f885f6 ("fpga-manager: altera-ps-spi: use bitrev8x4")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/fpga/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig
> index 474f304..cdd4f73 100644
> --- a/drivers/fpga/Kconfig
> +++ b/drivers/fpga/Kconfig
> @@ -40,6 +40,7 @@ config ALTERA_PR_IP_CORE_PLAT
> config FPGA_MGR_ALTERA_PS_SPI
> tristate "Altera FPGA Passive Serial over SPI"
> depends on SPI
> + select BITREVERSE
> help
> FPGA manager driver support for Altera Arria/Cyclone/Stratix
> using the passive serial interface over SPI.
> --
> 2.7.4
>
>
Acked-by: Moritz Fischer <mdf@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] fpga-manager: altera-ps-spi: Fix build error
2019-07-09 0:05 ` Moritz Fischer
@ 2019-07-24 9:29 ` Greg KH
0 siblings, 0 replies; 3+ messages in thread
From: Greg KH @ 2019-07-24 9:29 UTC (permalink / raw)
To: Moritz Fischer
Cc: YueHaibing, stillcompiling, atull, linux-kernel, linux-fpga
On Mon, Jul 08, 2019 at 05:05:27PM -0700, Moritz Fischer wrote:
> On Mon, Jul 08, 2019 at 03:13:56PM +0800, YueHaibing wrote:
> > If BITREVERSE is m and FPGA_MGR_ALTERA_PS_SPI is y,
> > build fails:
> >
> > drivers/fpga/altera-ps-spi.o: In function `altera_ps_write':
> > altera-ps-spi.c:(.text+0x4ec): undefined reference to `byte_rev_table'
> >
> > Select BITREVERSE to fix this.
> >
> > Reported-by: Hulk Robot <hulkci@huawei.com>
> > Fixes: fcfe18f885f6 ("fpga-manager: altera-ps-spi: use bitrev8x4")
> > Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> > ---
> > drivers/fpga/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig
> > index 474f304..cdd4f73 100644
> > --- a/drivers/fpga/Kconfig
> > +++ b/drivers/fpga/Kconfig
> > @@ -40,6 +40,7 @@ config ALTERA_PR_IP_CORE_PLAT
> > config FPGA_MGR_ALTERA_PS_SPI
> > tristate "Altera FPGA Passive Serial over SPI"
> > depends on SPI
> > + select BITREVERSE
> > help
> > FPGA manager driver support for Altera Arria/Cyclone/Stratix
> > using the passive serial interface over SPI.
> > --
> > 2.7.4
> >
> >
> Acked-by: Moritz Fischer <mdf@kernel.org>
I've queued this up directly now, thanks.
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-07-24 9:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-07-08 7:13 [PATCH] fpga-manager: altera-ps-spi: Fix build error YueHaibing
2019-07-09 0:05 ` Moritz Fischer
2019-07-24 9:29 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).