From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8508C433E2 for ; Mon, 31 Aug 2020 00:05:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C54672076D for ; Mon, 31 Aug 2020 00:05:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598832330; bh=WAj99MZmkWCx83oILFGlifM32P0+EBJTRm7XcESh6wU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=THZxJm5sPwGDhlC9tx/hFTwAx433+fEVJUr7SxyCw0zlJrdeKLoZ74qcOKPSHESH3 cLRD+4WyhwpOHLOf2kZm/SX/t3gZg6h84nlo4DzF9ZfIDoxBNwqe5aehM81GgKfKHA 4EJLwCxUUO/Ep8QozHVCI0Z/b2LO56AoTgclme7Y= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726453AbgHaAFa (ORCPT ); Sun, 30 Aug 2020 20:05:30 -0400 Received: from mail-pj1-f68.google.com ([209.85.216.68]:40014 "EHLO mail-pj1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726396AbgHaAF3 (ORCPT ); Sun, 30 Aug 2020 20:05:29 -0400 Received: by mail-pj1-f68.google.com with SMTP id kx11so2071157pjb.5; Sun, 30 Aug 2020 17:05:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=X+6Dlx8NV1kQ54mK9vN+wa4pINev/YtuIruDSPrIKmY=; b=ZWdHgZp3qWk5VVnzbE1ck9csFphq+jQLVcrDIG/I/zVmFTTfF6f/s4nHLriT7Z+ZuL QSaf8vyK2HofK0tnpeAjhotPnCF3RRukgf38yUfoYtPVZT6Rpf61a522t97w2C3JqvoJ WEApNkayExZQMCXQoEf4gmFEKpNma/7sSRWJsJ6lO+YMMXQMzdQdVgNPUsp8zKI242gR vZ5lsgPA0LcDhx8d6z7IWxTkg48VPBJUPudoUdk7INLzORdiX+lugtCijmm43w8U3yyZ BgtY6UkJfQjRjJ5hSP2G9m6t+PftY+KNYgce7viXuoxL84eyll0DOOYG4KkVKnbHdQlW pC3g== X-Gm-Message-State: AOAM533oB9QqwvLdYCIrSF/ZduWIdkYQQnFt9nFPtRCOTrLo+EQR1irN JFPUzlvV1WODZdqAyLe6rz4= X-Google-Smtp-Source: ABdhPJxKmdPEZzIvJKXdOOlmodT/nEgx8huKeBShc946fXpRzJ46pXeudtd4oPq3YXWNZ0DDWTlh6w== X-Received: by 2002:a17:90a:d711:: with SMTP id y17mr6705402pju.10.1598832328256; Sun, 30 Aug 2020 17:05:28 -0700 (PDT) Received: from localhost ([2601:647:5b00:1161:a4cc:eef9:fbc0:2781]) by smtp.gmail.com with ESMTPSA id b6sm5087273pjz.33.2020.08.30.17.05.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 30 Aug 2020 17:05:27 -0700 (PDT) Date: Sun, 30 Aug 2020 17:05:27 -0700 From: Moritz Fischer To: Luca Ceresoli Cc: linux-fpga@vger.kernel.org, Moritz Fischer , Tom Rix , Michal Simek , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Anatolij Gustschin Subject: Re: [PATCH v4 2/5] fpga manager: xilinx-spi: remove final dot from dev_err() strings Message-ID: <20200831000527.GB7421@epycbox.lan> References: <20200830163850.8380-1-luca@lucaceresoli.net> <20200830163850.8380-2-luca@lucaceresoli.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200830163850.8380-2-luca@lucaceresoli.net> Sender: linux-fpga-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fpga@vger.kernel.org On Sun, Aug 30, 2020 at 06:38:47PM +0200, Luca Ceresoli wrote: > Most dev_err messages in this file have no final dot. Remove the only two > exceptions to make them consistent. > > Reviewed-by: Tom Rix > Signed-off-by: Luca Ceresoli > > --- > > Changes in v4: > - add Reviewed-by Tom Rix > > Changes in v3: none. > > Changes in v2: > - move before the "provide better diagnostics on programming failure" > patch for clarity > --- > drivers/fpga/xilinx-spi.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/fpga/xilinx-spi.c b/drivers/fpga/xilinx-spi.c > index 502fae0d1d85..01f494172379 100644 > --- a/drivers/fpga/xilinx-spi.c > +++ b/drivers/fpga/xilinx-spi.c > @@ -77,7 +77,7 @@ static int xilinx_spi_write_init(struct fpga_manager *mgr, > int err; > > if (info->flags & FPGA_MGR_PARTIAL_RECONFIG) { > - dev_err(&mgr->dev, "Partial reconfiguration not supported.\n"); > + dev_err(&mgr->dev, "Partial reconfiguration not supported\n"); > return -EINVAL; > } > > @@ -169,7 +169,7 @@ static int xilinx_spi_write_complete(struct fpga_manager *mgr, > return xilinx_spi_apply_cclk_cycles(conf); > } > > - dev_err(&mgr->dev, "Timeout after config data transfer.\n"); > + dev_err(&mgr->dev, "Timeout after config data transfer\n"); > return -ETIMEDOUT; > } > > -- > 2.28.0 > Applied to for-next, Thanks