From: Moritz Fischer <mdf@kernel.org>
To: Luca Ceresoli <luca@lucaceresoli.net>
Cc: linux-fpga@vger.kernel.org, Moritz Fischer <mdf@kernel.org>,
Tom Rix <trix@redhat.com>, Michal Simek <michal.simek@xilinx.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Anatolij Gustschin <agust@denx.de>
Subject: Re: [PATCH v4 4/5] fpga manager: xilinx-spi: add error checking after gpiod_get_value()
Date: Sun, 30 Aug 2020 17:09:35 -0700 [thread overview]
Message-ID: <20200831000935.GD7421@epycbox.lan> (raw)
In-Reply-To: <20200830163850.8380-4-luca@lucaceresoli.net>
On Sun, Aug 30, 2020 at 06:38:49PM +0200, Luca Ceresoli wrote:
> Current code calls gpiod_get_value() without error checking. Should the
> GPIO controller fail, execution would continue without any error message.
>
> Fix by checking for negative error values.
>
> Reported-by: Tom Rix <trix@redhat.com>
> Reviewed-by: Tom Rix <trix@redhat.com>
> Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
>
> ---
>
> Changes in v4:
> - add Reviewed-by Tom Rix
>
> Changes in v3:
> - rebase on previous patches
>
> This patch is new in v2
> ---
> drivers/fpga/xilinx-spi.c | 35 +++++++++++++++++++++++++++--------
> 1 file changed, 27 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/fpga/xilinx-spi.c b/drivers/fpga/xilinx-spi.c
> index fba8eb4866a7..52aab5a1f0ba 100644
> --- a/drivers/fpga/xilinx-spi.c
> +++ b/drivers/fpga/xilinx-spi.c
> @@ -27,11 +27,22 @@ struct xilinx_spi_conf {
> struct gpio_desc *done;
> };
>
> -static enum fpga_mgr_states xilinx_spi_state(struct fpga_manager *mgr)
> +static int get_done_gpio(struct fpga_manager *mgr)
> {
> struct xilinx_spi_conf *conf = mgr->priv;
> + int ret;
> +
> + ret = gpiod_get_value(conf->done);
> +
> + if (ret < 0)
> + dev_err(&mgr->dev, "Error reading DONE (%d)\n", ret);
>
> - if (!gpiod_get_value(conf->done))
> + return ret;
> +}
> +
> +static enum fpga_mgr_states xilinx_spi_state(struct fpga_manager *mgr)
> +{
> + if (!get_done_gpio(mgr))
> return FPGA_MGR_STATE_RESET;
>
> return FPGA_MGR_STATE_UNKNOWN;
> @@ -57,10 +68,21 @@ static int wait_for_init_b(struct fpga_manager *mgr, int value,
>
> if (conf->init_b) {
> while (time_before(jiffies, timeout)) {
> - if (gpiod_get_value(conf->init_b) == value)
> + int ret = gpiod_get_value(conf->init_b);
> +
> + if (ret == value)
> return 0;
> +
> + if (ret < 0) {
> + dev_err(&mgr->dev, "Error reading INIT_B (%d)\n", ret);
> + return ret;
> + }
> +
> usleep_range(100, 400);
> }
> +
> + dev_err(&mgr->dev, "Timeout waiting for INIT_B to %s\n",
> + value ? "assert" : "deassert");
> return -ETIMEDOUT;
> }
>
> @@ -85,7 +107,6 @@ static int xilinx_spi_write_init(struct fpga_manager *mgr,
>
> err = wait_for_init_b(mgr, 1, 1); /* min is 500 ns */
> if (err) {
> - dev_err(&mgr->dev, "INIT_B pin did not go low\n");
> gpiod_set_value(conf->prog_b, 0);
> return err;
> }
> @@ -93,12 +114,10 @@ static int xilinx_spi_write_init(struct fpga_manager *mgr,
> gpiod_set_value(conf->prog_b, 0);
>
> err = wait_for_init_b(mgr, 0, 0);
> - if (err) {
> - dev_err(&mgr->dev, "INIT_B pin did not go high\n");
> + if (err)
> return err;
> - }
>
> - if (gpiod_get_value(conf->done)) {
> + if (get_done_gpio(mgr)) {
> dev_err(&mgr->dev, "Unexpected DONE pin state...\n");
> return -EIO;
> }
> --
> 2.28.0
>
Applied to for-next,
Thanks
next prev parent reply other threads:[~2020-08-31 0:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-30 16:38 [PATCH v4 1/5] fpga manager: xilinx-spi: remove stray comment Luca Ceresoli
2020-08-30 16:38 ` [PATCH v4 2/5] fpga manager: xilinx-spi: remove final dot from dev_err() strings Luca Ceresoli
2020-08-31 0:05 ` Moritz Fischer
2020-08-30 16:38 ` [PATCH v4 3/5] fpga manager: xilinx-spi: fix write_complete timeout handling Luca Ceresoli
2020-08-31 0:07 ` Moritz Fischer
2020-08-30 16:38 ` [PATCH v4 4/5] fpga manager: xilinx-spi: add error checking after gpiod_get_value() Luca Ceresoli
2020-08-31 0:09 ` Moritz Fischer [this message]
2020-08-30 16:38 ` [PATCH v4 5/5] fpga manager: xilinx-spi: provide better diagnostics on programming failure Luca Ceresoli
2020-08-31 0:09 ` Moritz Fischer
2020-08-31 0:05 ` [PATCH v4 1/5] fpga manager: xilinx-spi: remove stray comment Moritz Fischer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200831000935.GD7421@epycbox.lan \
--to=mdf@kernel.org \
--cc=agust@denx.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca@lucaceresoli.net \
--cc=michal.simek@xilinx.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).