From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D89AFC433E2 for ; Mon, 31 Aug 2020 00:10:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B42B620720 for ; Mon, 31 Aug 2020 00:10:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598832600; bh=HFBdfPzTptfAzARHMrR3+vfms6te3nWvd7UFRNZIZJs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=YVxxXFAYOkIanDFo4+VjIx3+ficujVFW24NAzuznZ7JGvPQF3wKDalYkGYurOGweQ ty0AvsB5zC9jrcPGdIIlbiMNZJNHDrC8T758tMX/MPbTLFIKBIwWabhIw7FGfLhsec j9rWIJ7k3oxUj32iR7aWhOBWXpE4+Xn4xG9g2R+E= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726439AbgHaAKA (ORCPT ); Sun, 30 Aug 2020 20:10:00 -0400 Received: from mail-pg1-f193.google.com ([209.85.215.193]:46645 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726430AbgHaAJ7 (ORCPT ); Sun, 30 Aug 2020 20:09:59 -0400 Received: by mail-pg1-f193.google.com with SMTP id 31so3336249pgy.13; Sun, 30 Aug 2020 17:09:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=iucP1YZuWrUVKjxqd1bXpSN+6NlJ9Lp0LD1bL/fThsw=; b=gH+fLqW58xwri18XYvcehOVAHK2Tuhjc7dsy+jhiWpfjx7NNAIYsMonIViSgdE8cw0 L8Pily16Xd0yzcPzkmfpIT64WJiyMZAzCDpWRoezaGZxm6Jbi93dSYduejIMz0QyFq5x LciQAG8T8a5TaHUaLoH941AvxeajPPM+12GUY9Gob9sk1jZmyFkTRuSrezRtlDlWM6V4 nTM+k7TLKmg3pwAw5s3pbO6cL5V05sD3/5aiPZGw/QdJ5KofdtA4kWKj+8AdD1mR7boO Sr+5vtz3YvCQqd9Sz4dN3D6O2WrZjMXx4tbvZbOUQji5ilcMn1iVcGfjsmBXjxu5DczC bg4Q== X-Gm-Message-State: AOAM5335HwyMnJrfR5KoDSnkqsyCfyBr6RuCP1FMwKerXQESrVkNHRLD qakCE+/b9ZwEuyVh57Tlpi4= X-Google-Smtp-Source: ABdhPJzGEkah4QjovWTx4O9dQqzC6p7ZVByNOuKX28HvpeMaEXxCmulr6ZefC8TTw0dsOpockaLF1w== X-Received: by 2002:a63:e018:: with SMTP id e24mr6219495pgh.175.1598832598485; Sun, 30 Aug 2020 17:09:58 -0700 (PDT) Received: from localhost ([2601:647:5b00:1161:a4cc:eef9:fbc0:2781]) by smtp.gmail.com with ESMTPSA id a6sm5270233pgt.70.2020.08.30.17.09.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 30 Aug 2020 17:09:58 -0700 (PDT) Date: Sun, 30 Aug 2020 17:09:57 -0700 From: Moritz Fischer To: Luca Ceresoli Cc: linux-fpga@vger.kernel.org, Moritz Fischer , Tom Rix , Michal Simek , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Anatolij Gustschin Subject: Re: [PATCH v4 5/5] fpga manager: xilinx-spi: provide better diagnostics on programming failure Message-ID: <20200831000957.GE7421@epycbox.lan> References: <20200830163850.8380-1-luca@lucaceresoli.net> <20200830163850.8380-5-luca@lucaceresoli.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200830163850.8380-5-luca@lucaceresoli.net> Sender: linux-fpga-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fpga@vger.kernel.org On Sun, Aug 30, 2020 at 06:38:50PM +0200, Luca Ceresoli wrote: > When the DONE pin does not go high after programming to confirm programming > success, the INIT_B pin provides some info on the reason. Use it if > available to provide a more explanatory error message. > > Reviewed-by: Tom Rix > Signed-off-by: Luca Ceresoli > > --- > > Changes in v4: > - add Reviewed-by Tom Rix > > Changes in v3: none. > > Changes in v2: > - also check for gpiod_get_value() errors (Tom Rix) > --- > drivers/fpga/xilinx-spi.c | 16 +++++++++++++++- > 1 file changed, 15 insertions(+), 1 deletion(-) > > diff --git a/drivers/fpga/xilinx-spi.c b/drivers/fpga/xilinx-spi.c > index 52aab5a1f0ba..824abbbd631e 100644 > --- a/drivers/fpga/xilinx-spi.c > +++ b/drivers/fpga/xilinx-spi.c > @@ -195,7 +195,21 @@ static int xilinx_spi_write_complete(struct fpga_manager *mgr, > return 0; > } > > - dev_err(&mgr->dev, "Timeout after config data transfer\n"); > + if (conf->init_b) { > + ret = gpiod_get_value(conf->init_b); > + > + if (ret < 0) { > + dev_err(&mgr->dev, "Error reading INIT_B (%d)\n", ret); > + return ret; > + } > + > + dev_err(&mgr->dev, > + ret ? "CRC error or invalid device\n" > + : "Missing sync word or incomplete bitstream\n"); > + } else { > + dev_err(&mgr->dev, "Timeout after config data transfer\n"); > + } > + > return -ETIMEDOUT; > } > > -- > 2.28.0 > Applied to for-next, Thanks