From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 996DCC433E2 for ; Mon, 14 Sep 2020 21:32:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 57D5220936 for ; Mon, 14 Sep 2020 21:32:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600119157; bh=5a5AuSGNf4eUyykuZcqB35IJyhfZHVWUNI/DwQCidq4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=Zudme7H6nuJPd51sSlWz76WuDkA8hVccJv1O8Qlg+otkLwSeWFLEYkyqp7AB/C9g0 PxWG68PrD/iL/yVz4/4XZr8dKOUxHgcBkbmKCHZ9pMFPVZIroOrc0RuJxnk/SkoRe8 jpvGFJ51/Gg7dfc8JIf62d0Gg3dQo0wUTJ30kJ14= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725994AbgINVch (ORCPT ); Mon, 14 Sep 2020 17:32:37 -0400 Received: from mail-pf1-f193.google.com ([209.85.210.193]:37541 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725920AbgINVcg (ORCPT ); Mon, 14 Sep 2020 17:32:36 -0400 Received: by mail-pf1-f193.google.com with SMTP id w7so666392pfi.4; Mon, 14 Sep 2020 14:32:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=GxPkXhqlAFVkhBlcdAangH+5G5NOYVoOkH633FrRrJM=; b=LSU5wCcQV3AIRcBPq5tO7BcB6RnUP/Na6BgwBhnWafBS7T9fphrqgX5yUHGU1H5a/j ZMqqvJlJ+X42NUpOeYq0iCHIP85F1rbRog6fIGiwmQuHZyDFu0po2MWahF8k+tT0UUHT ILYPAfuXo862NuEjVzGn6ZBhcIfhxDAoFsrFQ+5STdgGoMdU1w86wMulcV59unus9ASL XNfE+epISqeCDtnGchvSu7AkP7rRWQcCo969XVH2LZG2tPW1D1NRo137YjT2zgbPFsyj 4H7a3cGsvo5Jja8ZF0KoTJ1+WJTAWxgyv3SarnPTwKFCx/sxgB5AxznNfZ1iS02UWGgO OgpQ== X-Gm-Message-State: AOAM5303zYIZS/j3QytfNYEZJB3jjo2zsx/RWRoTrOE1BRIliAPCtQPh J4Or3hURuyHl4CJHd9akQ0c= X-Google-Smtp-Source: ABdhPJxWp+umJLT77yalayofcGiM3KtEpRnsJ8b5unXVtulF3tO6PepWq9IA7NWnyIwqUcaeAqDJ/A== X-Received: by 2002:aa7:9dd2:0:b029:13e:d13d:a109 with SMTP id g18-20020aa79dd20000b029013ed13da109mr14628525pfq.37.1600119155199; Mon, 14 Sep 2020 14:32:35 -0700 (PDT) Received: from localhost ([2601:647:5b00:1161:a4cc:eef9:fbc0:2781]) by smtp.gmail.com with ESMTPSA id i15sm4620056pfk.145.2020.09.14.14.32.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Sep 2020 14:32:34 -0700 (PDT) Date: Mon, 14 Sep 2020 14:32:32 -0700 From: Moritz Fischer To: "Wu, Hao" Cc: Tom Rix , "Xu, Yilun" , "mdf@kernel.org" , "linux-fpga@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "masahiroy@kernel.org" , "lgoncalv@redhat.com" , Matthew Gerlach , "Weight, Russell H" Subject: Re: [PATCH 1/3] fpga: dfl: move dfl_device_id to mod_devicetable.h Message-ID: <20200914213232.GA1040@epycbox.lan> References: <1599544129-17594-1-git-send-email-yilun.xu@intel.com> <1599544129-17594-2-git-send-email-yilun.xu@intel.com> <20200910084106.GB16318@yilunxu-OptiPlex-7050> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-fpga-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fpga@vger.kernel.org Hao, On Fri, Sep 11, 2020 at 06:50:18AM +0000, Wu, Hao wrote: > > On 9/10/20 1:41 AM, Xu Yilun wrote: > > > On Wed, Sep 09, 2020 at 05:55:33AM -0700, Tom Rix wrote: > > >> On 9/7/20 10:48 PM, Xu Yilun wrote: > > >>> In order to support MODULE_DEVICE_TABLE() for dfl device driver, this > > >>> patch moves struct dfl_device_id to mod_devicetable.h > > >>> > > >>> Signed-off-by: Xu Yilun > > >>> Signed-off-by: Wu Hao > > >>> Signed-off-by: Matthew Gerlach > > >>> Signed-off-by: Russ Weight > > >>> --- > > >>> drivers/fpga/dfl.h | 13 +------------ > > >>> include/linux/mod_devicetable.h | 12 ++++++++++++ > > >>> 2 files changed, 13 insertions(+), 12 deletions(-) > > >>> > > >>> diff --git a/drivers/fpga/dfl.h b/drivers/fpga/dfl.h > > >>> index 5dc758f..d5b0760 100644 > > >>> --- a/drivers/fpga/dfl.h > > >>> +++ b/drivers/fpga/dfl.h > > >>> @@ -26,6 +26,7 @@ > > >>> #include > > >>> #include > > >>> #include > > >>> +#include > > Please fix the order for the new one, other places to good to me. > Acked-by: Wu Hao for DFL related changes after this fix. Do you mean the order of the includes, like alphabeticized? If it's minor I can fix it up when applying. Thanks, Moritz