From: Moritz Fischer <mdf@kernel.org>
To: YueHaibing <yuehaibing@huawei.com>
Cc: hao.wu@intel.com, trix@redhat.com, mdf@kernel.org,
yilun.xu@intel.com, linux-fpga@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] fpga: dfl: Make m10_n3000_info static
Date: Wed, 16 Sep 2020 09:10:40 -0700 [thread overview]
Message-ID: <20200916161040.GA1066896@epycbox.lan> (raw)
In-Reply-To: <20200916142536.28748-1-yuehaibing@huawei.com>
Hi Yue,
On Wed, Sep 16, 2020 at 10:25:36PM +0800, YueHaibing wrote:
> Fix sparse warning:
>
> drivers/fpga/dfl-n3000-nios.c:392:23: warning:
> symbol 'm10_n3000_info' was not declared. Should it be static?
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/fpga/dfl-n3000-nios.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/fpga/dfl-n3000-nios.c b/drivers/fpga/dfl-n3000-nios.c
> index 5088f8f0e0cd..686813b59d33 100644
> --- a/drivers/fpga/dfl-n3000-nios.c
> +++ b/drivers/fpga/dfl-n3000-nios.c
> @@ -389,7 +389,7 @@ static int n3000_nios_init_done_check(struct n3000_nios *ns)
> return ret;
> }
>
> -struct spi_board_info m10_n3000_info = {
> +static struct spi_board_info m10_n3000_info = {
> .modalias = "m10-n3000",
> .max_speed_hz = 12500000,
> .bus_num = 0,
> --
> 2.17.1
>
Can you resend this with a [PATCH v2] or [PATCH v2 next], neither
lore nor patchwork picks it up in its current form.
This'll make sure it doesn't get lost.
While at it could you change the first line to:
"fpga: dfl: n3000-nios: Make m10_n3000_info static"
Thanks for the patch,
Moritz
next prev parent reply other threads:[~2020-09-16 20:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-16 14:25 [PATCH -next] fpga: dfl: Make m10_n3000_info static YueHaibing
2020-09-16 16:10 ` Moritz Fischer [this message]
2020-09-17 1:33 ` Yuehaibing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200916161040.GA1066896@epycbox.lan \
--to=mdf@kernel.org \
--cc=hao.wu@intel.com \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=trix@redhat.com \
--cc=yilun.xu@intel.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).