From: Greg KH <gregkh@linuxfoundation.org>
To: Xu Yilun <yilun.xu@intel.com>
Cc: Moritz Fischer <mdf@kernel.org>,
linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org,
trix@redhat.com, lgoncalv@redhat.com, hao.wu@intel.com
Subject: Re: [PATCH v3 1/5] fpga: dfl: rename the bus type "dfl" to "fpga-dfl"
Date: Fri, 9 Oct 2020 08:41:18 +0200 [thread overview]
Message-ID: <20201009064118.GA655664@kroah.com> (raw)
In-Reply-To: <20201009062059.GB24324@yilunxu-OptiPlex-7050>
On Fri, Oct 09, 2020 at 02:20:59PM +0800, Xu Yilun wrote:
> Hi Greg:
>
> On Mon, Sep 28, 2020 at 09:19:00PM -0700, Moritz Fischer wrote:
> > Hi Xu,
> >
> > On Tue, Sep 29, 2020 at 09:23:23AM +0800, Xu Yilun wrote:
> > > Hi moritz:
> > >
> > > On Sun, Sep 27, 2020 at 04:36:47PM +0800, Xu Yilun wrote:
> > > > Hi Greg,
> > > >
> > > > On Sun, Sep 27, 2020 at 09:54:01AM +0200, Greg KH wrote:
> > > > > On Sun, Sep 27, 2020 at 03:37:54PM +0800, Xu Yilun wrote:
> > > > > > Hi Greg,
> > > > > >
> > > > > > On Sun, Sep 27, 2020 at 07:51:08AM +0200, Greg KH wrote:
> > > > > > > On Sat, Sep 26, 2020 at 12:22:19PM -0700, Moritz Fischer wrote:
> > > > > > > > Hi Greg,
> > > > > > > >
> > > > > > > > On Sat, Sep 26, 2020 at 08:09:13AM +0200, Greg KH wrote:
> > > > > > > > > On Sat, Sep 26, 2020 at 10:23:46AM +0800, Xu Yilun wrote:
> > > > > > > > > > Hi greg,
> > > > > > > > > >
> > > > > > > > > > About the bus naming, I summarized some questions we've discussed to check
> > > > > > > > > > with you. See inline.
> > > > > > > > > >
> > > > > > > > > > On Thu, Sep 24, 2020 at 10:27:00AM -0700, Moritz Fischer wrote:
> > > > > > > > > > > Hi Xu,
> > > > > > > > > > >
> > > > > > > > > > > On Fri, Sep 25, 2020 at 12:59:57AM +0800, Xu Yilun wrote:
> > > > > > > > > > > > Now the DFL device drivers could be made as independent modules and put
> > > > > > > > > > > > in different subsystems according to their functionalities. So the name
> > > > > > > > > > > > should be descriptive and unique in the whole kernel.
> > > > > > > > > > > >
> > > > > > > > > > > > The patch changes the naming of dfl bus related structures, functions,
> > > > > > > > > > > > APIs and documentations.
> > > > > > > > > > > >
> > > > > > > > > > > > Signed-off-by: Xu Yilun <yilun.xu@intel.com>
> > > > > > > > > > > > ---
> > > > > > > > > > > > Documentation/ABI/testing/sysfs-bus-dfl | 15 --
> > > > > > > > > > > > Documentation/ABI/testing/sysfs-bus-fpga-dfl | 15 ++
> > > > > > > > > > > > MAINTAINERS | 2 +-
> > > > > > > > > > > > drivers/fpga/dfl.c | 254 ++++++++++++++-------------
> > > > > > > > > > > > drivers/fpga/dfl.h | 77 ++++----
> > > > > > > > > > > > 5 files changed, 184 insertions(+), 179 deletions(-)
> > > > > > > > > > > > delete mode 100644 Documentation/ABI/testing/sysfs-bus-dfl
> > > > > > > > > > > > create mode 100644 Documentation/ABI/testing/sysfs-bus-fpga-dfl
> > > > > > > > > > > >
> > > > > > > > > > > > diff --git a/Documentation/ABI/testing/sysfs-bus-dfl b/Documentation/ABI/testing/sysfs-bus-dfl
> > > > > > > > > > > > deleted file mode 100644
> > > > > > > > > > > > index 23543be..0000000
> > > > > > > > > > > > --- a/Documentation/ABI/testing/sysfs-bus-dfl
> > > > > > > > > > > > +++ /dev/null
> > > > > > > > > > > > @@ -1,15 +0,0 @@
> > > > > > > > > > > > -What: /sys/bus/dfl/devices/dfl_dev.X/type
> > > > > > > > > > > > -Date: Aug 2020
> > > > > > > > > > > > -KernelVersion: 5.10
> > > > > > > > > > > > -Contact: Xu Yilun <yilun.xu@intel.com>
> > > > > > > > > > > > -Description: Read-only. It returns type of DFL FIU of the device. Now DFL
> > > > > > > > > > > > - supports 2 FIU types, 0 for FME, 1 for PORT.
> > > > > > > > > > > > - Format: 0x%x
> > > > > > > > > > > > -
> > > > > > > > > > > > -What: /sys/bus/dfl/devices/dfl_dev.X/feature_id
> > > > > > > > > > > > -Date: Aug 2020
> > > > > > > > > > > > -KernelVersion: 5.10
> > > > > > > > > > > > -Contact: Xu Yilun <yilun.xu@intel.com>
> > > > > > > > > > > > -Description: Read-only. It returns feature identifier local to its DFL FIU
> > > > > > > > > > > > - type.
> > > > > > > > > > > > - Format: 0x%x
> > > > > > > > > > >
> > > > > > > > > > > You're changing userland facing ABI. I think that's something to avoid,
> > > > > > > > > > > please check with Greg on the rules since this hasn't been in a release yet.
> > > > > > > > > > >
> > > > > > > > > >
> > > > > > > > > > I'm going to change the name of bus stuff for other subsystems, to be
> > > > > > > > > > aligned, I also consider change the bus_type.name and dfl dev_name. But
> > > > > > > > > > it will cause the changing of user ABIs. No user case for these user ABI
> > > > > > > > > > now cause they are just queued, is it good I change them?
> > > > > > > > >
> > > > > > > > > Why change the user name here? No need for that, right? Unless you
> > > > > > > > > really want to, and think that no one will notice. If so, fine, change
> > > > > > > > > them :)
> > > > > > > >
> > > > > > > > Let's leave it as is -- An FPGA is one possible implementation and as for
> > > > > > > > other buses, you wouldn't call it fpga-usb or usb-fpga just because the
> > > > > > > > USB bus is implemented in an FPGA if it behaves like a normal USB bus.
> > > > > > > > Having an ASIC based DFL bus show up under dfl-fpga / fpga-dfl in sysfs
> > > > > > > > would be super confusing.
> > > >
> > > > I thought we have consensus that "dfl" could be used out of fpga domain.
> > > > And we are all good that we keep the user ABIs & the bus name - "dfl", so "dfl"
> > > > is good as a global name from linux user's point of view, is it?
> > > >
> > > > But why we reject the "dfl" in kernel code domain? I thought it is very
> > > > similar situation.
> > > >
> > > >
> > > > I think we have 2 options, to make the dfl self-consistent:
> > > >
> > > > 1. "dfl-fpga" for everything - bus name, user ABIs, structures & APIs for
> > > > other kernel subsystems. Then we lose the chance to support ASIC based DFL,
> > > > it would be hard if we change user ABIs later.
> > > >
> > > > 2. "dfl" for everything.
> > > >
> > > > BTW, no ASIC based DFL devices in kernel today.
> > > >
> > > > I fully understand the word "naming is hard" now, help me :)
> > >
> > > Seems now we have different opinions on this:
> > >
> > > - Hao thinks self-consistent is important to dfl framework.
> > Agreed. I mostly care about userspace facing ABI, though.
> >
> > > - "dfl" for everything seems not preferable to Greg.
> > Maybe now that we re-explained, we can take another look at that?
> >
> > > - From your previous mail, I assume you prefer to keep the bus name as "dfl"
> > > but change the stuff for other subsystem, is it?
> >
> > I mostly think we should keep DFL generic where it touches userspace and
> > defines ABI, since we cannot change it afterwards.
> >
> > I rest my point with the bus being independent of FPGAs despite the FPGA
> > being the (currently) only user.
> >
> > > So I got a little stuck here.
> > >
> > > Do you think "dfl-fpga" for everything would be an acceptable solution
> > > for you?
> >
> > I just think it doesn't make a lot of sense to call it fpga-dfl or
> > dfl-fpga. But if everyone else disagrees ... naming is hard :-)
>
> Hi Greg,
>
> We made some re-explanation why "dfl" could be independent of the fpga
> subsystem in this mail thread. And now the name "dfl" for all bus stuff is good
> to Moritz, Hao & Yilun. Could you help take another look at this?
What is "this"? I don't see any fpga patches in my inbox anywhere...
next prev parent reply other threads:[~2020-10-09 6:40 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-24 16:59 [PATCH v3 0/5] add DFL bus support to MODULE_DEVICE_TABLE() Xu Yilun
2020-09-24 16:59 ` [PATCH v3 1/5] fpga: dfl: rename the bus type "dfl" to "fpga-dfl" Xu Yilun
2020-09-24 17:27 ` Moritz Fischer
[not found] ` <20200926022346.GA5623@yilunxu-OptiPlex-7050>
2020-09-26 6:09 ` Greg KH
2020-09-26 19:22 ` Moritz Fischer
2020-09-27 5:51 ` Greg KH
2020-09-27 7:37 ` Xu Yilun
2020-09-27 7:54 ` Greg KH
[not found] ` <20200927083647.GC16433@yilunxu-OptiPlex-7050>
2020-09-29 1:23 ` Xu Yilun
2020-09-29 4:19 ` Moritz Fischer
2020-09-29 7:19 ` Xu Yilun
2020-10-09 6:20 ` Xu Yilun
2020-10-09 6:41 ` Greg KH [this message]
2020-10-09 7:34 ` Xu Yilun
2020-10-09 21:28 ` Moritz Fischer
2020-10-10 7:03 ` Greg KH
2020-09-24 19:01 ` Tom Rix
2020-09-25 2:41 ` Moritz Fischer
2020-09-25 3:15 ` Xu Yilun
2020-09-24 16:59 ` [PATCH v3 2/5] fpga: dfl: fix the definitions of type & feature_id for dfl devices Xu Yilun
2020-09-24 16:59 ` [PATCH v3 3/5] fpga: dfl: move fpga_dfl_device_id to mod_devicetable.h Xu Yilun
2020-09-24 17:00 ` [PATCH v3 4/5] fpga: dfl: add fpga dfl bus support to MODULE_DEVICE_TABLE() Xu Yilun
2020-09-24 17:00 ` [PATCH v3 5/5] fpga: dfl: move fpga dfl bus related APIs to include/linux/fpga/dfl.h Xu Yilun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201009064118.GA655664@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=hao.wu@intel.com \
--cc=lgoncalv@redhat.com \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mdf@kernel.org \
--cc=trix@redhat.com \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).