From: Moritz Fischer <mdf@kernel.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Xu Yilun <yilun.xu@intel.com>,
mdf@kernel.org, linux-fpga@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
gregkh@linuxfoundation.org, trix@redhat.com, lgoncalv@redhat.com,
hao.wu@intel.com, Russ Weight <russell.h.weight@intel.com>
Subject: Re: [PATCH v9 6/6] memory: dfl-emif: add the DFL EMIF private feature driver
Date: Mon, 12 Oct 2020 09:58:03 -0700 [thread overview]
Message-ID: <20201012165803.GA2654@archbook> (raw)
In-Reply-To: <CAJKOXPcLbnvXJLa6G8Rpa8tLv4v22dDVPBDx4DrakPnbGdK4QA@mail.gmail.com>
Hi Krzysztof,
On Mon, Oct 12, 2020 at 06:40:46PM +0200, Krzysztof Kozlowski wrote:
> On Sat, 10 Oct 2020 at 09:15, Xu Yilun <yilun.xu@intel.com> wrote:
> >
> > This driver is for the EMIF private feature implemented under FPGA
> > Device Feature List (DFL) framework. It is used to expose memory
> > interface status information as well as memory clearing control.
> >
> > The purpose of memory clearing block is to zero out all private memory
> > when FPGA is to be reprogrammed. This gives users a reliable method to
> > prevent potential data leakage.
> >
> > Signed-off-by: Xu Yilun <yilun.xu@intel.com>
> > Signed-off-by: Russ Weight <russell.h.weight@intel.com>
> > Acked-by: Krzysztof Kozlowski <krzk@kernel.org>
> > ---
> > v2: Adjust the position of this driver in Kconfig.
> > Improves the name of the Kconfig option.
> > Change the include dfl-bus.h to dfl.h, cause the previous patchset
> > renames the file.
> > Some minor fixes and comment improvement.
> > v3: Adjust the position of the driver in Makefile.
> > v9: Add static prefix for emif attributes macro
> > Update the kernel version of the sysfs interfaces in Doc.
> > ---
> > .../ABI/testing/sysfs-bus-dfl-devices-emif | 25 +++
> > drivers/memory/Kconfig | 9 +
> > drivers/memory/Makefile | 2 +
> > drivers/memory/dfl-emif.c | 207 +++++++++++++++++++++
> > 4 files changed, 243 insertions(+)
> > create mode 100644 Documentation/ABI/testing/sysfs-bus-dfl-devices-emif
> > create mode 100644 drivers/memory/dfl-emif.c
> >
>
> I am confused now. This was already taken by Moritz, wasn't it? And
> the dependencies were already taken, weren't they? Previously it was
> depending on "Modularization of DFL private feature drivers" and "add
> dfl bus support to MODULE_DEVICE_TABLE()"... now this is here so did
> the dependencies change? What is the reason to include this patch
> here?
It is confusing. Basically Greg had comments on the patch after I had
applied it. It's going through anothe round of review.
>
> My ack was for the purpose of taking it via Moritz tree, because of
> the dependencies. If this is not the case, then probably better to
> take it via memory controllers tree to avoid any conflicts (it's not a
> small change).
Once it's ok I can put it on a branch with a stable tag and you can pull
that in and take the patch through your tree.
Does that work?
Sorry for the mess,
Moritz
next prev parent reply other threads:[~2020-10-12 16:58 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-10 7:09 [PATCH v9 0/6] add DFL bus support to MODULE_DEVICE_TABLE() Xu Yilun
2020-10-10 7:09 ` [PATCH v9 1/6] fpga: dfl: fix the definitions of type & feature_id for dfl devices Xu Yilun
2020-10-10 15:07 ` Tom Rix
2020-10-12 2:41 ` Xu Yilun
2020-10-12 14:07 ` Tom Rix
2020-10-12 14:32 ` Greg KH
2020-10-10 7:09 ` [PATCH v9 2/6] fpga: dfl: move dfl_device_id to mod_devicetable.h Xu Yilun
2020-10-11 14:43 ` Greg KH
2020-10-12 2:27 ` Xu Yilun
2020-10-10 7:09 ` [PATCH v9 3/6] fpga: dfl: add dfl bus support to MODULE_DEVICE_TABLE() Xu Yilun
2020-10-10 7:09 ` [PATCH v9 4/6] fpga: dfl: move dfl bus related APIs to include/linux/fpga/dfl.h Xu Yilun
2020-10-11 14:45 ` Greg KH
2020-10-12 2:31 ` Xu Yilun
2020-10-10 7:09 ` [PATCH v9 5/6] fpga: dfl: add support for N3000 Nios private feature Xu Yilun
2020-10-10 21:21 ` Tom Rix
2020-10-12 6:51 ` Xu Yilun
2020-10-12 14:19 ` Tom Rix
2020-10-10 7:09 ` [PATCH v9 6/6] memory: dfl-emif: add the DFL EMIF private feature driver Xu Yilun
2020-10-12 16:40 ` Krzysztof Kozlowski
2020-10-12 16:58 ` Moritz Fischer [this message]
2020-10-12 17:27 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201012165803.GA2654@archbook \
--to=mdf@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hao.wu@intel.com \
--cc=krzk@kernel.org \
--cc=lgoncalv@redhat.com \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=russell.h.weight@intel.com \
--cc=trix@redhat.com \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).