From: Greg KH <gregkh@linuxfoundation.org>
To: Moritz Fischer <mdf@kernel.org>
Cc: linux-fpga@vger.kernel.org, Xu Yilun <yilun.xu@intel.com>,
Tom Rix <trix@redhat.com>, Wu Hao <hao.wu@intel.com>
Subject: Re: [PATCH 4/4] fpga: dfl: move dfl bus related APIs to include/linux/dfl.h
Date: Tue, 3 Nov 2020 08:43:07 +0100 [thread overview]
Message-ID: <20201103074307.GD2500572@kroah.com> (raw)
In-Reply-To: <20201103072104.12361-5-mdf@kernel.org>
On Mon, Nov 02, 2020 at 11:21:04PM -0800, Moritz Fischer wrote:
> From: Xu Yilun <yilun.xu@intel.com>
>
> Now the dfl drivers could be made as independent modules and put in
> different folders according to their functionalities. In order for
> scattered dfl device drivers to include dfl bus APIs, move the
> dfl bus APIs to a new header file in the public folder.
>
> [mdf@kernel.org: Fixed up header guards to match filename]
> Signed-off-by: Xu Yilun <yilun.xu@intel.com>
> Reviewed-by: Tom Rix <trix@redhat.com>
> Acked-by: Wu Hao <hao.wu@intel.com>
> Signed-off-by: Moritz Fischer <mdf@kernel.org>
> ---
> MAINTAINERS | 1 +
> drivers/fpga/dfl.c | 1 +
> drivers/fpga/dfl.h | 72 -------------------------------------
> include/linux/dfl.h | 86 +++++++++++++++++++++++++++++++++++++++++++++
> 4 files changed, 88 insertions(+), 72 deletions(-)
> create mode 100644 include/linux/dfl.h
Why move this if there is no in-kernel users?
greg k-h
next prev parent reply other threads:[~2020-11-03 7:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-03 7:21 [PATCH 0/4] DFL Module support Moritz Fischer
2020-11-03 7:21 ` [PATCH 1/4] fpga: dfl: fix the definitions of type & feature_id for dfl devices Moritz Fischer
2020-11-03 7:44 ` Greg KH
2020-11-03 8:53 ` Xu Yilun
2020-11-03 7:21 ` [PATCH 2/4] fpga: dfl: move dfl_device_id to mod_devicetable.h Moritz Fischer
2020-11-03 7:40 ` Greg KH
2020-11-03 8:54 ` Xu Yilun
2020-11-03 7:21 ` [PATCH 3/4] fpga: dfl: add dfl bus support to MODULE_DEVICE_TABLE() Moritz Fischer
2020-11-03 7:21 ` [PATCH 4/4] fpga: dfl: move dfl bus related APIs to include/linux/dfl.h Moritz Fischer
2020-11-03 7:43 ` Greg KH [this message]
2020-11-03 10:43 ` Xu Yilun
2020-11-03 11:08 ` Greg KH
2020-11-04 1:19 ` Xu Yilun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201103074307.GD2500572@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=hao.wu@intel.com \
--cc=linux-fpga@vger.kernel.org \
--cc=mdf@kernel.org \
--cc=trix@redhat.com \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).