From: Nava kishore Manne <nava.manne@xilinx.com>
To: <mdf@kernel.org>, <hao.wu@intel.com>, <yilun.xu@intel.com>,
<trix@redhat.com>, <michal.simek@xilinx.com>,
<linux-fpga@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>, <git@xilinx.com>
Cc: Nava kishore Manne <nava.manne@xilinx.com>
Subject: [PATCH v6 1/5] fpga: zynq: Fix incorrect variable type
Date: Sat, 23 Apr 2022 22:32:31 +0530 [thread overview]
Message-ID: <20220423170235.2115479-2-nava.manne@xilinx.com> (raw)
In-Reply-To: <20220423170235.2115479-1-nava.manne@xilinx.com>
zynq_fpga_has_sync () API is expecting "u8 *" but the
formal parameter that was passed is of type "const char *".
fix this issue by changing the buf type to "const char *"
Signed-off-by: Nava kishore Manne <nava.manne@xilinx.com>
Acked-by: Xu Yilun <yilun.xu@intel.com>
---
Changes for v2:
-None.
Changes for v3:
- Changed arg buf type to "const char *" as suggested by Tom.
- update zynq_fpga_has_sync () API description to align with API
functionality.
Changes for v4:
- None.
Changes for v5:
- Dropped the irrelevant doc update changes.
Changes for v6:
- None.
drivers/fpga/zynq-fpga.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/fpga/zynq-fpga.c b/drivers/fpga/zynq-fpga.c
index 426aa34c6a0d..6beaba9dfe97 100644
--- a/drivers/fpga/zynq-fpga.c
+++ b/drivers/fpga/zynq-fpga.c
@@ -239,7 +239,7 @@ static irqreturn_t zynq_fpga_isr(int irq, void *data)
* the correct byte order, and be dword aligned. The input is a Xilinx .bin
* file with every 32 bit quantity swapped.
*/
-static bool zynq_fpga_has_sync(const u8 *buf, size_t count)
+static bool zynq_fpga_has_sync(const char *buf, size_t count)
{
for (; count >= 4; buf += 4, count -= 4)
if (buf[0] == 0x66 && buf[1] == 0x55 && buf[2] == 0x99 &&
--
2.25.1
next prev parent reply other threads:[~2022-04-23 17:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-23 17:02 [PATCH v6 0/5]fpga: fix for coding style and kernel-doc issues Nava kishore Manne
2022-04-23 17:02 ` Nava kishore Manne [this message]
2022-04-25 13:23 ` [PATCH v6 1/5] fpga: zynq: Fix incorrect variable type Xu Yilun
2022-04-23 17:02 ` [PATCH v6 2/5] fpga: fix for coding style issues Nava kishore Manne
2022-04-25 4:23 ` Xu Yilun
2022-04-23 17:02 ` [PATCH v6 3/5] fpga: fpga-mgr: fix kernel-doc warnings Nava kishore Manne
2022-04-23 17:02 ` [PATCH v6 4/5] fpga: Use tab instead of space indentation Nava kishore Manne
2022-04-23 17:02 ` [PATCH v6 5/5] fpga: fpga-region: fix kernel-doc formatting issues Nava kishore Manne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220423170235.2115479-2-nava.manne@xilinx.com \
--to=nava.manne@xilinx.com \
--cc=git@xilinx.com \
--cc=hao.wu@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mdf@kernel.org \
--cc=michal.simek@xilinx.com \
--cc=trix@redhat.com \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).