* [PATCH v3] fpga: altera-pr-ip: fix unsigned comparison with less than zero
@ 2022-06-09 14:05 Marco Pagani
2022-06-10 7:50 ` Xu Yilun
0 siblings, 1 reply; 2+ messages in thread
From: Marco Pagani @ 2022-06-09 14:05 UTC (permalink / raw)
To: Moritz Fischer, Wu Hao, Xu Yilun, Tom Rix, Matthew Gerlach,
Alan Tull, Greg Kroah-Hartman
Cc: Marco Pagani, linux-fpga, linux-kernel
Fix the "comparison with less than zero" warning reported by
cppcheck for the unsigned (size_t) parameter count of the
alt_pr_fpga_write() function.
Fixes: d201cc17a8a3 ("fpga pr ip: Core driver support for Altera Partial Reconfiguration IP")
Reviewed-by: Tom Rix <trix@redhat.com>
Acked-by: Xu Yilun <yilun.xu@intel.com>
Signed-off-by: Marco Pagani <marpagan@redhat.com>
---
Changes v1 -> v2:
- Coding style fix
Changes v2 -> v3:
- Added Fixes tag
---
drivers/fpga/altera-pr-ip-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/fpga/altera-pr-ip-core.c b/drivers/fpga/altera-pr-ip-core.c
index be0667968d33..df8671af4a92 100644
--- a/drivers/fpga/altera-pr-ip-core.c
+++ b/drivers/fpga/altera-pr-ip-core.c
@@ -108,7 +108,7 @@ static int alt_pr_fpga_write(struct fpga_manager *mgr, const char *buf,
u32 *buffer_32 = (u32 *)buf;
size_t i = 0;
- if (count <= 0)
+ if (!count)
return -EINVAL;
/* Write out the complete 32-bit chunks */
--
2.35.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v3] fpga: altera-pr-ip: fix unsigned comparison with less than zero
2022-06-09 14:05 [PATCH v3] fpga: altera-pr-ip: fix unsigned comparison with less than zero Marco Pagani
@ 2022-06-10 7:50 ` Xu Yilun
0 siblings, 0 replies; 2+ messages in thread
From: Xu Yilun @ 2022-06-10 7:50 UTC (permalink / raw)
To: Marco Pagani
Cc: Moritz Fischer, Wu Hao, Tom Rix, Matthew Gerlach, Alan Tull,
Greg Kroah-Hartman, linux-fpga, linux-kernel
On Thu, Jun 09, 2022 at 04:05:19PM +0200, Marco Pagani wrote:
> Fix the "comparison with less than zero" warning reported by
> cppcheck for the unsigned (size_t) parameter count of the
> alt_pr_fpga_write() function.
>
> Fixes: d201cc17a8a3 ("fpga pr ip: Core driver support for Altera Partial Reconfiguration IP")
> Reviewed-by: Tom Rix <trix@redhat.com>
> Acked-by: Xu Yilun <yilun.xu@intel.com>
> Signed-off-by: Marco Pagani <marpagan@redhat.com>
Applied to for-next
Thanks,
Yilun
> ---
> Changes v1 -> v2:
> - Coding style fix
> Changes v2 -> v3:
> - Added Fixes tag
> ---
> drivers/fpga/altera-pr-ip-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/fpga/altera-pr-ip-core.c b/drivers/fpga/altera-pr-ip-core.c
> index be0667968d33..df8671af4a92 100644
> --- a/drivers/fpga/altera-pr-ip-core.c
> +++ b/drivers/fpga/altera-pr-ip-core.c
> @@ -108,7 +108,7 @@ static int alt_pr_fpga_write(struct fpga_manager *mgr, const char *buf,
> u32 *buffer_32 = (u32 *)buf;
> size_t i = 0;
>
> - if (count <= 0)
> + if (!count)
> return -EINVAL;
>
> /* Write out the complete 32-bit chunks */
> --
> 2.35.3
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-06-10 8:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-06-09 14:05 [PATCH v3] fpga: altera-pr-ip: fix unsigned comparison with less than zero Marco Pagani
2022-06-10 7:50 ` Xu Yilun
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).