From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C9ECC00144 for ; Fri, 29 Jul 2022 17:51:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238274AbiG2Rtt (ORCPT ); Fri, 29 Jul 2022 13:49:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58884 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238096AbiG2Rts (ORCPT ); Fri, 29 Jul 2022 13:49:48 -0400 Received: from mx1.emlix.com (mx1.emlix.com [136.243.223.33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4E6CC89A9E; Fri, 29 Jul 2022 10:49:47 -0700 (PDT) Received: from mailer.emlix.com (unknown [81.20.119.6]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.emlix.com (Postfix) with ESMTPS id 7AC965FDAA; Fri, 29 Jul 2022 19:49:45 +0200 (CEST) Date: Fri, 29 Jul 2022 19:49:45 +0200 From: Daniel =?iso-8859-1?Q?Gl=F6ckner?= To: Ivan Bornyakov Cc: mdf@kernel.org, hao.wu@intel.com, yilun.xu@intel.com, trix@redhat.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-fpga@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, system@metrotek.ru, Krzysztof Kozlowski Subject: Re: [PATCH v5 2/2] dt-bindings: fpga: add binding doc for ecp5-spi fpga mgr Message-ID: <20220729174945.GA7164@homes.emlix.com> References: <20220719112335.9528-1-i.bornyakov@metrotek.ru> <20220719112335.9528-3-i.bornyakov@metrotek.ru> <20220729090123.GA28299@homes.emlix.com> <20220729163347.irqqqcvh2biliqg2@x260> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220729163347.irqqqcvh2biliqg2@x260> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-fpga@vger.kernel.org On Fri, Jul 29, 2022 at 07:33:47PM +0300, Ivan Bornyakov wrote: > On Fri, Jul 29, 2022 at 11:01:24AM +0200, Daniel Glöckner wrote: > > On Tue, Jul 19, 2022 at 02:23:35PM +0300, Ivan Bornyakov wrote: > > > +properties: > > > + compatible: > > > + enum: > > > + - lattice,ecp5-fpga-mgr > > > > Since this driver uses the same interface as the existing > > drivers/fpga/machxo2-spi.c driver, wouldn't it be advisable to use a > > similar compatible id, i.e. lattice,ecp5-slave-spi? > > > > To quote Krzysztof Kozlowski from v1 review: > > Do not encode interface name in compatible so no "spi" > > See https://lore.kernel.org/linux-fpga/044a9736-a4ec-c250-7755-c80a5bcbe38b@linaro.org/ true... MachXO2 to MachXO5 and those Nexus chips speak that protocol both over spi and i2c and the position in the device tree decides which one it should be. Maybe the compatible string in the existing driver should be changed to lattice,machxo2. After all there is no other MachXO2-specific interface/protocol except maybe jtag. Best regards, Daniel