From: Ivan Bornyakov <i.bornyakov@metrotek.ru>
To: Xu Yilun <yilun.xu@intel.com>
Cc: mdf@kernel.org, hao.wu@intel.com, trix@redhat.com, dg@emlix.com,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
linux-fpga@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, system@metrotek.ru
Subject: Re: [PATCH v6 1/2] fpga: ecp5-spi: add Lattice ECP5 FPGA manager
Date: Wed, 17 Aug 2022 12:04:13 +0300 [thread overview]
Message-ID: <20220817090413.ywf7wescwj2manif@x260> (raw)
In-Reply-To: <Yvs0jieXsyzhn8q9@yilunxu-OptiPlex-7050>
On Tue, Aug 16, 2022 at 02:09:18PM +0800, Xu Yilun wrote:
> On 2022-08-16 at 07:58:41 +0300, Ivan Bornyakov wrote:
> > On Tue, Aug 16, 2022 at 10:00:41AM +0800, Xu Yilun wrote:
> > > On 2022-08-15 at 16:21:56 +0300, Ivan Bornyakov wrote:
> > > > Add support to the FPGA manager for programming Lattice ECP5 FPGA over
> > > > slave SPI interface with .bit formatted uncompressed bitstream image.
> > >
> > > Not sure if something is missed.
> > >
> > > https://lore.kernel.org/all/20220729145757.GA2601292@yilunxu-OptiPlex-7050/
> > >
> > > I was considering if a generic driver for lattice slave SPI sysCONFIG
> > > interface could be introduced. From machxo2 & ecp5 Programming Usage
> > > Guide, or others in this series, they basically use the same reconfigure
> > > interface & protocol.
> > >
> > > Thanks,
> > > Yilun
> > >
> >
> > I only have HW with ECP5, can't vouch for the rest.
>
> I understand your concern, but having separate drivers for the same IP on
> different boards makes the maintaining harder.
>
> We don't have to make everything fine, but start with machxo2 and ecp5
> first. If the change affects machxo2, other people may help.
>
> Thanks,
> Yilun
>
Hi, Yilun.
To clear things out, considering what Daniel said in
https://lore.kernel.org/linux-fpga/20220816074216.GA31706@homes.emlix.com/
you still don't want separate ECP5 driver, or this v6 is OK and review
continues?
next prev parent reply other threads:[~2022-08-17 9:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-15 13:21 [PATCH v6 0/2] Lattice ECP5 FPGA manager Ivan Bornyakov
2022-08-15 13:21 ` [PATCH v6 1/2] fpga: ecp5-spi: add " Ivan Bornyakov
2022-08-16 2:00 ` Xu Yilun
2022-08-16 4:58 ` Ivan Bornyakov
2022-08-16 6:09 ` Xu Yilun
2022-08-16 7:42 ` Daniel Glöckner
2022-08-17 9:04 ` Ivan Bornyakov [this message]
2022-08-18 2:13 ` Xu Yilun
2022-08-15 13:21 ` [PATCH v6 2/2] dt-bindings: fpga: add binding doc for ecp5-spi fpga mgr Ivan Bornyakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220817090413.ywf7wescwj2manif@x260 \
--to=i.bornyakov@metrotek.ru \
--cc=devicetree@vger.kernel.org \
--cc=dg@emlix.com \
--cc=hao.wu@intel.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mdf@kernel.org \
--cc=robh+dt@kernel.org \
--cc=system@metrotek.ru \
--cc=trix@redhat.com \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).