From: Johannes Zink <j.zink@pengutronix.de>
To: linux-fpga@vger.kernel.org
Cc: devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Moritz Fischer <mdf@kernel.org>, Wu Hao <hao.wu@intel.com>,
Xu Yilun <yilun.xu@intel.com>,
kernel@pengutronix.de, Johannes Zink <j.zink@pengutronix.de>
Subject: [PATCH 13/16] fpga: machxo2: add optional additional flash areas to be erased
Date: Thu, 25 Aug 2022 16:13:40 +0200 [thread overview]
Message-ID: <20220825141343.1375690-14-j.zink@pengutronix.de> (raw)
In-Reply-To: <20220825141343.1375690-1-j.zink@pengutronix.de>
This patch allows additional flash areas to be erased, i.e. not only the
configuration flash, but also sram, feature row and UFM (user flash
memory) can be erased.
Signed-off-by: Johannes Zink <j.zink@pengutronix.de>
---
drivers/fpga/machxo2-common.c | 40 +++++++++++++++++++++++++++++------
drivers/fpga/machxo2-common.h | 1 +
2 files changed, 35 insertions(+), 6 deletions(-)
diff --git a/drivers/fpga/machxo2-common.c b/drivers/fpga/machxo2-common.c
index 71f886a60cba..d93c304cceb9 100644
--- a/drivers/fpga/machxo2-common.c
+++ b/drivers/fpga/machxo2-common.c
@@ -10,10 +10,13 @@
#include <linux/delay.h>
#include <linux/bitfield.h>
+#include <linux/byteorder/generic.h>
+#include <asm-generic/unaligned.h>
#include <linux/fpga/fpga-mgr.h>
#include <linux/gpio/consumer.h>
#include <linux/module.h>
#include <linux/of.h>
+#include <linux/property.h>
#include "machxo2-common.h"
#define MACHXO2_LOW_DELAY_USEC 5
@@ -41,6 +44,16 @@
#define MACHXO2_ERR_EESDMEOF 7 /* SDM EOF */
#define MACHXO2_FAIL BIT(13)
+/*
+ * second byte ('operand') of ISC_ERASE can be ORed with the
+ * following bitmasks to not only erase configuration flash,
+ * but also SRAM, Feature Row or UFM, respectively. See MachXO2
+ * Programming and Configuration Usage Guide
+ */
+#define ISC_ERASE_SRAM BIT(16)
+#define ISC_ERASE_FEATURE_ROW BIT(17)
+#define ISC_ERASE_UFM BIT(19)
+
static inline u8 get_err(u32 status)
{
@@ -90,13 +103,13 @@ static int machxo2_wait_until_not_busy(struct machxo2_common_priv *priv)
static int machxo2_cleanup(struct fpga_manager *mgr)
{
struct machxo2_common_priv *priv = mgr->priv;
- u8 erase[] = ISC_ERASE;
u8 refresh[] = LSC_REFRESH;
struct machxo2_cmd cmd = {};
int ret;
- cmd.cmd = erase;
- cmd.cmd_len = sizeof(erase);
+ cmd.cmd = (u8 *)&priv->erase_cmd;
+ cmd.cmd_len = sizeof(priv->erase_cmd);
+
ret = priv->write_commands(priv, &cmd, 1);
if (ret)
goto fail;
@@ -143,7 +156,6 @@ static int machxo2_write_init(struct fpga_manager *mgr,
{
struct machxo2_common_priv *priv = mgr->priv;
u8 enable[] = ISC_ENABLE;
- u8 erase[] = ISC_ERASE;
u8 initaddr[] = LSC_INITADDRESS;
struct machxo2_cmd cmd[2] = {};
u32 status;
@@ -162,8 +174,9 @@ static int machxo2_write_init(struct fpga_manager *mgr,
cmd[0].cmd_len = sizeof(enable);
cmd[0].delay_us = MACHXO2_LOW_DELAY_USEC;
- cmd[1].cmd = erase;
- cmd[1].cmd_len = sizeof(erase);
+ cmd[1].cmd = (u8 *)&priv->erase_cmd;
+ cmd[1].cmd_len = sizeof(priv->erase_cmd);
+
ret = priv->write_commands(priv, cmd, 2);
if (ret)
goto fail;
@@ -302,6 +315,21 @@ static const struct fpga_manager_ops machxo2_ops = {
int machxo2_common_init(struct machxo2_common_priv *priv, struct device *dev)
{
struct fpga_manager *mgr;
+ u8 erase[] = ISC_ERASE;
+ u32 erase_cmd;
+
+ erase_cmd = get_unaligned_be32(erase);
+
+ if (device_property_read_bool(dev, "lattice,erase-sram"))
+ erase_cmd |= ISC_ERASE_SRAM;
+
+ if (device_property_read_bool(dev, "lattice,erase-feature-row"))
+ erase_cmd |= ISC_ERASE_FEATURE_ROW;
+
+ if (device_property_read_bool(dev, "lattice,erase-userflash"))
+ erase_cmd |= ISC_ERASE_UFM;
+
+ priv->erase_cmd = cpu_to_be32(erase_cmd);
priv->dev = dev;
diff --git a/drivers/fpga/machxo2-common.h b/drivers/fpga/machxo2-common.h
index a16060602a3f..1b54154f91b1 100644
--- a/drivers/fpga/machxo2-common.h
+++ b/drivers/fpga/machxo2-common.h
@@ -31,6 +31,7 @@ struct machxo2_common_priv {
struct machxo2_cmd *cmds, size_t cmd_count);
int (*get_status)(struct machxo2_common_priv *priv, u32 *status);
struct device *dev;
+ __be32 erase_cmd;
};
int machxo2_common_init(struct machxo2_common_priv *priv, struct device *dev);
--
2.30.2
next prev parent reply other threads:[~2022-08-25 14:16 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-25 14:13 [PATCH 00/16] Add support for Lattice MachXO2 programming via I2C Johannes Zink
2022-08-25 14:13 ` [PATCH 01/16] dt-bindings: fpga: convert Lattice MachXO2 Slave binding to YAML Johannes Zink
2022-08-30 20:30 ` Rob Herring
2022-08-31 7:12 ` Johannes Zink
2022-08-25 14:13 ` [PATCH 02/16] dt-bindings: fpga: machxo2-slave: add erasure properties Johannes Zink
2022-08-29 7:39 ` Xu Yilun
[not found] ` <9d5512768acb4d57f339942007402a9ed9483e84.camel@pengutronix.de>
[not found] ` <YwzWt8KjyfdyqehI@yilunxu-OptiPlex-7050>
2022-08-31 7:38 ` Johannes Zink
2022-09-03 14:49 ` Xu Yilun
2022-08-30 20:36 ` Rob Herring
2022-08-31 7:07 ` Johannes Zink
2022-08-25 14:13 ` [PATCH 03/16] dt-bindings: fpga: machxo2-slave: add pin for program sequence init Johannes Zink
2022-08-25 18:51 ` Rob Herring
2022-08-26 7:56 ` Johannes Zink
2022-08-29 7:45 ` Xu Yilun
[not found] ` <a42d72cd71c96ca675f5bb0cf59128c7f1cb04bb.camel@pengutronix.de>
[not found] ` <YwzZYM6GU0GiqBiq@yilunxu-OptiPlex-7050>
2022-08-31 7:51 ` Johannes Zink
2022-08-31 8:08 ` Johannes Zink
2022-08-25 14:13 ` [PATCH 04/16] dt-bindings: fpga: machxo2-slave: add lattice,machxo2-slave-i2c compatible Johannes Zink
2022-08-30 20:40 ` Rob Herring
2022-08-31 7:10 ` Johannes Zink
2022-08-25 14:13 ` [PATCH 05/16] fpga: machxo2-spi: remove #ifdef DEBUG Johannes Zink
2022-08-25 14:13 ` [PATCH 06/16] fpga: machxo2-spi: factor out status check for readability Johannes Zink
2022-08-25 14:13 ` [PATCH 07/16] fpga: machxo2-spi: fix big-endianness incompatibility Johannes Zink
2022-08-29 8:19 ` Xu Yilun
2022-08-29 10:41 ` Johannes Zink
2022-08-25 14:13 ` [PATCH 08/16] fpga: machxo2-spi: simplify with spi_sync_transfer() Johannes Zink
2022-08-25 14:13 ` [PATCH 09/16] fpga: machxo2-spi: simplify spi write commands Johannes Zink
2022-08-25 14:13 ` [PATCH 10/16] fpga: machxo2-spi: prepare extraction of common code Johannes Zink
2022-08-25 14:13 ` [PATCH 11/16] fpga: machxo2: move non-spi-related functionality to " Johannes Zink
2022-08-25 14:13 ` [PATCH 12/16] fpga: machxo2: improve status register dump Johannes Zink
2022-08-25 14:13 ` Johannes Zink [this message]
2022-08-25 14:13 ` [PATCH 14/16] fpga: machxo2: add program initialization signalling via gpio Johannes Zink
2022-08-25 14:13 ` [PATCH 15/16] fpga: machxo2: extend erase timeout for machxo2 FPGA Johannes Zink
2022-08-29 9:26 ` Xu Yilun
2022-08-29 10:51 ` Johannes Zink
2022-08-29 14:57 ` Xu Yilun
2022-08-31 7:56 ` Johannes Zink
2022-08-25 14:13 ` [PATCH 16/16] fpga: machxo2: add configuration over i2c Johannes Zink
2022-08-29 9:47 ` Xu Yilun
2022-08-29 13:21 ` Johannes Zink
2022-08-29 14:45 ` Xu Yilun
2022-08-31 16:07 ` Johannes Zink
2022-08-25 15:25 ` [PATCH 00/16] Add support for Lattice MachXO2 programming via I2C Ivan Bornyakov
2022-08-26 6:32 ` Johannes Zink
2022-08-26 8:15 ` Ivan Bornyakov
2022-08-26 8:25 ` Sascha Hauer
2022-08-26 9:00 ` Ivan Bornyakov
2022-08-26 9:19 ` Ivan Bornyakov
2022-08-26 15:26 ` Xu Yilun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220825141343.1375690-14-j.zink@pengutronix.de \
--to=j.zink@pengutronix.de \
--cc=devicetree@vger.kernel.org \
--cc=hao.wu@intel.com \
--cc=kernel@pengutronix.de \
--cc=linux-fpga@vger.kernel.org \
--cc=mdf@kernel.org \
--cc=robh+dt@kernel.org \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).