From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CC20EB64D9 for ; Mon, 10 Jul 2023 14:13:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231707AbjGJOLk (ORCPT ); Mon, 10 Jul 2023 10:11:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35802 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230263AbjGJOLj (ORCPT ); Mon, 10 Jul 2023 10:11:39 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 55E26AD; Mon, 10 Jul 2023 07:11:39 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E793760FE9; Mon, 10 Jul 2023 14:11:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DC73BC433C7; Mon, 10 Jul 2023 14:11:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1688998298; bh=KnoFgz/WVRm69Acdmguxy6Kmdym5tT/bK7QYbgZ1Gyg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=U27uaBqCHZ2xR2e09pZT/ldaLlsz1VKCWbQeri+Brc6VgkGU1ojfGSwxbN5L66nJn /nrCGLzgjt2ZVpHRqprD2Hxu1uy7rFCVXR2QKbkuakLstLY6dBlfBLyVVcsu5lKjXK rIlXiL/VR0wteIZwYx3anEMrMdUZsor38UBZtiXQ= Date: Mon, 10 Jul 2023 16:11:35 +0200 From: Greg Kroah-Hartman To: Yangtao Li Cc: Moritz Fischer , Wu Hao , Xu Yilun , Tom Rix , Alan Tull , Moritz Fischer , linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/3] fpga: socfpga-a10: Fix incorrect return value of devm_regmap_init_mmio Message-ID: <2023071010-anatomy-paying-3e3e@gregkh> References: <20230710133830.65631-1-frank.li@vivo.com> <20230710133830.65631-3-frank.li@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230710133830.65631-3-frank.li@vivo.com> Precedence: bulk List-ID: X-Mailing-List: linux-fpga@vger.kernel.org On Mon, Jul 10, 2023 at 09:38:30PM +0800, Yangtao Li wrote: > When devm_regmap_init_mmio fails, we should return PTR_ERR(priv->regmap) > instead of -ENODEV. > > Fixes: acbb910ae04b ("fpga-manager: Add Socfpga Arria10 support") Why are you not also including a cc: stable@ tag here? thanks, greg k-h