From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6ABCACE7B10 for ; Thu, 28 Sep 2023 09:18:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231521AbjI1JRG (ORCPT ); Thu, 28 Sep 2023 05:17:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38936 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230242AbjI1JRF (ORCPT ); Thu, 28 Sep 2023 05:17:05 -0400 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2C4CAC0; Thu, 28 Sep 2023 02:17:04 -0700 (PDT) Received: from kwepemi500008.china.huawei.com (unknown [172.30.72.55]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4Rx76b1wclztT3g; Thu, 28 Sep 2023 17:12:39 +0800 (CST) Received: from huawei.com (10.90.53.73) by kwepemi500008.china.huawei.com (7.221.188.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Thu, 28 Sep 2023 17:17:01 +0800 From: Jinjie Ruan To: , , , , , , CC: Subject: [PATCH RESEND] fpga: region: Fix possible memory leak in fpga_region_register_full() Date: Thu, 28 Sep 2023 17:16:36 +0800 Message-ID: <20230928091636.1209914-1-ruanjinjie@huawei.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.90.53.73] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To kwepemi500008.china.huawei.com (7.221.188.139) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-fpga@vger.kernel.org If device_register() fails in fpga_region_register_full(), the region allocated by kzalloc() and the id allocated by ida_alloc() also need be freed otherwise will cause memory leak. Fixes: 8886a579744f ("fpga: region: Use standard dev_release for class driver") Signed-off-by: Jinjie Ruan --- drivers/fpga/fpga-region.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/fpga/fpga-region.c b/drivers/fpga/fpga-region.c index b364a929425c..9dc6314976ef 100644 --- a/drivers/fpga/fpga-region.c +++ b/drivers/fpga/fpga-region.c @@ -228,12 +228,13 @@ fpga_region_register_full(struct device *parent, const struct fpga_region_info * ret = device_register(®ion->dev); if (ret) { - put_device(®ion->dev); - return ERR_PTR(ret); + goto err_put_device; } return region; +err_put_device: + put_device(®ion->dev); err_remove: ida_free(&fpga_region_ida, id); err_free: -- 2.34.1